>Subject: [EXT] Re: [PATCH v9 2/6] ethdev: add trace points for ethdev (part
>one)
>
>External Email
>
>----------------------------------------------------------------------
>On 2/7/2023 6:32 AM, Ankur Dwivedi wrote:
>> Adds trace points for ethdev functions.
>>
>> The rte_ethdev_trace.h is removed. The file ethdev_trace.h is added as
>> an internal header. ethdev_trace.h contains internal slow path and
>> fast path tracepoints. The public fast path tracepoints are present in
>> rte_ethdev_trace_fp.h header.
>>
>> Signed-off-by: Ankur Dwivedi <adwiv...@marvell.com>
>> Acked-by: Sunil Kumar Kori <sk...@marvell.com>
>
>Reviewed-by: Ferruh Yigit <ferruh.yi...@amd.com>
>
><...>
>
>> +RTE_TRACE_POINT(
>> +    rte_ethdev_trace_owner_set,
>> +    RTE_TRACE_POINT_ARGS(const uint16_t port_id,
>> +            const struct rte_eth_dev_owner *owner, int ret),
>> +    rte_trace_point_emit_u16(port_id);
>> +    rte_trace_point_emit_u64(owner->id);
>> +    rte_trace_point_emit_string(owner->name);
>> +    rte_trace_point_emit_int(ret);
>> +)
>> +
>> +RTE_TRACE_POINT(
>> +    rte_ethdev_trace_owner_unset,
>> +    RTE_TRACE_POINT_ARGS(const uint16_t port_id,
>> +            const uint64_t owner_id, int ret),
>> +    rte_trace_point_emit_u16(port_id);
>> +    rte_trace_point_emit_u64(owner_id);
>> +    rte_trace_point_emit_int(ret);
>> +)
>> +
>
>'const' qualifier is not needed for basic types, can you please fix if there 
>will be
>a new version.
Ok. Will fix this in next version.

Reply via email to