Re: [PATCH] drivers: remove invalid options for MSVC

2025-03-12 Thread David Marchand
On Wed, Mar 12, 2025 at 3:14 AM Andre Muezerie wrote: > > When compiling "drivers" directory with MSVC the errors below popped up: > > 1) > LINK : warning LNK4044: unrecognized option > '/Wl,/def:V:\github\dpdk\build\drivers\rte_bus_vdev_exports.def'; ignored I reworked passing the export map in

DPDK Release Status Meeting 2025-03-11

2025-03-12 Thread Mcnamara, John
Release status meeting minutes 2025-03-11 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * Broadcom * ARM * Debian * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the proposed work

[PATCH] net/mlx5: fix failed to match on empty gre on root table

2025-03-12 Thread Maayan Kashani
The currnent implementation sets a gre mask with protocol masked in case the user did not supply the protocol mask. In template mode, for group 0, the gre translation was called once with the mask and later with the value. with gre open matcher(mask/value is null) default values were assigned gre p

Re: [PATCH] buildtools: remove invalid option for Microsoft linker

2025-03-12 Thread Bruce Richardson
On Tue, Mar 11, 2025 at 06:53:08PM -0700, Andre Muezerie wrote: > When compiling "drivers" directory with MSVC the errors below popped up: > > drivers/rte_mempool_stack.pmd.c(1): error C2143: syntax error: > missing ')' before '(' > drivers/rte_mempool_stack.pmd.c(1): error C2059: syntax error

[PATCH] net/mlx5: fix failed to match on empty gre on root table

2025-03-12 Thread Maayan Kashani
The currnent implementation sets a gre mask with protocol masked in case the user did not supply the protocol mask. In template mode, for group 0, the gre translation was called once with the mask and later with the value. with gre open matcher(mask/value is null) default values were assigned gre p

[PATCH] app/crypto-perf: avoid infinite loop

2025-03-12 Thread Rupesh Chiluka
The enqueue/dequeue loop's exit condition is (ops_enqd_total >= total_ops). If the PMD driver cannot process the ops (returns zero), ops_enqd_total won't increase, resulting in an infinite loop. A check is added to process one op to determine whether PMD can process the packet. Signed-off-by: Rupe

Re: [PATCH] doc: update virtio prog guide with new feature list

2025-03-12 Thread Maxime Coquelin
On 3/4/25 6:42 PM, Kommula Shiva Shankar wrote: This patch adds newly added virtio hash report feature to prog guide. Signed-off-by: Kommula Shiva Shankar --- doc/guides/nics/virtio.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/vir

Re: [PATCH] bbdev: enable to be compiled with MSVC

2025-03-12 Thread Maxime Coquelin
On 3/11/25 8:17 PM, Andre Muezerie wrote: The errors below popped up when compiling with MSVC: ../lib/bbdev/rte_bbdev.c(79): error C2061: syntax error: identifier 'TAILQ_ENTRY' ../lib/bbdev/rte_bbdev.c(85): error C2059: syntax error: '}' This was caused by a missing include. Signe

Re: [PATCH] drivers: remove invalid options for MSVC

2025-03-12 Thread Bruce Richardson
On Wed, Mar 12, 2025 at 04:29:40PM +0100, David Marchand wrote: > On Wed, Mar 12, 2025 at 4:19 PM Bruce Richardson > wrote: > > > diff --git a/drivers/net/intel/ixgbe/meson.build > > > b/drivers/net/intel/ixgbe/meson.build > > > index 0ae12dd5ff..3553b0ffe1 100644 > > > --- a/drivers/net/intel/ix

[PATCH] net/intel: using common functions in idpf driver

2025-03-12 Thread Shaiq Wani
reworked the drivers to use the common functions and structures from drivers/net/intel/common. Signed-off-by: Shaiq Wani --- drivers/net/intel/common/tx.h | 21 +++- drivers/net/intel/cpfl/cpfl_ethdev.c | 1 + drivers/net/intel/cpfl/cpfl_ethdev.h | 2 +- dr

[PATCH] net/cpfl: enable AVX2 for singleq Rx/Tx

2025-03-12 Thread Shaiq Wani
In case some CPUs don't support AVX512. Enable AVX2 for them to get better per-core performance. The single queue model processes all packets in order while the split queue model separates packet data and metadata into different queues for parallel processing and improved performance. Signed-off-

[PATCH] net/intel: remove unnecessary compiler flag for mingw

2025-03-12 Thread Bruce Richardson
There was an issue with building DPDK using mingw v8.1[1], which required using the "-fno-asynchronous-unwind-tables" compiler flag when building using the mingw compiler. However, recent versions of the compiler no longer seem to need this flag, so remove it. [1] https://inbox.dpdk.org/dev/cajfa

Re: [PATCH] drivers: remove invalid options for MSVC

2025-03-12 Thread Bruce Richardson
On Tue, Mar 11, 2025 at 07:13:56PM -0700, Andre Muezerie wrote: > When compiling "drivers" directory with MSVC the errors below popped up: > > 1) > LINK : warning LNK4044: unrecognized option > '/Wl,/def:V:\github\dpdk\build\drivers\rte_bus_vdev_exports.def'; ignored > > 2) > cl : Command line wa

Re: [PATCH] rust: support DPDK API

2025-03-12 Thread Etelson, Gregory
Re-implementing test-pmd, l3fwd, etc in Rust is OK but not huge leap. DPDK examples and applications are part of inner infrastructure. The patch allows external RUST application as well. The real benefit would the ability to support PMD's built in Rust. That would be much more invasive It

Re: [PATCH] bbdev: enable to be compiled with MSVC

2025-03-12 Thread Maxime Coquelin
On 3/12/25 3:56 PM, Maxime Coquelin wrote: On 3/11/25 8:17 PM, Andre Muezerie wrote: The errors below popped up when compiling with MSVC: ../lib/bbdev/rte_bbdev.c(79): error C2061: syntax error: identifier 'TAILQ_ENTRY' ../lib/bbdev/rte_bbdev.c(85): error C2059: syntax error: '}'

Re: [EXTERNAL] Re: [patch v2 0/6] Support VMBUS channels without monitoring enabled

2025-03-12 Thread Stephen Hemminger
On Wed, 12 Mar 2025 00:33:52 + Long Li wrote: > > Subject: [EXTERNAL] Re: [patch v2 0/6] Support VMBUS channels without > > monitoring enabled > > > > On Mon, 10 Mar 2025 14:42:51 -0700 > > lon...@linuxonhyperv.com wrote: > > > > > From: Long Li > > > > > > Hyperv may expose VMBUS channe

Re: [PATCH v1 1/1] baseband/acc: fix queue setup failure clean up

2025-03-12 Thread Maxime Coquelin
On 3/12/25 2:48 PM, Maxime Coquelin wrote: On 3/5/25 7:27 PM, Nicolas Chautru wrote: Incomplete clean up for vrb2 variant when queue setup fails to complete successfully. Fixes: fc65d3dcabe01 ("baseband/acc: refactor queue allocation") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru -

Re: [PATCH v1 1/1] baseband/acc: fix queue setup failure clean up

2025-03-12 Thread Maxime Coquelin
On 3/5/25 7:27 PM, Nicolas Chautru wrote: Incomplete clean up for vrb2 variant when queue setup fails to complete successfully. Fixes: fc65d3dcabe01 ("baseband/acc: refactor queue allocation") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 2 ++

[PATCH] net/tap: fix documentation about number of queues

2025-03-12 Thread Stephen Hemminger
The limit of 8 queues when using a secondary process was removed, but documentation was not changed. Fixes: 6a2e47a3e26a ("net/tap: increase maximum allowable queues") Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- doc/guides/nics/tap.rst | 6 ++ 1 file changed, 2 insertions(+), 4

[PATCH v3 3/9] bus/fslmc: fix use after free

2025-03-12 Thread Stephen Hemminger
The cleanup loop would deference the dpio_dev after freeing. Use TAILQ_FOREACH_SAFE to fix that. Found by building with sanitizer undefined flag. Fixes: e55d0494ab98 ("bus/fslmc: support secondary process") Cc: shreyansh.j...@nxp.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger Acked-by:

[PATCH v3 2/9] net/qede: fix use after free

2025-03-12 Thread Stephen Hemminger
The loop cleaning up flowdir resources was using SLIST_FOREACH but the inner loop would call rte_free. Found by building with address sanitizer undefined check. Also remove needless initialization, and null check. Fixes: f5765f66f9bb ("net/qede: refactor flow director into generic aRFS") Cc: shah

[PATCH v3 0/9] introduce common FOREACH_SAFE macros

2025-03-12 Thread Stephen Hemminger
This series adds common macros for safe iteration over lists. It is a subset copy of the macros from FreeBSD that are missing from the Linux header sys/queue.h Chose this over several other options: - let each driver define their own as needed. One Intel driver got it wrong, others will as w

[PATCH v3 4/9] net/bnxt: fix use after free

2025-03-12 Thread Stephen Hemminger
The filter cleanup loop was using STAILQ_FOREACH and rte_free and would dereference the filter after free. Found by build with -Dbsanitize=address,undefined Fixes: e8fe0e067b68 ("net/bnxt: fix allocation of PF info struct") Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Ajit Kha

[PATCH v3 6/9] vhost: replace open coded TAILQ_FOREACH_SAFE

2025-03-12 Thread Stephen Hemminger
Proper macro is now in EAL rte_queue.h use it instead. Signed-off-by: Stephen Hemminger --- lib/vhost/socket.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c index 4c6c551c3d..dc9c9da9d1 100644 --- a/lib/vhost/socket.c +++

[PATCH v3 5/9] net/iavf: replace local version of TAILQ_FOREACH_SAFE

2025-03-12 Thread Stephen Hemminger
Now in EAL as rte_queue.h Signed-off-by: Stephen Hemminger --- drivers/net/intel/iavf/iavf_vchnl.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/intel/iavf/iavf_vchnl.c b/drivers/net/intel/iavf/iavf_vchnl.c index 6feca8435e..0b7c35250c 100644 --- a/drive

[PATCH v3 7/9] raw/ifpga: use EAL version of TAILQ_FOREACH_SAFE

2025-03-12 Thread Stephen Hemminger
Prefer the EAL version over local version of macro. Signed-off-by: Stephen Hemminger Reviewed-by: Rosen Xu --- drivers/raw/ifpga/base/ifpga_enumerate.c | 4 +--- drivers/raw/ifpga/base/opae_osdep.h | 1 + 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/raw/ifpga/base

[PATCH v3 8/9] net/i40e: replace open coded version of LIST_FOREACH_SAFE

2025-03-12 Thread Stephen Hemminger
Use macro instead. Signed-off-by: Stephen Hemminger --- drivers/net/intel/i40e/i40e_ethdev.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/intel/i40e/i40e_ethdev.c b/drivers/net/intel/i40e/i40e_ethdev.c index 1c5ab35a8b..616053dd5b 100644 --- a/drivers

[RFC 3/7] graph: replace unnecessary comma operator

2025-03-12 Thread Stephen Hemminger
Use of comma as statement separator is discouraged and reported as warning by clang with -Wcomma Signed-off-by: Stephen Hemminger --- lib/graph/graph_stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c index 0bbbd9fb7c..14

[RFC 6/7] test: replace unnecessary comma operators

2025-03-12 Thread Stephen Hemminger
Use of comma as statement separator is discouraged and reported as warning by clang with -Wcomma Signed-off-by: Stephen Hemminger --- app/test/test_compressdev.c | 4 ++-- app/test/test_link_bonding_rssconf.c | 2 +- app/test/test_thash.c| 2 +- 3 files changed, 4 insert

[RFC 5/7] net/mlx5: replace unnecessary comma operators

2025-03-12 Thread Stephen Hemminger
Use of comma as statement separator is discouraged and reported as warning by clang with -Wcomma Signed-off-by: Stephen Hemminger --- drivers/net/mlx5/linux/mlx5_os.c| 4 ++-- drivers/net/mlx5/linux/mlx5_verbs.c | 2 +- drivers/net/mlx5/mlx5_flow.c| 12 ++-- drivers/net/mlx

[RFC 1/7] eal: replace unnecessary comma operator

2025-03-12 Thread Stephen Hemminger
Use of comma as statement separator is discouraged and reported as warning by clang with -Wcomma Signed-off-by: Stephen Hemminger --- lib/eal/common/rte_malloc.c | 4 ++-- lib/eal/linux/eal_alarm.c | 6 -- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/eal/common/rte_ma

[RFC 0/7] avoid unnecessary use of comma op

2025-03-12 Thread Stephen Hemminger
This series was motivated by recent thread on netdev about build with -Wcomma Stephen Hemminger (7): eal: replace unnecessary comma operator ipsec: replace unnecessary comma operator graph: replace unnecessary comma operator net/mlx4: replace unnecessary comma operators net/mlx5: replace

[RFC 2/7] ipsec: replace unnecessary comma operator

2025-03-12 Thread Stephen Hemminger
Use of comma as statement separator is discouraged and reported as warning by clang with -Wcomma Signed-off-by: Stephen Hemminger --- lib/ipsec/misc.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/ipsec/misc.h b/lib/ipsec/misc.h index fd4d3f5256..54dc5c2d4d 100644 ---

[DPDK/ethdev Bug 1673] failed to parse device "net_pcap0"

2025-03-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1673 Bug ID: 1673 Summary: failed to parse device "net_pcap0" Product: DPDK Version: 21.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Prior

[PATCH v3 1/3] eal: add function rte_size_to_str

2025-03-12 Thread Andre Muezerie
It's common to use %' in the printf format specifier to make large numbers more easily readable by having the thousands grouped. However, this grouping does not work on Windows. Therefore, a function is needed to make uint64_t numbers more easily readable. There are at least two tests that can bene

RE: [PATCH 1/4] raw/ifpga: remove unnecessary deref of function pointers

2025-03-12 Thread Xu, Rosen
Hi, > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, March 11, 2025 11:51 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Xu, Rosen > > Subject: [PATCH 1/4] raw/ifpga: remove unnecessary deref of function > pointers > > The expression *dev->ops->start and dev->ops->start

Re: [PATCH] net/intel: using common functions in idpf driver

2025-03-12 Thread Bruce Richardson
On Wed, Mar 12, 2025 at 09:23:51PM +0530, Shaiq Wani wrote: > reworked the drivers to use the common functions and structures > from drivers/net/intel/common. > > Signed-off-by: Shaiq Wani > --- > drivers/net/intel/common/tx.h | 21 +++- > drivers/net/intel/cpfl/cpfl_ethdev.c

[PATCH v3 3/3] hash_readwrite_autotest: fix printf parameters

2025-03-12 Thread Andre Muezerie
Compiling with MSVC logs the warnings below, which result in build error: ../app/test/test_hash_readwrite.c(73): warning C4476: 'printf' : unknown type field character ''' in format specifier ../app/test/test_hash_readwrite.c(75): warning C4474: 'printf' : too many arguments passed for for

Re: [PATCH] buildtools: remove invalid option for Microsoft linker

2025-03-12 Thread Andre Muezerie
On Wed, Mar 12, 2025 at 12:53:55PM +0100, David Marchand wrote: > On Wed, Mar 12, 2025 at 2:53 AM Andre Muezerie > wrote: > > > > When compiling "drivers" directory with MSVC the errors below popped up: > > > > drivers/rte_mempool_stack.pmd.c(1): error C2143: syntax error: > > missing ')' befo

RE: [PATCH] config/arm: fix march features not being set

2025-03-12 Thread Wathsala Wathawana Vithanage
Hi Pavan, I think this patch does the right thing. I have a minor comment on the cc.has_argument you have added. > --- > config/arm/meson.build | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/config/arm/meson.build b/config/arm/meson.build index > dea329ceb7

Re: [PATCH] doc: update virtio prog guide with new feature list

2025-03-12 Thread Maxime Coquelin
On 3/4/25 6:42 PM, Kommula Shiva Shankar wrote: This patch adds newly added virtio hash report feature to prog guide. Signed-off-by: Kommula Shiva Shankar --- doc/guides/nics/virtio.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/vir

[PATCH] net/mlx5: fix NAT64 register selection

2025-03-12 Thread Dariusz Sosnowski
PMD statically assumed that REG_C_6 is always available for use with NAT64 HW flow action. This led to PMD configuration errors on FW versions which do not expose that specific register. This patch fixes that by adding a check for REG_C_6 against FW capabilities, when registers for NAT64 are selec

Re: [PATCH] buildtools: remove invalid option for Microsoft linker

2025-03-12 Thread David Marchand
On Wed, Mar 12, 2025 at 2:53 AM Andre Muezerie wrote: > > When compiling "drivers" directory with MSVC the errors below popped up: > > drivers/rte_mempool_stack.pmd.c(1): error C2143: syntax error: > missing ')' before '(' > drivers/rte_mempool_stack.pmd.c(1): error C2059: syntax error: ')' >

Re: [PATCH] drivers: remove invalid options for MSVC

2025-03-12 Thread Andre Muezerie
On Wed, Mar 12, 2025 at 08:51:12AM +0100, David Marchand wrote: > On Wed, Mar 12, 2025 at 3:14 AM Andre Muezerie > wrote: > > > > When compiling "drivers" directory with MSVC the errors below popped up: > > > > 1) > > LINK : warning LNK4044: unrecognized option > > '/Wl,/def:V:\github\dpdk\build\d

Re: [PATCH] net/intel: remove unnecessary compiler flag for mingw

2025-03-12 Thread David Marchand
On Wed, Mar 12, 2025 at 4:55 PM Bruce Richardson wrote: > > There was an issue with building DPDK using mingw v8.1[1], which > required using the "-fno-asynchronous-unwind-tables" compiler flag when > building using the mingw compiler. However, recent versions of the > compiler no longer seem to n

Re: [PATCH v2] rust: support raw DPDK API

2025-03-12 Thread Thomas Monjalon
10/03/2025 17:25, Bruce Richardson: > On Mon, Mar 10, 2025 at 04:13:21PM +, Van Haaren, Harry wrote: > > Looking at the above parts of "Port abstraction in Rust", I'm not sure it > > really adds anything. > > It feels a bit "middle of the road" (aka, adding some "abstraction", but > > not goi

Re: [PATCH] rust: support DPDK API

2025-03-12 Thread Thomas Monjalon
12/03/2025 16:29, Igor Gutorov: > On Mon, Mar 10, 2025 at 7:34 PM Stephen Hemminger > wrote: > > > > The real benefit would the ability to support PMD's built in Rust. > > Having DPDK libraries as Rust crates would be beneficial as well. The > mempool library in particular is something I've wante

Re: [PATCH] drivers: remove invalid options for MSVC

2025-03-12 Thread David Marchand
On Wed, Mar 12, 2025 at 4:19 PM Bruce Richardson wrote: > > diff --git a/drivers/net/intel/ixgbe/meson.build > > b/drivers/net/intel/ixgbe/meson.build > > index 0ae12dd5ff..3553b0ffe1 100644 > > --- a/drivers/net/intel/ixgbe/meson.build > > +++ b/drivers/net/intel/ixgbe/meson.build > > @@ -27,7 +

[PATCH v3 0/3] fix how large numbers are printed by hash tests

2025-03-12 Thread Andre Muezerie
v3: - Added rte_size_to_str to version.map (marked experimental for 25.07) so that symbol gets exported when building with -Ddefault_library=shared - Added sample outputs - Added a space between the number and the postfix (if a postfix is present) Andre Muezerie (3): eal: add function r

[PATCH v2] eal/linux: improve ASLR check

2025-03-12 Thread Yang Ming
This change ensures that the current process is checked for being run with 'setarch' before verifying the value of '/proc/sys/kernel/randomize_va_space'. The '-R' or '--addr-no-randomize' parameter of the 'setarch' command is used to disable the randomization of the virtual address space. Fixes: a

Re: [External] Re: [PATCH] eal/linux: enhance ASLR verification

2025-03-12 Thread Yang Ming
On 2025/3/13 00:29, Stephen Hemminger wrote: Caution: This is an external email. Please be very careful when clicking links or opening attachments. See http://nok.it/nsb for additional information. On Wed, 12 Mar 2025 11:13:27 +0800 Yang Ming wrote: On 2025/3/11 05:43, Stephen Hemminger wr

[PATCH v5 2/2] dts: add VF configuration and workflow

2025-03-12 Thread Patrick Robb
This patch adds an additional test run config option for selecting physical functions or virtual functions for the testrun. If virtual function is selected, it adds a workflow for creating the virtual functions during test run setup. Bugzilla ID: 1500 Signed-off-by: Jeremy Spewock Signed-off-by:

[PATCH v5 1/2] dts: add OS abstractions for creating virtual functions

2025-03-12 Thread Patrick Robb
Virtual functions are created in different ways per operating system. Accordingly, we have abstracted the functions for managing virtual functions into different classes per OS. This patch adds stubs for creating virtual functions and gathering virtual function info. Bugzilla ID: 1500 Signed-off-

[PATCH v5 0/2] dts: add VFs to the framework

2025-03-12 Thread Patrick Robb
There currently is no method of creating or managing virtual functions (VFs) in the new DTS framework but there are multiple test suites in the old DTS framework that provide testing coverage using them. This patch adds the functionality to the framework that is needed to create and use VFs in test

[PATCH v3 2/3] hash_multiwriter_autotest: fix printf parameters

2025-03-12 Thread Andre Muezerie
Compiling with MSVC logs the warnings below, which result in build error: ../app/test/test_hash_multiwriter.c(71): warning C4476: 'printf' : unknown type field character ''' in format specifier ../app/test/test_hash_multiwriter.c(73): warning C4474: 'printf' : too many arguments passed for

RE: [PATCH] config/arm: fix march features not being set

2025-03-12 Thread Pavan Nikhilesh Bhagavatula
> Hi Pavan, > > I think this patch does the right thing. I have a minor comment on the > cc.has_argument you have added. > > > --- > > config/arm/meson.build | 11 --- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/config/arm/meson.build b/config/arm/meson.build

Re: [PATCH v2 1/7] eal: add queue macro extensions from FreeBSD

2025-03-12 Thread Stephen Hemminger
On Wed, 19 Feb 2025 15:55:17 +0100 Thomas Monjalon wrote: > 14/02/2025 18:20, Stephen Hemminger: > > The Linux version of sys/queue.h is frozen at an older version > > and is missing the _SAFE macro variants. Several drivers started > > introducing the own workarounds for this. Should be handled

[PATCH v3 9/9] net/ice: replace open coded version of LIST_FOREACH_SAFE

2025-03-12 Thread Stephen Hemminger
Use macro instead. Signed-off-by: Stephen Hemminger --- drivers/net/intel/ice/ice_ethdev.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/intel/ice/ice_ethdev.c b/drivers/net/intel/ice/ice_ethdev.c index 3cdfa16f77..72129f5e0e 100644 --- a/drivers/net/i

[RFC 7/7] app/testpmd: replace comma operator with bracket

2025-03-12 Thread Stephen Hemminger
Use while with brackets in favor of comma operator. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline_flow.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index ad646444f0..26807b0465 100644 --- a/app/t

[PATCH v3 1/9] eal: add queue macro extensions from FreeBSD

2025-03-12 Thread Stephen Hemminger
The Linux version of sys/queue.h is frozen at an older version and is missing the _SAFE macro variants. Several drivers started introducing the own workarounds for this. Should be handled in EAL. Signed-off-by: Stephen Hemminger --- lib/eal/include/meson.build | 3 +- lib/eal/include/rte_queue

[PATCH] doc: announce bus/vmbus API changes

2025-03-12 Thread longli
From: Long Li All vmbus APIs are used internally by DPDK core and net/netvsc PMD. It's not feasible or practical to use those APIs by the application. Those APIs will be moved from "DPDK" to "Internal" in DPDK 25.11. Signed-off-by: Long Li --- doc/guides/rel_notes/deprecation.rst | 4 1 f

RE: [EXTERNAL] Re: [patch v2 0/6] Support VMBUS channels without monitoring enabled

2025-03-12 Thread Long Li
> Can't take it as is, here are some options: > > 1. Version the API even though should only be used internally. Use API > versioning >as transistion until 25.11. > 2. Wait for 25.11 and just fix it now, and do deprecation notice now. > > 3. Mark the API's as internal (in 25.11) and do depre

[RFC 4/7] net/mlx4: replace unnecessary comma operators

2025-03-12 Thread Stephen Hemminger
Use of comma as statement separator is discouraged and reported as warning by clang with -Wcomma Signed-off-by: Stephen Hemminger --- drivers/net/mlx4/mlx4_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx4/mlx4_rxtx.c b/drivers/net/mlx4/mlx4_rxtx.c index