On Wed, 12 Mar 2025 00:33:52 +0000 Long Li <lon...@microsoft.com> wrote:
> > Subject: [EXTERNAL] Re: [patch v2 0/6] Support VMBUS channels without > > monitoring enabled > > > > On Mon, 10 Mar 2025 14:42:51 -0700 > > lon...@linuxonhyperv.com wrote: > > > > > From: Long Li <lon...@microsoft.com> > > > > > > Hyperv may expose VMBUS channels without monitoring enabled. In this > > > case, it programs almost all the data traffic to VF. > > > > > > This patchset enabled vmbus/netvsc to use channels without monitoring > > > enabled. > > > > > > CI still reports a build issue > > There are ABI changes to rte_vmbus_* calls. This patch added > rte_vmbus_device* as the 1st parameter to those calls. > > This will be a breaking change, and it only affects hn_netvsc as it's the > only PMD using the vmbus. > > Reading ./doc/guides/contributing/abi_policy.rst, I think the best option is > to use RTE_NEXT_ABI. But I can't find its definition in the code base. > > Please advise on how to proceed with making those breaking ABI changes. > > Thanks, > Long Can't take it as is, here are some options: 1. Version the API even though should only be used internally. Use API versioning as transistion until 25.11. 2. Wait for 25.11 and just fix it now, and do deprecation notice now. 3. Mark the API's as internal (in 25.11) and do deprecation notice now. 4. Make new functions with different names, and mark old ones as deprecated, then remove in 25.11
