On Wed, 19 Feb 2025 15:55:17 +0100
Thomas Monjalon <tho...@monjalon.net> wrote:
> 14/02/2025 18:20, Stephen Hemminger:
> > The Linux version of sys/queue.h is frozen at an older version
> > and is missing the _SAFE macro variants. Several drivers started
> > introducing the own workarounds for this. Should be handled in EAL.
> >
> > Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
>
> We may want to unify with lib/eal/windows/include/sys/queue.h
>
>
Not sure, we have several options here:
1. Keep using Linux sys/queue.h and add enhancements in rte_queue.h
2. Make rte_queue.h a copy of FreeBSD version of queue.h (that is what
Windows did)
3. Use the bsd version of queue.h.
On Debian/Ubuntu this in libbsd-dev package and referred to as
bsd/sys/queue.h
I chose #1 as simplest. But all of these could work. #3 means DPDK has least new
code, but adds another dependency to the build.
No matter what, should add to checkpatch to block any new files that include
sys/queue.h
directly.
