Re: [PATCH v1 1/1] baseband/acc: fix queue setup failure clean up

[Maxime Coquelin]

On 3/5/25 7:27 PM, Nicolas Chautru wrote:

Incomplete clean up for vrb2 variant when queue setup fails
to complete successfully.

Fixes: fc65d3dcabe01 ("baseband/acc: refactor queue allocation")
Cc: sta...@dpdk.org

Signed-off-by: Nicolas Chautru <nicolas.chau...@intel.com>
---
  drivers/baseband/acc/rte_vrb_pmd.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/baseband/acc/rte_vrb_pmd.c 
b/drivers/baseband/acc/rte_vrb_pmd.c
index 27620ccc10..2c10ef2c94 100644
--- a/drivers/baseband/acc/rte_vrb_pmd.c
+++ b/drivers/baseband/acc/rte_vrb_pmd.c
@@ -1156,6 +1156,8 @@ vrb_queue_setup(struct rte_bbdev *dev, uint16_t queue_id,
  free_q:
        rte_free(q);
        q = NULL;
+       if (d->device_variant == VRB2_VARIANT)
+               d->queue_index[conf->op_type]--;

return ret;

  }

Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com>

Thanks,
Maxime