> -Original Message-
> From: Bruce Richardson
> Sent: Tuesday, January 21, 2025 10:42 PM
> To: dev@dpdk.org
> Cc: Pravin Pathak ; Bruce Richardson
> ; sta...@dpdk.org
> Subject: [EXTERNAL] [PATCH] event/dlb2: fix event weight handling in SSE code
> path
>
> Commit 6e2e98d6775b ("event/
> -Original Message-
> From: Akhil Goyal
> Sent: Friday, January 24, 2025 11:52 PM
> To: dev@dpdk.org
> Cc: Jerin Jacob ; Akhil Goyal
> Subject: [PATCH] common/cnxk: check MACsec HW capability
>
> Added ROC API to check if hardware has capability to perform MACsec
> operations.
> Skip
> -Original Message-
> From: psathe...@marvell.com
> Sent: Thursday, January 23, 2025 11:23 AM
> To: Nithin Kumar Dabilpuram ; Kiran Kumar
> Kokkilagadda ; Sunil Kumar Kori
> ; Satha Koteswara Rao Kottidi
> ; Harman Kalra
> Cc: dev@dpdk.org; Satheesh Paul Antonysamy
> Subject: [EXTERN
Intel IGC and E1000 drivers are distinct, but they are actually generated
from the same base code. This patchset will merge together all e1000-derived
drivers into one common base, with three different ethdev driver
frontends (EM, IGB, and IGC).
After the merge is done, base code is also updated t
Do a direct copy of i225 code into e1000 directory, replacing all symbol
and definition names with e1000_/E1000_ prefix instead of igc_/IGC_ prefix.
This is done in preparation for merging the two drivers together.
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_api.c
IGC and E1000 drivers are derived from the same base code. Now that e1000
code has enabled support for i225 devices, move IGC ethdev code to e1000
directory (renaming references to base code from igc_* to e1000_*).
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/{igc => e1000}/igc_ethdev.c
Currently, e1000 base code is compiled with removing warning for unused
parameters. The e1000 codebase does define a few macros to suppress
unused parameters explicitly and dilligently uses them where they are
needed, but the definitions for these macros are empty in e1000 osdep
file, which is prob
Add missing i225 devices to the list of supported devices by IGC driver,
as well as resort the device list to match sorting order of definitions
in the base code.
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_api.c | 5 +++--
drivers/net/intel/e1000/base/e1000_hw.h | 18
Some hardware device ID's from i210 and i219 series were added over the
years, but they were never added to the table of support PCI ID's for EM
and IGB drivers respectively. This commit adds the missing device ID's to
the table.
Signed-off-by: Anatoly Burakov
---
Notes:
This commit is not c
On Tue, Feb 4, 2025 at 2:24 AM Andre Muezerie
wrote:
>
> Variable "success" was not being initialized and there was a code
> path where the last do/while loop in __rte_stack_lf_pop_elems
> looked at the value of this variable before it was set to any.
>
> Compiling with msvc resulted in stack_lf_a
On 03/02/2025 9:18, David Marchand wrote:
Hello Anatoly,
On Fri, Jan 31, 2025 at 1:59 PM Anatoly Burakov
wrote:
Intel IGC and E1000 drivers are distinct, but they are actually generated
from the same base code. This patchset will merge together all e1000-derived
drivers into one common base,
> -Original Message-
> From: Anoob Joseph
> Sent: Tuesday, January 28, 2025 1:46 PM
> To: Chengwen Feng ; Kevin Laatz
> ; Bruce Richardson ;
> Thomas Monjalon ; David Marchand
>
> Cc: Jerin Jacob ; Vidya Sagar Velumuri
> ; dev@dpdk.org
> Subject: [PATCH] doc: update ODM dmadev guide
>
06/12/2024 19:14, Andre Muezerie:
> On Fri, Dec 06, 2024 at 04:41:16PM +, Konstantin Ananyev wrote:
> >
> > > > > Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it.
> > > > > Therefore the errors below are seen with MSVC:
> > > > >
> > > > > ../lib/mldev/mldev_utils_scalar.
30/01/2025 09:37, David Marchand:
> Using pragma must be prevented to avoid breaking builds with other
> compilers.
> Let EAL use them (like for abstraction macros).
>
> Signed-off-by: David Marchand
> ---
> + # forbid use of #pragma
> + awk -v FOLDERS='lib drivers app examples' \
> +
04/02/2025 16:41, Denis Davidoglu:
> Packet parsing and type detection fail for packets containing
> Arista Vendor Specific Protocol (AVSP) headers. This patch adds
> support for three L2 headers: Arista TGen, Arista 64-bit Timestamp
> and Arista 48-bit Timestamp.
I'm not familiar with these head
This commit adds preliminary support for developer driven FreeBSD testing
via the Cirrus-CI cloud continuous integration system.
NOTE: Currently, this does not successfully execute. See the following
build result:
https://cirrus-ci.com/task/5626189961756672
Full Logs:
https://api.cirrus-ci.c
Tested from a Fedora41/python3.13 container.
Tested-by: Patrick Robb
Reviewed-by: Patrick Robb
Applying to next-dts, thanks for the patch Luca.
Tested from a Fedora41/python3.13 container.
Tested-by: Patrick Robb
Reviewed-by: Patrick Robb
Applying to next-dts, thanks for the patch Luca.
Tested from a Fedora41/python3.13 container.
Tested-by: Patrick Robb
Reviewed-by: Patrick Robb
Applying to next-dts, thanks for the patch Luca.
On 2025/1/30 2:06, Bruce Richardson wrote:
> On Wed, Jan 29, 2025 at 09:17:38AM -0800, Stephen Hemminger wrote:
>> On Wed, 29 Jan 2025 10:54:16 +0200
>> Shani Peretz wrote:
>>
>>> DPDK provides two formats for specifying PCI device numbers:
>>> a full version (":08:00.0") and a short version (
Even if RTE_ENABLE_ASSERT is not enabled, the expression used should
still be checked for compiler warnings. Use sizeof()
and ternary operator in same manner as the assert() macro to
cause the expression to be evaluated but not generate code.
This was motivated by detection of problems in a driver
From: Satheesh Paul
ROC changes to support NPC flow on cn20k.
Signed-off-by: Satheesh Paul
Reviewed-by: Kiran Kumar K
---
v2:
* Fixed generic platform compiler error.
v3:
* Removed compile time macros.
v4:
* Rebased the patches.
v5:
* Updated release notes.
* Fixed '__io' label for mbox field.
From: Satheesh Paul
Support for rte flow in cn20k.
Signed-off-by: Satheesh Paul
Reviewed-by: Kiran Kumar K
---
doc/guides/rel_notes/release_25_03.rst | 4 +
drivers/net/cnxk/cn10k_flow.c | 227 ++---
drivers/net/cnxk/cn10k_flow.h | 10 +-
drivers/net/c
>-Original Message-
>From: Andre Muezerie
>Sent: Saturday, December 28, 2024 6:53 AM
>To: andre...@linux.microsoft.com
>Cc: bruce.richard...@intel.com; dev@dpdk.org;
>konstantin.v.anan...@yandex.ru; Vamsi Krishna Attunuru
>
>Subject: [EXTERNAL] [PATCH v2] drivers/net: use intrinsic to a
Hi David,
> On Feb 4, 2025, at 21:18, David Marchand wrote:
>
> External email: Use caution opening links or attachments
>
>
> Hello vhost maintainers,
>
> On Tue, Dec 24, 2024 at 4:50 PM Maxime Coquelin
> wrote:
>>
>> The vhost FD manager provides a way for the read/write
>> callbacks to r
Hello,
Please don't go private, as I tend to just ignore such mail.
Re-adding ml and others.
And don't top post.
On Wed, Feb 5, 2025 at 8:06 AM Nafiah Siddiqha
wrote:
>
> Hi,
> I'm able to run testpmd with the given set of instructions you had mentioned
> and tried it with pktgen fir which I'm
Reviewed-by: Luca Vizzarro
Hello,
Adding pktgen maintainer in the loop.
On Tue, Feb 4, 2025 at 2:42 PM Nafiah Siddiqha
wrote:
>
> Hi,
> I'm testing pktgen application using OpenNIC driver, but I face device cannot
> parse issue ,
> What do I need to pass in my vdev parameter for it to run
>
> Below are the logs of the er
https://bugs.dpdk.org/show_bug.cgi?id=1659
Bug ID: 1659
Summary: Softnic should be implemented as a proper
VirtualDevice
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRM
Release status meeting minutes 2025-02-04
=
Agenda:
* Release Dates
* Subtrees
* Roadmaps
* LTS
* Defects
* Opens
Participants:
* Broadcom
* ARM
* Intel
* Marvell
* Microsoft
* Nvidia
* Red Hat
Release Dates
-
The following are the proposed w
From: Nir Efrati
Integrated NVM is not supported on i225 and can be removed.
Signed-off-by: Nir Efrati
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_i225.c | 98 +--
drivers/net/intel/e1000/base/e1000_i225.h | 2 -
2 files changed, 1 insertion(+),
From: Dima Ruinskiy
Static analysis has reported that when there is no get link status callback
function, the value set in the if condition is not used and gets
overwritten in the "out" section of the code. Fix by not seting the
variable.
Signed-off-by: Dima Ruinskiy
Signed-off-by: Anatoly Bura
From: Sasha Neftin
When writing to Shadow RAM, we set rev_val on success, but since the value
is already set to success initially, it is possible for none of the writes
to be successful, yet ret_val will still be set to success. Fix it by
resetting the ret_val to failure before every loop iterati
From: Nir Efrati
On some MAC types, packet loss is observed due to wake DMA clock gating.
Disable wake DMA clock for some MAC types to avoid packet loss.
Signed-off-by: Nir Efrati
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_ich8lan.c | 7 +++
drivers/net/intel/e1
From: Vitaly Lifshits
Starting from MTP PHY type there is a synchronization issue between the
PHY's clock and PCH's synopsis PHY. This causes Tx packets corruptions.
The workaround to this issue is to change P0s power down state from
P0/P0s to P1 prior to disabling K1.
Signed-off-by: Vitaly Lif
From: Nir Efrati
Some tools need access to the function, so make it non-static.
Signed-off-by: Nir Efrati
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_i225.c | 2 +-
drivers/net/intel/e1000/base/e1000_i225.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff
From: Dima Ruinskiy
The LTR maximum value was incorrectly written using the scale from the
LTR minimum value. This would cause incorrect values to be sent, in cases
where the initial calculation lead to different min/max scales. Fix the
typo to correctly calculate the LTR maximum value.
Signed-o
From: Pawel Malinowski
According to datasheet software ownership of SWSM.SWESMBI bit should not
exceed 100ms. Current implementation caused incorrect timeout counter
values, where each iteration equals 50us delay. Because of that driver was
allowed to wait for semaphore even for 1,5s. This might
From: Sasha Neftin
i225 specification recommends minus 1 microsecond from a value
calculated for a LTR. Fix the calculation to match spec.
Signed-off-by: Sasha Neftin
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_i225.c | 2 ++
1 file changed, 2 insertions(+)
diff --g
From: Carolyn Wyborny
On 82575, driver is not supposed to check if managegement control is
enabled, and flush the Rx FIFO unconditionally.
Signed-off-by: Carolyn Wyborny
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_base.c | 3 ++-
1 file changed, 2 insertions(+), 1 de
From: Marcin Jurczak
This patch removes non-inclusive language from the e1000 shared code and
comments.
Signed-off-by: Marcin Jurczak
Signed-off-by: Anatoly Burakov
---
.../net/intel/e1000/base/e1000_80003es2lan.c | 8 ++--
drivers/net/intel/e1000/base/e1000_82571.c| 4 +-
drivers/net/
From: Nir Efrati
Sporadic MDI errors are observed on some platforms. To address them, a
read/write retry mechanism is introduced. Set the initial retry counter
to 3 with an option to disable/enable the mechanism for some specific
flows that errors are expected.
Signed-off-by: Nir Efrati
Signed-
From: Sasha Neftin
When reading NVM checksum, we may encounter the following scenarios:
- Checksum may be invalid, and can be updated
- Checksum may be invalid but cannot be updated because NVM is read-only
For the latter case, we should just ignore invalid checksum and not attempt
to update it
From: Dima Ruinskiy
PHY page and register notation traditionally uses decimal numbering. This
patch aligns the debug prints to this notation, as well as moves prints
to after we get a value of interest to us.
Signed-off-by: Dima Ruinskiy
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1
From: Adam Ludkiewicz
Define constants for WoL control on i210 NICs.
Signed-off-by: Adam Ludkiewicz
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_i210.h | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/intel/e1000/base/e1000_i210.h
b/drivers/net/int
From: Nir Efrati
Remove workaround for hardware synchronization before reset. The original
bug that was fixed by this workaround was root caused later and fixed in
other ways.
Signed-off-by: Nir Efrati
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_ich8lan.c | 17 --
From: Vitaly Lifshits
Add support for new hardware ID's from the I219 series.
Signed-off-by: Lifshits, Vitaly
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_api.c | 32 +
drivers/net/intel/e1000/base/e1000_hw.h | 36 +---
drivers
From: Sasha Neftin
PHY specification for i225 requires 300 microsecond delay after power up
sequence, so increase the delay after power up to 300 microseconds.
Signed-off-by: Sasha Neftin
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_phy.c | 1 +
1 file changed, 1 inse
From: Przemyslaw Ciesielski
Static analysis has found type mismatch between mask and register value.
Fix the bitwise operation type to avoid potential issues.
Signed-off-by: Przemyslaw Ciesielski
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_i225.c | 2 +-
1 file chang
Some definitions that are present in the base code are missing from DPDK.
This patch adds the following definitions:
- EEPROM R/W v2 modes
- BAR ctrl CSR shift size
- I225 flash access register
- EEE-related registers
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_defines
From: Evgeny Efimov
Use PHY reset generic implementation for i225.
Signed-off-by: Evgeny Efimov
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_i225.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/intel/e1000/base/e1000_i225.c
b/drivers/net/intel/e1000
From: Dima Ruinskiy
Currently, when writing GPY PHY registers, semaphor is acquired before
writing. However, if writing fails, semaphor is not released, causing
a deadlock down the line. Fix the issue by removing premature return.
Signed-off-by: Dima Ruinskiy
Signed-off-by: Anatoly Burakov
---
From: Dima Ruinskiy
When the driver fails to acquire HW semaphore, there is nothing that can be
done to address it, so just leave to avoid an infinite loop.
Signed-off-by: Dima Ruinskiy
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_i225.c | 11 +--
1 file chang
From: Sasha Neftin
It is expected that PHY power management control should provide a reliable
and accurate indication of PHY reset completion and decrease the delay time
after a PHY reset.
Signed-off-by: Sasha Neftin
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_define
From: Dima Ruinskiy
Call e1000_get_bus_info_pcie_generic from i225 to read PCIe bus info.
Signed-off-by: Dima Ruinskiy
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_i225.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/intel/e1000/bas
From: Piotr Pietruszewski
This change rearranges the ICH8LAN code to have less indentation levels.
Signed-off-by: Piotr Pietruszewski
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_ich8lan.c | 84 ++--
1 file changed, 43 insertions(+), 41 deletions(-)
d
From: Dima Ruinskiy
Mark e1000_access_phy_wakeup_reg_bm as non-static.
Signed-off-by: Dima Ruinskiy
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_phy.c | 6 ++
drivers/net/intel/e1000/base/e1000_phy.h | 2 ++
2 files changed, 4 insertions(+), 4 deletions(-)
diff -
The original code had incorrect indentation, and the fix was applied to
follow the indentation, i.e. adding brackets making the indentation valid.
However, the actual issue was incorrect indentation and not missing braces,
so the fix was incorrect.
This fix restores the original logic and corrects
From: Nir Efrati
Add some definitions related to ULP WoL, and set longer ULP exit timeout on
more MAC types.
Signed-off-by: Nir Efrati
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_hw.h | 1 +
drivers/net/intel/e1000/base/e1000_ich8lan.c | 2 +-
drivers/net/intel/
From: Nir Efrati
Add Extended Firmware Semaphore (EXFWSM) register definition.
Signed-off-by: Nir Efrati
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_defines.h | 3 ++-
drivers/net/intel/e1000/base/e1000_regs.h| 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
Add enable/disable EEE API to base code.
Signed-off-by: Evgeny Efimov
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_api.c | 17 +
drivers/net/intel/e1000/base/e1000_api.h | 1 +
drivers/net/intel/e1000/base/e1000_hw.h | 1 +
drivers/net/intel/e1000/
From: Sasha Neftin
Some tools require device profile information to be present, so add it.
Signed-off-by: Sasha Neftin
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_hw.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/intel/e1000/base/e1000_hw.h
b/driv
From: Sasha Neftin
Add new fields in structure to indicate if EEE LPI entries have been
observed on Tx and Rx path.
Signed-off-by: Sasha Neftin
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_hw.h | 2 ++
drivers/net/intel/e1000/base/e1000_mac.c | 2 ++
2 files changed,
From: Sasha Neftin
Add definitions for address select mask (selects source address to be
used in the address filtering), as well as queue select (indicates which
Rx queue should get the packet matching this MAC address).
Signed-off-by: Sasha Neftin
Signed-off-by: Anatoly Burakov
---
drivers/n
From: Barbara Skobiej
One of the bit shifts in MAC hash calculation triggers a static analysis
warning about a potential overflow. Fix the data type to avoid this.
Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org
Signed-off-by: Barbara Skobiej
Signed-off-by: Anatoly Burakov
--
From: Dima Ruinskiy
Static analysis has detected a write that is not checked for errors,
leading to ignored error return value. Add a check.
Fixes: edcdb3c5f71b ("e1000/base: fix link flap on 82579")
Cc: sta...@dpdk.org
Signed-off-by: Dima Ruinskiy
Signed-off-by: Anatoly Burakov
---
drivers/
From: Jakub Buchocki <101559614+jbuch...@users.noreply.github.com>
Coverity has detected potential usage of uninitialized values inside the
array. Fix the warning by initializing array.
Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org
Signed-off-by: Jakub Buchocki
Signed-off-by:
From: Przemysław Ciesielski
There are some static analysis warnings due to wrong data types being used
for various operations. Fix them with explicit typecasts.
Fixes: 5a32a257f957 ("e1000: more NICs in base driver")
Fixes: 38db3f7f50bd ("e1000: update base driver")
Cc: sta...@dpdk.org
Signed-o
From: Loktionov Aleksandr
In e1000_hash_mc_addr_generic() the expression:
"mc_addr[4] >> 8 - bit_shift", right shifting "mc_addr[4]"
shift by more than 7 bits always yields zero, so hash becomes not so
different. Add initialization with bit_shift = 1, and add a loop condition
to ensure
From: Barbara Skobiej
Fix setting device reset status bit in e1000_reset_hw_82580() function
for 82580 by first reading the register value, and then setting the
device reset bit.
Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org
Signed-off-by: Barbara Skobiej
Signed-off-by: Anat
From: Amir Avivi
Fix static analysis warning about comparison between types of
incompatible width, which might lead to an infinite loop due to overflow.
Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org
Signed-off-by: Amir Avivi
Signed-off-by: Anatoly Burakov
---
drivers/net/i
There are some mismatches between what's in the base driver, and what is
in DPDK version of it. This patch fixes the following issues:
- Unneeded #ifndef clause
- Missing comments
- Duplicate definitions
- Moved definitions
- Extraneous fall-through comments
- Function comments not matching functi
From: Piotr Kubaj
Rename version to nvm_version to avoid shadowing global variables on some
systems.
Signed-off-by: Piotr Kubaj
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_i210.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drive
Update README with more up-to-date information.
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/README | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/intel/e1000/base/README
b/drivers/net/intel/e1000/base/README
index b84ee5ad6e..2a0696f3
From: Dima Ruinskiy
Current implementation of e1000_get_bus_info_ich8lan first attempts to
call e1000_get_bus_info_pcie_generic, and hard codes the bus width if the
latter does not return a valid value.
However, e1000_get_bus_info_pcie_generic will always fail on an ICH
device, since no PCIe cap
From: Menachem Fogel
Implement LED blinking for i225.
Signed-off-by: Fogel Menachem
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_i225.c | 44 +++
drivers/net/intel/e1000/base/e1000_i225.h | 8 +
2 files changed, 52 insertions(+)
diff --git a/
From: Sasha Neftin
Align VLAN PQF naming convention to base code usage, as well as fix typos.
Signed-off-by: Sasha Neftin
Signed-off-by: Anatoly Burakov
---
drivers/net/intel/e1000/base/e1000_defines.h | 6 +++---
drivers/net/intel/e1000/base/e1000_regs.h| 2 +-
2 files changed, 4 inserti
On Tue, Feb 04, 2025 at 10:30:03AM +, Bruce Richardson wrote:
> On Mon, Feb 03, 2025 at 05:58:38PM -0800, Andre Muezerie wrote:
> > An implementation compatible with MSVC is provided for
> > atomic128_cmp_exchange in rte_stack_lf_c11.h.
> >
> > Now that the issues preventing the code needed to
From: Nir Efrati
On some customer platforms it was observed that invalid PHY ID (0x) was
returned on first try. This patch introduces PHY ID retry mechanism to
perform retries on PHY ID read for up to a second. Because the original
code was intentionally not checking PHY ID due to a different
Packet parsing and type detection fail for packets containing
Arista Vendor Specific Protocol (AVSP) headers. This patch adds
support for three L2 headers: Arista TGen, Arista 64-bit Timestamp
and Arista 48-bit Timestamp.
Signed-off-by: Denis Davidoglu
---
lib/net/rte_ether.h | 31 ++
It looks like this failed the check-meson script which we incorporated into
our apply/build pipeline recently, which is why this series got a "build
failure." It is indicating there are issues with lib/vhost/meson.build
and app/test/meson.build.
Obviously we need to provide an email body which mak
From: Konstantin Ananyev
../lib/gro/rte_gro.c:182:34: warning:
variable length array used [-Wvla]
../lib/gro/rte_gro.c:363:34: warning:
variable length array used [-Wvla]
In both cases the pattern is the same: we use unprocess_pkts[nb_pkts] to
collect un-used by GRO packets, and then cop
From: Konstantin Ananyev
gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account
that first entries in pkts[] can be already occupied by
un-processed packets.
Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP")
Cc: sta...@dpdk.org
Signed-off-by: Konstantin Ananyev
Acked-by: Ferr
From: Konstantin Ananyev
1) ./lib/rcu/rte_rcu_qsbr.c:359:9
: warning: ISO C90 forbids variable length array ‘data’ [-Wvla]
2) ./lib/rcu/rte_rcu_qsbr.c:422:9
: warning: ISO C90 forbids variable length array ‘data’ [-Wvla]
In both cases we allocate VLA for one element from RCU deferred que
From: Konstantin Ananyev
1) ./lib/ethdev/rte_ethdev.c:3244:16
: warning: ISO C90 forbids variable length array ‘xstats_names’
2) ./lib/ethdev/rte_ethdev.c:3345:17
: warning: ISO C90 forbids variable length array ‘ids_copy’
3) ./lib/ethdev/rte_ethdev.c:3538:16
: warning: ISO C90 forbid
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
Acked-by: Chengwen Feng
---
app/test-pmd/cmdline.c | 2 +-
app/test
From: Konstantin Ananyev
../drivers/net/ice/ice_rxtx.c:1871:29: warning:
variable length array used [-Wvla]
Here VLA is used as a temp array for mbufs that will be used as a split
RX data buffers.
As at any given time only one thread can do RX from particular queue,
at rx_queue_setup() we ca
From: Konstantin Ananyev
1) ./lib/hash/rte_cuckoo_hash.c:2362:9
: warning: ISO C90 forbids variable length array ‘positions’
2) ../lib/hash/rte_cuckoo_hash.c:2478:9
: warning: ISO C90 forbids variable length array ‘positions’
Both rte_hash_lookup_bulk_data() and
rte_hash_lookup_with_hash
From: Konstantin Ananyev
1) ../drivers/net/ixgbe/ixgbe_ethdev.c:3556:46: warning:
variable length array used [-Wvla]
2) ../drivers/net/ixgbe/ixgbe_ethdev.c:3739:23: warning:
variable length array used [-Wvla]
3) ../drivers/net/ixgbe/ixgbe_rxtx_vec_common.h:17:24: warning:
variable len
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
Acked-by: Bruce Richardson
---
drivers/common/idpf/idpf_common_rxtx.c
From: Konstantin Ananyev
1) ./lib/hash/rte_thash.c:774:9
: warning: ISO C90 forbids variable length array ‘tmp_tuple’
The tuple can exceed sizeof(union rte_thash_tuple), for example if any
tunneling header is used in the RSS hash calculation.
The longest RSS hash key currently supported is
From: Konstantin Ananyev
1) ./lib/eal/linux/eal_interrupts.c:1073:16
: warning: ISO C90 forbids variable length array 'events'
MSVC does not support VLAs. Use alloca() to allocate the memory on
the stack.
2) ./lib/eal/linux/eal_interrupts.c:1319:16
: warning: ISO C90 forbids variable le
As per guidance technical board meeting 2024/04/17. This series
removes the use of VLAs from code built for Windows for all 3
toolchains. If there are additional opportunities to convert VLAs
to regular C arrays please provide the details for incorporation
into the series.
MSVC does not support VL
From: Konstantin Ananyev
1) ../lib/eal/common/eal_common_proc.c:695:15
: warning: variable length array used
As msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced
it with fixed size array.
Signed-off-by: Konstantin Ananyev
Acked-by: Stephen Hemminger
---
lib/eal/common/eal_common
From: Tyler Retzlaff
Include alloca.h for Linux and malloc.h for Windows to get declaration
of alloca().
Signed-off-by: Tyler Retzlaff
---
lib/eal/freebsd/include/rte_os.h | 1 +
lib/eal/linux/include/rte_os.h | 1 +
lib/eal/windows/include/rte_os.h | 1 +
3 files changed, 3 insertions(+)
d
The no_wvla_cflag is added to meson.build files in directories that
are not yet VLA-free.
Signed-off-by: Andre Muezerie
---
drivers/common/cnxk/meson.build | 2 ++
drivers/common/mlx5/meson.build | 2 ++
drivers/common/qat/meson.build | 2 ++
drivers/crypto/ccp/meson.build
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Andre Muezerie
Acked-by: Chengwen Feng
---
app/test-pmd/shared_rxq_fwd.c | 2 +-
1 file changed, 1 insertion(+)
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
drivers/net/mlx5/mlx5.c | 5 ++---
drivers/net/mlx5/mlx5_flow.c |
The no_wvla_cflag is added to meson.build files in directories that
are not yet VLA-free.
Signed-off-by: Andre Muezerie
---
lib/acl/meson.build| 2 ++
lib/bpf/meson.build| 2 ++
lib/dispatcher/meson.build | 2 ++
lib/eventdev/meson.build | 2 ++
lib/ipsec/meson.build |
MSVC does not support VLAs, replace VLAs with standard C arrays.
Signed-off-by: Andre Muezerie
---
lib/hash/rte_thash_gf2_poly_math.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/lib/hash/rte_thash_gf2_poly_math.c
b/lib/hash/rte_thash_gf2_poly_math.c
index 1c6297
1 - 100 of 158 matches
Mail list logo
