When encountering errors in handling some queues, we should assert
here; otherwise, some queues will fail to send packets continuously,
leading to traffic forwarding issues.
Bugzilla ID: 1449
Signed-off-by: Jun Wang
---
drivers/net/mlx5/mlx5_tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deleti
Flex arrays are part of the C99 standard.
No need to mark them with __extension__.
Signed-off-by: David Marchand
---
I noticed this while reviewing Tyler series on some libraries.
Let's see if the compilers in the CI agrees with the patch.
---
drivers/crypto/ipsec_mb/ipsec_mb_private.h | 2 +-
> From: David Marchand [mailto:david.march...@redhat.com]
> Sent: Wednesday, 12 June 2024 09.13
>
> Flex arrays are part of the C99 standard.
> No need to mark them with __extension__.
>
> Signed-off-by: David Marchand
> ---
Thank you for cleaning this up.
Acked-by: Morten Brørup
Hello,
On Wed, Mar 6, 2024 at 11:14 PM Tyler Retzlaff
wrote:
>
> Use existing __rte_may_alias macro from rte_common.h instead of
> directly using __attribute__((__may_alias__)).
>
> Signed-off-by: Tyler Retzlaff
> ---
> drivers/net/cxgbe/base/common.h | 2 +-
> drivers/net/cxgbe/base/t4_hw.c
On 12/5/23 12:01, yuanzhiyuan0...@outlook.com wrote:
From 4cf72842a07b2270876939fd2bb2367efaad95f4 Mon Sep 17 00:00:00 2001
From: Yuan Zhiyuan
Date: Fri, 1 Dec 2023 11:27:51 +
Subject: [PATCH] vhost: optimize vhost user get protocol features
variable features is unused in vhost_user_get_
On 4/10/24 17:21, Luca Vizzarro wrote:
Hi everyone,
sending in a patch to resolve some build issues encountered with
GCC 13.2 when building against 32-bit targets. These issues were
originally reported by Luca Boccassi in one of his stable builds[1].
Although, I have noticed that this problem
On 3/21/24 10:57, Haoqian He wrote:
We should cleanup vq resubmit info when set_inflight_fd
before set_vring_kick which will check if there is any
inflight io waiting for resubmission.
Otherwise, when the vm is rebooting immediately after
reconnecting to the vhost target (inflight io has not
On 5/14/24 11:16, Daniil Ushkov wrote:
This patch introduces a new flag RTE_VHOST_USER_ASYNC_CONNECT,
which in combination with the flag RTE_VHOST_USER_CLIENT makes
rte_vhost_driver_start connect asynchronously to the vhost server.
Signed-off-by: Daniil Ushkov
---
* Rerun checks.
* Fix commi
On 3/29/24 00:33, Andrey Ignatov wrote:
Currently virtio_dev_tx_packed() always allocates requested @count of
packets, no matter how many packets are really available on the virtio
Tx ring. Later it has to free all packets it didn't use and if, for
example, there were zero available packets on
On 2/20/24 12:40, Nithin Dabilpuram wrote:
VIRTIO_F_ORDER_PLATFORM is needed feature when working with
real HW platforms that are exposing virtio-net devices
via VDPA framework. This feature helps in having more
real ordering requirements between descriptor updates and
notification data update
On 11. 6. 2024 17:33, Jeremy Spewock wrote:
On Tue, Jun 11, 2024 at 5:17 AM Juraj Linkeš wrote:
On 10. 6. 2024 22:06, Jeremy Spewock wrote:
Overall, my thoughts are that it's definitely an interesting idea to
make the normal shell subclass the critical. I explain more below, but
basicall
On 3/28/24 14:08, Maxime Coquelin wrote:
This series aims at fixing several issues found in
Virtio-user PMD related to queues setup and cleanup.
It has been tested with Vhost-vDPA backend using Nvidia
Cx6-Dx vDPA VF.
First patch in the series renames the queues iterator
helper, so it is not
On 6/11/24 15:39, Maxime Coquelin wrote:
This series aims at improving the Vhost FD manager.
The fdset internals is hidden from its callers, the
notification/synchronization is made systematic for
every FD add/del operations and finally the code is
reworked to make use of epoll insteal of pol
On 6/7/2024 2:03 PM, Serhii Iliushyk wrote:
Moved down. Please don't top post.
>
>
> *From:* Mykola Kostenok
> *Sent:* 04 June 2024 13:29
> *To:* Serhii Iliushyk ; dev@dpdk.org
> *Cc:* Christian Koue Muf ;
> andrew.rybche
On 6/12/2024 9:50 AM, Ferruh Yigit wrote:
> On 6/7/2024 2:03 PM, Serhii Iliushyk wrote:
>
> Moved down. Please don't top post.
>
>>
>>
>> *From:* Mykola Kostenok
>> *Sent:* 04 June 2024 13:29
>> *To:* Serhii Iliushyk ; dev@
On 5/2/24 22:45, Hernan Vargas wrote:
v2: Label memory barrier change as a fix.
v1: This series targeting 24.07 removes unused/dead code, memory barrier
improvements, cosmetic log changes.
Hernan Vargas (5):
baseband/acc: fix memory barrier
baseband/acc: remove ACC100 unused code
ba
On 11. 6. 2024 11:51, Luca Vizzarro wrote:
While working on my blocklist patch, I've just realised I forgot to add
another comment. I think it would be ideal to make capabilities a
generic class, and NicCapability a child of this. When collecting
capabilities we could group these by the fina
On 4/22/24 21:07, Hernan Vargas wrote:
Fix discrepancy in logic when using large fake mbuf.
Fixes: fd96ef3787f1 ("test/bbdev: extend support for large TB")
Cc: sta...@dpdk.org
Signed-off-by: Hernan Vargas
---
app/test-bbdev/test_bbdev_perf.c | 3 ++-
1 file changed, 2 insertions(+), 1 de
On Mon, May 6, 2024 at 6:09 PM Tyler Retzlaff
wrote:
> On Fri, May 03, 2024 at 07:35:48PM +0100, Daniel Gregory wrote:
> > Missed during commit 1ec6a845b5cb
> > ("eal: use stdatomic API in public headers")
> >
> > Signed-off-by: Daniel Gregory
> Acked-by: Tyler Retzlaff
>
Applied, thanks.
--
On 4/22/24 21:07, Hernan Vargas wrote:
For perf tests, the operation size for the MLD-TS was incorrect.
Fixed so that the performance numbers are correct.
Largely cosmetic only.
Fixes: 95f192a40e35 ("test/bbdev: add MLD cases")
Cc: sta...@dpdk.org
Signed-off-by: Hernan Vargas
---
app/test
On 4/22/24 21:07, Hernan Vargas wrote:
Fix possible error with regards to setting the burst size from the
enqueue thread.
Fixes: b2e2aec3239e ("app/bbdev: enhance interrupt test")
Cc: sta...@dpdk.org
Signed-off-by: Hernan Vargas
---
app/test-bbdev/test_bbdev_perf.c | 98 --
On 4/22/24 21:07, Hernan Vargas wrote:
-t --iter-max used for max number of iterations.
-T --timeout used for test timeout value.
Signed-off-by: Hernan Vargas
---
app/test-bbdev/test-bbdev.py | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/app/test-bb
On 4/22/24 21:07, Hernan Vargas wrote:
Print more info and format message for test timeouts.
No functional impact.
Signed-off-by: Hernan Vargas
---
app/test-bbdev/test-bbdev.py | 22 ++
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/app/test-bbdev/test-
Hi Jack,
> -Original Message-
> From: Jack Bond-Preston
> Sent: Tuesday, June 4, 2024 3:55 PM
> To: Ciara Power
> Cc: dev@dpdk.org; Wathsala Vithanage ; Paul
> Szczepanek
> Subject: [PATCH] app/test-crypto-perf: add shared session option
>
> Add the option to create one session for the
On 4/22/24 21:07, Hernan Vargas wrote:
Add vector parsing capability for soft output vectors.
Signed-off-by: Hernan Vargas
---
app/test-bbdev/test_bbdev_vector.c | 4
1 file changed, 4 insertions(+)
diff --git a/app/test-bbdev/test_bbdev_vector.c
b/app/test-bbdev/test_bbdev_vector.
On 4/22/24 21:07, Hernan Vargas wrote:
Add check for FFT window width.
Signed-off-by: Hernan Vargas
---
app/test-bbdev/test_bbdev_perf.c | 26 ++
app/test-bbdev/test_bbdev_vector.c | 14 ++
app/test-bbdev/test_bbdev_vector.h | 2 ++
3 files changed
On 4/22/24 21:07, Hernan Vargas wrote:
Update check for FFT measurement output to better account for tolerance.
Signed-off-by: Hernan Vargas
---
app/test-bbdev/test_bbdev_perf.c | 52 +++-
1 file changed, 51 insertions(+), 1 deletion(-)
Reviewed-by: Maxime C
On 4/22/24 21:08, Hernan Vargas wrote:
Remove unnecesary line of code.
No functional impact.
Signed-off-by: Hernan Vargas
---
app/test-bbdev/test_bbdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/app/test-bbdev/test_bbdev.c b/app/test-bbdev/test_bbdev.c
index cf224dca5d04..0bbce6
On 5/30/24 19:40, skotesh...@marvell.com wrote:
From: Satha Rao
Don't send NULL MAC addresses in MAC table update.
Fixes: 1b306359e58 ("virtio: suport multiple MAC addresses")
Cc: step...@networkplumber.org
Cc: sta...@dpdk.org
Signed-off-by: Satha Rao
---
drivers/net/virtio/virtio_ethde
Hello,
On Wed, Jun 12, 2024 at 1:01 PM wrote:
> From 7da90caa892abc0ab27fc11e892f6616f4bc8c9a Mon Sep 17 00:00:00 2001
> From: Yong Zhang
> Date: Wed, 12 Jun 2024 17:35:34 +0800
> Subject: [PATCH] raw/zxdh: introduce zxdh raw device driver
>
> Introduce rawdev driver support for ZXDH which
> can
On 5/30/24 19:40, skotesh...@marvell.com wrote:
From: Satha Rao
Don't send NULL MAC addresses in MAC table update.
Fixes: 1b306359e58 ("virtio: suport multiple MAC addresses")
Cc: step...@networkplumber.org
Cc: sta...@dpdk.org
Signed-off-by: Satha Rao
---
drivers/net/virtio/virtio_ethde
On 6/10/2024 11:07 PM, mmaatuq wrote:
> in case we didn't enter or finished the loop without getting ifname we
> ret shouldn't have an arbitrary value.
>
> Coverity issue: 424690
>
> Signed-off-by: mmaatuq
>
Change looks good to me,
but can you please add Fixes tag [1] and perhaps stable tag ba
This is a patchset loosely based on internal development tree which
tracked ICE driver development over a period of time since last
snapshot update.
RFC -> v1:
- From one, many
Anatoly Burakov (21):
net/ice/base: alloc port_info only once
net/ice/base: be more verbose when preparing timer syn
From: Ian Stokes
Update E830 header file for use with simulation systems.
Signed-off-by: Paul Greenwalt
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_hw_autogen.h | 78 +--
1 file changed, 49 insertions(+), 29 deletions(-)
diff --git a/drivers/net/ice/base/ic
From: Ian Stokes
Update en_link in curr_user_phy_cfg.caps on successful execution of
set_link_restart_an operation.
Signed-off-by: Siddaraju DH
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_common.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/driv
From: Ian Stokes
Currently, the 'temp' variable is in the same scope as 'first_teid_ptr'
and we take point to it, which means on new loop iterations the memory
goes out of scope and we keep a dangling pointer. Move 'temp' to
outside of the loop to fix it.
Signed-off-by: Stefan Wegrzyn
Signed-of
From: Ian Stokes
Replace all usages of ICE_SUCCESS with its integer equivalent.
Signed-off-by: Przemek Kitszel
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_acl.c | 2 +-
drivers/net/ice/base/ice_acl_ctrl.c | 16 +--
drivers/net/ice/base/ice_common.c| 78 +++---
From: Ian Stokes
When building with certain targets, a missing include was causing a compilation
failure. Add the missing include.
Signed-off-by: Jesse Brandeburg
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_flow.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ice/
From: Ian Stokes
Support to add large action to set 32 bits markid via switch filter.
Signed-off-by: Zhirun Yan
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_switch.c | 22 --
drivers/net/ice/base/ice_switch.h | 24
2 files changed, 24 ins
From: Ian Stokes
The ice_debug_cq function is called to print debug data for a control queue
descriptor in multiple places. This includes both before we send a message on a
transmit queue, after the writeback completion of a message on the transmit
queue, and when we receive a message on a receiv
From: Ian Stokes
Add new Admin Q command to check if netlist auth is supported.
Signed-off-by: Fabio Pricoco
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_common.c | 5 +
drivers/net/ice/base/ice_type.h | 2 ++
2 files changed, 7 insertions(+)
diff --git a/drivers/net/ice/base
From: Ian Stokes
Initialize some variable to avoid "variable might be not defined" warning. This
is due to the fact that for QV, sometimes alternative fragments of code are
being executed exclusively thanks to use of goto, which some compilers cannot
handle correctly.
Signed-off-by: Fabio Pricoc
From: Ian Stokes
The use of get link status PHY type for determining the media type can result in
incorrect reporting the incorrect media type. This can happen for a couple
reasons:
1. The get link states current PHY type field can return non-PHY type values
(i.e. bit 127 indicates link state d
From: Ian Stokes
ice_flow_seg_info fields match and range are being used with bit
operations but not declared as bitmaps. This can cause issues when
casting values greater than 32. This change is to declare them as proper
bitmaps so that the bitmap operations can function as intended.
Signed-off
From: Ian Stokes
Refactor __ice_aq_get_set_rss_lut():
get:
- make use params->lut_size only as a size of params->lut;
- return LUT size via params->lut_size;
set:
- remove option to set RSS LUT smaller than available
(eg forbid PF LUT sized 512);
both:
- clean up code.
Signed-off-by: Prze
From: Ian Stokes
New flag for external topology devices for different types of versioning.
Signed-off-by: Dawid Zielinski
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_common.c | 6 ++
drivers/net/ice/base/ice_type.h | 2 ++
2 files changed, 8 insertions(+)
diff --git a/driver
From: Ian Stokes
The firmware interface definition file mistakenly started using bitmap
declarations for its storage in a couple of structures. The data structure
contains a "bit-map" of bits that the hardware/firmware sets or reads but it's
not a DECLARE_BITMAP style bitmap and it's not accessed
From: Ian Stokes
The driver allocates a cmd_buf array in addition to the desc_buf array. This
array stores an ice_sq_cd command details structure for each entry in the
control queue ring.
The contents of the structure are copied from the value passed in via
ice_sq_send_cmd, and include only a po
When devlink reload is called port_info should stay. Check if it wasn't already
allocated before doing allocation.
Signed-off-by: Michal Swiatkowski
Signed-off-by: Anatoly Burakov
---
drivers/net/ice/base/ice_common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers
From: Ian Stokes
The Linux Kernel is now requiring flex array safe allocations from drivers and
the way that we used overlaid union structures was confusing or worse, breaking
Klocwork as well as failing upstream builds that were checking -Warray-bounds.
This update was inspired by Alexander Lob
From: Ian Stokes
Allow PF RSS LUT to be sized 128.
Recent refactor simplified code and made it impossible.
Also clean up unused defines.
Signed-off-by: Przemek Kitszel
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_adminq_cmd.h | 12 +++-
drivers/net/ice/base/ice_common.c
From: Ian Stokes
OROM update in recovery mode is allowed or not based on function capability
0x0090. This patch adds capability parsing for it.
Signed-off-by: Fabio Pricoco
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_adminq_cmd.h | 1 +
drivers/net/ice/base/ice_common.c | 5 +++
From: Ian Stokes
Adjustments required for E830 code base where other platforms may need to be
recognised. Changes are included here to reduced diff between here and upstream.
Also include minor comment adjustment.
Signed-off-by: Fabio Pricoco
Signed-off-by: Ian Stokes
---
drivers/net/ice/bas
From: Ian Stokes
Return error if there were no recipes found.
Signed-off-by: Grzegorz Nitka
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_switch.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ice/base/ice_switch.c
b/drivers/net/ice/base/ice_switch.c
index 448
From: Ian Stokes
If ice_cfg_phy_fec() goes through case ICE_FEC_DIS_AUTO but the underlying
device firmware isn't the correct version, then the memory used to hold the PHY
capabilities output from the firmware isn't freed.
Fix this by making sure the memory is freed by jumping to the label that
From: Ian Stokes
E810 products can support low latency Tx timestamp register read using the SW
interrupt from the FW. Add a check for the device capability and use the new
method if supported.
Signed-off-by: Karol Kolacinski
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_common.c | 3
From: Ian Stokes
Set up and use model-dependent number of PHY ports.
Also fix iterations over PTP ports.
Define 'max_phy_port', a new ice_hw struct member to store the max port number
handled by given clock owner. Replace 'phy_ports' with 'max_phy_port' for max
range in iterations over PTP port
From: Ian Stokes
Currently all functions related to promiscuous modes use u8 bit mask. All 8 bits
are utilized already and to be able to add any new flag, all the drivers need to
comply.
To address that, change u8 into ice_bitmap_t and use dedicated functions to
process it.
Signed-off-by: Mateu
From: Ian Stokes
Currently for unicast promiscuous, the driver is adding a LOOKUP_RX filter rule
using recipe 3. The direction bit in this recipe is the pkt_is_from_network
flag, so the filter only matches on packets from the network, not loopback
packets. To match loopback packets without replic
From: Ian Stokes
E825-C hardware has a new feature which allows to change the clocks which drives
the TX on the PHYs. The registers are accessed directly no interaction with FW
via admin queue commands. Add this support.
Signed-off-by: Michal Michalik
Signed-off-by: Ian Stokes
---
drivers/net
From: Ian Stokes
When applying UDP cloud filter with tunnel type different than VXLAN for each of
the filter new recipe will be created instead of using already created one. This
will quickly use all of the resources for specific recipe. Modified check to
detect if recipe with similar tunnel type
From: Ian Stokes
Allow only one VSI to alloc the PF RSS LUT.
Shared part consists of just a new field, actual implementation will use
`rss_locks` to serialize the access. Take advantage of the fact that VSI #0 is
main VSI for PF, what is the default PF LUT holder, so zero-init of struct
ice_hw s
From: Ian Stokes
The original bit-shift was made on a 16-bit value which could overflow.
Use 64-bit integer to do bit-shifts instead.
Signed-off-by: Lukasz Plachno
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_parser_rt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
dif
From: Ian Stokes
- Fix some alignment issues
- Added missing comment
- Removed useless !!
- Add Missing DBG cluster ID
Signed-off-by: Fabio Pricoco
Signed-off-by: Dan Nowlin
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_adminq_cmd.h | 1 +
drivers/net/ice/base/ice_switch.c | 10
From: Ian Stokes
The new series of devices supported by ice driver are E830 devices. This
hardware supports the PTP feature very similar to E810 devices. The main
difference besides some other register addresses is that in E830 we are able to
read the TX timestamps memory directly from BARs (in E
From: Ian Stokes
When errors happen during OROM reads, the allocated buffer is not freed.
Fix it by adding a goto label to free the buffer in case of error.
Signed-off-by: Fabio Pricoco
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_nvm.c | 10 ++
1 file changed, 6 insertions(
From: Ian Stokes
When current version of driver snapshot was generated, there was a "fix" applied
to it that moved the lock inside the if-else block. This change was made in
error and was later reverted in the upstream driver, so adjust DPDK driver
accordingly.
Signed-off-by: Jesse Brandeburg
S
From: Ian Stokes
Since we know that most side band queue messages complete within 2-3
microseconds, introduce an initial 5 microsecond delay before we enter the main
timeout loop. Use ice_flush(hw) first to ensure that we immediately flush the
tail bump before delaying. This should mean that in p
From: Ian Stokes
Add defines required by NVM feature check. Although not directly used in this
patch this change is required in order to better match upstream.
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_adminq_cmd.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/
From: Ian Stokes
Define MNG Transactions cluster ID, as well as adjust definition of 0xFF08 admin
command according to better match data sheet. Also, modify
ice_aq_get_internal_data() wrapping function so that it returns next cluster ID.
Signed-off-by: Stefan Wegrzyn
Signed-off-by: Ian Stokes
From: Ian Stokes
With the introduction of PTP auxiliary bus driver, aqc_driver_params are no
longer needed to share data between the PFs.
Signed-off-by: Karol Kolacinski
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_adminq_cmd.h | 5 -
1 file changed, 5 deletions(-)
diff --git a
From: Ian Stokes
Add a mask used to extract FW load status from GL_MNG_FWSM.
Signed-off-by: Jan Sokolowski
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_hw_autogen.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ice/base/ice_hw_autogen.h
b/drivers/net/ice/base/ice_
From: Ian Stokes
Currently it is possible to create a filter which breaks TX traffic, e.g.:
tc filter add dev $PF1 ingress protocol ip prio 1 flower ip_proto udp dst_port
$PORT action mirred egress redirect dev $VF1_PR
This adds a rule which might match both TX and RX traffic, and in TX path th
From: Ian Stokes
Data should not be changed by generic i2c write, hence it should be const.
Signed-off-by: Yochai Hagvi
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_common.c | 2 +-
drivers/net/ice/base/ice_common.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --gi
From: Ian Stokes
Align code to better resemble upstream.
Signed-off-by: Jesse Brandeburg
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_adminq_cmd.h | 33 ---
1 file changed, 33 deletions(-)
diff --git a/drivers/net/ice/base/ice_adminq_cmd.h
b/drivers/net/ice
From: Ian Stokes
Fix a static analysis warning where if the 16-bit value in mask has the high-bit
set, it will be sign extended by the shift left (which converts it to a signed
integer). Avoid this by casting to a u32 to make sure the conversion happens
before the shift and that it stays unsigned
From: Ian Stokes
If FW supports the corresponding functionality, the driver allows PFs to
subscribe the same switch recipes. Then when the PF is done with a switch
recipe, the PF can ask the FW to free that switch recipe.
When the FW detects that all subscribing PFs have freed the switch recipe,
From: Ian Stokes
Add a helper function to determine whether a given pin of DPLL is capable for
refsync configuration.
Signed-off-by: Yochai Hagvi
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_ptp_hw.c | 16
drivers/net/ice/base/ice_ptp_hw.h | 1 +
2 files changed, 1
From: Ian Stokes
Use proper bitmask to verify primary/secondary mode instead of whole 'mode'
field, which also includes other information. In the result, for Mode 2a for
example, 'secondary' mode was always reported which was misleading.
Signed-off-by: Prathisna Padmasanan
Signed-off-by: Ian St
From: Ian Stokes
Define Cage Max Power override NVM module which allows to override maximum power
of QSFP/SFP cage. There might be up to 8 cages so each of them has its own word
in the module. From the ice driver perspective we need only Override Enable bit
so there is no need to define bits wher
From: Ian Stokes
Previously, the "No FEC in Auto mode" feature was added to the link management
engine (part of firmware) for E810 devices, and was unsupported at the time on
E82X devices. However, this support is now being extended to new FW versions for
E82X devices, and so the SW check to enab
From: Ian Stokes
The upstream driver placed the ice_read_sma_ctrl_e810t and
ice_write_sma_ctrl_e810t functions before the ice_read_pca9575_reg_e810t
function.
Align with upstream and order the functions so that the sma functions come
before the pca9575 functions, slightly reducing the difference
From: Ian Stokes
The ice_sched_add_root_node() and ice_sched_add_node() functions have comments
to suppress Coverity warnings about a suspicious sizeof used when allocating the
children array of an struct ice_sched_node.
The size is calculated using the size of the scheduler node, which overallo
From: Ian Stokes
Update the offsets, and remove the ICE_TX_GCS_DESC_ENA define since a non-0
value used for the ICE_TX_GCS_DESC_TYPE field will enable GCS offload; there is
no dedicated bit to enable it anymore.
Signed-off-by: Eric Joyner
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice
From: Ian Stokes
Add a separate VSI type for devlink subfunctions due to specific handling in the
driver.
Signed-off-by: Piotr Raczynski
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_type.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ice/base/ice_type.h b/drivers/
From: Ian Stokes
"count" is the returned value, and in this function, value of "count" and "bit"
are the same, so there is no reason why these values should be declared as
different types, and for returned value data type to be different.
Signed-off-by: Chinh Cao
Signed-off-by: Ian Stokes
---
From: Ian Stokes
Code using ice_ptp_one_port_cmd() (or the device specific variants for E822 and
ETH56G) has a subtle bug where-in the executing of ice_ptp_exec_tmr_cmd() will
cause all other ports to execute their last executed command.
Most flows operate on all timers at once, but some flows s
From: Ian Stokes
Removed "else" statement in ice_get_ddp_pkg_state() as it may never happen.
Signed-off-by: Adrian Pielech
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_ddp.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ice/base/ice_ddp.c b/drive
From: Ian Stokes
Replace enum ice_status with int. Also replcae ICE_SUCCESS instances with 0.
Signed-off-by: Przemek Kitszel
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_common.c | 12 ++--
drivers/net/ice/base/ice_ptp_hw.c | 93 +++
drivers/net/ice/base/
From: Ian Stokes
A couple of E822 PTP functions use ICE_PTP_READ_TIME on the main timer to avoid
any side effects when programming a single PHY port. Match the ETH56G code by
using ICE_PTP_NOP instead, which better reflects the intended behavior.
Signed-off-by: Jacob Keller
Signed-off-by: Ian S
From: Ian Stokes
Shared code has a fw_log.c file that is used to handle the firmware
logging. For DPDK it's empty, but it is added to reduce delta between
DPDK and shared code.
Signed-off-by: Fabio Pricoco
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_fwlog.c
From: Ian Stokes
During upstream review of the introduction of ice_clear_phy_tstamp(), reviewers
requested to clarify the comments regarding the function behavior.
Signed-off-by: Jacob Keller
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_ptp_hw.c | 30 +-
From: Ian Stokes
With the exception of a few functions, the upstream Linux version of
ice_ptp_hw.c switched to using "int err" early before the initial conversion of
"enum ice_status status" to "int status" was completed. This results in the
upstream version using a different variable name than t
From: Ian Stokes
When upstreaming the E810-T support for Linux, during review it was pointed out
that the E810T subdevice IDs numbering was odd. The subdevice ID numbers seemed
to be arbitrary. The upstream driver re-numbered the subdevice ID values so that
they were in increasing order.
Align w
From: Ian Stokes
In certain unload conditions the non-standard paths to breaking down the bond
supporting resources need special considerations in that there could be nodes
moved out of the tree and this can cause a NULL pointer to be passed into the
find node by
teid function.
Add in a NULL poi
From: Ian Stokes
Check for 1PPS GPIO association in 1588 function caps. Remove legacy code
related to a workaround setting 1588 capabilities to a fixed value.
Signed-off-by: Temerkhanov, Sergey
Signed-off-by: Nitka, Grzegorz
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_common.c | 4
From: Ian Stokes
The driver checks the netlist for nodes indicating hardware support using
functions named "ice_is__present" sometimes with an additional _e810t
postfix. These functions check the contents of the netlist, and don't make any
direct device ID check.
When upstreaming the functions,
From: Ian Stokes
In case the rule already exists and another VSI wants to subscribe to it new VSI
list is being created and both VSIs are moved to it. Currently, the check for
already existing VSI with the same rule is done based on fdw_id.hw_vsi_id, which
applies only to LOOKUP_RX flag. Change i
From: Ian Stokes
If TS PLL fails to lock to the values from the capabilities, retry with safe
internal 25 MHz TCXO in nanosecond mode. This prevents PTP init fail and does
not disturb nominal initialization of the device.
Signed-off-by: Karol Kolacinski
Signed-off-by: Ian Stokes
---
drivers/n
From: Ian Stokes
When converting to source timer command value, tmr_idx is left shifted by 8
(CPK_SRC_SEL), which overflows the 8-bit data type. Change to 32-bit.
Signed-off-by: Yochai Hagvi
Signed-off-by: Ian Stokes
---
drivers/net/ice/base/ice_ptp_hw.c | 3 +--
1 file changed, 1 insertion(+
1 - 100 of 203 matches
Mail list logo
