On 6/10/2024 11:07 PM, mmaatuq wrote: > in case we didn't enter or finished the loop without getting ifname we > ret shouldn't have an arbitrary value. > > Coverity issue: 424690 > > Signed-off-by: mmaatuq <mahmoudmatook...@gmail.com> >
Change looks good to me, but can you please add Fixes tag [1] and perhaps stable tag based on the fixes tag, checkpatch will generate a warning for it if required, after Fixes tag added. Also can you please use full name, as following capitalization: Name Surname <email-all-lowerc...@domain.com> [1] https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body > --- > v2: > Fixed typo in word "arbitrary" > --- > drivers/net/mana/mana.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c > index 68c625258e..c37c4e3444 100644 > --- a/drivers/net/mana/mana.c > +++ b/drivers/net/mana/mana.c > @@ -715,7 +715,7 @@ mana_dev_stats_reset(struct rte_eth_dev *dev __rte_unused) > static int > mana_get_ifname(const struct mana_priv *priv, char (*ifname)[IF_NAMESIZE]) > { > - int ret; > + int ret = -ENODEV; > DIR *dir; > struct dirent *dent; > > -- > 2.43.0 >
