>> on testing this out the biggest gap I see is that we need a documentation
>> update for it. In V3 can you please update the FreeBSD GSG doc with some
>> details about how to use this feature.
>>
>> Also, on first run using testpmd, the application failed to start, as I was
>> missing a file
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Thursday, 25 April 2024 20.24
>
> The type argument is carried through malloc heap routines but
> never used.
>
> Signed-off-by: Stephen Hemminger
> ---
For the series,
Acked-by: Morten Brørup
On 2024-04-28 17:11, Mattias Rönnblom wrote:
On 2024-04-26 16:38, Ferruh Yigit wrote:
For stats reset, use an offset instead of zeroing out actual stats
values,
get_stats() displays diff between stats and offset.
This way stats only updated in datapath and offset only updated in stats
reset fun
Hi all,
Here is a list of patches targeted for stable release 23.11.1.
The planned date for the final release is 17th May.
Please help with testing and validation of your use cases and report
any issues/results with reply-all to this mail. For the final release
the fixes and reported validations
On Mon, May 06, 2024 at 07:53:54PM -0700, Stephen Hemminger wrote:
> Do not need to recompute all the table indices.
>
> Signed-off-by: Stephen Hemminger
Acked-by: Bruce Richardson
https://bugs.dpdk.org/show_bug.cgi?id=1436
lgl_hust (lgl_h...@sina.com) changed:
What|Removed |Added
Resolution|WONTFIX |---
Status|RESOLVED
Hi,
> -Original Message-
> From: Tyler Retzlaff
> Sent: Tuesday, May 7, 2024 1:58 AM
> To: dev@dpdk.org
> Cc: Mattias Rönnblom ; Morten Brørup
> ; Sevincer, Abdullah
> ; Ajit Khaparde
> ; Alok Prasad ;
> Burakov, Anatoly ; Andrew Rybchenko
> ; Anoob Joseph ;
> Richardson, Bruce ; Marohn,
https://bugs.dpdk.org/show_bug.cgi?id=1437
Bug ID: 1437
Summary: [dpdk-24.07] DPDK should adapt ICE DDP package search
path on ubuntu24.04?
Product: DPDK
Version: 24.07
Hardware: All
OS: All
Stat
Reviewed-by: Luca Vizzarro
Reviewed-by: Luca Vizzarro
Replacing myself as Telemetry maintainer with Bruce Richardson.
Signed-off-by: Ciara Power
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 7abb3aee49..7726e9e7a9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1739,7 +1739,7 @@ F
Replacing myself as Crypto Perf App maintainer with Brian Dooley.
Signed-off-by: Ciara Power
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 7726e9e7a9..4e4197e178 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1825,7 +1825,7 @@
On Tue, May 07, 2024 at 11:17:31AM +, Ciara Power wrote:
> Replacing myself as Telemetry maintainer with Bruce Richardson.
>
> Signed-off-by: Ciara Power
> ---
Sorry to see you leave, Ciara.
Acked-by: Bruce Richardson
On Tue, Apr 30, 2024 at 02:45:33PM -0400, Nicholas Pratte wrote:
> The term 'amount' is used for uncountable nouns. Since total hugepages
> is a discrete value (i.e. countable), the declaration of the 'amount'
> key value pair should be changes to a different term in both the config
> and the rest
On 07/05/2024 13:05, Bruce Richardson wrote:
Sorry to be late to the reviews here, but since this is a countable value -
as you state in the cover letter- would "number" or "count" not be better
terms. To me, "quantity" is just a synonym of "amount", and can be used for
uncountable values too, e.
The XGBE supports performing MDIO operations using an MDIO command
request. The driver mistakenly uses the mdio port address as the
MDIO command request device address instead of the MDIO command
request port address. Additionally, the driver does not properly check
for and create a clause 45 MDIO
Normally, auto negotiation and reconnect should be automatically done by
the hardware. But there seems to be an issue where auto negotiation has
to be restarted manually. This happens because of link training and so
even though still connected to the partner the link never "comes back".
This needs
Frequent link up/down events can happen when a Bel Fuse SFP part is
connected to the amd-xgbe device. Try to avoid the frequent link
issues by resetting the PHY as documented in Bel Fuse SFP datasheets.
Without the fix user will see continuous port link up and down.
Fixes: a5c7273771e8 ("net/axgb
Based on the IOMMU configuration, the current cache control settings can
result in possible coherency issues. The hardware team has recommended
new settings for the PCI device path to eliminate the issue.
Without the fix the user will get incorrect data in TSO functionality
Fixes: 7c4158a5b592 ("
Hardware interrupts are enabled during the init, however,
they are not disabled during close.
Disable all hardware interrupts during close operation to avoid any
issues.
Fixes: 9e890103267e ("net/axgbe: add Rx/Tx setup")
Cc: sta...@dpdk.org
Signed-off-by: Venkat Kumar Ande
---
drivers/net/axgb
Link stability issues are noticed on Yellow carp platforms when Receiver
Reset Cycle is issued. Since the CDR workaround is disabled on these
platforms, the Receiver Reset Cycle is not needed.
So, avoid issuing rrc on Yellow carp platforms.
Without the fix the user will not get the link UP.
Fixe
PLL control setting(RRC) is needed only in fixed PHY configuration to
fix the peer-peer issues. Without the PLL control setting, the link up
takes longer time in a fixed phy configuration.
Without the fix the user will not get the link come UP.
Driver implements SW RRC for Autoneg On configuratio
The current AXGBE code assumes that offset 6 of EEPROM SFP DAC (passive)
cables is NULL. However, some cables (the 5 meter and 7 meter Molex
passive cables) have non-zero data at offset 6. Fix the logic by moving
the passive cable check above the active checks, so as not to be
improperly identified
SFP+ active and passive cables are copper cables with fixed SFP+ end
connectors. Due to a misinterpretation of this, SFP+ active cables could
end up not being recognized, causing the driver to fail to establish a
connection.
Introduce a new enum in SFP+ cable types, XGBE_SFP_CABLE_FIBER, that is
t
There are cables that exist that can support speeds in excess of 10GbE.
The driver, however, restricts the EEPROM advertised nominal bitrate to
a specific range, which can prevent usage of cables that can support,
for example, up to 25GbE.
Rather than checking that an active or passive cable suppo
AN restart triggered during KR training not only aborts the KR training
process but also move the HW to unstable state. Driver has to wait up to
500ms or until the KR training is completed before restarting AN cycle.
Without the fix the user will face KR training failure issues.
Fixes: a5c7273771
The comm_owned field can hide logic where double locking is attempted
and prevent multiple threads for the same device from accessing the
mutex properly. Remove the comm_owned field and use the mutex API
exclusively for gaining ownership.
Signed-off-by: Venkat Kumar Ande
---
drivers/net/axgbe/a
There is difference in the TX Flow Control registers (TFCR) between the
revisions of the hardware. The older revisions of hardware used to have
single register per queue. Whereas, the newer revision of hardware (from
ver 30H onwards) have one register per priority.
Without the fix the user will fa
The driver currently sets an indication of whether the SFP supports, and
that the driver can obtain, diagnostics data. This isn't currently used
by the driver. Remove this field and the logic supporting it.
Signed-off-by: Venkat Kumar Ande
---
drivers/net/axgbe/axgbe_phy_impl.c | 10 --
After changing speed to 100Mbps as a result of auto-negotiation (AN),
some 10/100/1000Mbps SFPs indicate a successful link (no faults or loss
of signal), but cannot successfully transmit or receive data. These
SFPs required an extra auto-negotiation (AN) after the speed change in
order to operate
Instead of using hardcoded values, use enumerations for mailbox command
and sub commands.
Signed-off-by: Venkat Kumar Ande
---
drivers/net/axgbe/axgbe_ethdev.h | 25 +
drivers/net/axgbe/axgbe_phy_impl.c | 25 +++--
2 files changed, 40 insertions(+),
The conversion to bool is not needed, remove it.
Signed-off-by: Venkat Kumar Ande
---
drivers/net/axgbe/axgbe_phy_impl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/axgbe/axgbe_phy_impl.c
b/drivers/net/axgbe/axgbe_phy_impl.c
index 87ef8b6048..2620d44dfb 10064
Add the necessary changes to support 10 Mbps speed for BaseT and SFP
port modes. This is supported in MAC ver >= 30H.
Signed-off-by: Venkat Kumar Ande
---
drivers/net/axgbe/axgbe_dev.c | 3 ++
drivers/net/axgbe/axgbe_ethdev.h | 2 +
drivers/net/axgbe/axgbe_mdio.c | 22 +
dri
The xgbe MDIO bus driver can perform both C22 and C45 transfers, when
using its MDIO bus hardware. The SFP I2C mdio bus driver only supports
C22. Create separate functions for each and register the C45 versions
using the new API calls where appropriate.
Signed-off-by: Venkat Kumar Ande
---
drive
The axgbe driver reuses MII_ADDR_C45 for its own purpose. The values
derived with it are never passed to phylib or a linux MDIO bus driver.
In order that MII_ADDR_C45 can be removed, add an AXGBE specific
Signed-off-by: Venkat Kumar Ande
---
drivers/net/axgbe/axgbe_common.h | 4 ++--
drivers/net
Add support to the driver to fully recognize and enable 2.5GbE speed in
10GBaseT mode.
Signed-off-by: Venkat Kumar Ande
---
drivers/net/axgbe/axgbe_phy_impl.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/net/axgbe/axgbe_phy_impl.c
b/drivers/net/axgbe/axgbe
The existing implementation for non-Autonegotiation 10G speed modes does
not enable RX adaptation in the Driver and FW. The RX Equalization
settings (AFE settings alone) are manually configured and the existing
link-up sequence in the driver does not perform rx adaptation process as
mentioned in th
In the event of a change in AXGBE mode, the current auto-negotiation
needs to be reset and the AN cycle needs to be re-triggered. However,
the current code ignores the return value of axgbe_set_mode(), leading to
false information as the link is declared without checking the status
register.
Fix t
MAC version 21H supports the 10Mbps speed. So, extend support to
platforms that support it.
Signed-off-by: Venkat Kumar Ande
---
drivers/net/axgbe/axgbe_phy_impl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/axgbe/axgbe_phy_impl.c
b/drivers/net/axgbe/axgb
Modify debug messages to get better information from debug logs
Signed-off-by: Venkat Kumar Ande
---
drivers/net/axgbe/axgbe_ethdev.c | 4 ++--
drivers/net/axgbe/axgbe_phy_impl.c | 2 --
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/n
On Tue, May 07, 2024 at 01:43:30PM +0100, Luca Vizzarro wrote:
> On 07/05/2024 13:05, Bruce Richardson wrote:
> > Sorry to be late to the reviews here, but since this is a countable value -
> > as you state in the cover letter- would "number" or "count" not be better
> > terms. To me, "quantity" is
On 5/3/2024 11:00 PM, Stephen Hemminger wrote:
> On Fri, 3 May 2024 16:45:47 +0100
> Ferruh Yigit wrote:
>
>> For stats reset, use an offset instead of zeroing out actual stats values,
>> get_stats() displays diff between stats and offset.
>> This way stats only updated in datapath and offset onl
On 5/7/2024 8:23 AM, Mattias Rönnblom wrote:
> On 2024-04-28 17:11, Mattias Rönnblom wrote:
>> On 2024-04-26 16:38, Ferruh Yigit wrote:
>>> For stats reset, use an offset instead of zeroing out actual stats
>>> values,
>>> get_stats() displays diff between stats and offset.
>>> This way stats only
On Tue, 7 May 2024 14:49:19 +0100
Ferruh Yigit wrote:
> On 5/7/2024 8:23 AM, Mattias Rönnblom wrote:
> > On 2024-04-28 17:11, Mattias Rönnblom wrote:
> >> On 2024-04-26 16:38, Ferruh Yigit wrote:
> >>> For stats reset, use an offset instead of zeroing out actual stats
> >>> values,
> >>> get_
On Tue, 7 May 2024 14:48:51 +0100
Ferruh Yigit wrote:
> On 5/3/2024 11:00 PM, Stephen Hemminger wrote:
> > On Fri, 3 May 2024 16:45:47 +0100
> > Ferruh Yigit wrote:
> >
> >> For stats reset, use an offset instead of zeroing out actual stats values,
> >> get_stats() displays diff between stats
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com]
> Sent: Friday, 3 May 2024 17.46
>
> For stats reset, use an offset instead of zeroing out actual stats values,
> get_stats() displays diff between stats and offset.
> This way stats only updated in datapath and offset only updated in stats
> rese
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Tuesday, 7 May 2024 16.51
> I would prefer that the SW statistics be handled generically by ethdev
> layers and used by all such drivers.
I agree.
Please note that maintaining counters in the ethdev layer might cause more
cac
In order to prevent accidental misconfiguration of hugepages at runtime,
the following changes are made to only allow for configuration of 2MB
hugepages within the DTS config.yaml. In the previous implementation, a
default hugepage size was selected via the size listed in /proc/meminfo.
The problem
The previous implementation configures and allocates hugepage sizes
based on a system default. This can lead to two problems: overallocation of
hugepages (which may crash the remote host), and configuration of hugepage
sizes that are not recommended during runtime. This new implementation
allows on
The term 'amount' is used for uncountable nouns. Since total hugepages
is a discrete value (i.e. countable), the declaration of the 'amount'
key value pair should be changes to a different term in both the config
and the rest of the code.
Signed-off-by: Nicholas Pratte
---
dts/conf.yaml
On 5/7/2024 5:00 PM, Morten Brørup wrote:
>> From: Stephen Hemminger [mailto:step...@networkplumber.org]
>> Sent: Tuesday, 7 May 2024 16.51
>
>> I would prefer that the SW statistics be handled generically by ethdev
>> layers and used by all such drivers.
>
> I agree.
>
> Please note that mainta
On 5/7/2024 3:52 PM, Stephen Hemminger wrote:
> On Tue, 7 May 2024 14:48:51 +0100
> Ferruh Yigit wrote:
>
>> On 5/3/2024 11:00 PM, Stephen Hemminger wrote:
>>> On Fri, 3 May 2024 16:45:47 +0100
>>> Ferruh Yigit wrote:
>>>
For stats reset, use an offset instead of zeroing out actual stats
On 5/7/2024 4:27 PM, Morten Brørup wrote:
>> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com]
>> Sent: Friday, 3 May 2024 17.46
>>
>> For stats reset, use an offset instead of zeroing out actual stats values,
>> get_stats() displays diff between stats and offset.
>> This way stats only updated in d
In order to prevent accidental misconfiguration of hugepages at runtime,
the following changes are made to only allow for configuration of 2MB
hugepages within the DTS config.yaml. In the previous implementation, a
default hugepage size was selected via the size listed in /proc/meminfo.
The problem
The previous implementation configures and allocates hugepage sizes
based on a system default. This can lead to two problems: overallocation of
hugepages (which may crash the remote host), and configuration of hugepage
sizes that are not recommended during runtime. This new implementation
allows on
The term 'amount' is used for uncountable nouns. Since total hugepages
is a discrete value (i.e. countable), the declaration of the 'amount'
key value pair should be changes to a different term in both the config
and the rest of the code.
Signed-off-by: Nicholas Pratte
---
dts/conf.yaml
Resending the patch and superseding the old one on patchwork. I
accidentally sent this patch series through some kind of container
instance.
On Tue, May 7, 2024 at 1:44 PM Nicholas Pratte wrote:
>
> In order to prevent accidental misconfiguration of hugepages at runtime,
> the following changes a
On Tue, 7 May 2024 17:54:18 +0100
Ferruh Yigit wrote:
> On 5/7/2024 5:00 PM, Morten Brørup wrote:
> >> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> >> Sent: Tuesday, 7 May 2024 16.51
> >
> >> I would prefer that the SW statistics be handled generically by ethdev
> >> layers
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se]
> Sent: Tuesday, 7 May 2024 09.24
>
> On 2024-04-28 17:11, Mattias Rönnblom wrote:
> > On 2024-04-26 16:38, Ferruh Yigit wrote:
[...]
> > static uint64_t
> > counter_value(struct counter *counter)
> > {
> > uint64_t count = __atomic_lo
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com]
> Sent: Sunday, 5 May 2024 10.38
>
> Add test/set/clear/assign/flip functions which prevents certain
> compiler optimizations and guarantees that program-level memory loads
> and/or stores will actually occur.
>
> These functions are
On 2024-05-07 15:49, Ferruh Yigit wrote:
On 5/7/2024 8:23 AM, Mattias Rönnblom wrote:
On 2024-04-28 17:11, Mattias Rönnblom wrote:
On 2024-04-26 16:38, Ferruh Yigit wrote:
For stats reset, use an offset instead of zeroing out actual stats
values,
get_stats() displays diff between stats and off
On 2024-05-07 16:51, Stephen Hemminger wrote:
On Tue, 7 May 2024 14:49:19 +0100
Ferruh Yigit wrote:
On 5/7/2024 8:23 AM, Mattias Rönnblom wrote:
On 2024-04-28 17:11, Mattias Rönnblom wrote:
On 2024-04-26 16:38, Ferruh Yigit wrote:
For stats reset, use an offset instead of zeroing out actual
On 2024-05-07 21:19, Morten Brørup wrote:
From: Mattias Rönnblom [mailto:hof...@lysator.liu.se]
Sent: Tuesday, 7 May 2024 09.24
On 2024-04-28 17:11, Mattias Rönnblom wrote:
On 2024-04-26 16:38, Ferruh Yigit wrote:
[...]
static uint64_t
counter_value(struct counter *counter)
{
uint64_t
On 2024-05-07 21:17, Morten Brørup wrote:
From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com]
Sent: Sunday, 5 May 2024 10.38
Add test/set/clear/assign/flip functions which prevents certain
compiler optimizations and guarantees that program-level memory loads
and/or stores will actually
64 matches
Mail list logo
