On Tue, Apr 30, 2024 at 02:45:33PM -0400, Nicholas Pratte wrote: > The term 'amount' is used for uncountable nouns. Since total hugepages > is a discrete value (i.e. countable), the declaration of the 'amount' > key value pair should be changes to a different term in both the config > and the rest of the code. > > Signed-off-by: Nicholas Pratte <npra...@iol.unh.edu> > --- > dts/conf.yaml | 4 ++-- > dts/framework/config/__init__.py | 4 ++-- > dts/framework/config/conf_yaml_schema.json | 6 +++--- > dts/framework/config/types.py | 2 +- > dts/framework/testbed_model/linux_session.py | 4 ++-- > dts/framework/testbed_model/node.py | 2 +- > 6 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/dts/conf.yaml b/dts/conf.yaml > index 56c3ae6f4c..44b5e4ec84 100644 > --- a/dts/conf.yaml > +++ b/dts/conf.yaml > @@ -36,7 +36,7 @@ nodes: > use_first_core: false # tells DPDK to use any physical core > memory_channels: 4 # tells DPDK to use 4 memory channels > hugepages_2mb: # optional; if removed, will use system hugepage > configuration > - amount: 256 > + quantity: 256 > force_first_numa: false
Sorry to be late to the reviews here, but since this is a countable value - as you state in the cover letter- would "number" or "count" not be better terms. To me, "quantity" is just a synonym of "amount", and can be used for uncountable values too, e.g. "a quantity of water". /Bruce
