RE: RTE lock

2024-03-06 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Tuesday, 5 March 2024 21.18 > > Shouldn't we have a DPDK-native mutex API, rather than using direct > POSIX mutex lock calls? > > There are two reasons for this, as I see it > 1) more cleanly support non-POSIX operating system (i.e.,

[PATCH v3] lib/hash: add defer queue reclaim API

2024-03-06 Thread Abdullah Ömer Yamaç
This patch adds a new feature to the hash library to allow the user to reclaim the defer queue. This is useful when the user wants to force reclaim resources that are not being used. This API is only available if the RCU is enabled. Signed-off-by: Abdullah Ömer Yamaç --- lib/hash/rte_cuckoo_hash

[PATCH v3] lib/hash: add defer queue reclaim API

2024-03-06 Thread Abdullah Ömer Yamaç
This patch adds a new feature to the hash library to allow the user to reclaim the defer queue. This is useful when the user wants to force reclaim resources that are not being used. This API is only available if the RCU is enabled. Signed-off-by: Abdullah Ömer Yamaç --- lib/hash/rte_cuckoo_hash

[PATCH] net/hns3: fix user priority 4-7 didn't enable PFC

2024-03-06 Thread Jie Hai
Currently, hns3 driver only enable user priority 0-3 when the user set TC number to 4 and enable PFC and ETS by dev_configure. In this moment, the packet with user priority 4-7 cannot trigger PFC frame. By the way, the nb_tcs from user can never be 0 because of the ahead check in driver. So remove

[PATCH] net/hns3: support new device

2024-03-06 Thread Jie Hai
This patch adds new device to the driver. Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_cmd.c| 4 +++- drivers/net/hns3/hns3_ethdev.c | 2 ++ drivers/net/hns3/hns3_ethdev.h | 2 ++ 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_cmd.c b/drivers/net/hns3

Re: [PATCH v7 10/39] eventdev: use C11 alignas

2024-03-06 Thread David Marchand
On Tue, Mar 5, 2024 at 6:41 PM Tyler Retzlaff wrote: > > On Tue, Mar 05, 2024 at 04:47:05PM +0100, David Marchand wrote: > > On Mon, Mar 4, 2024 at 6:54 PM Tyler Retzlaff > > wrote: > > > diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h > > > index 3af4686..08e5f93 100644 >

Re: [PATCH v7 00/39] use C11 alignas

2024-03-06 Thread David Marchand
Hello Tyler, On Mon, Mar 4, 2024 at 6:53 PM Tyler Retzlaff wrote: > > The current location used for __rte_aligned(a) for alignment of types > and variables is not compatible with MSVC. There is only a single > location accepted by both toolchains. > > For variables standard C11 offers alignas(a)

Re: [PATCH] net/hns3: support new device

2024-03-06 Thread Ferruh Yigit
On 3/6/2024 9:21 AM, Jie Hai wrote: > This patch adds new device to the driver. > Just checking if a documentation update is rquired, hns3.rst has following description, "network engine found in the HiSilicon Kunpeng 920 SoC and Kunpeng 930 SoC", is this still holds with new device support? Also

Re: [PATCH 0/2] build eal & ring libraries with MSVC

2024-03-06 Thread David Marchand
On Tue, Feb 27, 2024 at 8:22 PM Tyler Retzlaff wrote: > > Enable build of eal & ring library when building with MSVC. > > This series depends on 2 other series that seem to be near being > accepted for merge. > > https://patches.dpdk.org/project/dpdk/list/?series=31229 > https://patches.dpdk.o

[PATCH v3] lib/hash: add defer queue reclaim API

2024-03-06 Thread Abdullah Ömer Yamaç
This patch adds a new feature to the hash library to allow the user to reclaim the defer queue. This is useful when the user wants to force reclaim resources that are not being used. This API is only available if the RCU is enabled. Signed-off-by: Abdullah Ömer Yamaç --- lib/hash/rte_cuckoo_hash

Re: release candidate 24.03-rc1

2024-03-06 Thread Thinh Tran
IBM - Power Systems DPDK v24.03-rc1-106-g2a0244d611 * Build CI on Fedora 30,37,38,39 container images for ppc64le * Basic PF on Mellanox: No issue found * Performance: not tested. * OS: RHEL 9.3 kernel: 5.14.0-362.2.1.el9_3.ppc64le with gcc version 11.4.1 20230605 (Red Hat 11.4.1-2)

[PATCH v4] net/i40e: support FEC feature

2024-03-06 Thread Zhichao Zeng
This patch enabled querying Forward Error Correction(FEC) capabilities, set FEC mode and get current FEC mode functions. Signed-off-by: Qiming Yang Signed-off-by: Zhichao Zeng --- v4: fix some logic v3: optimize code details v2: update NIC feature document --- doc/guides/nics/features/i40e.ini

RE: [EXTERNAL] [PATCH v5 1/4] crypto/ipsec_mb: bump minimum IPsec Multi-buffer version

2024-03-06 Thread Power, Ciara
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, March 5, 2024 7:12 PM > To: Dooley, Brian ; Ji, Kai ; De > Lara > Guarch, Pablo ; Patrick Robb > ; Aaron Conole > Cc: dev@dpdk.org; Sivaramakrishnan, VenkatX > ; Power, Ciara ; > Wathsala Vithanage ; tho...@monjalon.net; > Marc

RE: reg. https://patches.dpdk.org/project/dpdk/list/?series=31200 - patch result

2024-03-06 Thread Power, Ciara
Hi Aaron, > -Original Message- > From: Aaron Conole > Sent: Tuesday, March 5, 2024 6:37 PM > To: Power, Ciara > Cc: Sivaramakrishnan, VenkatX ; Akhil > Goyal ; Ji, Kai ; pr...@iol.unh.edu; > dev@dpdk.org > Subject: Re: reg. https://patches.dpdk.org/project/dpdk/list/?series=31200 - > pat

[PATCH v3 01/33] net/ena: rework the metrics multi-process functions

2024-03-06 Thread shaibran
From: Shai Brandes 1. Changed the rte_memcpy call to use the precomputed buf_size. 2. Removed redundant address operators (ampersand symbol) when providing memcpy source address parameter. 3. Code style related change. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net

[PATCH v3 02/33] net/ena: report new supported link speed capabilities

2024-03-06 Thread shaibran
From: Shai Brandes Updated the rte_eth_dev_info device supported speed bitmap to include 200Gbps and 400Gbps capabilities. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/ena_ethdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/ne

[PATCH v3 00/33] net/ena: v2.9.0 driver release

2024-03-06 Thread shaibran
From: Shai Brandes Hi all, the ena v2.9.0 release introduces: 1. HAL upgrade: - renamed the 'base' folder to be 'hal' - separated the HAL patches instead of a bulk update. 2. Restructured ena stats and metrics. 3. Restructured the LLQ configuration: - configurable via devarg. - suppor

[PATCH v3 04/33] net/ena: sub-optimal configuration notifications support

2024-03-06 Thread shaibran
From: Shai Brandes ENA device will send asynchronous notifications to the driver in order to notify users about sub-optimal configurations and refer them to public AWS documentation for further action. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- doc/guides/rel_notes/release_24

[PATCH v3 05/33] net/ena: fix fast mbuf free

2024-03-06 Thread shaibran
From: Shai Brandes In case the application enables fast mbuf release optimization, the driver releases 256 TX mbufs in bulk upon reaching the TX free threshold. The existing implementation utilizes rte_mempool_put_bulk for bulk freeing TXs, which exclusively supports direct mbufs. In case the app

[PATCH v3 03/33] net/ena: update imissed stat with Rx overruns

2024-03-06 Thread shaibran
From: Shai Brandes Depending on its acceleration support, the device updates a different statistic when an ingress packet is dropped because no buffers are available to hold it. - In AWS instance types from later generations 'rx_overruns' is updated. - Otherwise, in legacy instance types, 'rx_dro

[PATCH v3 07/33] net/ena: restructure the llq policy setting process

2024-03-06 Thread shaibran
From: Shai Brandes The driver will set the size of the LLQ header size according to the recommendation from the device. Replaced `enable_llq` and `large_llq_hdr` devargs with a new devarg `llq_policy` that accepts the following values: 0 - Disable LLQ. Use with extreme caution as it leads to

[PATCH v3 06/33] net/ena: rename base folder to hal

2024-03-06 Thread shaibran
From: Shai Brandes Changed the base HAL folder to hal. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/{base => hal}/ena_com.c | 0 drivers/net/ena/{base => hal}/ena_com.h | 0 drivers/net/ena/{base => hal}/ena_defs/ena_admin_defs.

[PATCH v3 09/33] net/ena/hal: add a new csum offload bit

2024-03-06 Thread shaibran
From: Shai Brandes Add a new driver supported feature bit for TX IPv6 checksum offload. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/hal/ena_defs/ena_admin_defs.h | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/net

[PATCH v3 10/33] net/ena/hal: added a bus parameter to ena memcpy macro

2024-03-06 Thread shaibran
From: Shai Brandes ENA_MEMCPY_TO_DEVICE_64 macro needs pci bus id in order to write to the device memory when using llq. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/hal/ena_eth_com.c | 3 ++- drivers/net/ena/hal/ena_plat_dpdk.h | 3 ++- 2 files changed, 4 ins

[PATCH v3 08/33] net/ena/hal: exponential backoff exp limit

2024-03-06 Thread shaibran
From: Shai Brandes limits the exponent in the exponential backoff mechanism in order to avoid the value overflowing. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/hal/ena_com.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/en

[PATCH v3 11/33] net/ena/hal: optimize Rx ring submission queue

2024-03-06 Thread shaibran
From: Shai Brandes RX ring submission queue descriptors are always located in host memory This optimization replaces the generic descriptor retrieval method with a tailored method for host memory type descriptors to avoid unnecessary if statement. Signed-off-by: Shai Brandes Reviewed-by: Amit B

[PATCH v3 12/33] net/ena/hal: rename fields in completion descriptors

2024-03-06 Thread shaibran
From: Shai Brandes Several reserved bits in ena_eth_io_tx_cdesc and ena_eth_io_rx_cdesc_base have been renamed explicitly to MBZ (Must Be Zero). These bits are set by the device to zero before being sent to the driver. The fields are used as an integrity check in order to ensure that the received

[PATCH v3 14/33] net/ena/hal: add completion descriptor corruption check

2024-03-06 Thread shaibran
From: Shai Brandes Adding a check of the MBZ (Must Be Zero) fields in the incoming tx and rx completion descriptors in order to identify corrupted descriptors. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/hal/ena_eth_com.c | 13 +++-- drivers/net/ena/hal

[PATCH v3 13/33] net/ena/hal: use correct read once on u8 field

2024-03-06 Thread shaibran
From: Shai Brandes The flags field in ena_eth_io_tx_cdesc is 8-bits long. The current macro used is READ_ONCE16. Switching to READ_ONCE8 to avoid reading extra data. Given that there's an implicit cast to u8 in the assignment, the correct value is being read, but this change makes it even more ac

[PATCH v3 15/33] net/ena/hal: malformed Tx descriptor error reason

2024-03-06 Thread shaibran
From: Shai Brandes Adding ENA_REGS_RESET_TX_DESCRIPTOR_MALFORMED to identify cases where the returned TX completion descriptors are corrupted. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/hal/ena_defs/ena_regs_defs.h | 1 + 1 file changed, 1 insertion(+) diff -

[PATCH v3 16/33] net/ena/hal: phc feature modifications

2024-03-06 Thread shaibran
From: Shai Brandes 1. PHC algorithm is updated to support reading new PHC values. 2. Update default PHC expiration timeout. 3. Fix a theoretical PHC destroy race. 4. Adjust PHC for multiple devices. 5. PHC activation version check point. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein

[PATCH v3 17/33] net/ena/hal: restructure interrupt handling

2024-03-06 Thread shaibran
From: Shai Brandes When invoking an admin command, in interrupt mode, if the interrupt is received after timeout and also after the calling function finished running, the response will be written into a memory that is no longer valid. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein ---

[PATCH v3 18/33] net/ena/hal: add unlikely to error checks

2024-03-06 Thread shaibran
From: Shai Brandes The unlikely mechanism is used to reduce pipe flush, caused by a wrong branch prediction. Moreover, it increases readability by wrapping unexpected errors. This commit adds unlikely to error checks that are unlikely to happen. Signed-off-by: Shai Brandes Reviewed-by: Amit Ber

[PATCH v3 19/33] net/ena/hal: missing admin interrupt reset reason

2024-03-06 Thread shaibran
From: Shai Brandes There can be cases when we trigger reset if an admin interrupt is missing. In order to identify this use-case specifically, this commit adds a new reset reason. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/hal/ena_com.c| 2 ++

[PATCH v3 20/33] net/ena/hal: check for existing keep alive notification

2024-03-06 Thread shaibran
From: Shai Brandes This commit adds an API to query the aenq on whether there is a pending keep alive notification. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/hal/ena_com.c | 39 +++ drivers/net/ena/hal/ena_com.h | 10 +

[PATCH v3 21/33] net/ena/hal: modify memory barrier comment

2024-03-06 Thread shaibran
From: Shai Brandes The dma_rmb() memory barrier guarantees that the device set the phase bit before continuing to read the rest of the descriptor. Because the phase bit and the rest of the descriptor are in the same cache line this ensures coherency of the data from the descriptor. Signed-off-by

[PATCH v3 22/33] net/ena/hal: rework Rx ring submission queue

2024-03-06 Thread shaibran
From: Shai Brandes RX ring submission queue descriptors are always located in host memory This optimization replaces the generic update tail method with a tailored method for host memory type descriptors to avoid unnecessary if statement. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein

[PATCH v3 24/33] net/ena/hal: handle command abort

2024-03-06 Thread shaibran
From: Shai Brandes Currently admin_queue->stats.aborted_cmd counter is incremented if an admin command status is ENA_CMD_ABORTED and only if the admin queue is in polling mode. This commit fixes handling the case of incrementing admin_queue->stats.aborted_cmd if the admin queue is in interrupt mo

[PATCH v3 25/33] net/ena/hal: add support for device reset request

2024-03-06 Thread shaibran
From: Shai Brandes Adds support for reset request message from the device to the driver, over AENQ, which in turn should cause the driver to trigger reset. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/hal/ena_defs/ena_admin_defs.h | 3 ++- drivers/net/ena/hal/en

[PATCH v3 27/33] net/ena/hal: modify customer metrics memory management

2024-03-06 Thread shaibran
From: Shai Brandes 1. Set buffer length to zero in case memory allocation failed and after memory is released. 2. The driver checks buffer_virt_addr for customer allocation success. In case the allocation fails, buffer_virt_addr may not necessarily be NULL. Signed-off-by: Shai Brandes

[PATCH v3 23/33] net/ena/hal: remove operating system type enum

2024-03-06 Thread shaibran
From: Shai Brandes remove all other operating system enumeration as they are unrelated to DPDK. Use a constant value instead. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/hal/ena_defs/ena_admin_defs.h | 13 + drivers/net/ena/hal/ena_plat_dpdk.h

[PATCH v3 26/33] net/ena: cosmetic changes

2024-03-06 Thread shaibran
From: Shai Brandes This patch makes several changes to improve the style and readability of the code. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/hal/ena_com.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/net/ena/hal

[PATCH v3 28/33] net/ena/hal: cosmetic changes

2024-03-06 Thread shaibran
From: Shai Brandes 1. modify log prints to use correct format specifier for unsigned variables. 2. removed line breaks for lines that do not exceed maximal line length. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/hal/ena_eth_com.c | 22 +++--

[PATCH v3 32/33] net/ena: control path pure polling mode

2024-03-06 Thread shaibran
From: Shai Brandes This commit implements a new operation mode that enables purely polling-based functionality, eliminating the need for interrupts in the control path. This mode is not activated by default and can be toggled using the "control_poll_interval" devarg. When operating in this mode,

[PATCH v3 30/33] net/ena: exhaust interrupt callbacks in device close

2024-03-06 Thread shaibran
From: Shai Brandes Change rte_intr_callback_unregister to its synchronous variant to ensure all active interrupt callbacks are completed before proceeding with the flow. Relocate the interrupt deregistration to precede the release of stats memory, thereby preventing the interrupt handler from acc

[PATCH v3 29/33] net/ena: update device-preferred size of rings

2024-03-06 Thread shaibran
From: Shai Brandes Update the device-preferred size of the Tx ring to fall within the valid range when a large LLQ is enabled. For consistency, align the device-preferred size of the Rx ring accordingly. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/ena_ethdev.c

[PATCH v3 31/33] net/ena: support max large llq depth from the device

2024-03-06 Thread shaibran
From: Shai Brandes Selected AWS instances from later generations enable large LLQ by default, allowing the transmission of packets with headers exceeding 96 bytes. Due to the overall ENA memory BAR size limitation, large LLQ has the side effect of halving the maximum number of LLQ entries (from

[PATCH v3 33/33] net/ena: upgrade driver version to 2.9.0

2024-03-06 Thread shaibran
From: Shai Brandes upgrade driver version to 2.9.0. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index a36efae38c..47f744

Re: [PATCH v7] app/test: secondary process passes allow parameters

2024-03-06 Thread Thomas Monjalon
14/11/2023 11:28, Mingjin Ye: > In EAL related test cases, the allow parameters are not passed to > the secondary process, resulting in unexpected NICs being loaded. > > This patch fixes this issue by appending the allow parameters to > the secondary process. > > Fixes: af75078fece3 ("first publi

Re: [PATCH] bus/vdev: fix devargs memory leak

2024-03-06 Thread Thomas Monjalon
01/09/2023 09:24, Mingjin Ye: > When a device is created by a secondary process, an empty devargs is > temporarily generated and bound to it. This causes the device to not > be associated with the correct devargs, and the empty devargs are not > released when the resource is freed. > > This patch

Re: [PATCH v7 2/2] bus/pci: fix legacy device missing region info

2024-03-06 Thread Thomas Monjalon
24/11/2023 11:47, Gupta, Nipun: > > On 11/22/2023 3:52 PM, Mingjin Ye wrote: > > If the legacy device in the primary process does not support mapping the > > io port bar, the secondary process needs to proactively get the device > > information and fil the region information. > > > > Fixes: 4b741

[RFC v1 0/1] allow header only libraries

2024-03-06 Thread Paul Szczepanek
The current devtools has a check that errors on any library (except drivers library which is exempted) that does not export any symbols. I want to create a header only library. I want to have the check ignore libraries which have no `global:` section. Paul Szczepanek (1): devtools: allow librari

[RFC v1 1/1] devtools: allow libraries with no global section

2024-03-06 Thread Paul Szczepanek
If a library has no global section in the version.map allow it not to have symbols and not report it as an error. This happens if a library doesn't export any functions if they're all inline. Signed-off-by: Paul Szczepanek --- devtools/check-symbol-maps.sh | 4 +++- 1 file changed, 3 insertions(

Re: [PATCH v4 2/2] config/arm: use common cpu arch for cross files

2024-03-06 Thread Thomas Monjalon
22/02/2024 22:38, Wathsala Wathawana Vithanage: > Hi Thomas, > > > > [host_machine] > > > system = 'linux' > > > cpu_family = 'aarch64' > > > -cpu = 'armv8-a' > > > +cpu = 'aarch64' > > > > Why aarch64 here and below? > > Joyce is no longer with Arm, and we have not been able to figure out >

Re: [PATCH v4 1/2] config: correct cpu instruction set for cross build

2024-03-06 Thread Thomas Monjalon
> > > > The platform value would be 'native' only when not cross build. > > > > Move the operation about modifying cpu_instruction_set while platform > > > > equals 'native' to the not cross build branch. > > > > > > > > Fixes: bf66003b51ec ("build: use platform for generic and native > > > > build

Re: [PATCH 0/2] build eal & ring libraries with MSVC

2024-03-06 Thread Patrick Robb
On Wed, Mar 6, 2024 at 5:00 AM David Marchand wrote: > > On Tue, Feb 27, 2024 at 8:22 PM Tyler Retzlaff > wrote: > > > > Enable build of eal & ring library when building with MSVC. > > > > This series depends on 2 other series that seem to be near being > > accepted for merge. > > > > https://p

[PATCH V2] doc/ipsec_mb: update Arm IPsec-MB library tag

2024-03-06 Thread Wathsala Vithanage
Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2024.03.05 in snow3g and zuc documentation. Tag SECLIB-IPSEC-2024.03.05 updates IPSec-MB library version to 1.4. Signed-off-by: Wathsala Vithanage Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli Reviewed-by: Jack Bond-Preston

Re: reg. https://patches.dpdk.org/project/dpdk/list/?series=31200 - patch result

2024-03-06 Thread Aaron Conole
"Power, Ciara" writes: > Hi Aaron, > >> -Original Message- >> From: Aaron Conole >> Sent: Tuesday, March 5, 2024 6:37 PM >> To: Power, Ciara >> Cc: Sivaramakrishnan, VenkatX ; Akhil >> Goyal ; Ji, Kai ; pr...@iol.unh.edu; >> dev@dpdk.org >> Subject: Re: reg. https://patches.dpdk.org/pro

Re: [EXTERNAL] [PATCH v5 1/4] crypto/ipsec_mb: bump minimum IPsec Multi-buffer version

2024-03-06 Thread Patrick Robb
On Wed, Mar 6, 2024 at 6:12 AM Power, Ciara wrote: > > > > And this is also failing http://mails.dpdk.org/archives/test-report/2024- > > March/601301.html > > These need to be fixed in CI infra. > > This function that throws the error is available in the recently tagged 1.4 > equivalent Arm repo,

RE: [PATCH v4 2/2] config/arm: use common cpu arch for cross files

2024-03-06 Thread Wathsala Wathawana Vithanage
> > Joyce is no longer with Arm, and we have not been able to figure out > > this patch. I think the first patch of this series makes sense. > > This second patch to us looks like a nice to have, rather than > > something that fixes an issue. Therefore, we would like to pull this > > patch out of t

[PATCH] app/dma-perf: calrify incorrect NUMA config

2024-03-06 Thread Vipin Varghese
Current commit decalres either `source or destination numa is greater than acture numa` as cause of error. Rephrase as `Source or Destination` is incorrect numa by checking which is greater than available numa. Signed-off-by: Vipin Varghese --- app/test-dma-perf/benchmark.c | 3 ++- 1 file chang

RE: [PATCH v4 2/2] config/arm: use common cpu arch for cross files

2024-03-06 Thread Wathsala Wathawana Vithanage
> > > > OK > > What will become this second patch? > > > I will suppress patch 2/2. > Thanks. I'm not allowed to suppress it, perhaps someone with admin privileges could do it.

[PATCH v2] app/dma-perf: add average latency per worker

2024-03-06 Thread Vipin Varghese
Modify the user display data with total average latency per worker. Signed-off-by: Vipin Varghese V2 Changes: - keep one-digit precision is enough, suggested by Chengwen --- app/test-dma-perf/benchmark.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-dma-perf/be

RE: [PATCH v2 45/71] event/dlb2: replace use of fixed size rte_memcpy

2024-03-06 Thread Sevincer, Abdullah
Acked-by: Abdullah Sevincer

RE: [EXTERNAL] [PATCH v5 1/4] crypto/ipsec_mb: bump minimum IPsec Multi-buffer version

2024-03-06 Thread Power, Ciara
> -Original Message- > From: Patrick Robb > Sent: Wednesday, March 6, 2024 2:59 PM > To: Power, Ciara > Cc: Akhil Goyal ; Dooley, Brian ; > Ji, Kai ; De Lara Guarch, Pablo > ; Aaron Conole ; > dev@dpdk.org; Sivaramakrishnan, VenkatX > ; Wathsala Vithanage > ; tho...@monjalon.net; Marcha

Re: [PATCH v2 1/4] config/arm: add Neoverse V2 part number

2024-03-06 Thread Thomas Monjalon
20/02/2024 02:45, Honnappa Nagarahalli: > Add Arm Neoverse V2 CPU part number > > Signed-off-by: Honnappa Nagarahalli > Acked-by: Ruifeng Wang > Reviewed-by: Wathsala Vithanage Series applied, thanks.

Re: [PATCH v4 2/2] config/arm: use common cpu arch for cross files

2024-03-06 Thread Thomas Monjalon
06/03/2024 16:04, Wathsala Wathawana Vithanage: > > > > > > OK > > > What will become this second patch? > > > > > I will suppress patch 2/2. > > Thanks. > I'm not allowed to suppress it, perhaps someone with admin privileges could > do it. We don't suppress anything :) I can change the status to

Re: [PATCH v3] config/arm: add Marvell Odyssey

2024-03-06 Thread Thomas Monjalon
06/03/2024 06:50, Anoob Joseph: > --- /dev/null > +++ b/config/arm/arm64_odyssey_linux_gcc > @@ -0,0 +1,17 @@ > +[binaries] > +c = ['ccache', 'aarch64-marvell-linux-gnu-gcc'] > +cpp = ['ccache', 'aarch64-marvell-linux-gnu-g++'] > +ar = 'aarch64-marvell-linux-gnu-gcc-ar' > +strip = 'aarch64-marvell-

Re: [RFC v1 1/1] devtools: allow libraries with no global section

2024-03-06 Thread David Marchand
On Wed, Mar 6, 2024 at 3:36 PM Paul Szczepanek wrote: > > If a library has no global section in the version.map > allow it not to have symbols and not report it as an error. > This happens if a library doesn't export any functions > if they're all inline. > > Signed-off-by: Paul Szczepanek Added

Re: [PATCH] net/tap: allow more that 4 queues

2024-03-06 Thread Ferruh Yigit
On 2/29/2024 5:56 PM, Stephen Hemminger wrote: > The tap device needs to exchange file descriptors for tx and rx. > But the EAL MP layer has limit of 8 file descriptors per message. > The ideal resolution would be to increase the number of file > descriptors allowed for rte_mp_sendmsg(), but this w

[PATCH v7 1/3] config/arm: avoid mcpu and march conflicts

2024-03-06 Thread pbhagavatula
From: Pavan Nikhilesh The compiler options march and mtune are a subset of mcpu and will lead to conflicts if improper march is chosen for a given mcpu. To avoid conflicts, discard part number march when mcpu is available and is supported by the compiler. Example: march = armv9-a

[PATCH v7 2/3] config/arm: add support for fallback march

2024-03-06 Thread pbhagavatula
From: Pavan Nikhilesh Some ARM CPUs have specific march requirements and are not compatible with the supported march list. Add fallback march in case the mcpu and the march advertised in the part_number_config are not supported by the compiler. Example mcpu = neoverse-n2 march =

[PATCH v7 3/3] config/arm: allow WFE to be enabled config time

2024-03-06 Thread pbhagavatula
From: Pavan Nikhilesh Allow RTE_ARM_USE_WFE to be enabled at meson configuration time by passing it via c_args instead of modifying `config/arm/meson.build`. Example usage: meson build -Dc_args='-DRTE_ARM_USE_WFE' \ --cross-file config/arm/arm64_cn10k_linux_gcc Signed-off-by: Pavan Nik

Re: [RFC v1 1/1] devtools: allow libraries with no global section

2024-03-06 Thread Bruce Richardson
On Wed, Mar 06, 2024 at 05:14:15PM +0100, David Marchand wrote: > On Wed, Mar 6, 2024 at 3:36 PM Paul Szczepanek > wrote: > > > > If a library has no global section in the version.map > > allow it not to have symbols and not report it as an error. > > This happens if a library doesn't export any

Re: [PATCH v2] build: make buffer headroom configurable

2024-03-06 Thread Thomas Monjalon
27/02/2024 17:10, Morten Brørup: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Tuesday, 27 February 2024 17.02 > > > > While this is not likely a setting that many will need to change, it's > > not > > the first time I've heard of users looking to adjust it. > > > > Bec

Re: [RFC v1 1/1] devtools: allow libraries with no global section

2024-03-06 Thread David Marchand
On Wed, Mar 6, 2024 at 5:40 PM Bruce Richardson wrote: > > On Wed, Mar 06, 2024 at 05:14:15PM +0100, David Marchand wrote: > > On Wed, Mar 6, 2024 at 3:36 PM Paul Szczepanek > > wrote: > > > > > > If a library has no global section in the version.map > > > allow it not to have symbols and not re

RE: reg. https://patches.dpdk.org/project/dpdk/list/?series=31200 - patch result

2024-03-06 Thread Power, Ciara
Hi Aaron, > -Original Message- > From: Aaron Conole > Sent: Wednesday, March 6, 2024 2:57 PM > To: Power, Ciara > Cc: Sivaramakrishnan, VenkatX ; Akhil > Goyal ; Ji, Kai ; pr...@iol.unh.edu; > dev@dpdk.org; De Lara Guarch, Pablo ; > Thomas Monjalon ; David Marchand > ; Kevin Traynor > S

Re: [PATCH v2] hash: make GFNI stubs inline (again)

2024-03-06 Thread Thomas Monjalon
05/03/2024 04:07, Stephen Hemminger: > Tyler found build issues with MSVC and the thash gfni stubs. > The problem would be link errors from missing symbols. > > This version puts back the rte_thash_gfni function stubs as > inlines, but instead of logging a message, they panic. > This is intentiona

Re: [PATCH 3/4] argparse: fix argument flags operate as uint32 type

2024-03-06 Thread David Marchand
On Tue, Feb 20, 2024 at 2:16 PM Chengwen Feng wrote: > > The struct rte_argparse_arg's flags was 64bit type, uint64_t should be > used instead of uint32_t where the operation happened. Something is strange. An enum in C is represented as an int. Plus, this enum type is not used anywhere: lib/arg

Re: [PATCH v3 1/1] app/test: fix external mbuf test when assertions enabled

2024-03-06 Thread Thomas Monjalon
23/11/2023 07:42, Rakesh Kudurumalla: > when RTE_ENABLE_ASSERT is defined test_mbuf application is > failing because we are trying to attach extbuf to a cloned > buffer to which external mbuf is already attached.To make > test_mbuf pass CI we have updated ol_flags. This patch fixes > the same. > >

Re: [PATCH] test: set iova=va mode on ppc64 with --no-huge

2024-03-06 Thread Thomas Monjalon
28/11/2023 15:56, Luca Boccassi: > On Tue, 28 Nov 2023 at 14:40, wrote: > > > > From: Christian Ehrhardt > > > > On ppc64, without huge pages, pa would be the default but fails like: > > EAL: Cannot use IOVA as 'PA' since physical addresses are not available > > > > On a normal system setup we'

Re: [PATCH v7 00/39] use C11 alignas

2024-03-06 Thread Tyler Retzlaff
On Wed, Mar 06, 2024 at 10:55:36AM +0100, David Marchand wrote: > Hello Tyler, > > On Mon, Mar 4, 2024 at 6:53 PM Tyler Retzlaff > wrote: > > > > The current location used for __rte_aligned(a) for alignment of types > > and variables is not compatible with MSVC. There is only a single > > locatio

[PATCH v3] app/eventdev: support DMA adapter test

2024-03-06 Thread Amit Prakash Shukla
Added performance test support for DMA adapter. Signed-off-by: Amit Prakash Shukla --- v3: - Resolved review comments. v2: - Fixed intel compilation error. app/test-eventdev/evt_common.h | 3 + app/test-eventdev/evt_main.c | 15 ++ app/test-eventdev/evt_options.c | 36 ++

Re: [PATCH v2 0/3] use rte macros instead of GCC __attribute

2024-03-06 Thread Tyler Retzlaff
ping. Doesn't seem this series carries high risk, worth considering for rc2/rc3? On Wed, Feb 28, 2024 at 10:47:53AM -0800, Tyler Retzlaff wrote: > Clean up direct uses of GCC __attribute__ in libs outside of EAL. A > checkpatch check already warns for new additions. > > v2: > * fix typo __rte_

Re: [PATCH v4 0/6] more replacement of zero length array

2024-03-06 Thread Tyler Retzlaff
ping Is this one worth closing out as a part of rc2 so it is done? not sure if it's a priority to have lib ~complete. On Thu, Feb 29, 2024 at 02:58:47PM -0800, Tyler Retzlaff wrote: > Replace some missed zero length arrays not captured in the > original series. > https://patchwork.dpdk.org/proje

Re: [PATCH v8 0/3] test/dma: add vchan reconfig and SG tests

2024-03-06 Thread Thomas Monjalon
16/11/2023 18:45, Gowrishankar Muthukrishnan: > Gowrishankar Muthukrishnan (3): > test/dma: use unit test framework > test/dma: test multiple vchan > test/dma: add SG copy tests Applied, thanks.

Re: [PATCH] drivers: use stdatomic API

2024-03-06 Thread Tyler Retzlaff
withdrawing this series. i will submit a new series that tries to address atomics conversion in all drivers. On Wed, Nov 08, 2023 at 11:34:03PM -0800, Tyler Retzlaff wrote: > Replace the use of gcc builtin __atomic_xxx intrinsics with > corresponding rte_atomic_xxx optional stdatomic API. > > Si

Re: [v11 0/4] PCI Dev and SG copy support

2024-03-06 Thread Thomas Monjalon
29/02/2024 14:48, Gowrishankar Muthukrishnan: > Improve dma-perf application to support PCI dev and SG copy, > along with additional supports as below: > - validate copied memory > - skip tests if not opted. > > v11: > - Review suggestions. > > Gowrishankar Muthukrishnan (4): > app/dma-perf:

Re: [PATCH 0/6] Coverity related fixes

2024-03-06 Thread David Marchand
On Fri, Mar 1, 2024 at 6:59 PM Stephen Hemminger wrote: > > Some small stuff that can be picked up after 24.03 > > Stephen Hemminger (6): > test/bpf: make sure mbuf is initialized > net/tap: log if netlink ext ack not possible > examples/l2fwd-keepalive: use rte_drand_max > net/qede: repla

[PATCH v5 1/6] hash: replace zero length array with flex array

2024-03-06 Thread Tyler Retzlaff
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Tyler Retzlaff Reviewed-by: Honnappa Nagarahalli Reviewed-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Stephen Hemminger --- lib/hash/rte_thash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

[PATCH v5 0/6] more replacement of zero length array

2024-03-06 Thread Tyler Retzlaff
Replace some missed zero length arrays not captured in the original series. https://patchwork.dpdk.org/project/dpdk/list/?series=30410&state=* Zero length arrays are a GNU extension that has been superseded by flex arrays. https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html v5: * no changes, r

[PATCH v5 4/6] pipeline: replace zero length array with flex array

2024-03-06 Thread Tyler Retzlaff
Zero length arrays are GNU extension. Replace with standard flex array. Add a temporary suppression for rte_pipeline_table_entry libabigail bug: Bugzilla ID: https://sourceware.org/bugzilla/show_bug.cgi?id=31377 Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup Acked-by: Stephen Hemming

[PATCH v5 2/6] rcu: replace zero length array with flex array

2024-03-06 Thread Tyler Retzlaff
Zero length arrays are GNU extension. Replace with standard flex array. Add a temporary suppression for rte_pipeline_table_entry libabigail bug: Bugzilla ID: https://sourceware.org/bugzilla/show_bug.cgi?id=31377 Signed-off-by: Tyler Retzlaff Reviewed-by: Honnappa Nagarahalli Reviewed-by: Morte

[PATCH v5 3/6] fib: replace zero length array with flex array

2024-03-06 Thread Tyler Retzlaff
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup Acked-by: Stephen Hemminger --- lib/fib/dir24_8.h | 2 +- lib/fib/trie.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/fib/dir24_8.h

[PATCH v5 5/6] lpm: replace zero length array with flex array

2024-03-06 Thread Tyler Retzlaff
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- lib/lpm/rte_lpm6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/lpm/rte_lpm6.c b/lib/lpm/rte_lpm6.c index 46d8f71..5cc1bb2 100644 --- a

[PATCH v5 6/6] table: replace zero length array with flex array

2024-03-06 Thread Tyler Retzlaff
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- lib/table/rte_table_acl.c | 2 +- lib/table/rte_table_array.c | 2 +- lib/table/rte_table_hash_cuckoo.c | 2 +- lib/table/rte_table_hash_ext.c|

Re: [PATCH v2 1/5] app/test-mp: add multiprocess test

2024-03-06 Thread David Marchand
On Sun, Dec 17, 2023 at 4:54 AM Artemy Kovalyov wrote: > > This commit adds a test scenario that initiates multiple processes > concurrently. These processes attach to the same shared heap, with an > automatic detection mechanism to identify the primary process. > > Signed-off-by: Artemy Kovalyov

Re: [PATCH] net/tap: allow more that 4 queues

2024-03-06 Thread Stephen Hemminger
On Wed, 6 Mar 2024 16:14:51 + Ferruh Yigit wrote: > On 2/29/2024 5:56 PM, Stephen Hemminger wrote: > > The tap device needs to exchange file descriptors for tx and rx. > > But the EAL MP layer has limit of 8 file descriptors per message. > > The ideal resolution would be to increase the numbe

[PATCH 1/4] net/mlx5/hws: fix direct index insert on dep wqe

2024-03-06 Thread Dariusz Sosnowski
From: Alex Vesker In case a depend WQE was required and direct index was needed we would not set the direct index on the dep_wqe. This leads to incorrect insertion to index zero. Fixes: 38b5bf6452a6 ("net/mlx5/hws: support insert/distribute RTC properties") Cc: sta...@dpdk.org Signed-off-by: Al

[PATCH 3/4] net/mlx5: fix rollback on failed flow configure

2024-03-06 Thread Dariusz Sosnowski
If rte_flow_configure() failed, then some port resources were either not freed, nor reset to the default state. As a result, assumptions in other places in PMD were invalidated and that lead to segmentation faults during release of HW Steering resources when port was closed. This patch adds missin

  1   2   >