05/03/2024 04:07, Stephen Hemminger: > Tyler found build issues with MSVC and the thash gfni stubs. > The problem would be link errors from missing symbols. > > This version puts back the rte_thash_gfni function stubs as > inlines, but instead of logging a message, they panic. > This is intentional because any application should be checking > with function rte_thash_gfni_supported() before calling the > hashing functions here. Better to panic then return zero > and put out log message which will be ignored...
I want to be able to grep rte_panic in the lib directory to find those we should remove. Having "legit" panic calls is a no-go for me.
