From: Shai Brandes <shaib...@amazon.com>

1. Changed the rte_memcpy call to use the precomputed buf_size.
2. Removed redundant address operators (ampersand symbol)
   when providing memcpy source address parameter.
3. Code style related change.

Signed-off-by: Shai Brandes <shaib...@amazon.com>
Reviewed-by: Amit Bernstein <amitb...@amazon.com>
---
 drivers/net/ena/ena_ethdev.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index beb17c4125..6d500bfa78 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -531,8 +531,8 @@ __extension__ ({
 __extension__ ({
        ENA_TOUCH(rsp);
        ENA_TOUCH(ena_dev);
-       if (stats != (struct ena_admin_eni_stats *)&adapter->metrics_stats)
-               rte_memcpy(stats, &adapter->metrics_stats, sizeof(*stats));
+       if (stats != (struct ena_admin_eni_stats *)adapter->metrics_stats)
+               rte_memcpy(stats, adapter->metrics_stats, sizeof(*stats));
 }),
        struct ena_com_dev *ena_dev, struct ena_admin_eni_stats *stats);
 
@@ -590,9 +590,8 @@ __extension__ ({
 __extension__ ({
        ENA_TOUCH(rsp);
        ENA_TOUCH(ena_dev);
-       ENA_TOUCH(buf_size);
-       if (buf != (char *)&adapter->metrics_stats)
-               rte_memcpy(buf, &adapter->metrics_stats, adapter->metrics_num * 
sizeof(uint64_t));
+       if (buf != (char *)adapter->metrics_stats)
+               rte_memcpy(buf, adapter->metrics_stats, buf_size);
 }),
        struct ena_com_dev *ena_dev, char *buf, size_t buf_size);
 
@@ -4088,7 +4087,7 @@ ena_mp_primary_handle(const struct rte_mp_msg *mp_msg, 
const void *peer)
        case ENA_MP_CUSTOMER_METRICS_GET:
                res = ena_com_get_customer_metrics(ena_dev,
                                (char *)adapter->metrics_stats,
-                               sizeof(uint64_t) * adapter->metrics_num);
+                               adapter->metrics_num * sizeof(uint64_t));
                break;
        case ENA_MP_SRD_STATS_GET:
                res = ena_com_get_ena_srd_info(ena_dev,
-- 
2.17.1

Reply via email to