RE: [EXT] Re: [PATCH v2 8/8] crypto/ipsec_mb: set and use session ID

2023-06-19 Thread Fangming Fang
> From: Akhil Goyal > > 16/05/2023 17:24, Ciara Power: > > > From: Pablo de Lara > > > > > > When creating a session, get the session ID that defines the fixed > > > session parameters and store it in the private data. > > > When retrieving IMB_JOB's, if their internal session ID matches the > >

KNI to Vhost changes

2023-06-19 Thread Prasad Kachawar
hi team, I have joined one project where KNI will be removed with vhost . as am completely new for me please suggest path to achieve that with good understanding Thanks prasad k

[PATCH v2] config/arm: add Ampere Altra/AltraMax/AmpereOne platform

2023-06-19 Thread Yutang Jiang
This patch add Ampere series platform support for DPDK: 1. Merging the eMAG and AmpereOne to the one struct implementer_ampere. 2. The microarchitecture of Altra/AltraMax is N1, which implementer/part_number is defined in arm, so the definition of RTE_MAX_LCORE/RTE_MAX_NUMA_NODES refers to th

RE: KNI to Vhost changes

2023-06-19 Thread Xia, Chenbo
Hi, Check here: https://doc.dpdk.org/guides/howto/virtio_user_as_exception_path.html /Chenbo From: Prasad Kachawar Sent: Thursday, June 15, 2023 2:10 PM To: dev@dpdk.org Subject: KNI to Vhost changes hi team, I have joined one project where KNI will be removed with vhost . as am completely n

Re: [PATCH] mbuf: fix doxygen for distributor metadata

2023-06-19 Thread David Marchand
On Thu, Jun 15, 2023 at 5:15 PM Bruce Richardson wrote: > > On Thu, Jun 15, 2023 at 03:49:42PM +0200, David Marchand wrote: > > /**< is for post annotations. > > > > Fixes: 839b20be0e9b ("ethdev: support metadata as flow rule criteria") > > Cc: sta...@dpdk.org > > > > Signed-off-by: David Marchand

Re: [PATCH] net/ixgbe: fix inverted test and set conditional

2023-06-19 Thread David Marchand
On Thu, Jun 15, 2023 at 9:30 PM Tyler Retzlaff wrote: > > Correct a mistake when converting ixgbe to use __atomic_test_and_set > instead of rte_atomic32_test_and_set. The return value from > __atomic_test_and_set is inverted relative to rte_atomic32_test_and_set. > > Fixes: e90baf6b82f6 ("net/ixgb

Re: [PATCH v3] build: select optional libraries

2023-06-19 Thread David Marchand
On Fri, Jun 16, 2023 at 11:42 AM Bruce Richardson wrote: > On Fri, Jun 16, 2023 at 09:14:50AM +0200, David Marchand wrote: > > There is currently no way to know which libraries are optional. > > Introduce a enable_libs option (close to what we have for drivers) so > > that packagers or projects co

RE: [PATCH] net/ixgbe: fix inverted test and set conditional

2023-06-19 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Monday, 19 June 2023 09.54 > > On Thu, Jun 15, 2023 at 9:30 PM Tyler Retzlaff > wrote: > > > > Correct a mistake when converting ixgbe to use __atomic_test_and_set > > instead of rte_atomic32_test_and_set. The return value from > >

Re: [PATCH v3] net/bonding: fix bond startup failure when NUMA is -1

2023-06-19 Thread Ferruh Yigit
On 6/16/2023 1:00 PM, humin (Q) wrote: > Hi, > > 在 2023/6/16 15:20, Chaoyong He 写道: >> From: Zerun Fu >> >> After the mainline Linux kernel commit >> "fe205d984e7730f4d21f6f8ebc60f0698404ac31" (ACPI: Remove side effect >> of partly creating a node in acpi_map_pxm_to_online_node) by >> Jonathan Ca

[PATCH] test/pdcp: remove side affect from assertion

2023-06-19 Thread Volodymyr Fialko
Remove side affect from test assertion, to avoid different behaviour in non-debug build. Issues reported by coverity scan. Coverity issue: 385419, 385420 Fixes: 6f00462979ad ("test/pdcp: add timer expiry cases") Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 6 -- 1 file changed

RE: [PATCH] net/mlx5: add timestamp ascending order error statistics

2023-06-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Thursday, April 20, 2023 11:19 AM > To: dev@dpdk.org > Subject: [PATCH] net/mlx5: add timestamp ascending order error statistics > > The ConnectX NICs support packet send scheduling on specified moment of > time. Application c

Re: [PATCH v2 3/3] net/sfc: support FEC feature

2023-06-19 Thread Andrew Rybchenko
On 6/15/23 11:38, Denis Pryazhennikov wrote: Support ethdev methods to query and set FEC information. Limitations: ignoring rte_eth_fec_get_capability() results can lead to NOFEC if the device is not strated. Signed-off-by: Denis Pryazhennikov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton

Re: [PATCH] ethdev: rename functions checking queue validity

2023-06-19 Thread Andrew Rybchenko
On 6/14/23 19:44, Stephen Hemminger wrote: On Wed, 14 Jun 2023 17:20:59 +0200 Thomas Monjalon wrote: Two functions helping to check Rx/Tx queues validity were added in DPDK 23.07-rc1. As the release is not closed, it is still time to rename. The name proposed originally rte_eth_dev_is

Re: [PATCH v5 1/3] common/sfc_efx/base: report VLAN stripping capability

2023-06-19 Thread Andrew Rybchenko
On 6/13/23 18:12, Artemii Morozov wrote: These changes are necessary in order to add support for stripping VLAN tags in the future. Signed-off-by: Artemii Morozov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko

RE: [PATCH] ixgbe: Allow setting IVAR register for X550EM_a

2023-06-19 Thread Joyce Kong
Hi All, It seems a false positive. I have tested the patch with aarch32 link_bond_autotest on arm server, and the test cases all succeed. Best Regards, Joyce > -Original Message- > From: Zhang, Qi Z > Sent: Monday, June 19, 2023 9:09 AM > To: Vladimir Ratnikov ; Yang, Qiming > ; Wu, We

Re: [RFC] lib/ethdev: introduce table driven APIs

2023-06-19 Thread Jerin Jacob
On Mon, Jun 19, 2023 at 5:53 AM Zhang, Qi Z wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Friday, June 16, 2023 9:20 AM > > To: Zhang, Qi Z ; Dumitrescu, Cristian > > > > Cc: Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL) > > ; david.march...@redhat.com; Richardso

RE: [PATCH] test/pdcp: remove side affect from assertion

2023-06-19 Thread Anoob Joseph
> > Remove side affect from test assertion, to avoid different behaviour in non- > debug build. Issues reported by coverity scan. > > Coverity issue: 385419, 385420 > Fixes: 6f00462979ad ("test/pdcp: add timer expiry cases") > > Signed-off-by: Volodymyr Fialko Acked-by: Anoob Joseph

Re: [PATCH v5 2/3] common/sfc_efx/base: add support to enable VLAN stripping

2023-06-19 Thread Andrew Rybchenko
On 6/13/23 18:12, Artemii Morozov wrote: To enable VLAN stripping, two conditions must be met: the corresponding flag must be set and the appropriate RX prefix should be requested. RX -> Rx VLAN stripping is supported for ef100 datapath only. "ef100 datapath" does not make sense in libefx.

Re: [PATCH v5 3/3] net/sfc: support VLAN stripping offload

2023-06-19 Thread Andrew Rybchenko
On 6/13/23 18:12, Artemii Morozov wrote: Extract VLAN TCI provided by the HW in the prefix and put it to mbuf. VLAN stripping is supported for ef100 datapath only. This is device level offload. Signed-off-by: Artemii Morozov Reviewed-by: Viacheslav Galaktionov Reviewed-by: Ivan Malov Reviewed

RE: [PATCH v2] bitmap: add scan from offset function

2023-06-19 Thread Dumitrescu, Cristian
> -Original Message- > From: Volodymyr Fialko > Sent: Tuesday, June 13, 2023 4:40 PM > To: dev@dpdk.org; Dumitrescu, Cristian > Cc: jer...@marvell.com; ano...@marvell.com; tho...@monjalon.net; > Volodymyr Fialko > Subject: [PATCH v2] bitmap: add scan from offset function > > Currentl

RE: [PATCH v1] net/mlx5: add test for hot upgrade

2023-06-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Rongwei Liu > Sent: Tuesday, May 16, 2023 8:42 AM > To: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) > Subject: [PATCH v1] net/mlx5: add test for hot upgrade > > This patch adds testpmd app a runtime

RE: [PATCH v2] net/mlx5: fix risk in Rx descriptor read in NEON vector path

2023-06-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Ruifeng Wang > Sent: Tuesday, May 30, 2023 8:48 AM > To: Raslan Darawsheh ; Matan Azrad > ; Slava Ovsiienko > Cc: dev@dpdk.org; honnappa.nagaraha...@arm.com; sta...@dpdk.org; > n...@arm.com; Ruifeng Wang ; Ali Alnubani > > Subject: [PATCH v2] net/mlx5: f

RE: [PATCH 1/1] net/mlx5: fix device removal event handling

2023-06-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Slava Ovsiienko > Sent: Tuesday, May 30, 2023 6:13 PM > To: dev@dpdk.org > Cc: Ori Kam ; Raslan Darawsheh ; > Matan Azrad ; sta...@dpdk.org > Subject: [PATCH 1/1] net/mlx5: fix device removal event handling > > On the device removal kernel notifies user s

RE: [PATCH v1 0/2] mlx5 supports InfiniBand BTH item match

2023-06-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bill Zhou > Sent: Tuesday, June 6, 2023 2:07 PM > To: Ori Kam ; Alex Vesker ; Slava > Ovsiienko ; NBU-Contact-Thomas Monjalon > (EXTERNAL) > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v1 0/2] mlx5 supports InfiniBand BTH item match > > mlx5 su

Re: [RFC PATCH v2] ethdev: advertise flow restore in mbuf

2023-06-19 Thread Andrew Rybchenko
On 6/15/23 16:47, David Marchand wrote: As reported by Ilya [1], unconditionally calling rte_flow_get_restore_info() impacts an application performance for drivers that do not provide this ops. It could also impact processing of packets that require no call to rte_flow_get_restore_info() at all.

Re: [RFC PATCH v2 0/3] improve FEC API usage

2023-06-19 Thread Ferruh Yigit
On 5/12/2023 12:57 PM, Ferruh Yigit wrote: > On 5/8/2023 12:47 PM, Denis Pryazhennikov wrote: >> The documentation for the FEC API is currently incomplete and contains >> inaccuracies in its descriptions of function parameters. >> Specifically, the semantics of the fec_capa parameter in rte_eth_fe

[PATCH 1/8] crypto/cnxk: check for null pointer

2023-06-19 Thread Tejasree Kondoj
Checking for NULL pointer dereference. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cnxk_se.h | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h index c66ab80749..a85e4c5170 100644 --- a/drive

[PATCH 0/8] fixes and improvements to CNXK crypto PMD

2023-06-19 Thread Tejasree Kondoj
This series adds SM4, raw cryptodev API support and fixes to CNXK crypto PMD. Aakash Sasidharan (1): crypto/cnxk: use pt inst for null cipher with null auth Anoob Joseph (3): crypto/cnxk: remove packet length checks in crypto offload crypto/cnxk: add support for raw APIs test/crypto: enab

[PATCH 2/8] crypto/cnxk: remove packet length checks in crypto offload

2023-06-19 Thread Tejasree Kondoj
From: Anoob Joseph When performing crypto offload, the packet length of the input/output buffer does not matter. The length that matters is the cipher/authentication range specified in crypto_op. Since application can request for ciphering of a small portion of the buffer, the extra comparison of

[PATCH 3/8] crypto/cnxk: use pt inst for null cipher with null auth

2023-06-19 Thread Tejasree Kondoj
From: Aakash Sasidharan Use passthrough instruction for NULL cipher with NULL auth combination. Signed-off-by: Aakash Sasidharan --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 20 drivers/crypto/cnxk/cnxk_se.h| 59 2 files changed, 50 insertions(+)

[PATCH 4/8] crypto/cnxk: enable context cache for 103XX

2023-06-19 Thread Tejasree Kondoj
Enabling context cache for SE instructions on 106B0 and 103XX. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 6 +++--- drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 8 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_c

[PATCH 5/8] crypto/cnxk: add support for raw APIs

2023-06-19 Thread Tejasree Kondoj
From: Anoob Joseph Add crypto RAW API support in cnxk PMD Enable the flag to allow execution of raw test suite. Signed-off-by: Vidya Sagar Velumuri Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 459 ++ drivers/crypto/cnxk/cnxk_cryptodev.c

[PATCH 6/8] test/crypto: enable raw crypto tests for crypto_cn10k

2023-06-19 Thread Tejasree Kondoj
From: Anoob Joseph Enable raw crypto tests with crypto_cn10k. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c | 8 1 file changed, 8 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index fb2af40b99..2ba37ed4bd 100644 --- a/app/test/test_cryp

[PATCH 7/8] crypto/cnxk: add support for sm4

2023-06-19 Thread Tejasree Kondoj
From: Vidya Sagar Velumuri Add support for SM4 cipher Support for modes: SM4_CBC, SM4_ECB, SM4_CTR, SM4_OFB, SM4_CFB Signed-off-by: Vidya Sagar Velumuri --- doc/guides/cryptodevs/cnxk.rst| 1 + doc/guides/cryptodevs/features/cn10k.ini | 1 + drivers/common/cnxk/hw/cpt.

[PATCH 8/8] crypto/cnxk: fix order of ECFPM parameters

2023-06-19 Thread Tejasree Kondoj
From: Gowrishankar Muthukrishnan Fix order of ECFPM parameters. Fixes: 76618fc4bef ("crypto/cnxk: fix order of ECFPM parameters") Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/cnxk/cnxk_ae.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/cn

Re: [PATCH v5] gro : fix reordering of packets in GRO library

2023-06-19 Thread Thomas Monjalon
01/11/2022 08:05, Kumara Parameshwaran: > From: Kumara Parameshwaran > > When a TCP packet contains flags like PSH it is returned > immediately to the application though there might be packets of > the same flow in the GRO table. If PSH flag is set on a segment > packets up to the segment should

Re: [PATCH v9] gro : ipv6 changes to support GRO for TCP/ipv6

2023-06-19 Thread Thomas Monjalon
15/06/2023 08:20, Kumara Parameshwaran: > The patch adds GRO support for TCP/ipv6 packets. This does not > include the support for vxlan, udp ipv6 packets. > > Signed-off-by: Kumara Parameshwaran > --- > lib/gro/gro_tcp.h | 187 > lib/gro/gro_tcp4.c

RE: [RFC PATCH v2] ethdev: advertise flow restore in mbuf

2023-06-19 Thread Slava Ovsiienko
Hi, My primary concern is vectorized rx_burst performance impact. @Ali Alnubani, could we conduct the performance check, at least with SSE (x86) and Neon (BF2/3) archs? With best regards, Slava > -Original Message- > From: David Marchand > Sent: Thursday, June 15, 2023 4:47 PM > To: de

Re: [PATCH v3] build: select optional libraries

2023-06-19 Thread David Marchand
On Fri, Jun 16, 2023 at 9:21 AM David Marchand wrote: > @@ -141,13 +137,25 @@ foreach l:libraries > deps += ['eal'] > endif > > -if disabled_libs.contains(l) > +if not enable_libs.contains(l) > +build = false > +reason = 'not in enabled libraries build config'

Re: [PATCH] mbuf: fix doxygen for distributor metadata

2023-06-19 Thread Bruce Richardson
On Mon, Jun 19, 2023 at 09:37:09AM +0200, David Marchand wrote: > On Thu, Jun 15, 2023 at 5:15 PM Bruce Richardson > wrote: > > > > On Thu, Jun 15, 2023 at 03:49:42PM +0200, David Marchand wrote: > > > /**< is for post annotations. > > > > > > Fixes: 839b20be0e9b ("ethdev: support metadata as flow

Re: [PATCH v3] build: select optional libraries

2023-06-19 Thread Bruce Richardson
On Mon, Jun 19, 2023 at 04:11:37PM +0200, David Marchand wrote: > On Fri, Jun 16, 2023 at 9:21 AM David Marchand > wrote: > > @@ -141,13 +137,25 @@ foreach l:libraries > > deps += ['eal'] > > endif > > > > -if disabled_libs.contains(l) > > +if not enable_libs.contains(l) > >

RE: [PATCH v1] net/mlx5: adapt parse graph header length limitation

2023-06-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Rongwei Liu > Sent: Monday, June 12, 2023 11:04 AM > To: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > > Subject: [PATCH v1] net/mlx5: adapt parse graph header length limitation > > Fi

RE: [PATCH 0/4] net/mlx5: implement Flow update API

2023-06-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Monday, June 12, 2023 11:06 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; Slava Ovsiienko ; Ori Kam > ; Erez Shitrit > Subject: [PATCH 0/4] net/mlx5: implement Flow update API > > Add the implementation for the

Re: [PATCH v4 00/34] net/sfc: support HW conntrack assistance

2023-06-19 Thread Ferruh Yigit
On 6/7/2023 2:02 PM, Ivan Malov wrote: > On EF100 hardware, match-action engine (MAE) can be equipped > with an assistance table for connection tracking (CT). In it, > an entry key is a set of exact match fields: an EtherType, a > pair of IP addresses, a L4 protocol ID and a pair of L4 port > numbe

Re: [PATCH v4 03/34] common/sfc_efx/base: add API to list HW tables

2023-06-19 Thread Ferruh Yigit
On 6/7/2023 2:02 PM, Ivan Malov wrote: > From: Denis Pryazhennikov > > New MCDI Table Access API allows management of > the HW tables' content. > This part of API helps to list all supported tables. > In the near future, only the CT table is planned > to be used, so only one identifier for this t

Re: [PATCH v4 00/34] net/sfc: support HW conntrack assistance

2023-06-19 Thread Ferruh Yigit
On 6/8/2023 1:33 PM, Andrew Rybchenko wrote: > On 6/7/23 16:02, Ivan Malov wrote: >> On EF100 hardware, match-action engine (MAE) can be equipped >> with an assistance table for connection tracking (CT). In it, >> an entry key is a set of exact match fields: an EtherType, a >> pair of IP addresses,

Re: [PATCH] net/ixgbe: fix inverted test and set conditional

2023-06-19 Thread Tyler Retzlaff
On Mon, Jun 19, 2023 at 10:19:00AM +0200, Morten Brørup wrote: > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Monday, 19 June 2023 09.54 > > > > On Thu, Jun 15, 2023 at 9:30 PM Tyler Retzlaff > > wrote: > > > > > > Correct a mistake when converting ixgbe to use __atomic_tes

CFP Submission and Registration Reminders - DPDK Dublin Summit 2023

2023-06-19 Thread Nathan Southern
Good morning DPDK Community Members, I hope you're each well and that you had a fantastic weekend. A twofold reminder: -If you wish to submit a proposal for a talk - live *or *virtual - at this year's Dublin summit (Sep. 12-13) please do so within the next 14 days. All submissions are due by no

Re: [PATCH] app/testpmd: add flow update CLI command

2023-06-19 Thread Ferruh Yigit
On 6/14/2023 6:21 PM, Ori Kam wrote: > Hi > >> -Original Message- >> From: Alexander Kozyrev >> Sent: Tuesday, June 13, 2023 12:14 AM >> >> Add testpmd CLI interface for the flow update API. >> flow queue 1 update 2 rule 3 actions_template 4 postpone yes >> pattern end actions

Re: [PATCH] net/nfp: fix VNI of VXLAN encap action

2023-06-19 Thread Ferruh Yigit
On 6/13/2023 4:15 AM, Chaoyong He wrote: > The 'vx_vni' field of VXLAN header is contain 24 bits of VNI and > 8 bits of reserved. After convert into CPU endian, the reserved > 8 bits should be shifted, or the VNI value will be not correct. > > Fixes: 861949032d0f ("net/nfp: fix VNI of VXLAN encap

Re: [PATCH 0/2] fix VNI of NVGRE encap action

2023-06-19 Thread Ferruh Yigit
On 6/13/2023 4:20 AM, Chaoyong He wrote: > This patch series fix the problem of IPv4/6 NVGRE encap action. > > Chaoyong He (2): > net/nfp: fix VNI of IPv4 NVGRE encap action > net/nfp: fix VNI of IPv6 NVGRE encap action > Series applied to dpdk-next-net/main, thanks.

[PATCH v3 0/3] Replace obsolote test cases.

2023-06-19 Thread Arek Kusztal
This patchset removes obsolete test cases for RSA, MOD EXP, MOD INV. Doing that, new way of handling ut_setup and ut_teardown was proposed. Now both behave like constructor/desctuctor in the unit tests. It frees particular alghorithm functions from any kind of responsibility to free resources for

[PATCH v3 1/3] app/test: remove obsolete test function

2023-06-19 Thread Arek Kusztal
Removed function `one by one` as it was not enough scalable and robust. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 404 - app/test/test_cryptodev_mod_test_vectors.h | 925 - app/test/test_cryptodev_rsa_test_vectors.h | 224 - 3 fi

[PATCH v3 2/3] app/test: add modexp and modinv functions

2023-06-19 Thread Arek Kusztal
Added modular exponentiation and modular inverse tests to the asymmetric crypto testsuite. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 152 +++-- app/test/test_cryptodev_mod_test_vectors.h | 123 + 2 files changed, 263 insertions(+

[PATCH v3 3/3] app/test: add rsa none padding tests

2023-06-19 Thread Arek Kusztal
Added RSA NONE padding test cases. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 205 +++ app/test/test_cryptodev_rsa_test_vectors.h | 220 + 2 files changed, 425 insertions(+) diff --git a/app/test/test_cryptodev_asym.c b/app/t

Re: [PATCH v15 00/16] graph enhancement for multi-core dispatch

2023-06-19 Thread David Marchand
On Wed, Jun 14, 2023 at 6:13 PM Zhirun Yan wrote: > > V15: > Fix build issues. (add unused macro in patch 10 then remove in patch 11, > fix log message format in patch 01, rm wrong assert in dispatch_walk in patch > 12) > > V14: > Rebase to main and fix build issues.(align header name in patch 01

[PATCH 1/2] test: add graph tests

2023-06-19 Thread David Marchand
We forgot to add graph unit tests to the CI testsuites. Signed-off-by: David Marchand --- app/test/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test/meson.build b/app/test/meson.build index d0fabcbb8b..35d6baeb22 100644 --- a/app/test/meson.build +++ b/app/test/meson.bu

[PATCH 2/2] lib: make graph optional

2023-06-19 Thread David Marchand
Allow disabling of the graph library in builds. Signed-off-by: David Marchand --- app/test/meson.build | 12 +++- lib/meson.build | 1 + 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/app/test/meson.build b/app/test/meson.build index 35d6baeb22..c96488126f 100644 --

RE: [EXT] [PATCH v2 0/9] crypto/mlx5: support AES-GCM

2023-06-19 Thread Suanming Mou
Hi, Sorry for the late response. > -Original Message- > From: Akhil Goyal > Sent: Thursday, June 15, 2023 2:12 AM > To: Suanming Mou > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: RE: [EXT] [PATCH v2 0/9] crypto/mlx5: support AES-GCM > > > AES-GCM provides both authenticated encrypti

[PATCH v3 1/9] common/mlx5: export memory region lookup by address

2023-06-19 Thread Suanming Mou
In case user provides the address without mempool. Export the function to lookup the address without mempool is required. Signed-off-by: Suanming Mou --- drivers/common/mlx5/mlx5_common_mr.c | 2 +- drivers/common/mlx5/mlx5_common_mr.h | 4 drivers/common/mlx5/version.map | 1 + 3 file

[PATCH v2 0/9] crypto/mlx5: support AES-GCM

2023-06-19 Thread Suanming Mou
AES-GCM provides both authenticated encryption and the ability to check the integrity and authentication of additional authenticated data (AAD) that is sent in the clear. The crypto operations are performed with crypto WQE. If the input buffers(AAD, mbuf, digest) are not contiguous and there is no

[PATCH v3 2/9] crypto/mlx5: split AES-XTS

2023-06-19 Thread Suanming Mou
As there will be other crypto algo be supported. This commit splits AES-XTS code to another *_xts.c file. The mlx5_crypto.c file will just contain the common code. Signed-off-by: Suanming Mou --- drivers/crypto/mlx5/meson.build | 1 + drivers/crypto/mlx5/mlx5_crypto.c | 642 ++---

[PATCH v3 3/9] crypto/mlx5: add AES-GCM query and initialization

2023-06-19 Thread Suanming Mou
AES-GCM provides both authenticated encryption and the ability to check the integrity and authentication of additional authenticated data (AAD) that is sent in the clear. This commit adds the AES-GCM attributes query and initialization function. Signed-off-by: Suanming Mou --- drivers/common/ml

[PATCH v3 5/9] crypto/mlx5: add AES-GCM session configure

2023-06-19 Thread Suanming Mou
Sessions are used in symmetric transformations in order to prepare objects and data for packet processing stage. The AES-GCM session includes IV, AAD, digest(tag), DEK, operation mode information. Signed-off-by: Suanming Mou --- drivers/common/mlx5/mlx5_prm.h| 12 +++ drivers/crypto

[PATCH v3 4/9] crypto/mlx5: add AES-GCM encryption key

2023-06-19 Thread Suanming Mou
The crypto device requires the DEK(data encryption key) object for data encryption/decryption operation. This commit adds the AES-GCM DEK object management support. Signed-off-by: Suanming Mou --- drivers/crypto/mlx5/mlx5_crypto.h | 17 - drivers/crypto/mlx5/mlx5_crypto_dek.c | 102 +++

[PATCH v3 6/9] common/mlx5: add WQE-based QP synchronous basics

2023-06-19 Thread Suanming Mou
Nvidia HW provides a synchronous mechanism between QPs. When creating the QPs, user can set one as primary and another as follower. The follower QP's WQE execution can be controlled by primary QP via SEND_EN WQE. This commit introduces the SEND_EN WQE to improve the WQE execution sync-up between p

[PATCH v3 7/9] crypto/mlx5: add queue pair setup for GCM

2023-06-19 Thread Suanming Mou
Crypto queue pair is for handling the encryption/decryption operations. As AES-GCM AEAD API provides AAD, mbuf, digest separately, low-level FW only accepts the data in a single contiguous memory region, two internal QPs are created for AES-GCM queue pair. One for organizing the memory to be conti

[PATCH v3 8/9] crypto/mlx5: add enqueue and dequeue operations

2023-06-19 Thread Suanming Mou
The crypto operations are performed with crypto WQE. If the input buffers(AAD, mbuf, digest) are not contiguous and there is no enough headroom/tailroom for copying AAD/digest, as the requirement from FW, an UMR WQE is needed to generate contiguous address space for crypto WQE. The UMR WQE and cryp

[PATCH v3 9/9] crypto/mlx5: enable AES-GCM capability

2023-06-19 Thread Suanming Mou
This commit generates AES-GCM capability based on the NIC attributes and enables AES-GCM algo. An new devarg "algo" is added to identify if the crypto PMD will be initialized as AES-GCM(algo=1) or AES-XTS(algo=0, default). Signed-off-by: Suanming Mou --- doc/guides/cryptodevs/mlx5.rst |

RE: [RFC] lib/ethdev: introduce table driven APIs

2023-06-19 Thread Zhang, Qi Z
> -Original Message- > From: Jerin Jacob > Sent: Monday, June 19, 2023 5:52 PM > To: Zhang, Qi Z > Cc: Dumitrescu, Cristian ; Ori Kam > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; david.march...@redhat.com; Richardson, Bruce > ; jer...@marvell.com; ferruh.yi...@amd.com; > Mcnamara, Joh

Re: [PATCH v3] net/bonding: fix bond startup failure when NUMA is -1

2023-06-19 Thread humin (Q)
在 2023/6/19 16:57, Ferruh Yigit 写道: On 6/16/2023 1:00 PM, humin (Q) wrote: Hi, 在 2023/6/16 15:20, Chaoyong He 写道: From: Zerun Fu After the mainline Linux kernel commit "fe205d984e7730f4d21f6f8ebc60f0698404ac31" (ACPI: Remove side effect of partly creating a node in acpi_map_pxm_to_online_n

Re: [PATCH] net/bonding: fix destroy dedicated queues flow

2023-06-19 Thread humin (Q)
Acked-by: Min Hu (Connor) 在 2023/6/8 10:59, Chaoyong He 写道: From: Long Wu Bonding port in mode 4 enables dedicated queues, we will create a flow for this feature. So we need to destroy this flow when we remove the member port. Furthermore if we don't destroy the flow that created for dedicat

Re: [RFC] lib/ethdev: introduce table driven APIs

2023-06-19 Thread Jerin Jacob
On Tue, Jun 20, 2023 at 7:22 AM Zhang, Qi Z wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Monday, June 19, 2023 5:52 PM > > To: Zhang, Qi Z > > Cc: Dumitrescu, Cristian ; Ori Kam > > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > > ; david.march...@redhat.com; Richardso

[PATCH v2 0/8] fixes and improvements to CNXK crypto PMD

2023-06-19 Thread Tejasree Kondoj
This series adds SM4, raw cryptodev API support and fixes to CNXK crypto PMD. v2: * Fixed documentation build failure * Updated release notes Aakash Sasidharan (1): crypto/cnxk: use pt inst for null cipher with null auth Anoob Joseph (3): crypto/cnxk: remove packet length checks in crypto of

[PATCH v2 1/8] crypto/cnxk: check for null pointer

2023-06-19 Thread Tejasree Kondoj
Checking for NULL pointer dereference. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cnxk_se.h | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h index c66ab80749..a85e4c5170 100644 --- a/drive

[PATCH v2 2/8] crypto/cnxk: remove packet length checks in crypto offload

2023-06-19 Thread Tejasree Kondoj
From: Anoob Joseph When performing crypto offload, the packet length of the input/output buffer does not matter. The length that matters is the cipher/authentication range specified in crypto_op. Since application can request for ciphering of a small portion of the buffer, the extra comparison of

[PATCH v2 3/8] crypto/cnxk: use pt inst for null cipher with null auth

2023-06-19 Thread Tejasree Kondoj
From: Aakash Sasidharan Use passthrough instruction for NULL cipher with NULL auth combination. Signed-off-by: Aakash Sasidharan --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 20 drivers/crypto/cnxk/cnxk_se.h| 59 2 files changed, 50 insertions(+)

[PATCH v2 4/8] crypto/cnxk: enable context cache for 103XX

2023-06-19 Thread Tejasree Kondoj
Enabling context cache for SE instructions on 106B0 and 103XX. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 6 +++--- drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 8 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_c

[PATCH v2 5/8] crypto/cnxk: add support for raw APIs

2023-06-19 Thread Tejasree Kondoj
From: Anoob Joseph Add crypto RAW API support in cnxk PMD Enable the flag to allow execution of raw test suite. Signed-off-by: Vidya Sagar Velumuri Signed-off-by: Anoob Joseph --- doc/guides/rel_notes/release_23_07.rst| 1 + drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 459 ++

[PATCH v2 6/8] test/crypto: enable raw crypto tests for crypto_cn10k

2023-06-19 Thread Tejasree Kondoj
From: Anoob Joseph Enable raw crypto tests with crypto_cn10k. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c | 8 1 file changed, 8 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index fb2af40b99..2ba37ed4bd 100644 --- a/app/test/test_cryp

[PATCH v2 7/8] crypto/cnxk: add support for sm4

2023-06-19 Thread Tejasree Kondoj
From: Vidya Sagar Velumuri Add support for SM4 cipher Support for modes: SM4_CBC, SM4_ECB, SM4_CTR, SM4_OFB, SM4_CFB Signed-off-by: Vidya Sagar Velumuri --- doc/guides/cryptodevs/cnxk.rst| 1 + doc/guides/cryptodevs/features/cn10k.ini | 5 + doc/guides/rel_notes/releas

[PATCH v2 8/8] crypto/cnxk: fix order of ECFPM parameters

2023-06-19 Thread Tejasree Kondoj
From: Gowrishankar Muthukrishnan Fix order of ECFPM parameters. Fixes: 76618fc4bef ("crypto/cnxk: fix order of ECFPM parameters") Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/cnxk/cnxk_ae.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/cn

Re: [PATCH 1/2] test: add graph tests

2023-06-19 Thread David Marchand
Hello guys, On Mon, Jun 19, 2023 at 10:47 PM David Marchand wrote: > > We forgot to add graph unit tests to the CI testsuites. > > Signed-off-by: David Marchand Sorry, I forgot to Cc: you. Can you have a look at this series? Thanks. -- David Marchand

RE: [PATCH 1/2] net/mlx5/hws: removing the table name from dest root table

2023-06-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bar Neuman > Sent: Tuesday, June 13, 2023 8:28 AM > To: dev@dpdk.org > Cc: Ori Kam ; Raslan Darawsheh ; > Matan Azrad ; Slava Ovsiienko > ; Maayan Kashani ; Itamar > Gozlan > Subject: [PATCH 1/2] net/mlx5/hws: removing the table name from dest root > tab

RE: [EXT] [PATCH 0/6] Trivial crypto PMDs cleanup

2023-06-19 Thread Akhil Goyal
Hi Maxime, Can you please rebase on next-crypto? The series does not apply. Regards, Akhil > -Original Message- > From: Akhil Goyal > Sent: Wednesday, June 14, 2023 11:47 PM > To: Maxime Coquelin ; dev@dpdk.org; > kai...@intel.com; g.si...@nxp.com; hemant.agra...@nxp.com; > pablo.de.lar

Re: [PATCH 1/2] test: add graph tests

2023-06-19 Thread Jerin Jacob
On Tue, Jun 20, 2023 at 2:17 AM David Marchand wrote: > > We forgot to add graph unit tests to the CI testsuites. > > Signed-off-by: David Marchand Could we add Fixes: ? Either way, Acked-by: Jerin Jacob > --- > app/test/meson.build | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a

Re: [PATCH 1/2] test: add graph tests

2023-06-19 Thread David Marchand
On Tue, Jun 20, 2023 at 8:50 AM Jerin Jacob wrote: > > On Tue, Jun 20, 2023 at 2:17 AM David Marchand > wrote: > > > > We forgot to add graph unit tests to the CI testsuites. > > > > Signed-off-by: David Marchand > > Could we add Fixes: ? > Either way, > Acked-by: Jerin Jacob Indeed. I don't t

Re: [PATCH 2/2] lib: make graph optional

2023-06-19 Thread Jerin Jacob
On Tue, Jun 20, 2023 at 2:17 AM David Marchand wrote: > > Allow disabling of the graph library in builds. Good to make graph as optional. I did not check the build, will examples/l3fwd-graph/ skip automatically ? > > Signed-off-by: David Marchand > --- > +if dpdk_conf.has('RTE_LIB_GRAPH') Can