On 6/7/2023 2:02 PM, Ivan Malov wrote: > From: Denis Pryazhennikov <denis.pryazhenni...@arknetworks.am> > > New MCDI Table Access API allows management of > the HW tables' content. > This part of API helps to list all supported tables. > In the near future, only the CT table is planned > to be used, so only one identifier for this table > was added to the efx. > New table IDs will be added as needed. > > Signed-off-by: Denis Pryazhennikov <denis.pryazhenni...@arknetworks.am> > Reviewed-by: Andy Moreton <amore...@xilinx.com> >
This patch adds a function to the base code, but it is disconnected from the context. In the future if someone looks this function in git log, there is no easy way to see why this function added and where/how it is used at time it is added etc.. So, instead of making commit per function, can you please split commits based on functionality/logic? Please combine the commit that new function and commit where new function is used to single commit, making a commit per feature? If you are concerned about checkpatch warnings related to the component (like common/sfc_efx/base), please ignore it for the case when a feature is distributed into multiple components, and feel free to use most appropriate component name, I assume it will be driver component (net/sfc) most of the times. There is apply errors on CI, which prevents CI checks, can you please rebase set on top of latest head? Btw, we call 'API' to end-user facing functions, that user directly call, for this context better to call it 'function', but after patches merged probably you won't need it at all. Thanks, Ferruh
