Re: [PATCH v4 2/3] graph: pcap capture for graph nodes

2023-01-31 Thread Jerin Jacob
On Tue, Jan 24, 2023 at 4:52 PM Amit Prakash Shukla wrote: > > Implementation adds support to capture packets at each node with > packet metadata and node name. > > Signed-off-by: Amit Prakash Shukla > --- > v2: > - Fixed code style issue > - Fixed CI compilation issue on github-robot > > v3: >

RE: [PATCH 4/4] crypto/cnxk: add error interrupt event query handler

2023-01-31 Thread Akhil Goyal
> Subject: RE: [PATCH 4/4] crypto/cnxk: add error interrupt event query handler > > Hi Akhil, > > Please find the correct description inline, > > Thanks, > Srujana. > > > > Subject: [PATCH 4/4] crypto/cnxk: add error interrupt event query > > > handler > > > > > > Adds RTE_CRYPTODEV_EVENT_ERROR

RE: [EXT] [PATCH v2] crypto/openssl: fix warning on copy length

2023-01-31 Thread Akhil Goyal
> When building with gcc 11.2.0, the compiler warns as follows: > In function 'memcpy', > inlined from 'openssl_set_session_auth_parameters' at > ../drivers/crypto/openssl/rte_openssl_pmd.c:699:3, > inlined from 'openssl_set_session_parameters' at > ../drivers/crypto/openssl/rte_openssl_pmd

RE: [EXT] [PATCH v2 0/3] Add support for SHAKE

2023-01-31 Thread Akhil Goyal
> This series defines new enums for SHAKE128 and SHAKE256 authentication > algorithms and implements support for CNXK crypto PMD. > > v2: > - rebased for dpdk-next-crypto > > Volodymyr Fialko (3): > cryptodev: add SHAKE algorithm > app/test: add SHAKE test cases > crypto/cnxk: add support f

RE: [PATCH v4 07/15] common/idpf: add irq map/unmap

2023-01-31 Thread Wu, Jingjing
> @@ -247,8 +247,21 @@ idpf_vport_init(struct idpf_vport *vport, > goto err_rss_lut; > } > > + /* recv_vectors is used for VIRTCHNL2_OP_ALLOC_VECTORS response, > + * reserve maximum size for it now, may need optimization in future. > + */ > + vport->recv_vecto

Re: [PATCH v4 3/3] l3fwd-graph: changes to configure pcap capture

2023-01-31 Thread Jerin Jacob
On Tue, Jan 24, 2023 at 4:53 PM Amit Prakash Shukla wrote: > > Added support to configure pcap capture. > > Signed-off-by: Amit Prakash Shukla Change the subject as examples/l3fwd-graph: > --- > v2: > - Fixed code style issue > - Fixed CI compilation issue on github-robot > > v3: > - Code r

RE: [EXT] [PATCH] ipsec: remove unneccessary null check

2023-01-31 Thread Akhil Goyal
> Subject: [EXT] [PATCH] ipsec: remove unneccessary null check Changed subject to crypto/ipsec_mb: remove unnecessary null check Fixed couple of spellings in description and title. Applied to dpdk-next-crypto Thanks. > > The function rte_ring_free() accepts NULL as vaild input > like free() and

Re: Google Virtual NIC (GVE) PMD

2023-01-31 Thread Levend Sayar
Thanks for the reply Junfeng. I will check the document you mentioned. I don't know the command 'cksum set ip hw 0', but it looks like to me as "hardware will NOT do checksum'. There is a gateway between VMs at GCP as you mentioned. My test application generates UDP packets. I am checking the o

[PATCH v4] net/iavf:enhance NUMA affinity heuristic

2023-01-31 Thread Kaisen You
Trying to allocate memory on the first detected numa node has less chance to find some memory actually available rather than on the main lcore numa node (especially when the DPDK application is started only on one numa node). Fixes: 705356f0811f ("eal: simplify control thread creation") Fixes: bb0

Re: [PATCH v3 2/7] testpmd: fix whitespace

2023-01-31 Thread Singh, Aman Deep
On 1/17/2023 5:44 AM, Stephen Hemminger wrote: The style standard is to use blank after keywords. I.e "if (" not "if(" Signed-off-by: Stephen Hemminger Acked-by: Aman Singh

RE: [EXT] [PATCH] compressdev: fix end of comp PMD list macro conflict

2023-01-31 Thread Akhil Goyal
> Subject: RE: [EXT] [PATCH] compressdev: fix end of comp PMD list macro > conflict > > > The "rte_compressdev_info_get()" function retrieves the contextual > > information of a device. > > The output structure "dev_info" contains a list of devices supported > > capabilities for each supported alg

RE: [PATCH v4 09/15] common/idpf: add vport info initialization

2023-01-31 Thread Wu, Jingjing
> +int > +idpf_create_vport_info_init(struct idpf_vport *vport, > + struct virtchnl2_create_vport *vport_info) > +{ > + struct idpf_adapter *adapter = vport->adapter; > + > + vport_info->vport_type = rte_cpu_to_le_16(VIRTCHNL2_VPORT_TYPE_DEFAULT); > + if (adapter

Re: [PATCH v4 3/3] ethdev: add standby flags for live migration

2023-01-31 Thread Jerin Jacob
On Tue, Jan 31, 2023 at 8:23 AM Rongwei Liu wrote: > > HI Jerin: > > BR > Rongwei > > > -Original Message- > > From: Jerin Jacob > > Sent: Tuesday, January 31, 2023 01:10 > > To: Rongwei Liu > > Cc: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > > ; Ori Kam ; NBU-Contact- > > Thomas Monja

RE: [PATCH v4 3/3] ethdev: add standby flags for live migration

2023-01-31 Thread Rongwei Liu
Hi Jerin: BR Rongwei > -Original Message- > From: Jerin Jacob > Sent: Tuesday, January 31, 2023 16:46 > To: Rongwei Liu > Cc: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; > step...@networkplumber.org; Raslan Darawsheh ; > Ferruh Y

RE: [PATCH v3 1/8] ethdev: add IPv6 routing extension header definition

2023-01-31 Thread Rongwei Liu
HI Stephen: BR Rongwei > -Original Message- > From: Rongwei Liu > Sent: Tuesday, January 31, 2023 11:25 > To: Stephen Hemminger ; Andrew Rybchenko > > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Aman Singh > ; Yuying Zhang ; > Ferruh Yigit

Re: [PATCH v1 01/13] test/bbdev: fix seg fault for non supported HARQ len

2023-01-31 Thread Maxime Coquelin
Hi Hernan, On 1/17/23 17:50, Hernan Vargas wrote: Catching a corner in bbdev-test (not in the actual PMD) when running some specific vectors which size are not supported by the PMD. Could you please reword the commit message, the title is clearer than the commit message itself. Also, the app

Re: [PATCH v10 2/2] testpmd: cleanup cleanly from signal

2023-01-31 Thread Ferruh Yigit
On 1/30/2023 8:09 PM, Stephen Hemminger wrote: > Do a clean shutdown of testpmd when a signal is received; instead of > having testpmd kill itself. This fixes the problem where a signal could > be received in the middle of a PMD and then the signal handler would > call PMD's close routine leading

Re: [PATCH V2 09/10] net/hns3: fix bad memory structure conversion

2023-01-31 Thread Dongdong Liu
On 2023/1/30 17:31, Dongdong Liu wrote: From: Huisong Li When the type in 'struct rte_flow_action' is RTE_FLOW_ACTION_TYPE_RSS, the 'conf' pointer references the 'struct rte_flow_action_rss' instead of the 'struct hns3_rss_conf' in driver. But driver uses 'struct hns3_rss_conf' to convert th

[v1 00/16] net/mlx5/hws: support range and partial hash matching

2023-01-31 Thread Alex Vesker
ConnectX and BlueField devices which support HWS are capable of performing advanced match, range-match and hashing operations on packet headers. This patch-set introduces support for (1) range matching - allows combining range and exact match over provided item fields using spec, last and mask. A u

[v1 06/16] net/mlx5/hws: add send FW match STE using gen WQE

2023-01-31 Thread Alex Vesker
Send STE WQE function wraps the send WQE command to support WQE build and FDB abstraction. Sending using FW is different from sending from HW since FW returns the completion immediately which requires us to retry on failure and prepare the completion as part of the send process. Signed-off-by: Ale

[v1 02/16] net/mlx5/hws: matcher remove AT and MT limitation

2023-01-31 Thread Alex Vesker
The action and match templates were stored on the matcher in a fixed size array to reduce cache misses and reuse template calculations. This approuch introduced two issues: -limitation of fixed array -definer is bindind to match template and cannot be used with union definer since the layout is fi

[v1 07/16] net/mlx5/hws: add send FW range STE WQE

2023-01-31 Thread Alex Vesker
FW WQE supports complex rules, constructed from 2 STEs, for example: Hash(DefinerA) SteMatch(DefinerB) SteRange(DefinerC) DefinerA is a subset of DefinerB This complex rule is written using a single FW command which has a single WQE control, STE match data0 and STE

[v1 03/16] net/mlx5/hws: support GTA WQE write using FW command

2023-01-31 Thread Alex Vesker
The generate WQE command is used as an interface to writing GTA WQEs with fields that are not supported in current HW, for example extended match definer. Signed-off-by: Alex Vesker --- drivers/common/mlx5/mlx5_prm.h| 27 +- drivers/net/mlx5/hws/mlx5dr_cmd.c | 47

[v1 10/16] net/mlx5/hws: redesign definer create

2023-01-31 Thread Alex Vesker
Until now definer creation and deletion get and put functions were used, the get function would calculate the definer field copy (fc), header layout (hl) and definer layout internally without taking into account other match templates used over the same matcher. This logic had to be split to allow s

[v1 08/16] net/mlx5/hws: move matcher size check to function

2023-01-31 Thread Alex Vesker
This check can be later on reused for other places, it will look better in a function Signed-off-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_matcher.c | 43 +-- 1 file changed, 27 insertions(+), 16 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_matcher.c b/dr

[v1 14/16] net/mlx5/hws: add debug dump support for range and hash

2023-01-31 Thread Alex Vesker
Add support for dumping range and hash definers objects. Hash definer is a per matcher object describing the fields used for hashing. Range definer is per match template object describing the fields used for range matching. Both are optional based on the given match templates. Signed-off-by: Alex

[v1 11/16] net/mlx5/hws: support partial hash

2023-01-31 Thread Alex Vesker
Hash definers allow performing hashing over a subset of the fields which are used for matching. This allows combining match templates which were considered invalid until now. During matcher creation mlx5dr code will process the match templates and check if such hash definer is needed based on the d

[v1 16/16] net/mlx5/hws: cache definer for reuse

2023-01-31 Thread Alex Vesker
Definers are a limited resource in the system per GVMI, to avoid failure we try to improve bt checking if it is possible to reuse the definers in some cases. Added a cache on the context for this purpose. Signed-off-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_context.c | 12 ++- drivers/net

[v1 09/16] net/mlx5/hws: support range match

2023-01-31 Thread Alex Vesker
Support range matching over selected items and range is not supported over all the items. The range match is done using: item->last.field - maximum value item->mask.field - bitmask item->spec.field - minimum value When items are processed if item last and mask fields are non zero range matching wi

[v1 12/16] net/mlx5/hws: add range definer creation support

2023-01-31 Thread Alex Vesker
Calculate and create an additional definer used for range check during matcher creation. In such case two definers will be created one for specific matching and a range definer. Since range HW GTA WQE doesn't support the needed range support rule insertion rule insertion is done using the FW GTA WQ

[v1 13/16] net/mlx5/hws: add FW WQE rule creation logic

2023-01-31 Thread Alex Vesker
FW WQE and HW WQE are done in a similar way but not to jeopardize the performance rule creation is done over the new FW rule creation function. The deletion function is shared between both flows. Signed-off-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_rule.c | 180 +++-

[v1 15/16] net/mlx5/hws: rename pattern cache object

2023-01-31 Thread Alex Vesker
To have the same name convention for future caches, use cache and cache item naming. Signed-off-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_pat_arg.c | 22 +++--- drivers/net/mlx5/hws/mlx5dr_pat_arg.h | 6 +++--- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git

[PATCH v4 0/3] add IPv6 routing extension support

2023-01-31 Thread Rongwei Liu
Support IPv6 routing extension header matching with new rte_flow item. Add encapsulation support for IPv6 routing extension header. v4: use flex array to define variable length segments and move PMD implementation out. v3: enhance the format and use be32/be16 in network header structure. v2: r

[PATCH v4 1/3] ethdev: add IPv6 routing extension header definition

2023-01-31 Thread Rongwei Liu
Add IPv6 routing extension header definition and no TLV support for now. At rte_flow layer, there are new items defined for matching type/nexthdr/segments_left field. Add command line support for IPv6 routing extension header matching: type/nexthdr/segment_list. Signed-off-by: Rongwei Liu Acked

[PATCH v4 2/3] ethdev: add modify IPv6 protocol field

2023-01-31 Thread Rongwei Liu
Add IPv6 protocol modify field definition. Add new modify field destination type string: "ipv6_proto". Signed-off-by: Rongwei Liu Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 3 ++- lib/ethdev/rte_flow.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test

[PATCH v4 3/3] app/testpmd: add IPv6 routing extension header in raw encap

2023-01-31 Thread Rongwei Liu
Add IPv6 routing extension header support in raw_encap command. 1. No TLV support now. 2. Assume header length equals to the current segment_left. Signed-off-by: Rongwei Liu Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 23 +++ 1 file changed, 23 insertions(+) diff --

[v1 01/16] net/mlx5/hws: support synchronous drain

2023-01-31 Thread Alex Vesker
Until now we supported asynchronous drain, triggering the queue to start the drain, now we added support for synchronous which assures all the work was processed on the queue. This is useful when working over a FW command and HW queue in parallel sending arguments over the HW queue and match over

[v1 05/16] net/mlx5/hws: align RTC create command with PRM format

2023-01-31 Thread Alex Vesker
Rename rtc params create for new format. Signed-off-by: Alex Vesker --- drivers/common/mlx5/mlx5_prm.h| 16 ++-- drivers/net/mlx5/hws/mlx5dr_cmd.c | 13 +++-- drivers/net/mlx5/hws/mlx5dr_cmd.h | 11 +++ drivers/net/mlx5/hws/mlx5dr_matcher.c | 19 ++

[v1 04/16] net/mlx5/hws: add capability query for gen wqe command

2023-01-31 Thread Alex Vesker
Read the capabilities required to determine support for GENERATE_WQE. Signed-off-by: Alex Vesker --- drivers/common/mlx5/mlx5_prm.h| 6 -- drivers/net/mlx5/hws/mlx5dr_cmd.c | 12 drivers/net/mlx5/hws/mlx5dr_cmd.h | 3 +++ 3 files changed, 19 insertions(+), 2 deletions(-)

Re: [PATCH v7 1/5] eal: add lcore info in telemetry

2023-01-31 Thread Robin Jarry
Hi Stephen, Stephen Hemminger, Jan 26, 2023 at 18:03: Alternatively, you could should check for lcore out of range. Simplified as: struct lcore_telemetry_info info = { .d = d }; char *endptr; // init not really needed if (params == NULL) // length check can be handled

Re: [PATCH v3 1/8] ethdev: add IPv6 routing extension header definition

2023-01-31 Thread Thomas Monjalon
31/01/2023 10:18, Rongwei Liu: > From: Rongwei Liu > > From: Stephen Hemminger > > > Rongwei Liu wrote: > > > > > > > +/** > > > > + * @warning > > > > + * @b EXPERIMENTAL: this structure may change without prior notice > > > > + * > > > > + * RTE_FLOW_ITEM_TYPE_IPV6_ROUTING_EXT. > > > > + * > >

Re: [PATCH v1 02/13] test/bbdev: refactor TB throughput report

2023-01-31 Thread Maxime Coquelin
On 1/17/23 17:50, Hernan Vargas wrote: Refactor calculation for tb_size. No functional impact. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbde

Re: [PATCH v10 0/4] add rte_thread_set_name API for rte_thread_t

2023-01-31 Thread David Marchand
On Tue, Jan 24, 2023 at 7:12 PM Tyler Retzlaff wrote: > > v10: > * change intended deprecation of rte_thread_setname > from 23.03 to 23.07 > > v9: > * fix typo in v8 deprecation notice picked up by ci > > v8: > * document that no implementation or internal implementation > failure is

Re: [PATCH v1 03/13] test/bbdev: add timeout for latency tests

2023-01-31 Thread Maxime Coquelin
On 1/17/23 17:50, Hernan Vargas wrote: Add a timeout to force exit the latency tests in case dequeue never happens. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/app/test-bb

Re: [PATCH] net/gve: add support for basic stats

2023-01-31 Thread Ferruh Yigit
On 1/31/2023 1:51 AM, Joshua Washington wrote: > Hello, > > I tested it out, and the updates to testpmd seem to work. > Hi Joshua, Thanks for testing, I will send a patch soon. But this was testpmd issue, do you have any objection with the net/gve patch, if not can you please record this with

Re: [PATCH v1 05/13] test/bbdev: report device status in bbdev-test

2023-01-31 Thread Maxime Coquelin
On 1/17/23 17:50, Hernan Vargas wrote: No functional impact. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 12fa988da6..36ea399938 100644 ---

[PATCH] net/iavf: add check for mbuf

2023-01-31 Thread Mingjin Ye
The scalar Tx path would send wrong mbuf that causes the kernel driver to fire the MDD event. This patch adds mbuf detection in tx_prepare to fix this issue, rte_errno will be set to EINVAL and returned if the verification fails. Fixes: 3fd32df381f8 ("net/iavf: check Tx packet with correct UP and

Re: [PATCH v3] bus/fslmc: unlock spinlock in case of timeout

2023-01-31 Thread David Marchand
On Wed, Jan 4, 2023 at 8:41 AM Alvaro Karsz wrote: > > Bug in function mc_send_command, > A spinlock is not unlocked in case of timeouts. > > Fixes: 79711846f676 ("bus/fslmc: add timeout in MC send command") > Cc: sta...@dpdk.org > > Signed-off-by: Alvaro Karsz > Reviewed-by: David Marchand No

Re: [PATCH] fbarray: fix metadata dump

2023-01-31 Thread David Marchand
On Tue, Jan 3, 2023 at 11:49 AM David Marchand wrote: > > If the passed fbarray is invalid, its lock was not taken before > releasing. > > Fixes: c44d09811b40 ("eal: add shared indexed file-backed array") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Applied. -- David Marchand

Re: [PATCH] graph: fix node shrink

2023-01-31 Thread David Marchand
On Thu, Jan 19, 2023 at 11:32 AM David Marchand wrote: > > If the node id check failed, graph_lock was not taken before releasing. > > Fixes: c59dac2ca14a ("graph: implement node operations") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > If the node id check failed, graph_lock was no

Re: [PATCH] gpudev: fix deadlocks when registering callback

2023-01-31 Thread David Marchand
On Tue, Jan 3, 2023 at 11:49 AM David Marchand wrote: > > gpu_callback_lock was not released in some branches of the register > helper. > While at it, set rte_errno in one branch. > > Fixes: 18cb07563165 ("gpudev: add event notification") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Ac

Re: [PATCH v1 04/13] test/bbdev: early termination not explicit set

2023-01-31 Thread Maxime Coquelin
On 1/17/23 17:50, Hernan Vargas wrote: Early termination needs to be explicitly enabled. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test

Re: [PATCH v1 06/13] test/bbdev: log capture from queue stop

2023-01-31 Thread Maxime Coquelin
On 1/17/23 17:50, Hernan Vargas wrote: Improve log capture in bbdev not requiring standard output. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/

Re: [PATCH v10 4/4] eal: deprecation notice for rte thread setname API

2023-01-31 Thread David Marchand
On Mon, Jan 30, 2023 at 9:35 PM Tyler Retzlaff wrote: > thank you both, i'll rebase the rte_ctrl_thread_create patch series once > this is merged to get it moving forward again. > We are missing a reference to rte_thread.h in doc/api/doxy-api-index.md. Please, can you send a patch for this too?

Re: [PATCH v1 07/13] test/bbdev: add support for BLER for 4G

2023-01-31 Thread Maxime Coquelin
On 1/17/23 17:50, Hernan Vargas wrote: New feature to add BLER support for 4G in bbdev-test. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 184 ++- 1 file changed, 183 insertions(+), 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev_pe

[PATCH v3] net/i40e: rework maximum frame size configuration

2023-01-31 Thread Simei Su
This patch removes unnecessary link status check and adds link update. Fixes: a4ba77367923 ("net/i40e: enable maximum frame size at port level") Fixes: 2184f7cdeeaa ("net/i40e: fix max frame size config at port level") Fixes: 719469f13b11 ("net/i40e: fix jumbo frame Rx with X722") Cc: sta...@dpdk.

[PATCH v2] net/sfc: export pick transfer proxy callback to representors

2023-01-31 Thread Ivan Malov
Currently, the "pick transfer proxy ethdev" callback is only advertised for non-representor (in example, main PF) ethdevs. That does not sit well with the original idea of this method, which is to let applications discover the privileged port to use for transfer flow management instead of any given

Re: [PATCH v2] net/sfc: export pick transfer proxy callback to representors

2023-01-31 Thread Andrew Rybchenko
On 1/31/23 14:08, Ivan Malov wrote: Currently, the "pick transfer proxy ethdev" callback is only advertised for non-representor (in example, main PF) ethdevs. That does not sit well with the original idea of this method, which is to let applications discover the privileged port to use for transfe

Re: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-01-31 Thread David Marchand
On Wed, Jan 18, 2023 at 9:31 AM Morten Brørup wrote: > > +To: Thomas & David, you probably have some opinions on this too! > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Tuesday, 17 January 2023 22.17 > > > > On Tue, Jan 17, 2023 at 09:19:22AM +0100, Morten Brørup wrot

Re: [PATCH v1 08/13] test/bbdev: extend support for large TB

2023-01-31 Thread Maxime Coquelin
On 1/17/23 17:50, Hernan Vargas wrote: Add support for large TB when it cannot fit into a true mbuf. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.

RE: [PATCH v3 1/8] ethdev: add IPv6 routing extension header definition

2023-01-31 Thread Ori Kam
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, 31 January 2023 11:43 > Subject: Re: [PATCH v3 1/8] ethdev: add IPv6 routing extension header > definition > > 31/01/2023 10:18, Rongwei Liu: > > From: Rongwei Liu > > > From: Stephen Hemminger > > > > Rongwei Liu wrote: >

RE: [PATCH v4 1/3] ethdev: add flow rule group description

2023-01-31 Thread Ori Kam
Hi Rongwei, > -Original Message- > From: Rongwei Liu > Sent: Wednesday, 18 January 2023 17:45 > > Add more sentences to describe the group concepts > and define group 0 as root group for traffic to search a > hit rule. > > Signed-off-by: Rongwei Liu > --- > lib/ethdev/rte_flow.h | 13

[PATCH] app/testpmd: fix forwarding stats for Tx dropped

2023-01-31 Thread Ferruh Yigit
There is an inconsistency at displaying Tx dropped value for per port forwarding stats and accumulated forwarding stats. While displaying per port TX-dropped value, it only takes 'ports_stats[pt_id].tx_dropped' into account, but for accumulated TX-dropped results it takes both 'ports_stats[pt_id].

Re: [PATCH v1 09/13] test/bbdev: bbdev-test cannot compare some scenarios

2023-01-31 Thread Maxime Coquelin
On 1/17/23 17:50, Hernan Vargas wrote: Updating logic for compression usecases. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.

RE: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-01-31 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Tuesday, 31 January 2023 12.15 > > On Wed, Jan 18, 2023 at 9:31 AM Morten Brørup > wrote: > > > > +To: Thomas & David, you probably have some opinions on this too! > > > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com

Re: [PATCH v1 10/13] test/bbdev: adjustment for soft output

2023-01-31 Thread Maxime Coquelin
On 1/17/23 17:50, Hernan Vargas wrote: Extend bbdev-test for soft output check, notably due to the logic in test-bbdev bbdev-test to enable termination changing. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 26 +- 1 file changed, 13 inser

Re: [PATCH v1 11/13] test/bbdev: expose warning counters

2023-01-31 Thread Maxime Coquelin
On 1/17/23 17:50, Hernan Vargas wrote: Print warnings reported on queues for offload test. No functional impact. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_

Re: [PATCH v1 12/13] test/bbdev: remove check for invalid opaque data

2023-01-31 Thread Maxime Coquelin
On 1/17/23 17:50, Hernan Vargas wrote: Assert also if the opaque date is invalid. data* Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_

Re: [PATCH v1 13/13] test/bbdev: remove iteration count check

2023-01-31 Thread Maxime Coquelin
On 1/17/23 17:50, Hernan Vargas wrote: To make the test compatible with devices that do not support early termination, the iteration count assert can be removed. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) d

[PATCH V3 01/10] net/hns3: fix error log about indirection table size

2023-01-31 Thread Dongdong Liu
From: Huisong Li The error log about indirection table size during initialization phase of PF and VF is unreasonable when the indirection table size obtained from firmware or PF function should be zero. In addition, VF driver should use error level to print this log. Fixes: 0fce2c46dc16 ("net/hn

[PATCH V3 00/10] net/hns3: some bugfixes for rss

2023-01-31 Thread Dongdong Liu
This patchset is to do some bugfixes for hns3 rss. v2->v3: - Fix segmentation fault when key_len is 40 and key is NULL for [PATCH V2 09/10]. v1->v2: - Fix missing comparison of types and level when verifying duplicate rules for [PATCH 10/10]. Huisong Li (10): net/hns3: fix error log about

[PATCH V3 04/10] net/hns3: fix fixed RSS key size to be more compatibility

2023-01-31 Thread Dongdong Liu
From: Huisong Li For better compatibility, the RSS key size of PF and VF are obtained from firmware. However, many places still used the old macro HNS3_RSS_KEY_SIZE as the key size. Fixes: 9c740336f024 ("net/hns3: get device specifications from firmware") Cc: sta...@dpdk.org Signed-off-by: Huis

[PATCH V3 02/10] net/hns3: extract common API to query device

2023-01-31 Thread Dongdong Liu
From: Huisong Li Extract common function to query device specifications. Fixes: 9c740336f024 ("net/hns3: get device specifications from firmware") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_common.c| 75

[PATCH V3 03/10] net/hns3: refactor set RSS hash algorithm and key interface

2023-01-31 Thread Dongdong Liu
From: Huisong Li The hns3_rss_set_algo_key() is used to set RSS hash algorithm and key to hardware. The maximum times of command sent to firmware depend on the length of key. However, now this times is fixed, which isn't good for key expansion. In addition, hash algorithm comes from rss_info::has

[PATCH V3 06/10] net/hns3: using RSS filter list to check duplicated rule

2023-01-31 Thread Dongdong Liu
From: Huisong Li All rules from user are saved in RSS filter list, so use RSS filter list to check duplicated rule. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_flow.c | 35 ++

[PATCH V3 09/10] net/hns3: fix bad memory structure conversion

2023-01-31 Thread Dongdong Liu
From: Huisong Li When the type in 'struct rte_flow_action' is RTE_FLOW_ACTION_TYPE_RSS, the 'conf' pointer references the 'struct rte_flow_action_rss' instead of the 'struct hns3_rss_conf' in driver. But driver uses 'struct hns3_rss_conf' to convert this 'conf' pointer to get RSS action configura

[PATCH V3 08/10] net/hns3: fix useless warning when flush or destroy rule

2023-01-31 Thread Dongdong Liu
From: Huisong Li The types of the rule will no longer be used when user flush all rules or destroy a rule. But user would receive some RSS types warnings, like, "modified RSS types based on hardware support, requested:0x137f83fffc configured:0x3ffc". Fixes: ec674cb742e5 ("net/hns3: fix flushing

[PATCH V3 07/10] net/hns3: remove useless code when destroy valid RSS rule

2023-01-31 Thread Dongdong Liu
From: Huisong Li The hw::rss_info::conf::func was set to the macro RTE_ETH_HASH_FUNCTION_MAX and hw::rss_info::conf::queue was set to NULL when all rules are flushed, which indicates no flow rules is issued. See commit eb158fc756a5 ("net/hns3: fix config when creating RSS rule after flush"). Actu

[PATCH V3 05/10] net/hns3: fix misclearing RSS configuration

2023-01-31 Thread Dongdong Liu
From: Huisong Li The RSS configuration will be miscleared when driver receives a RSS rule which has more one RSS action. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_flow.c | 4 +--- 1 file c

[PATCH V3 10/10] net/hns3: fix incorrect check for duplicate RSS rule

2023-01-31 Thread Dongdong Liu
From: Huisong Li Currently, the interface for verifying duplicate RSS rules has some problems: 1) If the value of 'func' in configuring RSS rule is default value, this rule is mistakenly considered as a duplicate rule. 2) If key length is zero or 'key' is NULL in configuring RSS rule this r

RE: [EXT] Re: [PATCH v3 0/4] implementation of ML common code

2023-01-31 Thread Srikanth Yalavarthi
> -Original Message- > From: Jerin Jacob > Sent: 27 January 2023 15:58 > To: Thomas Monjalon > Cc: Shivah Shankar Shankar Narayan Rao ; > Srikanth Yalavarthi ; dev@dpdk.org; Jerin Jacob > Kollanukkaran ; Anup Prabhu > ; ferruh.yi...@amd.com; > bruce.richard...@intel.com; david.march...@re

RE: [PATCH v4 2/3] ethdev: add standby state for live migration

2023-01-31 Thread Ori Kam
Hi Rongwei, > -Original Message- > From: Rongwei Liu > Sent: Wednesday, 18 January 2023 17:45 > > When a DPDK application must be upgraded, > the traffic downtime should be shortened as much as possible. > During the migration time, the old application may stay alive > while the new appl

Re: [PATCH v1 1/6] baseband/acc: file renaming from acc200 to generic vrb

2023-01-31 Thread Maxime Coquelin
On 1/17/23 23:36, Nicolas Chautru wrote: Renaming files as part of refactor to have generic intel vRAN Boost PMD (vrb) whose acc200 is only one variant. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/meson.build | 2 +- drivers/baseband/acc/rte_acc100_pmd.

RE: [PATCH v2 1/2] ethdev: add PHY affinity match item

2023-01-31 Thread Ori Kam
Hi Jiawei, > -Original Message- > From: Jiawei(Jonny) Wang > Sent: Monday, 30 January 2023 19:01 > > For the multiple hardware ports connect to a single DPDK port (mhpsdp), > currently, there is no information to indicate the packet belongs to > which hardware port. > > This patch intro

Re: [PATCH v4 3/3] ethdev: add standby flags for live migration

2023-01-31 Thread Jerin Jacob
On Tue, Jan 31, 2023 at 2:31 PM Rongwei Liu wrote: > > Hi Jerin: > > BR > Rongwei > > > -Original Message- > > From: Jerin Jacob > > Sent: Tuesday, January 31, 2023 16:46 > > To: Rongwei Liu > > Cc: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > > ; Ori Kam ; NBU-Contact- > > Thomas Monja

Re: [PATCH v1 2/6] baseband/acc: extension of the device structure

2023-01-31 Thread Maxime Coquelin
On 1/17/23 23:36, Nicolas Chautru wrote: Make the device structure more generic so that to have personnalization of the VRB PMD to support multiple variants. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/acc200_pf_enum.h | 8 +- drivers/baseband/acc/acc_common.h | 6 ++

RE: [PATCH v4 3/3] ethdev: add standby flags for live migration

2023-01-31 Thread Ori Kam
Hi Jerin and Rongwei, > -Original Message- > From: Jerin Jacob > Sent: Tuesday, 31 January 2023 16:37 > > On Tue, Jan 31, 2023 at 2:31 PM Rongwei Liu wrote: > > > > Hi Jerin: > > > > BR > > Rongwei > > > > > -Original Message- > > > From: Jerin Jacob > > > Sent: Tuesday, Januar

Re: [PATCH v1 3/6] baseband/acc: adding prefix to VRB1 registers

2023-01-31 Thread Maxime Coquelin
On 1/17/23 23:36, Nicolas Chautru wrote: Adding prefix to register names specific to VRB1 (ACC200) to avoid future enum collision. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/acc200_pf_enum.h | 174 +- drivers/baseband/acc/acc200_vf_enum.h | 128 +++

Re: [PATCH v1 4/6] baseband/acc: update prefix for VRB PMD functions

2023-01-31 Thread Maxime Coquelin
On 1/17/23 23:36, Nicolas Chautru wrote: Include vrb_ prefix for all generic functions for VRB PMD. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 248 ++--- drivers/baseband/acc/vrb_pmd.h | 2 +- 2 files changed, 124 insertions(+),

Re: [PATCH v1 5/6] baseband/acc: rename of remaining acc200 prefix to vrb1

2023-01-31 Thread Maxime Coquelin
On 1/17/23 23:36, Nicolas Chautru wrote: Rename remaining variable, comments and enums names when generic usage is applicable. VRB1 is specific to current HW support and VRB is more generic. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/acc_common.h | 12 +- drivers

Re: [PATCH v1 6/6] doc: updated naming convention for acc200 PMD

2023-01-31 Thread Maxime Coquelin
On 1/17/23 23:36, Nicolas Chautru wrote: The documentation for the Intel vRAN Boost PMD is being updated in term of filename and content to match with new branding and product name. Signed-off-by: Nicolas Chautru --- .../bbdevs/features/{acc200.ini => vrb1.ini} | 2 +- doc/guides/bbdevs

Re: [PATCH v4] net/iavf:enhance NUMA affinity heuristic

2023-01-31 Thread Thomas Monjalon
31/01/2023 16:05, Kaisen You: > lib/eal/common/eal_common_thread.c | 1 + > lib/eal/common/malloc_heap.c | 4 > 2 files changed, 5 insertions(+) Why the title refers to net/iavf?

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-01-31 Thread Jerin Jacob
On Fri, Jan 27, 2023 at 8:31 PM Thomas Monjalon wrote: > > 27/01/2023 11:42, Nithin Kumar Dabilpuram: > > From: Thomas Monjalon > > > 27/01/2023 06:02, Nithin Kumar Dabilpuram: > > > > From: Thomas Monjalon > > > > > Ferruh is proposing to have a command "port config ..." > > > > > to configure

Re: [PATCH v4 1/9] eal: annotate spinlock, rwlock and seqlock

2023-01-31 Thread Maxime Coquelin
On 1/19/23 19:46, David Marchand wrote: clang offers some thread safety checks, statically verifying that locks are taken and released in the code. To use those checks, the full code leading to taking or releasing locks must be annotated with some attributes. Wrap those attributes into our ow

Re: [PATCH v7 1/5] eal: add lcore info in telemetry

2023-01-31 Thread Stephen Hemminger
On Tue, 31 Jan 2023 10:40:08 +0100 "Robin Jarry" wrote: > Hi Stephen, > > Stephen Hemminger, Jan 26, 2023 at 18:03: > > Alternatively, you could should check for lcore out of range. > > > > Simplified as: > > struct lcore_telemetry_info info = { .d = d }; > > char *endptr; // init not r

Re: [PATCH v4 2/9] vhost: simplify need reply handling

2023-01-31 Thread Maxime Coquelin
On 1/19/23 19:46, David Marchand wrote: Dedicate send_vhost_slave_message() helper to the case when no reply is needed. Add a send_vhost_slave_message_process_reply() helper for the opposite. This new helper merges both send_vhost_slave_message() and the code previously in process_slave_messa

RE: [PATCH v3 2/2] ring: add ring info telemetry cmd

2023-01-31 Thread Honnappa Nagarahalli
Few minor nits. Otherwise, Reviewed-by: Honnappa Nagarahalli > -Original Message- > From: Jie Hai > Sent: Monday, January 30, 2023 8:29 PM > To: Honnappa Nagarahalli ; > konstantin.v.anan...@yandex.ru; dev@dpdk.org > Cc: liudongdo...@huawei.com; haij...@huawei.com > Subject: [PATCH v3 2

RE: [PATCH v3 1/2] ring: add ring list telemetry cmd

2023-01-31 Thread Honnappa Nagarahalli
Few minor comments inline. Otherwise, Reviewed-by: Honnappa Nagarahalli > -Original Message- > From: Jie Hai > Sent: Monday, January 30, 2023 8:29 PM > To: Honnappa Nagarahalli ; > konstantin.v.anan...@yandex.ru; dev@dpdk.org > Cc: liudongdo...@huawei.com; haij...@huawei.com > Subject:

Re: [PATCH v4 3/9] vhost: terminate when access lock is not taken

2023-01-31 Thread Maxime Coquelin
On 1/19/23 19:46, David Marchand wrote: Be a bit more strict when a programmatic error is detected wrt to the with regards to* access_lock not being taken. Mark the new helper with __rte_assert_exclusive_lock so that clang understands where locks are expected to be taken. Signed-off-by: D

Re: [PATCH v4 4/9] vhost: annotate virtqueue access lock

2023-01-31 Thread Maxime Coquelin
On 1/19/23 19:46, David Marchand wrote: vhost_user_lock/unlock_all_queue_pairs must be waived since clang annotations can't express taking a runtime number of locks. vhost_queue_stats_update() requirement can be expressed with a required tag. Signed-off-by: David Marchand --- Changes since

  1   2   >