HI Stephen:
BR
Rongwei
> -----Original Message-----
> From: Rongwei Liu
> Sent: Tuesday, January 31, 2023 11:25
> To: Stephen Hemminger <step...@networkplumber.org>; Andrew Rybchenko
> <andrew.rybche...@oktetlabs.ru>
> Cc: Matan Azrad <ma...@nvidia.com>; Slava Ovsiienko
> <viachesl...@nvidia.com>; Ori Kam <or...@nvidia.com>; NBU-Contact-
> Thomas Monjalon (EXTERNAL) <tho...@monjalon.net>; Aman Singh
> <aman.deep.si...@intel.com>; Yuying Zhang <yuying.zh...@intel.com>;
> Ferruh Yigit <ferruh.yi...@amd.com>; Olivier Matz
> <olivier.m...@6wind.com>; dev@dpdk.org; Raslan Darawsheh
> <rasl...@nvidia.com>
> Subject: RE: [PATCH v3 1/8] ethdev: add IPv6 routing extension header
> definition
>
> Hi Stephen
>
> BR
> Rongwei
>
> > -----Original Message-----
> > From: Stephen Hemminger <step...@networkplumber.org>
> > Sent: Tuesday, January 31, 2023 11:02
> > To: Rongwei Liu <rongw...@nvidia.com>
> > Cc: Matan Azrad <ma...@nvidia.com>; Slava Ovsiienko
> > <viachesl...@nvidia.com>; Ori Kam <or...@nvidia.com>; NBU-Contact-
> > Thomas Monjalon (EXTERNAL) <tho...@monjalon.net>; Aman Singh
> > <aman.deep.si...@intel.com>; Yuying Zhang <yuying.zh...@intel.com>;
> > Ferruh Yigit <ferruh.yi...@amd.com>; Andrew Rybchenko
> > <andrew.rybche...@oktetlabs.ru>; Olivier Matz
> > <olivier.m...@6wind.com>; dev@dpdk.org; Raslan Darawsheh
> > <rasl...@nvidia.com>
> > Subject: Re: [PATCH v3 1/8] ethdev: add IPv6 routing extension header
> > definition
> >
> > External email: Use caution opening links or attachments
> >
> >
> > On Mon, 30 Jan 2023 05:59:33 +0200
> > Rongwei Liu <rongw...@nvidia.com> wrote:
> >
> > > +/**
> > > + * @warning
> > > + * @b EXPERIMENTAL: this structure may change without prior notice
> > > + *
> > > + * RTE_FLOW_ITEM_TYPE_IPV6_ROUTING_EXT.
> > > + *
> > > + * Matches an IPv6 routing extension header.
> > > + */
> > > +struct rte_flow_item_ipv6_routing_ext {
> > > + struct rte_ipv6_routing_ext hdr; };
> >
> > The problem with nesting a variable length structure inside another
> > structure is not allowed.
> >
> > The issue is that the applicaiton would have to pass a variable length
> > structure in for the flow definition. The flow item is variable length
> > for this type? all the others are fixed length.
> >
> Yeah, segments_left is uint8 per definition. RFC doesn't set an upper
> limitation.
> It stands for intermediate routing nodes between src and dst nodes.
> > One option would be to get rid of the wrapper structure.
> Yeah, it works. @Andrew Rybchenko Can you share your preference here?
I want to propose "moving flex array" out of the "struct rte_ipv6_routing_ext "
and present in " struct rte_flow_item_ipv6_routing_ext"
Sounds good?
