RE: [PATCH] vdpa/mlx5: fix return value check of mkey create

2021-11-16 Thread Bing Zhao
Hi Chenbo, > -Original Message- > From: Xia, Chenbo > Sent: Tuesday, November 16, 2021 3:54 PM > To: Bing Zhao ; Slava Ovsiienko > ; Matan Azrad > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: RE: [PATCH] vdpa/mlx5: fix return value check of mkey > create > > External email: Use cauti

RE: [PATCH] vdpa/mlx5: fix return value check of mkey create

2021-11-16 Thread Xia, Chenbo
> -Original Message- > From: Bing Zhao > Sent: Tuesday, November 16, 2021 4:01 PM > To: Xia, Chenbo ; Slava Ovsiienko > ; Matan Azrad ; > maxime.coque...@redhat.com > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: RE: [PATCH] vdpa/mlx5: fix return value check of mkey create > > Hi Chenbo,

RE: [PATCH] vhost: fix get hpa fail from guest pages

2021-11-16 Thread Xia, Chenbo
> -Original Message- > From: Xia, Chenbo > Sent: Monday, November 15, 2021 4:04 PM > To: Wang, YuanX ; maxime.coque...@redhat.com > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > ; Ma, WenwuX ; He, Xingguang > ; Yang, YvonneX > Subject: RE: [PATCH] vhost: fix get hpa fail from guest pages >

RE: [PATCH] vdpa/mlx5: fix return value check of mkey create

2021-11-16 Thread Bing Zhao
Hi, > -Original Message- > From: Xia, Chenbo > Sent: Tuesday, November 16, 2021 4:05 PM > To: Bing Zhao ; Slava Ovsiienko > ; Matan Azrad ; > maxime.coque...@redhat.com > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: RE: [PATCH] vdpa/mlx5: fix return value check of mkey > create > > Ext

RE: [PATCH v4] vhost: fix physical address mapping

2021-11-16 Thread Ding, Xuan
Hi Chenbo, > -Original Message- > From: Xia, Chenbo > Sent: 2021年11月16日 15:48 > To: Ding, Xuan ; maxime.coque...@redhat.com > Cc: dev@dpdk.org; Hu, Jiayu ; Wang, YuanX > ; He, Xingguang > Subject: RE: [PATCH v4] vhost: fix physical address mapping > > > -Original Message- > > Fr

[PATCH v1] net/vhost: add queue status check

2021-11-16 Thread Miao Li
This patch adds queue status check to make sure that vhost monitor address will not be got until the link between backend and frontend up and the packets are allowed to be queued. Signed-off-by: Miao Li --- drivers/net/vhost/rte_eth_vhost.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/d

Re: [PATCH v2] eal/ppc: support ASan

2021-11-16 Thread David Marchand
On Mon, Nov 15, 2021 at 10:39 PM David Christensen wrote: > > Add support for Address Sanitizer (ASan) for PPC/POWER architecture. > > Signed-off-by: David Christensen Reviewed-by: David Marchand -- David Marchand

RE: [PATCH] vhost: fix get hpa fail from guest pages

2021-11-16 Thread Ding, Xuan
Hi Chenbo, > -Original Message- > From: Xia, Chenbo > Sent: 2021年11月16日 16:07 > To: Xia, Chenbo ; Wang, YuanX > ; maxime.coque...@redhat.com > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > ; Ma, WenwuX ; He, > Xingguang ; Yang, YvonneX > > Subject: RE: [PATCH] vhost: fix get hpa fail from g

Re: [PATCH] vhost: fix get hpa fail from guest pages

2021-11-16 Thread Maxime Coquelin
Hi, On 11/16/21 09:47, Ding, Xuan wrote: Hi Chenbo, -Original Message- From: Xia, Chenbo Sent: 2021年11月16日 16:07 To: Xia, Chenbo ; Wang, YuanX ; maxime.coque...@redhat.com Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan ; Ma, WenwuX ; He, Xingguang ; Yang, YvonneX Subject: RE: [PATCH] vhost

[PATCH] common/mlx5: fix MPRQ mempool registration

2021-11-16 Thread Dmitry Kozlyuk
Mempool registration code had a wrong assumption that it is always dealing with packet mempools and always called rte_pktmbuf_priv_flags(), which returned a random value for different types of mempools. In particular, it could consider MPRQ mempools as having externally pinned buffers, which is wro

RE: [PATCH] vhost: fix get hpa fail from guest pages

2021-11-16 Thread Xia, Chenbo
> -Original Message- > From: Ding, Xuan > Sent: Tuesday, November 16, 2021 4:47 PM > To: Xia, Chenbo ; Wang, YuanX ; > maxime.coque...@redhat.com > Cc: dev@dpdk.org; Hu, Jiayu ; Ma, WenwuX > ; He, Xingguang ; Yang, YvonneX > > Subject: RE: [PATCH] vhost: fix get hpa fail from guest pages

RE: [PATCH] common/mlx5: fix MPRQ mempool registration

2021-11-16 Thread Slava Ovsiienko
> -Original Message- > From: Dmitry Kozlyuk > Sent: Tuesday, November 16, 2021 10:58 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH] common/mlx5: fix MPRQ mempool registration > > Mempool registration code had a wrong assumption that it is a

Re: [PATCH v1] examples/l3fwd-power: add wakeup log

2021-11-16 Thread David Hunt
Hi Li, On 16/11/2021 1:00 PM, Miao Li wrote: This patch adds a log in main telemetry loop to show the thread is waked up and begins to send and receive packets. Signed-off-by: Miao Li --- examples/l3fwd-power/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/l3fwd-power

Re: [PATCH] examples/vhost: fix port init failure in mergeable mode

2021-11-16 Thread Maxime Coquelin
On 11/4/21 06:11, Chenbo Xia wrote: When the example starts in mergeable mode with an i40e port, it fails to launch because the examples use default mtu MAX_MTU to configure ethdev. The root cause is some devices have Ethernet frame overhead and then MAX_MTU will be larger than device's max mt

RE: [PATCH v2] net/mlx5: fix missing RSS validation with meter policy

2021-11-16 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Monday, November 15, 2021 4:51 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh ; Li Zhang > ; sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix missing RSS validation with meter policy > > The RSS can be

Re: ethdev: hide internal structures

2021-11-16 Thread Ferruh Yigit
On 11/16/2021 12:24 AM, Tyler Retzlaff wrote: hi folks, I don't understand the text of this change. would you mind explaining? commit f9bdee267ab84fd12dc288419aba341310b6ae08 Author: Konstantin Ananyev Date: Wed Oct 13 14:37:04 2021 +0100 ethdev: hide internal structures

Re: [PATCH v1] net/vhost: add queue status check

2021-11-16 Thread Maxime Coquelin
On 11/16/21 17:44, Miao Li wrote: This patch adds queue status check to make sure that vhost monitor address will not be got until the link between backend and frontend s/got/gone/? up and the packets are allowed to be queued. It needs a fixes tag. Signed-off-by: Miao Li --- drivers/n

Re: [PATCH v1] net/vhost: add queue status check

2021-11-16 Thread Maxime Coquelin
On 11/16/21 10:34, Maxime Coquelin wrote: On 11/16/21 17:44, Miao Li wrote: This patch adds queue status check to make sure that vhost monitor address will not be got until the link between backend and frontend s/got/gone/? up and the packets are allowed to be queued. It needs a fixes t

[PATCH v2 00/12] use compiler atomic builtins for app modules

2021-11-16 Thread Joyce Kong
Since atomic operations have been adopted in DPDK now[1], change rte_atomicNN_xxx APIs to compiler's atomic built-ins in app modules[2]. [1] https://www.dpdk.org/blog/2021/03/26/dpdk-adopts-the-c11-memory-model/ [2] https://doc.dpdk.org/guides/rel_notes/deprecation.html v2: By Honnappa Nagaraha

[PATCH v2 01/12] test/pmd_perf: use compiler atomic builtins for polling sync

2021-11-16 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for polling sync in pmd_perf test cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/test/test_pmd_perf.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/app/test/test_pmd_perf.c b/app/test

[PATCH v2 02/12] test/ring_perf: use compiler atomic builtins for lcores sync

2021-11-16 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for lcores sync in ring_perf test cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test/test_ring_perf.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/app/t

[PATCH v2 03/12] test/timer: use compiler atomic builtins for sync

2021-11-16 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for lcore_state and collisions sync. Also, move 'main_init_workers' outside of 'timer_stress2_main_loop' to guarantee lcore_state initialized correctly before the threads launched. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- ap

[PATCH v2 04/12] test/stack_perf: use compiler atomics for lcore sync

2021-11-16 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for lcore sync in stack_perf test cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test/test_stack_perf.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git

[PATCH v2 05/12] test/bpf: use compiler atomics for calculation

2021-11-16 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for calculation in bpf test cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/test/test_bpf.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/app/test/test_bpf.c b/app/test

[PATCH v2 06/12] test/func_reentrancy: use compiler atomics for data sync

2021-11-16 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for shared data sync in func_reentrancy test cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test/test_func_reentrancy.c | 27 +-- 1 file changed, 13 insertions(+

[PATCH v2 07/12] app/eventdev: use compiler atomics for shared data sync

2021-11-16 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for shared data sync in eventdev cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/test-eventdev/evt_main.c | 1 - app/test-eventdev/test_order_atq.c| 4 ++-- app/test-eventdev/test_order_common.c | 4 ++-- app

[PATCH v2 08/12] app/crypto: use compiler atomic builtins for display sync

2021-11-16 Thread Joyce Kong
Convert rte_atomic_test_and_set usage to compiler atomic CAS operation for display sync in crypto cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test-crypto-perf/cperf_test_latency.c| 6 -- app/test-crypto-perf/cperf_test_pmd_cy

[PATCH v2 09/12] app/compress: use compiler atomic builtins for display sync

2021-11-16 Thread Joyce Kong
Convert rte_atomic_test_and_set usage to compiler atomic CAS operation for display sync. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/test-compress-perf/comp_perf_test_common.h| 2 +- .../comp_perf_test_cyclecount.c | 15 +++ .../comp_perf_test_

[PATCH v2 10/12] app/testpmd: remove atomic operations for port status

2021-11-16 Thread Joyce Kong
The port_status changes do not need to be handled atomically, as they are modified during initialization or through the testpmd prompt instead of multiple threads. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/test-pmd/testpmd.c | 58 ++ 1 f

[PATCH v2 11/12] app/bbdev: use compiler atomics for shared data sync

2021-11-16 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for shared data sync in bbdev cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test-bbdev/test_bbdev_perf.c | 135 ++- 1 file changed, 59 insertions(+), 76 del

[PATCH v2 12/12] app: remove unnecessary include of atomic header file

2021-11-16 Thread Joyce Kong
Remove the unnecessary rte_atomic.h included in app modules. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/proc-info/main.c | 1 - app/test-pipeline/config.c | 1 - app/test-pipeline/init.c | 1 - app/test-pipeline/main.c | 1 - app/test-pipeline/runtime.c | 1 -

Re: [PATCH v3] vhost: fix packed ring descriptor update in async enqueue

2021-11-16 Thread Maxime Coquelin
On 11/16/21 16:17, Jiayu Hu wrote: If the packet uses multiple descriptors and its descriptor indices are wrapped, the first descriptor flag is not updated last, which may cause virtio read the incomplete packet. For example, given a packet uses 64 descriptors, and virtio ring size is 256, and

Re: [dpdk-dev] [PATCH v5 3/3] examples/l3fwd: use reserved addresses for EM mode

2021-11-16 Thread David Marchand
On Fri, Nov 5, 2021 at 9:39 AM wrote: > > From: Pavan Nikhilesh > > The l3fwd example should use the reserved IPv4/v6 reserved address > ranges defined in RFC5735, RFC5180 and RFC863 discard protocol for > the port number in the exact match mode of L3 forwarding. > > Signed-off-by: Pavan Nikhiles

RE: [PATCH v9 1/5] app/flow-perf: define flow-options as global

2021-11-16 Thread Wisam Monther
Hi, > -Original Message- > From: Rongwei Liu > Sent: Thursday, November 11, 2021 4:24 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon ; Wisam Monther > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v9 1/5] app/flow-perf: define flow-options

RE: [PATCH v9 2/5] app/flow-perf: support meter policy API

2021-11-16 Thread Wisam Monther
Hi, > -Original Message- > From: Rongwei Liu > Sent: Thursday, November 11, 2021 4:24 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon ; Wisam Monther > > Cc: dev@dpdk.org; Raslan Darawsheh ; Haifei Luo > ; Jiawei(Jonny) Wang > Subject: [PATCH v9 2/5]

RE: [PATCH v9 3/5] app/flow-perf: support dynamic values for meter profile

2021-11-16 Thread Wisam Monther
Hi, > -Original Message- > From: Rongwei Liu > Sent: Thursday, November 11, 2021 4:24 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon ; Wisam Monther > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v9 3/5] app/flow-perf: support dynamic value

RE: [PATCH v9 4/5] app/flow-perf: add packet metering mode

2021-11-16 Thread Wisam Monther
Hi, > -Original Message- > From: Rongwei Liu > Sent: Thursday, November 11, 2021 4:24 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon ; Wisam Monther > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v9 4/5] app/flow-perf: add packet metering m

RE: [PATCH v9 5/5] app/flow-perf: fix previous wrong indentation

2021-11-16 Thread Wisam Monther
Hi, > -Original Message- > From: Rongwei Liu > Sent: Thursday, November 11, 2021 4:24 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon ; Wisam Monther > ; Bill Zhou ; Alexander > Kozyrev > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject

RE: [PATCH v9 5/5] app/flow-perf: fix previous wrong indentation

2021-11-16 Thread Rongwei Liu
> Hi, > > > -Original Message- > > From: Rongwei Liu > > Sent: Thursday, November 11, 2021 4:24 PM > > To: Matan Azrad ; Slava Ovsiienko > > ; Ori Kam ; NBU-Contact- > > Thomas Monjalon ; Wisam Monther > > ; Bill Zhou ; Alexander > > Kozyrev > > Cc: dev@dpdk.org; Raslan Darawsheh ; > > s

RE: [PATCH] vhost: fix get hpa fail from guest pages

2021-11-16 Thread Ding, Xuan
Hi, > -Original Message- > From: Xia, Chenbo > Sent: 2021年11月16日 17:01 > To: Ding, Xuan ; Wang, YuanX ; > maxime.coque...@redhat.com > Cc: dev@dpdk.org; Hu, Jiayu ; Ma, WenwuX > ; He, Xingguang ; Yang, > YvonneX > Subject: RE: [PATCH] vhost: fix get hpa fail from guest pages > > > -

Re: [PATCH] vhost: fix get hpa fail from guest pages

2021-11-16 Thread Maxime Coquelin
On 11/16/21 11:08, Ding, Xuan wrote: Hi, -Original Message- From: Xia, Chenbo Sent: 2021年11月16日 17:01 To: Ding, Xuan ; Wang, YuanX ; maxime.coque...@redhat.com Cc: dev@dpdk.org; Hu, Jiayu ; Ma, WenwuX ; He, Xingguang ; Yang, YvonneX Subject: RE: [PATCH] vhost: fix get hpa fail from

Re: [PATCH] test/red: fix typo in comment

2021-11-16 Thread David Marchand
On Mon, Nov 15, 2021 at 12:52 PM Dumitrescu, Cristian wrote: > > This is probably due a s/red/rte_red/ a long time ago. > > > > Fixes: de3cfa2c9823 ("sched: initial import") > > > > Signed-off-by: David Marchand > Acked-by: Cristian Dumitrescu Applied, thanks. -- David Marchand

Re: [PATCH v2] eal/ppc: support ASan

2021-11-16 Thread David Marchand
On Tue, Nov 16, 2021 at 9:42 AM David Marchand wrote: > > On Mon, Nov 15, 2021 at 10:39 PM David Christensen > wrote: > > > > Add support for Address Sanitizer (ASan) for PPC/POWER architecture. > > > > Signed-off-by: David Christensen > Reviewed-by: David Marchand Applied, thanks. -- David

[PATCH] app/test-crypto-perf: fix segment size for IPsec operation

2021-11-16 Thread Gagandeep Singh
Application calculates segment size based on buffer size plus digest size only, But if the operation mode is IPsec then packet length can be increased upto 73 bytes due to IPsec overhead. In this patch, adding the IPsec overhead length in segment size when there is no user given segment size. Sig

Re: [PATCH] vdpa/mlx5: fix return value check of mkey create

2021-11-16 Thread Maxime Coquelin
On 11/12/21 15:42, Bing Zhao wrote: The return value of "mlx5_os_wrapped_mkey_create" is checked in the caller. A zero means success without any error. The typo in the if-condition should be fixed in case there is a misjudgment. Fixes: f26e06d97d57 ("vdpa/mlx5: workaround dirty bitmap MR cre

Re: [PATCH] examples/vhost: fix port init failure in mergeable mode

2021-11-16 Thread Maxime Coquelin
On 11/4/21 06:11, Chenbo Xia wrote: When the example starts in mergeable mode with an i40e port, it fails to launch because the examples use default mtu MAX_MTU to configure ethdev. The root cause is some devices have Ethernet frame overhead and then MAX_MTU will be larger than device's max mt

RE: [PATCH] vdpa/mlx5: fix return value check of mkey create

2021-11-16 Thread Bing Zhao
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, November 16, 2021 6:25 PM > To: Bing Zhao ; Slava Ovsiienko > ; Matan Azrad > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: Re: [PATCH] vdpa/mlx5: fix return value check of mkey > create > > External email: Use ca

Re: [PATCH v3] vhost: fix packed ring descriptor update in async enqueue

2021-11-16 Thread Maxime Coquelin
On 11/16/21 16:17, Jiayu Hu wrote: If the packet uses multiple descriptors and its descriptor indices are wrapped, the first descriptor flag is not updated last, which may cause virtio read the incomplete packet. For example, given a packet uses 64 descriptors, and virtio ring size is 256, and

RE: ethdev: hide internal structures

2021-11-16 Thread Ananyev, Konstantin
> hi folks, > > I don't understand the text of this change. would you mind explaining? > > commit f9bdee267ab84fd12dc288419aba341310b6ae08 > Author: Konstantin Ananyev > Date: Wed Oct 13 14:37:04 2021 +0100 > ethdev: hide internal structures > > +* ethdev: Made ``rte_eth_dev`

[PATCH v2] app/test-crypto-perf: fix segment size for IPsec operation

2021-11-16 Thread Gagandeep Singh
Application calculates segment size based on buffer size plus digest size only, But if the operation mode is IPsec then packet length can be increased up to 73 bytes due to IPsec overhead. In this patch, adding the IPsec overhead length in segment size when there is no user given segment size. Fi

RE: [EXT] [PATCH v2] app/test-crypto-perf: fix segment size for IPsec operation

2021-11-16 Thread Akhil Goyal
> Application calculates segment size based on buffer size plus > digest size only, But if the operation mode is IPsec then > packet length can be increased up to 73 bytes due to IPsec > overhead. > Can you explain the calculation for 73 bytes in the code? Will it be sufficient for IPv6? > In th

[PATCH -v1] Update num_ops type to be uint32_t in rte_bbdev_enc_op_alloc_bulk

2021-11-16 Thread Zhang, Mingshan
From: "Zhang, Mingshan" Update num_ops type from uint16_t to uint32_t in rte_bbdev_enc_op_alloc_bulk to enlarge the input range. Nicolas Chautru (1): SCSY-51090 ACC100 Padding 5GDL input BLEN drivers/baseband/acc100/rte_acc100_pmd.c | 22 +- 1 file changed, 13 insertions

[PATCH -v1] SCSY-51090 ACC100 Padding 5GDL input BLEN

2021-11-16 Thread Zhang, Mingshan
From: Nicolas Chautru Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c index 392b0f9..794eb

Re: [PATCH v9 0/5] add meter policy support in flow-perf

2021-11-16 Thread Thomas Monjalon
11/11/2021 15:23, Rongwei Liu: > Add meter policy support and provide options to specify > green/yellow/red colored actions and cir/cbs/ebs values. > > v9: split into more commits. > v8: clean log. > v7: rebase on top of dpdk.org/main and fix existed styles. > v6: rebase on top of main. > v5: fix

RE: [PATCH] net/iavf: fix VLAN insertion

2021-11-16 Thread Zhang, Qi Z
> -Original Message- > From: Nicolau, Radu > Sent: Monday, November 15, 2021 7:42 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z ; Nicolau, Radu > > Subject: [PATCH] net/iavf: fix VLAN insertion > > Fix wrong VLAN insertion position as inner. > Fixes: 1e728b0112

RE: [EXT] [PATCH v2] app/test-crypto-perf: fix segment size for IPsec operation

2021-11-16 Thread Gagandeep Singh
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, November 16, 2021 4:12 PM > To: Gagandeep Singh ; dev@dpdk.org > Subject: RE: [EXT] [PATCH v2] app/test-crypto-perf: fix segment size for IPsec > operation > > > Application calculates segment size based on buffer size plus > >

[PATCH v2] common/mlx5: fix MPRQ mempool registration

2021-11-16 Thread Dmitry Kozlyuk
Mempool registration code had a wrong assumption that it is always dealing with packet mempools and always called rte_pktmbuf_priv_flags(), which returned a random value for different types of mempools. In particular, it could consider MPRQ mempools as having externally pinned buffers, which is wro

Re: [PATCH 5/6] drivers/net: fix unused but set variables

2021-11-16 Thread David Marchand
On Mon, Nov 15, 2021 at 6:59 PM Conor Walsh wrote: > > This patch fixes unused but set variables in the following net drivers: > - bnxt > - hinic > - liquidio > - nfp > - octeontx > - qede > - txgbe > - vmxnet3 > > Bugzilla ID: 881 > Fixes: b87abb2e55cb ("net/bnxt: support marking packet")

RE: Probing the expected state/support of DPDK@armhf

2021-11-16 Thread Juraj Linkeš
> -Original Message- > From: Christian Ehrhardt > Sent: Wednesday, November 10, 2021 8:48 AM > To: Ruifeng Wang > Cc: Jan Viktorin ; dev ; Luca > Boccassi ; Juraj Linkeš ; > Honnappa Nagarahalli ; nd > Subject: Re: Probing the expected state/support of DPDK@armhf > > On Tue, Nov 9, 20

RE: [dpdk-dev] [PATCH] Add Armv7 support

2021-11-16 Thread Juraj Linkeš
> -Original Message- > From: dev On Behalf Of > s.chandrak...@globaledgesoft.com > Sent: Thursday, June 10, 2021 1:19 PM > To: dev@dpdk.org > Cc: zaheer...@globaledgesoft.com; gurusidhesh...@globaledgesoft.com; > sm.supr...@globaledgesoft.com; Chandrakant Sharpa > > Subject: [dpdk-dev]

Re: [PATCH 0/6] fix unused but set variables

2021-11-16 Thread David Marchand
n Mon, Nov 15, 2021 at 6:59 PM Conor Walsh wrote: > > When DPDK is compiled with clang 13, several warnings for unused but set > variables are present. > > This patchset fixes these warnings, which were present within: > - app/test > - drivers/bus/fslmc > - drivers/common/qat > - drivers/event

[PATCH] ci: add Fedora 35 container in GHA

2021-11-16 Thread David Marchand
Build DPDK with Fedora 35 containers. Differences with the Ubuntu GHA vm images: - tasks are run as root in containers, no need for sudo, - compiler must be explicitly installed: clang is not in container images, - GHA artifacts can't contain a ':' in their name, and must be filtered, Signed-off-b

[Bug 881] [dpdk-21.11] build failure on Fedora35 with clang 13.0.0

2021-11-16 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=881 David Marchand (david.march...@redhat.com) changed: What|Removed |Added Status|CONFIRMED |RESOLVED Reso

[PATCH v6 0/1] gpu/cuda: introduce CUDA driver

2021-11-16 Thread eagostini
From: Elena Agostini This is the CUDA implementation of the gpudev library. Funcitonalities implemented through CUDA Driver API are: - Device probe and remove - Manage device memory allocations - Register/unregister external CPU memory in the device memory area Changelog: - CUDA driver implemen

[PATCH v6 1/1] gpu/cuda: introduce CUDA driver

2021-11-16 Thread eagostini
From: Elena Agostini This is the CUDA implementation of the gpudev library. Functionalities implemented through CUDA Driver API are: - Device probe and remove - Manage device memory allocations - Register/unregister external CPU memory in the device memory area Signed-off-by: Elena Agostini ---

Re: [PATCH] doc: update release notes for DCF reset API

2021-11-16 Thread Ferruh Yigit
On 11/10/2021 8:59 AM, dapengx...@intel.com wrote: From: Dapeng Yu The ice DCF device reset has been supported. Release notes is updated to synchronize with the feature. Hi Dapeng, Can you please provide fixes line, for the commit that introduced the feature you are documenting? Signed-of

RE: [PATCH] doc: update release notes for DCF reset API

2021-11-16 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, November 16, 2021 8:45 PM > To: Yu, DapengX > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: Re: [PATCH] doc: update release notes for DCF reset API > > On 11/10/2021 8:59 AM, dapengx...@intel.com wrote: > > From: Dapeng Yu > > >

[PATCH 0/4] fixes to TruFlow

2021-11-16 Thread Venkat Duvvuru
This patch set adds fixes to Truflow feature. Jay Ding (1): net/bnxt: remove settings to support multiple session Kishore Padmanabha (3): net/bnxt: fix sram resource free block list net/bnxt: fix multi adapter support net/bnxt: fix ULP context list deadlock drivers/net/bnxt/tf_core/tf_d

[PATCH 1/4] net/bnxt: remove settings to support multiple session

2021-11-16 Thread Venkat Duvvuru
From: Jay Ding Move wc_tcam_slices_per_row and database structure of global_cfg and if_tbl to session structure to support multiple TruFlow sessions with different card type under single dpdk application instance. Signed-off-by: Jay Ding Signed-off-by: Venkat Duvvuru Reviewed-by: Farah Smith

[PATCH 2/4] net/bnxt: fix sram resource free block list

2021-11-16 Thread Venkat Duvvuru
From: Kishore Padmanabha The sram resource free did not reset the next block to be used when the block is not empty. This caused the flows not be created when max flows limit is reached and you delete one flow and try to add a new flow. The fix calls the update of the next free block even when bl

[PATCH 3/4] net/bnxt: fix multi adapter support

2021-11-16 Thread Venkat Duvvuru
From: Kishore Padmanabha 1. removed the global flag for tf global config initialization. 2. Modified the truflow context lock to be a global lock instead of per context lock. 3. The ulp context list is modified to check on the ulp configiuration data so alarm handlers can operate on the correct

[PATCH 4/4] net/bnxt: fix ULP context list deadlock

2021-11-16 Thread Venkat Duvvuru
From: Kishore Padmanabha The ulp context list was not updated when high availability feature was deinitialized. This caused the ulp context list to acquire the lock when it is not supposed to causing the deadlock. The fix is to correctly clear the list. Fixes: 3184b1ef666a ("net/bnxt: add HA sup

RE: [PATCH] net/mlx5: fix keeping indirect RSS non-isolated mode

2021-11-16 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dmitry Kozlyuk > Sent: Tuesday, November 16, 2021 9:39 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Ori Kam ; Raslan > Darawsheh ; Xueming(Steven) Li > ; Slava Ovsiienko > Subject: [PATCH] net/mlx5: fix keeping indirect RSS non-isolated mode > > When a port

Re: [dpdk-dev] [pull-request] dpdk-next-eventdev - v21.11 rc3

2021-11-16 Thread Thomas Monjalon
16/11/2021 08:12, Jerin Jacob Kollanukkaran: > http://dpdk.org/git/next/dpdk-next-eventdev Pulled, thanks.

Re: [PATCH v5] test/bpf_convert: do not require DNS lookup

2021-11-16 Thread David Marchand
On Tue, Nov 16, 2021 at 12:30 AM Stephen Hemminger wrote: > > These tests were using strings with hostname (dpdk.org) and this makes > test code do a DNS lookup. In container environment used for OpenSuse > build, DNS is unavailable. Replace dpdk.org with an IPv4 address > reserved for documentati

RE: [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension header length

2021-11-16 Thread Slava Ovsiienko
> -Original Message- > From: Ferruh Yigit > Sent: Monday, November 15, 2021 21:02 > To: Raslan Darawsheh ; Ori Kam ; > Slava Ovsiienko > Cc: sta...@dpdk.org; Xiaoyun Li ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension header > length > > On 11/4/2021

Re: [PATCH v2] hash: fix thash gfni implementation

2021-11-16 Thread David Marchand
On Fri, Nov 12, 2021 at 3:17 PM Vladimir Medvedkin wrote: > > 1. This patch replaces _mm512_set_epi8 with _mm512_set_epi32 > due to the lack of support by some compilers. Ok, it was the initial report from Lance. > 2. This patch checks if AVX512F is supported along with GFNI. > This is done if t

RE: [PATCH v2] hash: fix thash gfni implementation

2021-11-16 Thread Walsh, Conor
> From: David Marchand > Sent: Tuesday 16 November 2021 13:54 > To: Medvedkin, Vladimir > Cc: dev ; Thomas Monjalon ; > Ananyev, Konstantin ; Lance Richardson > ; j...@dpdk.org; Ji, Kai ; > Wang, Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce > > Subject: Re: [PATCH v2] hash: fix thash gfni impl

Re: [PATCH v2] hash: fix thash gfni implementation

2021-11-16 Thread Bruce Richardson
On Tue, Nov 16, 2021 at 02:53:49PM +0100, David Marchand wrote: > On Fri, Nov 12, 2021 at 3:17 PM Vladimir Medvedkin > wrote: > > > > 1. This patch replaces _mm512_set_epi8 with _mm512_set_epi32 > > due to the lack of support by some compilers. > > Ok, it was the initial report from Lance. > > >

[PATCH v2] app/flow-perf: add missing default option

2021-11-16 Thread Raslan Darawsheh
Currently, if an invalid parameter is passed to the application it will cause a crash due to missing default in options. For example: ./dpdk-test-flow-perf -a 01:00.0 -- --invalid This adds missing default for options, and prints the invalid option. Fixes: 3344cf2e3001 ("app/flow-perf: a

Re: [PATCH v2] hash: fix thash gfni implementation

2021-11-16 Thread David Marchand
On Tue, Nov 16, 2021 at 3:10 PM Bruce Richardson wrote: > > On Tue, Nov 16, 2021 at 02:53:49PM +0100, David Marchand wrote: > > On Fri, Nov 12, 2021 at 3:17 PM Vladimir Medvedkin > > wrote: > > > > > > 1. This patch replaces _mm512_set_epi8 with _mm512_set_epi32 > > > due to the lack of support b

RE: [PATCH v2] app/flow-perf: add missing default option

2021-11-16 Thread Wisam Monther
Hi, > -Original Message- > From: Raslan Darawsheh > Sent: Tuesday, November 16, 2021 4:12 PM > To: dev@dpdk.org > Cc: Wisam Monther ; sta...@dpdk.org > Subject: [PATCH v2] app/flow-perf: add missing default option > > Currently, if an invalid parameter is passed to the application it wil

Re: [PATCH v2] hash: fix thash gfni implementation

2021-11-16 Thread Medvedkin, Vladimir
Hi David, On 16/11/2021 14:53, David Marchand wrote: On Fri, Nov 12, 2021 at 3:17 PM Vladimir Medvedkin wrote: 1. This patch replaces _mm512_set_epi8 with _mm512_set_epi32 due to the lack of support by some compilers. Ok, it was the initial report from Lance. 2. This patch checks if AVX51

Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/l3fwd-power: fix ctrl+c issue

2021-11-16 Thread David Marchand
On Fri, Oct 29, 2021 at 5:50 PM Burakov, Anatoly wrote: > On 29-Oct-21 3:05 PM, Harneet Singh wrote: > > Currently, EAL init cannot be interrupted with SIGINT because the > > signal handler is already overridden by the time EAL init happens. > > > > Fix it by moving signal handler installation to

Re: [pull-request] next-crypto 21.11 rc3

2021-11-16 Thread Thomas Monjalon
16/11/2021 08:35, Akhil Goyal: > http://dpdk.org/git/next/dpdk-next-crypto Pulled, thanks. Some titles were adjusted to better comply with some guidelines.

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension header length

2021-11-16 Thread Ferruh Yigit
On 11/16/2021 1:42 PM, Slava Ovsiienko wrote: -Original Message- From: Ferruh Yigit Sent: Monday, November 15, 2021 21:02 To: Raslan Darawsheh ; Ori Kam ; Slava Ovsiienko Cc: sta...@dpdk.org; Xiaoyun Li ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension

[PATCH v3] hash: fix thash gfni implementation

2021-11-16 Thread Vladimir Medvedkin
1. This patch replaces _mm512_set_epi8 with _mm512_set_epi32 due to the lack of support by some compilers. 2. This patch checks if AVX512F is supported along with GFNI. This is done if the code is built on a platform that supports GFNI, but does not support AVX512. 3. Also this patch fixes compilat

Re: [PATCH v2 0/2] performance optimized for hns3 PMD

2021-11-16 Thread Ferruh Yigit
On 11/16/2021 1:22 AM, Min Hu (Connor) wrote: This patch set contains two ways to optimized Tx performance. Chengwen Feng (2): net/hns3: optimized Tx performance by mbuf fast free net/hns3: optimized Tx performance doc/guides/nics/features/hns3.ini | 1 + drivers/net/hns3/hns3_rxtx.c

[PATCH] common/mlx5: fix redundant field in MR control structure

2021-11-16 Thread michaelba
From: Michael Baum Inside the MR control structure there is a pointer to the common device. This pointer enables access to the global cache as well as hardware objects that may be required in case a new MR needs to be created. The purpose of adding this pointer into the MR control structure was

[PATCH v7 0/1] gpu/cuda: introduce CUDA driver

2021-11-16 Thread eagostini
From: Elena Agostini This is the CUDA implementation of the gpudev library. Funcitonalities implemented through CUDA Driver API are: - Device probe and remove - Manage device memory allocations - Register/unregister external CPU memory in the device memory area Changelog: - CUDA driver implemen

[PATCH v7 1/1] gpu/cuda: introduce CUDA driver

2021-11-16 Thread eagostini
From: Elena Agostini This is the CUDA implementation of the gpudev library. Functionalities implemented through CUDA Driver API are: - Device probe and remove - Manage device memory allocations - Register/unregister external CPU memory in the device memory area Signed-off-by: Elena Agostini ---

Re: [PATCH] ci: add Fedora 35 container in GHA

2021-11-16 Thread Aaron Conole
David Marchand writes: > Build DPDK with Fedora 35 containers. > Differences with the Ubuntu GHA vm images: > - tasks are run as root in containers, no need for sudo, > - compiler must be explicitly installed: clang is not in container images, > - GHA artifacts can't contain a ':' in their name,

[PATCH v6] net/mlx5: fix mutex unlock in txpp cleanup

2021-11-16 Thread Chengfeng Ye
The lock sh->txpp.mutex was not correctly released on one path of cleanup function return, potentially causing the deadlock. Fixes: d133f4cdb7 ("net/mlx5: create clock queue for packet pacing") Cc: sta...@dpdk.org Signed-off-by: Chengfeng Ye --- drivers/net/mlx5/mlx5_txpp.c | 30 ---

[PATCH] doc: add mlx5 PMD flex item documentation

2021-11-16 Thread Gregory Etelson
Describe firmware configuration requirements. List mlx5 hardware and PMD limitations. Signed-off-by: Gregory Etelson --- doc/guides/nics/mlx5.rst | 16 1 file changed, 16 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 552e06c0db..bbeeb1a3d4

回复: [PATCH] net/mlx5: remove redundant "set used"

2021-11-16 Thread YE Chengfeng
Hi, I send the v6 patch. Best regards, Chengfeng 发件人: YE Chengfeng 发送时间: 2021年11月12日 2:31 收件人: Slava Ovsiienko ; Ferruh Yigit ; dev@dpdk.org 抄送: Raslan Darawsheh ; Matan Azrad ; sta...@dpdk.org 主题: Re: [PATCH] net/mlx5: remove redundant "set used" Got it. 获

Re: [dpdk-dev] [PATCH v2] eal/arm: remove CASP constraints for GCC

2021-11-16 Thread David Marchand
On Mon, Nov 8, 2021 at 8:15 AM Ruifeng Wang wrote: > > > -Original Message- > > From: pbhagavat...@marvell.com > > Sent: Friday, November 5, 2021 4:57 PM > > To: Ruifeng Wang ; david.march...@redhat.com; > > jer...@marvell.com > > Cc: dev@dpdk.org; Pavan Nikhilesh > > Subject: [dpdk-dev]

Re: [dpdk-dev] [PATCH v5 1/2] hash: split x86 and SW hash CRC intrinsics

2021-11-16 Thread David Marchand
On Fri, Nov 5, 2021 at 11:11 AM wrote: > > From: Pavan Nikhilesh > > Split x86 and SW hash crc intrinsics into a separate files. > > Signed-off-by: Pavan Nikhilesh > --- > v5 Changes: > - Move CRC functions to implementation specific files to remove >ifdef clutter. (Ruifeng) It is late fo

RE: [PATCH v2 0/2] performance optimized for hns3 PMD

2021-11-16 Thread Fengchengwen
May be forgotten, I send v2 to him this morning, and maybe forgot adding the sign off. But the patch set is OK because we both check them. 发件人:Ferruh Yigit 收件人:humin (Q) ;dev 抄 送:thomas 时 间:2021-11-16 22:37:23 主 题:Re: [PATCH v2 0/2] performance optimized for hns3 PMD On 11/16/2021 1:22 AM, M

RE: [PATCH v6] net/mlx5: fix mutex unlock in txpp cleanup

2021-11-16 Thread Slava Ovsiienko
> -Original Message- > From: Chengfeng Ye > Sent: Tuesday, November 16, 2021 16:49 > To: Matan Azrad ; Slava Ovsiienko > ; Tzahi Oved ; > ferruh.yi...@intel.com; Raslan Darawsheh > Cc: dev@dpdk.org; Chengfeng Ye ; sta...@dpdk.org > Subject: [PATCH v6] net/mlx5: fix mutex unlock in txpp cl

Re: [PATCH] doc: add mlx5 PMD flex item documentation

2021-11-16 Thread Thomas Monjalon
16/11/2021 15:51, Gregory Etelson: > Describe firmware configuration requirements. > List mlx5 hardware and PMD limitations. That's a pity we missed documentation when adding the feature. Please a line "Fixes". [...] > +- Flex item API: > + > + - Firmware configuration: ``FLEX_PARSER_PROFILE_ENA

  1   2   >