> hi folks, > > I don't understand the text of this change. would you mind explaining? > > commit f9bdee267ab84fd12dc288419aba341310b6ae08 > Author: Konstantin Ananyev <konstantin.anan...@intel.com> > Date: Wed Oct 13 14:37:04 2021 +0100 > ethdev: hide internal structures > > +* ethdev: Made ``rte_eth_dev``, ``rte_eth_dev_data``, > ``rte_eth_rxtx_callback`` + private data structures. > ``rte_eth_devices[]`` can't > be accessed directly > + by user any more. While it is an ABI breakage, this change is intended > + to be transparent for both users (no changes in user app is required) and > + PMD developers (no changes in PMD is required). > > > if it is an ABI break (and it is also an API break) how is it that > this change could be "transparent" to the user application? > > * existing binaries will not run. (they need to be recompiled) > * existing code will not compile. (code changes are required) > > in order to cope with this change an application will have to have the > code modified and will need to be re-compiled. so i don't understand how > that is transparent? rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback are internal data structures that were used by public inline ethdev functions. Well behaving app should not access these data structures directly. So, for well behaving app there should no changes in the code required. That what I meant by 'transparent' above. But it is still an ABI change, so yes, the app has to be re-compiled.
Konstantin
