Hi, > -----Original Message----- > From: Bing Zhao <bi...@nvidia.com> > Sent: Monday, November 15, 2021 4:51 PM > To: Slava Ovsiienko <viachesl...@nvidia.com>; Matan Azrad > <ma...@nvidia.com> > Cc: dev@dpdk.org; Raslan Darawsheh <rasl...@nvidia.com>; Li Zhang > <l...@nvidia.com>; sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix missing RSS validation with meter policy > > The RSS can be one of the fate actions when creating a meter with policy. In > the previous implementation, the RSS validation was missed when creating a > flow rule with such meter due to the fact that a policy meter was created > firstly and then used in the rule. In the stage of meter creation, no > rte_flow_item* information was provided. > > A unnecessary RSS expansion might be called since the validation was missed > and would cause an unexpected error of the rule creation. Even though the > rule should be rejected from the very beginning, it would cause confusion. > There might be some other errors when the validation was missed. > > Adding the RSS validation inside the meter action validation will prevent the > code from continuing when there is a conflict between the items, other > actions and the policy meter RSS action. > > Fixes: 444320186393 ("net/mlx5: support meter creation with policy") > Cc: l...@nvidia.com > Cc: sta...@dpdk.org > > Signed-off-by: Bing Zhao <bi...@nvidia.com> > Reviewed-by: Li Zhang <l...@nvidia.com> > Acked-by: Matan Azrad <ma...@nvidia.com> > --- > v2: fix the coding style issue. > ---
Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh