[dpdk-dev] [PATCH 1/2] dmadev: hide devices array

No need to expose rte_dma_devices out of the dmadev library. Existing helpers should be enough, and inlines make use of rte_dma_fp_objs. Signed-off-by: David Marchand --- app/test/test_dmadev.c | 5 +++-- lib/dmadev/rte_dmadev.c | 2 +- lib/dmadev/rte_dmadev_pmd.h | 2 -- lib/dmadev/ver

[dpdk-dev] [PATCH 2/2] dmadev: remove symbol versioning for inline helpers

Inline helpers have no global symbols in shared libraries. There is no reason to ask for versioning (plus this library would not build on Windows). Fixes: 91e581e5c924 ("dmadev: add data plane API") Fixes: ea8cf0f8536d ("dmadev: add burst capacity API") Signed-off-by: David Marchand --- lib/dma

Re: [dpdk-dev] [PATCH v5] lib/cmdline: release cl when cmdline exit

On Mon, Oct 18, 2021 at 05:29:35PM +0300, Dmitry Kozlyuk wrote: > 2021-10-18 21:58 (UTC+0800), zhihongx.p...@intel.com: > > From: Zhihong Peng > > > > Malloc cl in the cmdline_stdin_new function, so release in the > > cmdline_stdin_exit function is logical, so that cl will not be > > released alo

Re: [dpdk-dev] [PATCH] dmadev: enable build on Windows

On Wed, Oct 20, 2021 at 8:32 AM David Marchand wrote: > > On Tue, Oct 19, 2021 at 2:28 PM Bruce Richardson > wrote: > > > > The dmadev library was not added to the list of libraries built on > > Windows, meaning it was skipped in those builds and also that none of > > the drivers were being consi

Re: [dpdk-dev] [PATCH v3 6/6] mempool: deprecate unused defines

On Tue, Oct 19, 2021 at 08:40:22PM +0300, Andrew Rybchenko wrote: > MEMPOOL_PG_NUM_DEFAULT and MEMPOOL_PG_SHIFT_MAX are not used. > > Fixes: fd943c764a63 ("mempool: deprecate xmem functions") > > Signed-off-by: Andrew Rybchenko Acked-by: Olivier Matz

Re: [dpdk-dev] [PATCH v10 04/16] dma/idxd: create dmadev instances on bus probe

On 2021/10/19 22:10, Kevin Laatz wrote: > When a suitable device is found during the bus scan/probe, create a dmadev > instance for each HW queue. Internal structures required for device > creation are also added. > [snip] > static void * > idxd_bus_mmap_wq(struct rte_dsa_device *dev) > { > @

Re: [dpdk-dev] [PATCH] net/ixgbe: initialize max_rx_pkt_len if rlpml_set_vf fails

Hi Ferruh, I have tested with the dpdk-next-net branch. It includes the commit 'ethdev: fix max Rx packet length' Setup: Hypervisor: VMware ESXi 6.0.0 PF ixgbe Driver: 3.7.13.7 (default PF driver installed with ESXi 6.0 and 6.5) NIC: Intel 82599 Guest OS : Ubuntu 20.04 It seems that with the rec

Re: [dpdk-dev] [PATCH v2] kni: fix build for SLES15-SP3

> -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: Tuesday, October 19, 2021 6:49 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Singh, Aman Deep > ; sta...@dpdk.org; Christian Ehrhardt > ; Marco Varlese > Subject: [dpdk-dev] [PATCH v2] kni: fix build for SLES15-SP3 > > From

[dpdk-dev] [PATCH 0/2] set txq affinity in round-robin

Create multiple TISs (number of PF) and bind TXQ to different TISs. The TXQ affinity is predictable and unchanged. Traffic is load-balanced per PMD process. Rongwei Liu (2): common/mlx5: support lag context query net/mlx5: set txq affinity in round-robin doc/guides/nics/mlx5.rst

[dpdk-dev] [PATCH 2/2] net/mlx5: set txq affinity in round-robin

Previously, we set txq affinity to 0 and let firmware to perform round-robin when bonding. Firmware uses a global counter to assign txq affinity to different physical ports accord to remainder after division. There are three dis-advantages: 1. The global counter is shared between kernel and dpdk.

Re: [dpdk-dev] [PATCH v1 3/3] test/devargs: add devargs test cases

On Tue, 2021-10-19 at 17:07 +0200, Gaëtan Rivet wrote: > On Tue, Oct 5, 2021, at 17:54, Xueming Li wrote: > > Initial version to test Global devargs syntax. > > > > Signed-off-by: Xueming Li > > Hi, > > The test is a very nice addition, absolutely required. > I have however two remarks on the c

[dpdk-dev] [PATCH 1/2] common/mlx5: support lag context query

Added a new api mlx5_devx_cmd_query_lag() to query lag property from firmware including state/affinity/mode etc. Signed-off-by: Jiawei Wang Signed-off-by: Rongwei Liu Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 40 + drivers/common/mlx5/mlx5_devx_cm

Re: [dpdk-dev] [PATCH] net/ixgbe: initialize max_rx_pkt_len if rlpml_set_vf fails

since this is not a plain text mail, have to reply on top. ;-) By checking the kernel implementation, this fix makes sense, and finally it works. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c#n2015 Just give an error me

Re: [dpdk-dev] [PATCH v10 05/16] dma/idxd: create dmadev instances on pci probe

On 2021/10/19 22:10, Kevin Laatz wrote: > When a suitable device is found during the PCI probe, create a dmadev > instance for each HW queue. HW definitions required are also included. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > --- [snip] >

Re: [dpdk-dev] [PATCH v2 3/3] test/devargs: add devargs test cases

On Wed, Oct 20, 2021 at 9:32 AM Xueming Li wrote: > > Initial version to test Global devargs syntax. > > Signed-off-by: Xueming Li > --- > app/test/autotest_data.py | 803 ++ This file is getting reintroduced by your patch. We dropped it recently: https://git.

Re: [dpdk-dev] [PATCH v2] ethdev: fix one MAC address occupies two index in mac addrs

On 10/20/2021 7:49 AM, lihuisong (C) wrote: Hi Ferruh 在 2021/10/20 1:45, Ferruh Yigit 写道: On 10/11/2021 10:28 AM, Min Hu (Connor) wrote: From: Huisong Li The dev->data->mac_addrs[0] will be changed to a new MAC address when applications modify the default MAC address by rte_eth_dev_default_m

[dpdk-dev] [PATCH v2 0/9] ethdev: cosmetic fixes

Sicne rte_eth_dev and rte_eth_dev_data structures are just moved right now is a good chance to make a cleanup. Moreover ethdev is or will be shuffled a lot in the release, so do cleanup in all files. Maybe at least some fixes from below could be accepted. Spelling is fixed in log messages as well

[dpdk-dev] [PATCH v2 1/9] ethdev: avoid documentation in next lines

Documentation in the next separate line is confusing. If documentation requires own line it should be before, not after. Fix a number of incorrect markups on the way. When corresponding lines are touched by the patch anyway, add missing full stop to defined types description. Signed-off-by: Andr

[dpdk-dev] [PATCH v2 3/9] ethdev: fix Ethernet spelling

Signed-off-by: Andrew Rybchenko --- lib/ethdev/ethdev_driver.h | 6 +++--- lib/ethdev/ethdev_pci.h | 2 +- lib/ethdev/ethdev_profile.c | 2 +- lib/ethdev/ethdev_vdev.h| 2 +- lib/ethdev/rte_ethdev.h | 10 +- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a

[dpdk-dev] [PATCH v2 2/9] ethdev: fix Rx/Tx spelling

Fix it everywhere in ethdev including log messages. Signed-off-by: Andrew Rybchenko --- lib/ethdev/ethdev_driver.h | 94 ++-- lib/ethdev/ethdev_profile.c | 4 +- lib/ethdev/rte_eth_ctrl.h| 2 +- lib/ethdev/rte_ethdev.c | 50 +++ lib/ethdev/rte_ethdev.h | 278 ++

[dpdk-dev] [PATCH v2 4/9] ethdev: fix DCB and VMDq spelling

Fix both in one changeset since they share line in a number of cases. Signed-off-by: Andrew Rybchenko --- lib/ethdev/ethdev_driver.h | 2 +- lib/ethdev/rte_ethdev.h| 42 +++--- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/lib/ethdev/ethdev

[dpdk-dev] [PATCH v2 5/9] ethdev: fix VLAN spelling including VLAN ID case

Signed-off-by: Andrew Rybchenko --- lib/ethdev/rte_ethdev.c | 2 +- lib/ethdev/rte_ethdev.h | 30 +++--- lib/ethdev/rte_flow.h | 6 +++--- 3 files changed, 19 insertions(+), 19 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index acb667c11

[dpdk-dev] [PATCH v2 6/9] ethdev: fix ID spelling in comments and log messages

Signed-off-by: Andrew Rybchenko --- lib/ethdev/ethdev_driver.h | 2 +- lib/ethdev/ethdev_private.h | 2 +- lib/ethdev/rte_class_eth.c | 2 +- lib/ethdev/rte_ethdev.c | 14 - lib/ethdev/rte_ethdev.h | 62 ++--- lib/ethdev/rte_flow.h | 4 +

[dpdk-dev] [PATCH v2 8/9] ethdev: make device and data structures readable

Add empty lines to separate fields commented using different styles. Signed-off-by: Andrew Rybchenko --- lib/ethdev/ethdev_driver.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h index 7bfc43a99b..dee6b26a5f 100644 --- a/l

[dpdk-dev] [PATCH v2 7/9] ethdev: remove reserved fields from internal structures

Fixes: 8ea354d92f80 ("ethdev: hide eth dev related structures") Signed-off-by: Andrew Rybchenko --- lib/ethdev/ethdev_driver.h | 5 - 1 file changed, 5 deletions(-) diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h index 09a9bcbb50..7bfc43a99b 100644 --- a/lib/ethdev/ethd

[dpdk-dev] [PATCH v2 9/9] ethdev: remove full stop after short comments and references

Full stop at the end of short comment just make line longer. It should be either everywhere or nowhere to be consistent. Signed-off-by: Andrew Rybchenko --- lib/ethdev/ethdev_driver.h | 68 +++--- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/lib

Re: [dpdk-dev] [PATCH 0/5] ethdev: cosmetic fixes for just moved structures

On 10/20/21 1:20 AM, Thomas Monjalon wrote: > 20/10/2021 00:05, Ferruh Yigit: >> On 10/19/2021 7:07 PM, Andrew Rybchenko wrote: >>> On 10/19/21 2:55 PM, Ferruh Yigit wrote: On 10/14/2021 9:36 AM, Andrew Rybchenko wrote: > Sicne rte_eth_dev and rte_eth_dev_data structures are just moved >>>

Re: [dpdk-dev] [PATCH v10 06/16] dma/idxd: add datapath structures

On 2021/10/19 22:10, Kevin Laatz wrote: > Add data structures required for the data path for IDXD devices. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > --- > drivers/dma/idxd/idxd_bus.c | 1 + > drivers/dma/idxd/idxd_common.c | 33 ++

[dpdk-dev] [PATCH v13 1/4] enable ASan AddressSanitizer

From: Zhihong Peng `AddressSanitizer `_ (ASan) is a widely-used debugging tool to detect memory access errors. It helps to detect issues like use-after-free, various kinds of buffer overruns in C/C++ programs, and other similar errors, a

[dpdk-dev] [PATCH v13 2/4] DPDK code adapts to ASan

From: Zhihong Peng DPDK ASan functionality is currently only supported on Linux x86_64. If want to support on other platforms, need to define ASAN_SHADOW_OFFSET value according to google ASan document, and configure meson file (config/meson.build). Signed-off-by: Xueqin Lin Signed-off-by: Zhiho

[dpdk-dev] [PATCH v13 3/4] code changes to avoid the ASan error

From: Zhihong Peng Code changes to avoid the following ASan error: "Control reaches end of non-void function". Signed-off-by: Xueqin Lin Signed-off-by: Zhihong Peng Acked-by: Cristian Dumitrescu --- v7: no change. v8: no change. v9: Modify the submit log. v10:no change. v11:no change. v12:Mod

[dpdk-dev] [PATCH v13 4/4] performance-thread: avoid cross compilation fail

From: Zhihong Peng Code changes to avoid the following ASan error: "strncpy specified bound XX equals destination size". Signed-off-by: Xueqin Lin Signed-off-by: Zhihong Peng Acked-by: Bruce Richardson --- v11: Use rte_strlcpy to replace strncpy. v12: Delete rte_strlcpy's rte_. v13: Modify th

Re: [dpdk-dev] [EXT] [PATCH] app/test-eventdev: fix terminal colour after control-c exit

On Mon, Oct 18, 2021 at 6:24 PM Pavan Nikhilesh Bhagavatula wrote: > > >Before this commit, a Control^C exit of the test-eventdev application > >would print the worker packet percentages, and leave the terminal with > >a green colour despite the colour reset being issued after the newline. > >By m

Re: [dpdk-dev] [PATCH v10 2/7] ethdev: new API to resolve device capability name

On 10/20/21 10:47 AM, Xueming(Steven) Li wrote: > On Tue, 2021-10-19 at 20:57 +0300, Andrew Rybchenko wrote: >> On 10/19/21 6:28 PM, Xueming Li wrote: >>> This patch adds API to return name of device capability. >>> >>> Signed-off-by: Xueming Li >> >> [snip] >> >>> diff --git a/lib/ethdev/rte_ethd

[dpdk-dev] [PATCH v17 0/5] Add PIE support for HQoS library

DPDK sched library is equipped with mechanism that secures it from the bufferbloat problem which is a situation when excess buffers in the network cause high latency and latency variation. Currently, it supports RED for active queue management. However, more advanced queue management is required

[dpdk-dev] [PATCH v17 1/5] sched: add PIE based congestion management

Implement PIE based congestion management based on rfc8033 Signed-off-by: Liguzinski, WojciechX -- Changes in V17: - Corrected paragraph link naming in qos_framework.rst to fix CI builds Changes in V16: - Fixed 'title underline too short' error in qos_framework.rst - Applied __rte_unused macro t

[dpdk-dev] [PATCH v17 2/5] example/qos_sched: add PIE support

patch add support enable PIE or RED by parsing config file. Signed-off-by: Liguzinski, WojciechX --- config/rte_config.h | 1 - examples/qos_sched/app_thread.c | 1 - examples/qos_sched/cfg_file.c | 127 +++-- examples/qos_sched/cfg_file.h | 5 + examples/qo

[dpdk-dev] [PATCH v17 3/5] example/ip_pipeline: add PIE support

Adding the PIE support for IP Pipeline Signed-off-by: Liguzinski, WojciechX --- examples/ip_pipeline/tmgr.c | 142 +++- 1 file changed, 74 insertions(+), 68 deletions(-) diff --git a/examples/ip_pipeline/tmgr.c b/examples/ip_pipeline/tmgr.c index e4e364cbc0..b138

[dpdk-dev] [PATCH v17 4/5] doc/guides/prog_guide: added PIE

Added PIE related information to documentation. Signed-off-by: Liguzinski, WojciechX --- doc/guides/prog_guide/glossary.rst | 3 + doc/guides/prog_guide/qos_framework.rst | 64 +--- doc/guides/prog_guide/traffic_management.rst | 13 +++- 3 files changed, 68 insert

[dpdk-dev] [PATCH v17 5/5] app/test: add tests for PIE

Tests for PIE code added to test application. Signed-off-by: Liguzinski, WojciechX --- app/test/meson.build |4 + app/test/test_pie.c | 1065 ++ lib/sched/rte_pie.c |6 +- lib/sched/rte_pie.h | 17 +- 4 files changed, 1085 insertions(+), 7 del

Re: [dpdk-dev] [PATCH v3 2/6] mempool: add namespace prefix to flags

On 10/19/21 11:03 PM, David Marchand wrote: > On Tue, Oct 19, 2021 at 7:40 PM Andrew Rybchenko > wrote: >> @@ -752,7 +752,7 @@ >> test_mempool_flag_non_io_set_when_no_iova_contig_set(void) >> ret = rte_mempool_populate_default(mp); >> RTE_TEST_ASSERT(ret > 0, "Failed to populate m

Re: [dpdk-dev] [PATCH v3 0/6] mempool: cleanup namespace

On Tue, Oct 19, 2021 at 10:09 PM David Marchand wrote: > On Tue, Oct 19, 2021 at 7:40 PM Andrew Rybchenko > wrote: > > > > Add RTE_ prefix to mempool API including internal. Keep old public API > > with fallback to new defines. Internal API is just renamed. > > > > v3: > > - fix typo > >

Re: [dpdk-dev] [PATCH v3 0/6] mempool: cleanup namespace

On 10/19/21 11:09 PM, David Marchand wrote: > On Tue, Oct 19, 2021 at 7:40 PM Andrew Rybchenko > wrote: >> >> Add RTE_ prefix to mempool API including internal. Keep old public API >> with fallback to new defines. Internal API is just renamed. >> >> v3: >> - fix typo >> - rebase on top of

Re: [dpdk-dev] [PATCH] mempool: accept user flags only

On Mon, Oct 18, 2021 at 10:36 AM Olivier Matz wrote: > > On Mon, Oct 18, 2021 at 10:26:35AM +0200, David Marchand wrote: > > As reported by Dmitry, MEMPOOL_F_POOL_CREATED is a flag only manipulated > > internally. > > This flag is not supposed to be requested from an application and would > > prob

Re: [dpdk-dev] [PATCH v10 07/16] dma/idxd: add configure and info_get functions

Reviewed-by: Chengwen Feng On 2021/10/19 22:10, Kevin Laatz wrote: > Add functions for device configuration. The info_get function is included > here since it can be useful for checking successful configuration. > > Documentation is also updated to add device configuration usage info. > > Signe

Re: [dpdk-dev] [PATCH v3 0/6] mempool: cleanup namespace

On 10/20/21 10:52 AM, David Marchand wrote: > On Tue, Oct 19, 2021 at 10:09 PM David Marchand > wrote: >> On Tue, Oct 19, 2021 at 7:40 PM Andrew Rybchenko >> wrote: >>> >>> Add RTE_ prefix to mempool API including internal. Keep old public API >>> with fallback to new defines. Internal API is jus

Re: [dpdk-dev] [PATCH v10 08/16] dma/idxd: add start and stop functions for pci devices

On 2021/10/19 22:10, Kevin Laatz wrote: > Add device start/stop functions for DSA devices bound to vfio. For devices > bound to the IDXD kernel driver, these are not required since the IDXD > kernel driver takes care of this. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Rev

Re: [dpdk-dev] [PATCH v3 0/6] mempool: cleanup namespace

On Wed, Oct 20, 2021 at 9:52 AM Andrew Rybchenko wrote: > > Thanks for the quick rebase. > > I had rebased v2 before Olivier comments. > > I spotted a little issue diffing with your v3 (see comment on patch > > 2), and fixed your v3 in a local branch of mine. > > It passes my checks. > > > > I'll

Re: [dpdk-dev] [PATCH v10 06/16] dma/idxd: add datapath structures

On Wed, Oct 20, 2021 at 03:44:28PM +0800, fengchengwen wrote: > On 2021/10/19 22:10, Kevin Laatz wrote: > > Add data structures required for the data path for IDXD devices. > > > > Signed-off-by: Bruce Richardson > > Signed-off-by: Kevin Laatz > > Reviewed-by: Conor Walsh > > --- > > drivers/d

Re: [dpdk-dev] [PATCH v2 3/3] test/devargs: add devargs test cases

On Wed, 2021-10-20 at 09:38 +0200, David Marchand wrote: > On Wed, Oct 20, 2021 at 9:32 AM Xueming Li wrote: > > > > Initial version to test Global devargs syntax. > > > > Signed-off-by: Xueming Li > > --- > > app/test/autotest_data.py | 803 ++ > > This fil

[dpdk-dev] [Bug 829] [build]Meson build 'enic' failed on OpenSuse15.2 with GCC 7.5.0

https://bugs.dpdk.org/show_bug.cgi?id=829 longfengx.li...@intel.com (longfengx.li...@intel.com) changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED

Re: [dpdk-dev] [PATCH v10 09/16] dma/idxd: add data-path job submission functions

On 2021/10/19 22:10, Kevin Laatz wrote: > Add data path functions for enqueuing and submitting operations to DSA > devices. > > Documentation updates are included for dmadev library and IDXD driver docs > as appropriate. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Revi

Re: [dpdk-dev] [PATCH] build/windows: remove separate list of libs

On Wed, Oct 20, 2021 at 08:29:09AM +0200, David Marchand wrote: > On Tue, Oct 19, 2021 at 6:19 PM Bruce Richardson > wrote: > > > > Rather than maintaining a separate list of libraries which are to be > > built on windows, use the standard library list and explicitly add to > > each library that i

Re: [dpdk-dev] [EXT] [PATCH v4 00/14] drivers/crypto: introduce ipsec_mb framework

> > > Acked-by: Akhil Goyal > > > Patches are rebased over TOT of next-crypto > > > Release notes are updated > > > Applied to dpdk-next-crypto > > > > I think compilation has not been tested. > > I am not sure why this is failing at your end, > On my machine, it is getting compiled with intel-ip

Re: [dpdk-dev] [EXT] [PATCH v3] app/test-eventdev: add burst enqueue support

On Mon, Oct 18, 2021 at 6:23 PM Pavan Nikhilesh Bhagavatula wrote: > > >This commit introduces a new command line option prod_enq_burst_sz > >to set burst size for eventdev enqueue at producer in perf_queue > >test. The newly added function perf_producer_burst is called when > >prod_enq_burst_sz i

[dpdk-dev] [PATCH v4 0/5] add new definitions for wait scheme

Add new definitions for wait scheme, and apply this new definitions into lib to replace rte_pause. v2: 1. use macro to create new wait scheme (Stephen) v3: 1. delete unnecessary bug fix in bpf (Konstantin) v4: 1. put size into the macro body (Konstantin) 2. replace assert with BUILD_BUG_ON (Step

[dpdk-dev] [PATCH v4 1/5] eal: add new definitions for wait scheme

Introduce macros as generic interface for address monitoring. Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang --- lib/eal/arm/include/rte_pause_64.h | 126 lib/eal/include/generic/rte_pause.h | 32 +++ 2 files changed, 104 insertions(+), 54 deletions(-)

[dpdk-dev] [PATCH v4 2/5] eal: use wait event for read pflock

Instead of polling for read pflock update, use wait event scheme for this case. Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang --- lib/eal/include/generic/rte_pflock.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/eal/include/generic/rte_pflock.h b/lib/eal/in

[dpdk-dev] [PATCH v4 3/5] eal: use wait event scheme for mcslock

Instead of polling for mcslock to be updated, use wait event scheme for this case. Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang --- lib/eal/include/generic/rte_mcslock.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/eal/include/generic/rte_mcslock.h b

[dpdk-dev] [PATCH v4 4/5] lib/bpf: use wait event scheme for Rx/Tx iteration

Instead of polling for cbi->use to be updated, use wait event scheme. Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang --- lib/bpf/bpf_pkt.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/bpf/bpf_pkt.c b/lib/bpf/bpf_pkt.c index 6e8248f0d6..00a5748061 100644

[dpdk-dev] [PATCH v4 5/5] lib/distributor: use wait event scheme

Instead of polling for bufptr64 to be updated, use wait event for this case. Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang --- lib/distributor/rte_distributor_single.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/distributor/rte_distributor_single.c

Re: [dpdk-dev] [EXT] [PATCH v4 00/14] drivers/crypto: introduce ipsec_mb framework

Hi Thomas, As stated in all cryptodev guides for the PMDs based on intel-ipsec-mb, the minimum dependent intel-ipsec-mb lib version is bumped to 1.0. Could you bump the library version and try again? Regards, Fan > -Original Message- > From: Akhil Goyal > Sent: Wednesday, October 20, 2

Re: [dpdk-dev] [EXT] Re: [PATCH v4 1/7] malloc: introduce malloc is ready API

> -Original Message- > From: Dmitry Kozlyuk > Sent: Wednesday, October 20, 2021 3:34 AM > To: Harman Kalra > Cc: dev@dpdk.org; Anatoly Burakov ; > david.march...@redhat.com; m...@ashroe.eu; tho...@monjalon.net > Subject: [EXT] Re: [PATCH v4 1/7] malloc: introduce malloc is ready API >

Re: [dpdk-dev] [EXT] [PATCH v4 00/14] drivers/crypto: introduce ipsec_mb framework

20/10/2021 10:31, Akhil Goyal: > > > > Acked-by: Akhil Goyal > > > > Patches are rebased over TOT of next-crypto > > > > Release notes are updated > > > > Applied to dpdk-next-crypto > > > > > > I think compilation has not been tested. > > > > I am not sure why this is failing at your end, > > On

Re: [dpdk-dev] [EXT] [PATCH v4 00/14] drivers/crypto: introduce ipsec_mb framework

> Hi Thomas, > > As stated in all cryptodev guides for the PMDs based on intel-ipsec-mb, > the minimum dependent intel-ipsec-mb lib version is bumped to 1.0. > > Could you bump the library version and try again? > Hi Fan, The version is bumped. I downloaded from the zip link https://github.com/

Re: [dpdk-dev] [PATCH v3 3/3] test/devargs: add devargs test cases

On Wed, Oct 20, 2021 at 10:22 AM Xueming Li wrote: > > Initial version to test Global devargs syntax. > > Signed-off-by: Xueming Li 10/95 DPDK:fast-tests / devargs_autotest FAIL 0.17 s (exit status 255 or signal 127 SIGinvalid) --- command --- DPDK_TEST='devargs_autotest' /home/runner/

Re: [dpdk-dev] [PATCH v5 14/15] test/crypto: add raw API test for dpaax

17/10/2021 18:16, Hemant Agrawal: > This patch add support for raw API tests for > dpaa_sec and dpaa2_sec platforms. Why do we have tests specific to some drivers? Is there a plan to remove them? > +REGISTER_TEST_COMMAND(cryptodev_dpaa2_sec_raw_api_autotest, > + test_cryptodev_dpaa2_s

[dpdk-dev] [PATCH] devtools: check prefix for libraries patches

The convention in DPDK is to directly use library names as prefix, without a lib/. Signed-off-by: David Marchand --- devtools/check-git-log.sh | 6 ++ 1 file changed, 6 insertions(+) diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh index 9988bf863d..475f2464ab 100755 --- a

Re: [dpdk-dev] [EXT] Re: [PATCH v5 14/15] test/crypto: add raw API test for dpaax

> 17/10/2021 18:16, Hemant Agrawal: > > This patch add support for raw API tests for > > dpaa_sec and dpaa2_sec platforms. > > Why do we have tests specific to some drivers? > Is there a plan to remove them? > The testsuites are common and there is no driver specific test. The test command is di

Re: [dpdk-dev] [PATCH v10 11/16] dma/idxd: add operation statistic tracking

On 2021/10/19 22:10, Kevin Laatz wrote: > Add statistic tracking for DSA devices. > > The dmadev library documentation is also updated to add a generic section > for using the library's statistics APIs. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh

Re: [dpdk-dev] [EXT] Re: [PATCH v5 14/15] test/crypto: add raw API test for dpaax

20/10/2021 11:15, Akhil Goyal: > > 17/10/2021 18:16, Hemant Agrawal: > > > This patch add support for raw API tests for > > > dpaa_sec and dpaa2_sec platforms. > > > > Why do we have tests specific to some drivers? > > Is there a plan to remove them? > > > > The testsuites are common and there i

Re: [dpdk-dev] [PATCH v5] lib/cmdline: release cl when cmdline exit

> -Original Message- > From: Peng, ZhihongX > Sent: Monday, October 18, 2021 9:59 PM > To: olivier.m...@6wind.com; dmitry.kozl...@gmail.com > Cc: dev@dpdk.org; Peng, ZhihongX > Subject: [PATCH v5] lib/cmdline: release cl when cmdline exit > > From: Zhihong Peng > > Malloc cl in the cmd

Re: [dpdk-dev] [EXT] Re: [PATCH v4 3/7] eal/interrupts: avoid direct access to interrupt handle

> -Original Message- > From: Dmitry Kozlyuk > Sent: Wednesday, October 20, 2021 2:58 AM > To: Harman Kalra > Cc: dev@dpdk.org; Bruce Richardson ; > david.march...@redhat.com; m...@ashroe.eu; tho...@monjalon.net > Subject: [EXT] Re: [PATCH v4 3/7] eal/interrupts: avoid direct access to

Re: [dpdk-dev] [PATCH] eventdev/rx_adapter: fix wrr buffer overrun issue

On Mon, Oct 18, 2021 at 4:39 PM Jayatheerthan, Jay wrote: > > Acked-by: Jay Jayatheerthan Changed the subject to: eventdev/rx_adapter: fix WRR buffer overrun issue Cced sta...@dpdk.org Series applied to dpdk-next-net-eventdev/for-main. Thanks > > > -Original Message- > > From: Naga Ha

Re: [dpdk-dev] [PATCH v3 08/18] eal: fix typos in comments

On 14/10/2021 22:56, Stephen Hemminger wrote: Minor spelling errors. Signed-off-by: Stephen Hemminger Acked-by: Ray Kinsella

Re: [dpdk-dev] [PATCH v5 1/4] mempool: add event callbacks

On 15/10/2021 17:02, Dmitry Kozlyuk wrote: Data path performance can benefit if the PMD knows which memory it will need to handle in advance, before the first mbuf is sent to the PMD. It is impractical, however, to consider all allocated memory for this purpose. Most often mbuf memory comes fr

Re: [dpdk-dev] [PATCH v10 12/16] dma/idxd: add vchan status function

On 2021/10/19 22:10, Kevin Laatz wrote: > When testing dmadev drivers, it is useful to have the HW device in a known > state. This patch adds the implementation of the function which will wait > for the device to be idle (all jobs completed) before proceeding. > > Signed-off-by: Kevin Laatz > Rev

Re: [dpdk-dev] [PATCH v5 3/4] common/mlx5: add mempool registration facilities

On 15/10/2021 17:02, Dmitry Kozlyuk wrote: Add internal API to register mempools, that is, to create memory regions (MR) for their memory and store them in a separate database. Implementation deals with multi-process, so that class drivers don't need to. Each protection domain has its own data

Re: [dpdk-dev] [PATCH v2 0/9] ethdev: cosmetic fixes

On 10/20/2021 8:42 AM, Andrew Rybchenko wrote: Sicne rte_eth_dev and rte_eth_dev_data structures are just moved right now is a good chance to make a cleanup. Moreover ethdev is or will be shuffled a lot in the release, so do cleanup in all files. Maybe at least some fixes from below could be acc

Re: [dpdk-dev] [PATCH v2 02/13] common/mlx5: support receive memory pool

On 16/10/2021 10:12, Xueming Li wrote: Adds DevX supports of PRM shared receive memory pool(RMP) object. RMP is used to support shared Rx queue. Multiple RQ could share same RMP. Memory buffers are supplied to RMP. This patch makes RMP RQ optional, created only if mlx5_devx_rq.rmp is set. Si

Re: [dpdk-dev] [EXT] Re: [PATCH v5 14/15] test/crypto: add raw API test for dpaax

> > 20/10/2021 11:15, Akhil Goyal: > > > 17/10/2021 18:16, Hemant Agrawal: > > > > This patch add support for raw API tests for > > > > dpaa_sec and dpaa2_sec platforms. > > > > > > Why do we have tests specific to some drivers? > > > Is there a plan to remove them? > > > > > > > The testsuites ar

Re: [dpdk-dev] [PATCH v10 13/16] dma/idxd: add burst capacity API

Reviewed-by: Chengwen Feng On 2021/10/19 22:10, Kevin Laatz wrote: > Add support for the burst capacity API. This API will provide the calling > application with the remaining capacity of the current burst (limited by > max HW batch size). > > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Wal

[dpdk-dev] [PATCH v6 0/3] support PPPoL2TPv2oUDP RSS Hash

Support IAVF PPPoL2TPv2oUDP RSS Hash. Required to distribute packets based on inner IP src+dest address and TCP/UDP src+dest port. --- v6: * update release notes. * update lib/net/meson.build. * update testpmd_funcs.rst. * update doxygen comments in header files. * update doc/api/doxy-api-ind

[dpdk-dev] [PATCH v6 1/3] ethdev: support PPP and L2TPV2 procotol

Added flow pattern items and header formats of L2TPv2 and PPP. Signed-off-by: Wenjun Wu Signed-off-by: Jie Wang --- doc/api/doxy-api-index.md | 2 + doc/guides/prog_guide/rte_flow.rst | 25 +++ doc/guides/rel_notes/release_21_11.rst | 5 + doc/guides/testpmd

[dpdk-dev] [PATCH v6 2/3] net/iavf: support PPPoL2TPv2oUDP RSS Hash

Add support for PPP over L2TPv2 over UDP protocol RSS Hash based on inner IP src/dst address and TCP/UDP src/dst port. Patterns are listed below: eth/ipv4(6)/udp/l2tpv2/ppp/ipv4(6) eth/ipv4(6)/udp/l2tpv2/ppp/ipv4(6)/udp eth/ipv4(6)/udp/l2tpv2/ppp/ipv4(6)/tcp Signed-off-by: Wenjun Wu Signed-off-b

[dpdk-dev] [PATCH v6 3/3] app/testpmd: support L2TPV2 and PPP protocol pattern

Add support for test-pmd to parse protocol pattern L2TPv2 and PPP. Signed-off-by: Wenjun Wu Signed-off-by: Jie Wang --- app/test-pmd/cmdline_flow.c | 251 1 file changed, 251 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow

Re: [dpdk-dev] [PATCH] ip_frag: promote APIs to stable

On 18/10/2021 16:36, Konstantin Ananyev wrote: Promote rte_frag_table_del_expired_entries() function to stable. It was around for few years by now without any changes. Signed-off-by: Konstantin Ananyev --- lib/ip_frag/rte_ip_frag.h | 1 - lib/ip_frag/version.map | 7 +-- 2 files ch

Re: [dpdk-dev] [PATCH 2/2] dmadev: remove symbol versioning for inline helpers

On Wed, Oct 20, 2021 at 08:59:44AM +0200, David Marchand wrote: > Inline helpers have no global symbols in shared libraries. > There is no reason to ask for versioning (plus this library would not > build on Windows). > > Fixes: 91e581e5c924 ("dmadev: add data plane API") > Fixes: ea8cf0f8536d ("d

Re: [dpdk-dev] [PATCH v3 3/3] test/devargs: add devargs test cases

On Wed, 2021-10-20 at 11:08 +0200, David Marchand wrote: > On Wed, Oct 20, 2021 at 10:22 AM Xueming Li wrote: > > > > Initial version to test Global devargs syntax. > > > > Signed-off-by: Xueming Li > > 10/95 DPDK:fast-tests / devargs_autotest FAIL 0.17 s (exit > status 255 or signal

Re: [dpdk-dev] [PATCH 1/2] dmadev: hide devices array

On 2021/10/20 14:59, David Marchand wrote: > No need to expose rte_dma_devices out of the dmadev library. > Existing helpers should be enough, and inlines make use of > rte_dma_fp_objs. > > Signed-off-by: David Marchand > --- > app/test/test_dmadev.c | 5 +++-- > lib/dmadev/rte_dmadev.c

Re: [dpdk-dev] [EXT] Re: [PATCH v4 3/7] eal/interrupts: avoid direct access to interrupt handle

2021-10-20 09:25 (UTC+), Harman Kalra: > [...] > > > diff --git a/lib/eal/freebsd/eal_interrupts.c > > > b/lib/eal/freebsd/eal_interrupts.c > > [...] > > > @@ -135,9 +137,18 @@ rte_intr_callback_register(const struct > > rte_intr_handle *intr_handle, > > > ret

Re: [dpdk-dev] [PATCH v10 12/16] dma/idxd: add vchan status function

On Wed, Oct 20, 2021 at 05:30:13PM +0800, fengchengwen wrote: > On 2021/10/19 22:10, Kevin Laatz wrote: > > When testing dmadev drivers, it is useful to have the HW device in a known > > state. This patch adds the implementation of the function which will wait > > for the device to be idle (all job

Re: [dpdk-dev] [PATCH v6 1/3] ethdev: support PPP and L2TPV2 procotol

On 10/20/21 12:32 PM, Jie Wang wrote: > Added flow pattern items and header formats of L2TPv2 and PPP. > > Signed-off-by: Wenjun Wu > Signed-off-by: Jie Wang Newly added items must be added to doc/guides/nics/features/default.ini in correct order. When the item is supported, ini file of the co

Re: [dpdk-dev] [PATCH 1/2] dmadev: hide devices array

On Wed, Oct 20, 2021 at 11:47 AM fengchengwen wrote: > > On 2021/10/20 14:59, David Marchand wrote: > > No need to expose rte_dma_devices out of the dmadev library. > > Existing helpers should be enough, and inlines make use of > > rte_dma_fp_objs. > > > > Signed-off-by: David Marchand > > --- >

Re: [dpdk-dev] [PATCH] port: eventdev port api promoted

On 13/10/2021 13:12, Thomas Monjalon wrote: +Cc Cristian, the maintainer 10/09/2021 15:40, Kinsella, Ray: On 10/09/2021 08:36, David Marchand wrote: On Fri, Sep 10, 2021 at 9:31 AM Kinsella, Ray wrote: On 09/09/2021 17:40, Rahul Shah wrote: rte_port_eventdev_reader_ops, rte_port_eventdev

Re: [dpdk-dev] [PATCH 1/2] dmadev: hide devices array

> Subject: [dpdk-dev] [PATCH 1/2] dmadev: hide devices array > > No need to expose rte_dma_devices out of the dmadev library. > Existing helpers should be enough, and inlines make use of > rte_dma_fp_objs. > > Signed-off-by: David Marchand > --- The devices array is not needed by the drivers.

Re: [dpdk-dev] [PATCH v3 3/6] net: advertise no support for keeping flow rules

On 10/19/21 3:37 PM, Dmitry Kozlyuk wrote: > When RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP capability bit is zero, > the specified behavior is the same as it had been before > this bit was introduced. Explicitly reset it in all PMDs > supporting rte_flow API in order to attract the attention > of maintainer

Re: [dpdk-dev] [PATCH v3 0/6] Flow entites behavior on port restart

On 10/19/21 3:37 PM, Dmitry Kozlyuk wrote: > It is unspecified whether flow rules and indirect actions are kept > when a port is stopped, possibly reconfigured, and started again. > Vendors approach the topic differently, e.g. mlx5 and i40e PMD > disagree in whether flow rules can be kept, and mlx5

Re: [dpdk-dev] [PATCH v2] ethdev: fix one MAC address occupies two index in mac addrs

On 20/10/2021 08:41, Ferruh Yigit wrote: On 10/20/2021 7:49 AM, lihuisong (C) wrote: Hi Ferruh 在 2021/10/20 1:45, Ferruh Yigit 写道: On 10/11/2021 10:28 AM, Min Hu (Connor) wrote: From: Huisong Li The dev->data->mac_addrs[0] will be changed to a new MAC address when applications modify the de

[dpdk-dev] [PATCH v3] app/testpmd: fix l4 sw csum over multi segments

In csum forwarding mode, software UDP/TCP csum calculation only takes the first segment into account while using the whole packet length so the calculation will read invalid memory region with multi-segments packets and will get wrong value. This patch fixes this issue. Fixes: af75078fece3 ("first

  1   2   3   4   >