On 2021/10/20 14:59, David Marchand wrote:
> No need to expose rte_dma_devices out of the dmadev library.
> Existing helpers should be enough, and inlines make use of
> rte_dma_fp_objs.
>
> Signed-off-by: David Marchand <david.march...@redhat.com>
> ---
> app/test/test_dmadev.c | 5 +++--
> lib/dmadev/rte_dmadev.c | 2 +-
> lib/dmadev/rte_dmadev_pmd.h | 2 --
> lib/dmadev/version.map | 1 -
> 4 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c
> index 1e327bd45f..8b58256afc 100644
> --- a/app/test/test_dmadev.c
> +++ b/app/test/test_dmadev.c
> @@ -747,10 +747,11 @@ test_dmadev_instance(int16_t dev_id)
> };
> const int vchan = 0;
>
> + rte_dma_info_get(dev_id, &info);
suggest declare info as: struct rte_dma_stats info = { 0 };
so that the following %s will display NULL if rte_dma_info_get call fail.
anyway,
Reviewed-by: Chengwen Feng <fengcheng...@huawei.com>
> +
> printf("\n### Test dmadev instance %u [%s]\n",
> - dev_id, rte_dma_devices[dev_id].data->dev_name);
> + dev_id, info.dev_name);
>
> - rte_dma_info_get(dev_id, &info);
> if (info.max_vchans < 1)
> ERR_RETURN("Error, no channels available on device id %u\n",
> dev_id);
>
> diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c
> index 182d32aedb..d4b32b2971 100644
[snip]
