On 10/19/21 3:37 PM, Dmitry Kozlyuk wrote: > When RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP capability bit is zero, > the specified behavior is the same as it had been before > this bit was introduced. Explicitly reset it in all PMDs > supporting rte_flow API in order to attract the attention > of maintainers, who should eventually choose to advertise > the new capability or not. It is already known that > mlx4 and mlx5 will not support this capability. > > For RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEP > similar action is not performed, > because no PMD except mlx5 supports indirect actions. > Any PMD that starts doing so will anyway have to consider > all relevant API, including this capability. > > Suggested-by: Ferruh Yigit <ferruh.yi...@intel.com> > Signed-off-by: Dmitry Kozlyuk <dkozl...@nvidia.com>
[snip] > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index aa7e7fdc85..1a6e0128ff 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -1009,6 +1009,7 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev > *eth_dev, > dev_info->speed_capa = bnxt_get_speed_capabilities(bp); > dev_info->dev_capa = RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP | > RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP; > + dev_info->dev_capa &= ~RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP; Sorry, but here and everywhere below I see no point to cleanup the bit explicitly when it is not actually set. [snip]
