Re: [dpdk-dev] [PATCH 8/8] examples/tep_termination: enhance getopt_long usage

2020-11-02 Thread Ibtisam Tariq
Hi David, Thank you for the update. On Thu, Oct 29, 2020 at 6:16 PM David Marchand wrote: > Hello Ibtisam, > > On Thu, Oct 29, 2020 at 1:58 PM Ibtisam Tariq > wrote: > > > > Instead of using getopt_long return value, strcmp was used to > > compare the input parameters with the struct option ar

Re: [dpdk-dev] [PATCH] net/ice: add AVX512BW flag check both in build and runtime

2020-11-02 Thread Ali Alnubani
Hi, > -Original Message- > From: David Marchand > Sent: Tuesday, October 27, 2020 3:17 PM > To: Ferruh Yigit > Cc: Leyi Rong ; Qi Zhang ; > Bruce Richardson ; Wenzhuo Lu > ; Ali Alnubani ; Andrew > Rybchenko ; dev > Subject: Re: [PATCH] net/ice: add AVX512BW flag check both in build and

Re: [dpdk-dev] [PATCH v1 2/2] net/ice: support inner/outer L2/L3 field for FDIR

2020-11-02 Thread Yan, Zhirun
> -Original Message- > From: Cao, Yahui > Sent: Thursday, October 15, 2020 5:29 PM > To: Yan, Zhirun ; Zhang, Qi Z ; > dev@dpdk.org > Cc: Wang, Xiao W ; Su, Simei > ; Guo, Junfeng > Subject: RE: [PATCH v1 2/2] net/ice: support inner/outer L2/L3 field for FDIR > > > > > -Original

Re: [dpdk-dev] [PATCH v5 04/11] build: Arm reformat, comments, move config

2020-11-02 Thread Ruifeng Wang
> -Original Message- > From: Juraj Linkeš > Sent: Wednesday, October 28, 2020 10:04 PM > To: bruce.richard...@intel.com; Ruifeng Wang ; > Honnappa Nagarahalli ; Phil Yang > ; vcchu...@amazon.com; Dharmik Thakkar > ; jerinjac...@gmail.com; > hemant.agra...@nxp.com > Cc: dev@dpdk.org; Juraj

Re: [dpdk-dev] [PATCH 1/8] examples/fips_validation: enhance getopt_long usage

2020-11-02 Thread Ibtisam Tariq
Hi David, Thank you for reviewing the patch. I will submit the v2 of the patchset with new updates. On Fri, Oct 30, 2020 at 3:07 AM David Marchand wrote: > Hello Ibtisam, > > On Thu, Oct 29, 2020 at 1:55 PM Ibtisam Tariq > wrote: > > > > Instead of using getopt_long return value, strcmp was us

[dpdk-dev] [PATCH] examples/l3fwd: enable multiple Tx queues on a lcore

2020-11-02 Thread Leyi Rong
This patch enable multiple Tx queues handling on a lcore. Signed-off-by: Leyi Rong --- examples/l3fwd/l3fwd_common.h| 6 ++--- examples/l3fwd/l3fwd_em.c| 2 +- examples/l3fwd/l3fwd_em_hlm.h| 4 ++-- examples/l3fwd/l3fwd_em_sequential.h | 5 +++-- examples/l3fwd/l3

Re: [dpdk-dev] [PATCH] examples/l3fwd: enable multiple Tx queues on a lcore

2020-11-02 Thread David Marchand
On Mon, Nov 2, 2020 at 9:36 AM Leyi Rong wrote: > > This patch enable multiple Tx queues handling on a lcore. This is the "What". The "Why" should come first, so please explain what makes you think we need this patch. Thanks. -- David Marchand

Re: [dpdk-dev] [PATCH v11 00/23] Add DLB2 PMD

2020-11-02 Thread Jerin Jacob
On Mon, Nov 2, 2020 at 5:07 AM Timothy McDaniel wrote: > > The following patch series adds support for a new eventdev PMD. The DLB2 > PMD adds support for the Intel Dynamic Load Balancer 2.0 (DLB2) > hardware. > The DLB2 is a PCIe device that provides load-balanced, prioritized > scheduling of cor

[dpdk-dev] [PATCH v8 0/2] fix default max mtu size when device configured

2020-11-02 Thread SteveX Yang
Update the max_rx_pkt_len to have MTU as RTE_ETHER_MTU. v8: * update workaround comment; * add deprecation for ethdev; v7: * drop patch 2 due to Jumbo frame flag issue; v6: * change the max_rx_pkt_len in the init_config of testpmd; * change the mtu value in the rte_ethdev; v5: * update comme

[dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-02 Thread SteveX Yang
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped. Fixes: 35b2d13fd6fd ("net: add rte prefix to ether defines") Signed-off-by: SteveX Yang --- app/test-pmd/testpmd.c | 23 +

[dpdk-dev] [PATCH v8 2/2] doc: annouce deprecation of jumbo frame flag condition

2020-11-02 Thread SteveX Yang
Annouce to replace 'RTE_ETHER_MAX_LEN' with 'RTE_ETHER_MTU' as type condition of jumbo frame. Involved scopes: - rte_ethdev; - app, e.g.: test-pmd, test-eventdev; - examples, e.g.: ipsec-secgw, l3fwd, vhost; - net PMDs which support VLAN tag(s) within overhead, e.g.: i40e, ixgbe; Signed-off-by: St

Re: [dpdk-dev] [PATCH v6 00/15] remove mbuf userdata

2020-11-02 Thread Jiawen Wu
On Sunday, November 1, 2020 6:26 PM, David Marchand wrote: > On Sun, Nov 1, 2020 at 10:15 AM Thomas Monjalon > wrote: > > > The new txgbe driver in the next-net is also using ‘udata64’, that > > > also needs to be updated. cc'ed txgbe maintainer. > > > > That's a pity it did not take into account

[dpdk-dev] [PATCH v3] ethdev: fix data type for port id

2020-11-02 Thread wangyunjian
From: Yunjian Wang The ethdev port id is 16 bits now. This patch fixes the data type of the variable for 'pid', which changing from uint32_t to uint16_t. RTE_MAX_ETHPORTS is the maximum number of ports, which customized by the user. To avoid 16-bit unsigned integer overflow, the valid value of R

Re: [dpdk-dev] [PATCH] common/sfc_efx/base: fix prefix in struct member names

2020-11-02 Thread Ivan Malov
Hi Ferruh, Many thanks for your help. It looks like I forgot to add the line Fixes: 0902ed140fcf("common/sfc_efx/base: add MAE action set provisioning APIs") to the commit log of the patch. Currently, the said commit has old suffix used in it: drivers/common/sfc_efx/base/efx_mae.c:927: MAE_

Re: [dpdk-dev] [PATCH v12 01/10] drivers/baseband: add PMD for ACC100

2020-11-02 Thread Ferruh Yigit
On 10/5/2020 11:12 PM, Nicolas Chautru wrote: Add stubs for the ACC100 PMD Signed-off-by: Nicolas Chautru Reviewed-by: Tom Rix Acked-by: Liu Tianjiao --- doc/guides/bbdevs/acc100.rst | 228 + doc/guides/bbdevs/features/acc100.ini | 14

Re: [dpdk-dev] [PATCH v2 8/9] net/mlx5: support shared age action

2020-11-02 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Matan Azrad > Sent: Monday, November 2, 2020 8:17 AM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 8/9] net/mlx5: support shared age action > > Hi Self note > > From: Matan Azrad: > > Add su

Re: [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue callback functions

2020-11-02 Thread Gujjar, Abhinandan S
Hi Akhil, What is the status of this patch? Is it pulled into RC2? Regards Abhinandan > -Original Message- > From: Gujjar, Abhinandan S > Sent: Saturday, October 31, 2020 12:06 AM > To: 'Akhil Goyal' ; dev@dpdk.org; Doherty, Declan > ; honnappa.nagaraha...@arm.com; Ananyev, > Konstantin

Re: [dpdk-dev] [PATCH 1/2] ethdev: introduce transfer attribute to shared action conf

2020-11-02 Thread Ori Kam
Hi Ivan, PSB small comment about the comment, And feel free to add my ack. Best, Ori > -Original Message- > From: Ori Kam > Sent: Sunday, November 1, 2020 11:35 AM > Subject: RE: [dpdk-dev] [PATCH 1/2] ethdev: introduce transfer attribute to > shared action conf > > Hi Ivan > > > -

Re: [dpdk-dev] [PATCH v2 10/14] net/octeontx2: switch timestamp to dynamic mbuf field

2020-11-02 Thread Thomas Monjalon
01/11/2020 19:28, Jerin Jacob: > On Sun, Nov 1, 2020 at 11:40 PM Thomas Monjalon wrote: > > > > The mbuf timestamp is moved to a dynamic field > > in order to allow removal of the deprecated static field. > > The related mbuf flag is also replaced. > > > > Signed-off-by: Thomas Monjalon > > --- [

Re: [dpdk-dev] [PATCH v15 00/23] Add DLB PMD

2020-11-02 Thread David Marchand
On Sun, Nov 1, 2020 at 10:26 PM McDaniel, Timothy wrote: > > + I did not look too much at the PCI code in this file, but I suspect > > we could factor some of it with librte_pci. > > > > Can we look at possibly doing that post rc2 merge? Please try to look at dpdk existing API before adding code.

Re: [dpdk-dev] [PATCH 1/4] test/lpm: fix cycle calculation in rcu qsbr perf

2020-11-02 Thread David Marchand
On Thu, Oct 29, 2020 at 4:37 PM Dharmik Thakkar wrote: > > Fix incorrect calculations for LPM adds, LPM deletes, > and average cycles in RCU QSBR perf tests > > Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") > Cc: honnappa.nagaraha...@arm.com > Cc: sta...@dpdk.org > > Signed-off-by: D

Re: [dpdk-dev] [PATCH V3 1/2] net/netvsc: allow setting rx and tx copy break

2020-11-02 Thread Ferruh Yigit
On 10/31/2020 12:24 AM, Long Li wrote: From: Stephen Hemminger The values for Rx and Tx copy break should be tunable rather than hard coded constants. The rx_copybreak sets the threshold where the driver uses an external mbuf to avoid having to copy data. Setting 0 for copybreak will cause dri

Re: [dpdk-dev] [PATCH v16 18/23] event/dlb: add dequeue and its burst variants

2020-11-02 Thread Burakov, Anatoly
On 01-Nov-20 11:30 PM, Timothy McDaniel wrote: Add support for dequeue, dequeue_burst, ... DLB does not currently support interrupts, but instead uses umonitor/umwait if supported by the processor. This allows the software to monitor and wait on writes to a cache-line. DLB supports normal and s

Re: [dpdk-dev] [PATCH v2] l3fwd-power: make interrupt wakeup log thread safe

2020-11-02 Thread Xie, WeiX
Tested-by: Zhang, XiX The tag is correct and I send the email on behalf of him, his mailbox can't receive dev patch. Thx. Regards, Xie Wei > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt > Sent: Wednesday, October 7, 2020 11:06 PM > To: Burakov

Re: [dpdk-dev] performance degradation with fpic

2020-11-02 Thread Ali Alnubani
Hi Bruce, I was able to pin this down on drivers/net/mlx5/mlx5_rxtx.c. Removing -fPIC from its ninja recipe in build.ninja resolves the issue (had to prevent creating shared libs in this case). What do you suggest I do? Can we have per-pmd customized compilation flags? Regards, Ali > -Orig

Re: [dpdk-dev] [PATCH] common/sfc_efx/base: fix prefix in struct member names

2020-11-02 Thread Ferruh Yigit
On 11/2/2020 9:22 AM, Ivan Malov wrote: Hi Ferruh, Many thanks for your help. It looks like I forgot to add the line Fixes: 0902ed140fcf("common/sfc_efx/base: add MAE action set provisioning APIs") to the commit log of the patch. Currently, the said commit has old suffix used in it: drivers/c

[dpdk-dev] mbuf->packet_type

2020-11-02 Thread Levend Sayar
Hi all. Recently I encountered a dont-know-why issue about mbuf->packet_type. Two different setups behave differently. One is a bare metal server, one KVM based OpenStack VM (virtio). Both use the uio driver. Namely only hardware is different. Software stack is the same. But this macro does not

Re: [dpdk-dev] [PATCH v2] l3fwd-power: make interrupt wakeup log thread safe

2020-11-02 Thread David Marchand
On Fri, Oct 2, 2020 at 2:07 PM Anatoly Burakov wrote: > > Currently, the interrupt status notification prevents log spam by > remembering whether previous interrupt wakeup was due to traffic or due > to timeout expiring. However, it is a single variable that can > potentially be accessed from mult

Re: [dpdk-dev] [RFC 3/3] sft: introduce API

2020-11-02 Thread Andrey Vesnovaty
Hi Andrew, Ray and everybody reviewing SFT RFC patch series. Anything you comments to this patchset coupled with other open issues made me & Ori rethink the suggested API. Ori is about to publish V2 for SFT RFC very soon addressing al the mentioned above. Thanks, Andrey > -Original Messag

Re: [dpdk-dev] [PATCH] mlx5: add ConnectX-7 and Bluefield-3 device IDs

2020-11-02 Thread Ferruh Yigit
On 11/1/2020 9:08 AM, Raslan Darawsheh wrote: Hi Ferruh, -Original Message- From: Ferruh Yigit Sent: Thursday, October 29, 2020 5:26 PM To: Raslan Darawsheh ; dev@dpdk.org Cc: Matan Azrad ; Slava Ovsiienko ; Shy Shyman Subject: Re: [dpdk-dev] [PATCH] mlx5: add ConnectX-7 and Bluefield

Re: [dpdk-dev] [PATCH v2 10/14] net/octeontx2: switch timestamp to dynamic mbuf field

2020-11-02 Thread Thomas Monjalon
02/11/2020 10:38, Thomas Monjalon: > 01/11/2020 19:28, Jerin Jacob: > > On Sun, Nov 1, 2020 at 11:40 PM Thomas Monjalon wrote: > > > > > > The mbuf timestamp is moved to a dynamic field > > > in order to allow removal of the deprecated static field. > > > The related mbuf flag is also replaced. >

Re: [dpdk-dev] performance degradation with fpic

2020-11-02 Thread Luca Boccassi
On Mon, 2020-11-02 at 10:40 +, Ali Alnubani wrote: > Hi Bruce, > > I was able to pin this down on drivers/net/mlx5/mlx5_rxtx.c. Removing -fPIC > from its ninja recipe in build.ninja resolves the issue (had to prevent > creating shared libs in this case). > What do you suggest I do? Can we ha

Re: [dpdk-dev] [PATCH v4 1/1] vfio: modify spapr iommu support to use static window sizing

2020-11-02 Thread Burakov, Anatoly
On 15-Oct-20 6:23 PM, David Christensen wrote: The SPAPR IOMMU requires that a DMA window size be defined before memory can be mapped for DMA. Current code dynamically modifies the DMA window size in response to every new memory allocation which is potentially dangerous because all existing mappi

Re: [dpdk-dev] [PATCH v6 00/15] remove mbuf userdata

2020-11-02 Thread Ferruh Yigit
On 11/2/2020 9:11 AM, Jiawen Wu wrote: On Sunday, November 1, 2020 6:26 PM, David Marchand wrote: On Sun, Nov 1, 2020 at 10:15 AM Thomas Monjalon wrote: The new txgbe driver in the next-net is also using ‘udata64’, that also needs to be updated. cc'ed txgbe maintainer. That's a pity it did n

[dpdk-dev] [PATCH v11 0/6] Add PMD power mgmt

2020-11-02 Thread Liang Ma
This patchset proposes a simple API for Ethernet drivers to cause the CPU to enter a power-optimized state while waiting for packets to arrive, along with a set of generic intrinsics that facilitate that. This is achieved through cooperation with the NIC driver that will allow us to know address of

Re: [dpdk-dev] [PATCH v2 0/9] net/mlx5: support flow hit steering action

2020-11-02 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Matan Azrad > Sent: Sunday, November 1, 2020 7:58 PM > To: Slava Ovsiienko > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 0/9] net/mlx5: support flow hit steering > action > > A new ASO (Advanced Steering Operation) feature was added

[dpdk-dev] [PATCH v11 3/6] net/ixgbe: implement power management API

2020-11-02 Thread Liang Ma
Implement support for the power management API by implementing a `get_wake_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Anatoly Burakov Signed-off-by: Liang Ma Acked-by: Konstantin Ananyev --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + drivers/net/ixgbe/i

[dpdk-dev] [PATCH v11 1/6] ethdev: add simple power management API

2020-11-02 Thread Liang Ma
Add a simple API to allow getting address of getting notification information from the PMD, as well as release notes information. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- Notes: v11: - Rework the API Doxygen documentation v10: - A

[dpdk-dev] [PATCH v11 5/6] net/ice: implement power management API

2020-11-02 Thread Liang Ma
Implement support for the power management API by implementing a `get_wake_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- drivers/net/ice/ice_ethdev.c | 1 + drivers/net/ice/ice_rxt

[dpdk-dev] [PATCH v11 4/6] net/i40e: implement power management API

2020-11-02 Thread Liang Ma
Implement support for the power management API by implementing a `get_wake_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev Acked-by: Jeff Guo --- drivers/net/i40e/i40e_ethdev.c | 1 + d

[dpdk-dev] [PATCH v11 2/6] power: add PMD power management API and callback

2020-11-02 Thread Liang Ma
Add a simple on/off switch that will enable saving power when no packets are arriving. It is based on counting the number of empty polls and, when the number reaches a certain threshold, entering an architecture-defined optimized power state that will either wait until a TSC timestamp expires, or w

Re: [dpdk-dev] [EXT] [dpdk-dev 1/2] fips_validation: fix missed version line

2020-11-02 Thread Archana Muniganti
> -Original Message- > From: Fan Zhang > Sent: Thursday, October 22, 2020 3:29 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Fan Zhang ; Archana > Muniganti > Subject: [EXT] [dpdk-dev 1/2] fips_validation: fix missed version line > > External Email > >

[dpdk-dev] [PATCH v11 6/6] examples/l3fwd-power: enable PMD power mgmt

2020-11-02 Thread Liang Ma
Add PMD power management feature support to l3fwd-power sample app. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: David Hunt --- Notes: v11: - Update l3fwd-power documentation v8: - Add return status check for queue enable v6: - Fixed typos in docum

Re: [dpdk-dev] [PATCH v12 01/10] drivers/baseband: add PMD for ACC100

2020-11-02 Thread Ferruh Yigit
On 11/2/2020 9:25 AM, Ferruh Yigit wrote: On 10/5/2020 11:12 PM, Nicolas Chautru wrote: Add stubs for the ACC100 PMD Signed-off-by: Nicolas Chautru Reviewed-by: Tom Rix Acked-by: Liu Tianjiao ---   doc/guides/bbdevs/acc100.rst   | 228 +   doc/guides/bb

Re: [dpdk-dev] [EXTERNAL] [RFC] pthread on Windows

2020-11-02 Thread Nick Connolly
Hi Khoa, On 29/10/2020 21:19, Khoa To wrote: -Original Message- From: dev On Behalf Of Nick Connolly Sent: Monday, October 19, 2020 2:59 AM To: dev@dpdk.org Subject: [EXTERNAL] [dpdk-dev] [RFC] pthread on Windows The proposed changes are: 1. An EAL implementation of pthread with a

Re: [dpdk-dev] [PATCH] common/sfc_efx/base: fix prefix in struct member names

2020-11-02 Thread Ferruh Yigit
On 11/2/2020 10:45 AM, Ferruh Yigit wrote: On 11/2/2020 9:22 AM, Ivan Malov wrote: Hi Ferruh, Many thanks for your help. It looks like I forgot to add the line Fixes: 0902ed140fcf("common/sfc_efx/base: add MAE action set provisioning APIs") to the commit log of the patch. Currently, the said

[dpdk-dev] [PATCH] doc: fix typing error in example/l3_forward_access_ctrl

2020-11-02 Thread Ibtisam Tariq
Add "--" and remove extra spaces in l3fwd-acl commands. Fixes: d0dff9ba4 ("doc: sample application user guide") Cc: bernard.iremon...@intel.com Signed-off-by: Ibtisam Tariq --- doc/guides/sample_app_ug/l3_forward_access_ctrl.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) dif

[dpdk-dev] [PATCH v2 1/2] ethdev: introduce transfer attribute to shared action conf

2020-11-02 Thread Ivan Malov
In a flow rule, attribute "transfer" means operation level at which both traffic is matched and actions are conducted. Add the very same attribute to shared action configuration. If a driver needs to prepare HW resources in two different ways, depending on the operation level, in order to set up a

[dpdk-dev] [PATCH v2 2/2] app/testpmd: support shared flow action attribute transfer

2020-11-02 Thread Ivan Malov
This attribute helps PMDs to tell actions supposed to work on the so-called hardware e-switch level from regular ones. Signed-off-by: Ivan Malov --- app/test-pmd/cmdline_flow.c | 12 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- 2 files changed, 13 insertions(

[dpdk-dev] [PATCH] compress/isal: check allocation in qp setup

2020-11-02 Thread wangyunjian
From: Yunjian Wang The function rte_zmalloc() could return NULL, the return value need to be checked. Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality") Fixes: 7bf4f0630af6 ("compress/isal: add ISA-L decomp functionality") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang

[dpdk-dev] [PATCH] example/vhost_crypto: add new line character in usage

2020-11-02 Thread Ibtisam Tariq
Add new line character(\n) in the usage of vhost_crypto example for better readability Fixes: 709521f4c2c ("examples/vhost_crypto: support multi-core") Cc: roy.fan.zh...@intel.com Signed-off-by: Ibtisam Tariq --- examples/vhost_crypto/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[dpdk-dev] [PATCH v3 2/2] app/testpmd: support shared flow action attribute transfer

2020-11-02 Thread Ivan Malov
This attribute helps PMDs to tell actions supposed to work on the so-called hardware e-switch level from regular ones. Signed-off-by: Ivan Malov --- app/test-pmd/cmdline_flow.c | 12 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- 2 files changed, 13 insertions(

[dpdk-dev] [PATCH] example/qos_sched: fix option -i in usage

2020-11-02 Thread Ibtisam Tariq
The short option written for interactive mode is --i in usage of this qos_sched example. Actually, it is -i. Fixes: cfd5c971e5e ("examples/qos_sched: add stats") Signed-off-by: Ibtisam Tariq --- examples/qos_sched/args.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exampl

[dpdk-dev] [PATCH v3 1/2] ethdev: introduce transfer attribute to shared action conf

2020-11-02 Thread Ivan Malov
In a flow rule, attribute "transfer" means operation level at which both traffic is matched and actions are conducted. Add the very same attribute to shared action configuration. If a driver needs to prepare HW resources in two different ways, depending on the operation level, in order to set up a

Re: [dpdk-dev] [PATCH] net/ice: delete unsupport ptypes in default hash set

2020-11-02 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Junfeng > Sent: Monday, November 2, 2020 9:55 AM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Guo, Junfeng > Subject: [PATCH] net/ice: delete unsupport ptypes in default hash set > > Ptypes for GTPU with inner SCTP are not su

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-02 Thread Ferruh Yigit
On 11/2/2020 8:52 AM, SteveX Yang wrote: When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped. Fixes: 35b2d13fd6fd ("net: add rte prefix to ether defines") Signed-off-by: SteveX Yang Revie

[dpdk-dev] [PATCH v3] net/iavf: fix invalid RSS type

2020-11-02 Thread Simei Su
When a RSS rule with symmetric hash function, the RSS type shouldn't carry with SRC/DST_ONLY. This patch adds invalid RSS type check for the case. Fixes: 91f27b2e39ab ("net/iavf: refactor RSS") Signed-off-by: Simei Su v3: * correct invalid case. v2: * move invalid check into "iavf_any_invalid_

Re: [dpdk-dev] [PATCH v8 2/2] doc: annouce deprecation of jumbo frame flag condition

2020-11-02 Thread Ferruh Yigit
On 11/2/2020 8:52 AM, SteveX Yang wrote: Annouce to replace 'RTE_ETHER_MAX_LEN' with 'RTE_ETHER_MTU' as type condition of jumbo frame. Involved scopes: - rte_ethdev; - app, e.g.: test-pmd, test-eventdev; - examples, e.g.: ipsec-secgw, l3fwd, vhost; - net PMDs which support VLAN tag(s) within over

Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2020-11-02 Thread 谢华伟(此时此刻)
Hi Ferruh: Comments to this v5 version? On 2020/10/22 23:51, 谢华伟(此时此刻) wrote: From: "huawei.xhw" Legacy virtio-pci only supports PIO BAR resource. As we need to create lots of virtio devices and PIO resource on x86 is very limited, we expose MMIO BAR. Kernel supports both PIO and MMIO BAR f

Re: [dpdk-dev] [PATCH v6 00/15] remove mbuf userdata

2020-11-02 Thread Ferruh Yigit
On 11/2/2020 11:08 AM, Ferruh Yigit wrote: On 11/2/2020 9:11 AM, Jiawen Wu wrote: On Sunday, November 1, 2020 6:26 PM, David Marchand wrote: On Sun, Nov 1, 2020 at 10:15 AM Thomas Monjalon wrote: The new txgbe driver in the next-net is also using ‘udata64’, that also needs to be updated. cc'e

Re: [dpdk-dev] [PATCH] common/sfc_efx/base: fix prefix in struct member names

2020-11-02 Thread Ivan Malov
On 02/11/2020 14:18, Ferruh Yigit wrote: On 11/2/2020 10:45 AM, Ferruh Yigit wrote: On 11/2/2020 9:22 AM, Ivan Malov wrote: Hi Ferruh, Many thanks for your help. It looks like I forgot to add the line Fixes: 0902ed140fcf("common/sfc_efx/base: add MAE action set provisioning APIs") to the co

[dpdk-dev] [PATCH v4] net/iavf: fix invalid RSS type

2020-11-02 Thread Simei Su
When a RSS rule with symmetric hash function, the RSS type shouldn't carry with SRC/DST_ONLY. This patch adds invalid RSS type check for the case. Fixes: 91f27b2e39ab ("net/iavf: refactor RSS") Signed-off-by: Simei Su v4: * Simplify code to be more readable. v3: * Correct invalid case. v2: *

Re: [dpdk-dev] [PATCH v2] build: add pkg-config validation

2020-11-02 Thread Bruce Richardson
On Mon, Nov 02, 2020 at 08:45:48AM +0200, Gregory Etelson wrote: > DPDK relies on pkg-config(1) to provide correct parameters for > compiler and linker used in application build. > Inaccurate build parameters, produced by pkg-config from DPDK .pc > files could fail application build or cause unpred

Re: [dpdk-dev] [PATCH v4] net/iavf: fix invalid RSS type

2020-11-02 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Monday, November 2, 2020 7:56 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Guo, Junfeng ; Guo, Jia > ; Su, Simei > Subject: [PATCH v4] net/iavf: fix invalid RSS type > > When a RSS rule with symmetric hash function, the RSS type shouldn't ca

Re: [dpdk-dev] [PATCH v2 0/2] raw/ifpga: fix coverity defects

2020-11-02 Thread Zhang, Qi Z
> -Original Message- > From: Huang, Wei > Sent: Friday, October 30, 2020 8:22 AM > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: Huang, Wei > Subject: [PATCH v2 0/2] raw/ifpga: fix coverity defects > > These two patches fix defects found by coverity scan. > > Main changes from v

Re: [dpdk-dev] [PATCH v11 1/6] ethdev: add simple power management API

2020-11-02 Thread Burakov, Anatoly
On 02-Nov-20 11:10 AM, Liang Ma wrote: Add a simple API to allow getting address of getting notification information from the PMD, as well as release notes information. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov Acked-by: Konstantin Ananyev --- Notes: v11: - Rework the

[dpdk-dev] [PATCH] eal: fix incorrect API doc for power intrinsics

2020-11-02 Thread Anatoly Burakov
Currently, the intrinsics documentation refers to `rte_cpu_get_features` as a check for whether these intrinsics are supported at runtime. This is incorrect, because actually the user should use the `rte_cpu_get_intrinsics_support` API to do said check. Fix the typo. Fixes: 128021421256 ("eal: add

Re: [dpdk-dev] [PATCH] net/mlx4: fix glue library name

2020-11-02 Thread Ferruh Yigit
On 10/26/2020 9:20 AM, Ali Alnubani wrote: The MLX4 library wasn't being successfully initialized with -Dibverbs_link=dlopen because it expected a shared object file with a different name. The mlx4 glue library name seems changed in the patch pointed by Fixes line, but mlx5 library name is st

Re: [dpdk-dev] [PATCH] net/mlx4: fix glue library name

2020-11-02 Thread Ferruh Yigit
On 11/2/2020 1:01 PM, Ferruh Yigit wrote: On 10/26/2020 9:20 AM, Ali Alnubani wrote: The MLX4 library wasn't being successfully initialized with -Dibverbs_link=dlopen because it expected a shared object file with a different name. The mlx4 glue library name seems changed in the patch pointed

Re: [dpdk-dev] [PATCH] net/mlx4: fix glue library name

2020-11-02 Thread Ali Alnubani
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Monday, November 2, 2020 3:01 PM > To: Ali Alnubani ; Slava Ovsiienko > > Cc: bruce.richard...@intel.com; dev@dpdk.org; Matan Azrad > ; Shahaf Shuler > Subject: Re: [dpdk-dev] [PATCH] net/mlx4: fix glue library name > > On 10

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce transfer attribute to shared action conf

2020-11-02 Thread Andrew Rybchenko
On 11/2/20 2:43 PM, Ivan Malov wrote: In a flow rule, attribute "transfer" means operation level at which both traffic is matched and actions are conducted. Add the very same attribute to shared action configuration. If a driver needs to prepare HW resources in two different ways, depending on t

Re: [dpdk-dev] [PATCH v8 2/2] doc: annouce deprecation of jumbo frame flag condition

2020-11-02 Thread Andrew Rybchenko
On 11/2/20 11:52 AM, SteveX Yang wrote: Annouce to replace 'RTE_ETHER_MAX_LEN' with 'RTE_ETHER_MTU' as type condition of jumbo frame. Involved scopes: - rte_ethdev; - app, e.g.: test-pmd, test-eventdev; - examples, e.g.: ipsec-secgw, l3fwd, vhost; - net PMDs which support VLAN tag(s) within overh

[dpdk-dev] [PATCH v6 01/11] build: alias default build as generic

2020-11-02 Thread Juraj Linkeš
The current machine='default' build name is not descriptive. The actual default build is machine='native'. Add an alternative string which does the same build and better describes what we're building: machine='generic'. Leave machine='default' for backwards compatibility. Signed-off-by: Juraj Link

[dpdk-dev] [PATCH v6 02/11] build: rename Arm build variables

2020-11-02 Thread Juraj Linkeš
Rename Arm build variables and values so that they better conform to Arm specifications. Also rename generically sounding variable to names that better capture what the variables hold. Rename machine_args_generic to part_number_config_arm since the variable contains more than just the generic mach

[dpdk-dev] [PATCH v6 00/11] Arm build options rework

2020-11-02 Thread Juraj Linkeš
The current way of specifying Arm configuration options is insufficient since we can't identify the SoC we're building for from the MIDR information. For example, we can't distinguish between N1SDP, Graviton2 or Ampere Altra. Add a way to specify the cpu count and numa node count for cross builds.

[dpdk-dev] [PATCH v6 03/11] build: remove unused or superfluous variables

2020-11-02 Thread Juraj Linkeš
Remove variables that were either not used, referenced just once or not needed. Signed-off-by: Juraj Linkeš Reviewed-by: Ruifeng Wang --- config/arm/meson.build | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/config/arm/meson.build b/config/arm/meson.bu

[dpdk-dev] [PATCH v6 04/11] build: reformat and move Arm config and comments

2020-11-02 Thread Juraj Linkeš
Change formatting so that it's more consistent and readable, add/modify comments/stdout messages, move configuration options to more appropriate places and make the order consistent according to these rules: 1. First list generic configuration options, then list options that may be overwritten.

[dpdk-dev] [PATCH v6 05/11] build: simplify how Arm flags are processed

2020-11-02 Thread Juraj Linkeš
Set flags in one loop. Append flags to a list and use the list in the loop. Signed-off-by: Juraj Linkeš --- config/arm/meson.build | 37 + 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/config/arm/meson.build b/config/arm/meson.build index 91e

[dpdk-dev] [PATCH v6 06/11] build: use dict in Arm part number config

2020-11-02 Thread Juraj Linkeš
Use dictionary lookup instead of iterating over all elements in the list. Fallback to generic part number if the discovered part number is unknown. Signed-off-by: Juraj Linkeš --- config/arm/meson.build | 85 -- 1 file changed, 48 insertions(+), 37 deletio

[dpdk-dev] [PATCH v6 07/11] build: streamline Arm build setup and machine args

2020-11-02 Thread Juraj Linkeš
Modify the Arm build system so it satisfies the following: * Use predefined configuration values and predefined machine args the generic portable build. * Use configuration values based on MIDR and native machine args for native builds. * Use configuration values and machine args based on MIDR

[dpdk-dev] [PATCH v6 09/11] build: add core and NUMA counts to cross files

2020-11-02 Thread Juraj Linkeš
Add support for setting core count and numa nodes in cross files. The values specified in cross files will override the default values. Also add missing default values to Arm config. Signed-off-by: Juraj Linkeš --- config/arm/arm64_armada_linux_gcc| 2 ++ config/arm/arm64_armv8_linux_gcc

[dpdk-dev] [PATCH v6 08/11] build: optional NUMA and cpu counts detection

2020-11-02 Thread Juraj Linkeš
Add an option to automatically discover the host's numa and cpu counts and use those values for a non cross-build. Give users the option to override the per-arch default values or values from cross files by specifying them on the command line with -Dmax_lcores and -Dmax_numa_nodes. Signed-off-by:

[dpdk-dev] [PATCH v6 11/11] build: disable libnuma in cross builds

2020-11-02 Thread Juraj Linkeš
Some Arm SoCs are not NUMA systems. Add the capability to disable NUMA for cross build and disabled NUMA in Arm cross files. Signed-off-by: Juraj Linkeš --- config/arm/arm64_armada_linux_gcc| 1 + config/arm/arm64_armv8_linux_gcc | 1 + config/arm/arm64_bluefield_linux_gcc | 1 + config/

[dpdk-dev] [PATCH v6 10/11] build: disable Arm drivers

2020-11-02 Thread Juraj Linkeš
A few options that disabled drivers in the old makefiles were improperly ported to the meson build system. Fix this by adding a to the list of disabled drivers, similarly how the command line option works. Remove unneeded driver options ported from the old makefile system. Add support for removing

Re: [dpdk-dev] [RFC PATCH v3 3/6] build: automatic NUMA and cpu counts detection

2020-11-02 Thread Bruce Richardson
On Thu, Oct 29, 2020 at 04:31:33AM +, Honnappa Nagarahalli wrote: > > > > > > > > > > On Wed, Oct 21, 2020 at 01:37:38PM +0200, Juraj Linkeš wrote: > > > > > The build machine's number of cpus and numa nodes vary, resulting > > > > > in mismatched counts of RTE_MAX_LCORE and > > RTE_MAX_NUMA_

Re: [dpdk-dev] [PATCH v8 2/2] doc: annouce deprecation of jumbo frame flag condition

2020-11-02 Thread Ferruh Yigit
On 11/2/2020 1:18 PM, Andrew Rybchenko wrote: On 11/2/20 11:52 AM, SteveX Yang wrote: Annouce to replace 'RTE_ETHER_MAX_LEN' with 'RTE_ETHER_MTU' as type condition of jumbo frame. Involved scopes: - rte_ethdev; - app, e.g.: test-pmd, test-eventdev; - examples, e.g.: ipsec-secgw, l3fwd, vhost; -

Re: [dpdk-dev] [PATCH] eventdev: check input parameter for dump op

2020-11-02 Thread Jerin Jacob
On Mon, Nov 2, 2020 at 2:22 AM McDaniel, Timothy wrote: > > > > > -Original Message- > > From: David Marchand > > Sent: Sunday, November 1, 2020 2:37 PM > > To: dev@dpdk.org > > Cc: McDaniel, Timothy ; Jerin Jacob > > > > Subject: [PATCH] eventdev: check input parameter for dump op > > >

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: support shared flow action attribute transfer

2020-11-02 Thread Ori Kam
> -Original Message- > From: Ivan Malov > Sent: Monday, November 2, 2020 1:43 PM > To: dev@dpdk.org > Cc: Xueming(Steven) Li ; Ori Kam ; > Wenzhuo Lu ; Beilei Xing ; > Bernard Iremonger > Subject: [PATCH v3 2/2] app/testpmd: support shared flow action attribute > transfer > > This att

Re: [dpdk-dev] [PATCH v16 00/23] Add DLB PMD

2020-11-02 Thread Jerin Jacob
On Mon, Nov 2, 2020 at 4:58 AM Timothy McDaniel wrote: > > The following patch series adds support for a new eventdev PMD. The DLB > PMD adds support for the Intel Dynamic Load Balancer (DLB) hardware. > The DLB is a PCIe device that provides load-balanced, prioritized > scheduling of core-to-core

[dpdk-dev] [pull-request] next-eventdev 20.11 RC2

2020-11-02 Thread Jerin Jacob Kollanukkaran
The following changes since commit 79d69c6dcf0debea38ac258d230e2f8c93e5ad12: mbuf: remove seqn field (2020-10-31 22:14:44 +0100) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to e06cd1ddfeac30b4926a52a69336b4f25a9cd209: ev

[dpdk-dev] [PATCH 0/8] misc fixes for hns3

2020-11-02 Thread Lijun Ou
This patch series includes three Tx checksum bugs and two static check warnings fixes. The remaining includes two features fixes. Chengchang Tang (4): net/hns3: add limit promisc mode to VF net/hns3: fix Tx cksum outer header prepare net/hns3: fix Tx checksum with fix header length net/hn

[dpdk-dev] [PATCH 2/8] net/hns3: fix Tx cksum outer header prepare

2020-11-02 Thread Lijun Ou
From: Chengchang Tang Currently, there are two mistakes in Tx checksum outer header prepare. 1) Check whether the packet outer header is IPV4 based on PKT_TX_IPV4 which is incorrect. 2) For HIP08, the outer UDP cksum could not be offloaded. And driver should ensure the outer udp cksum filed

[dpdk-dev] [PATCH 1/8] net/hns3: add limit promisc mode to VF

2020-11-02 Thread Lijun Ou
From: Chengchang Tang For kunpeng920, both tx and rx promisc is set when the promisc mode is open. In the word, all the ingress packets and the packets sent from the PF and other VFs on the same physical port will be copied to the function which set promisc mode on. Kunpeng930 support to turn of

[dpdk-dev] [PATCH 3/8] net/hns3: fix Tx checksum with fix header length

2020-11-02 Thread Lijun Ou
From: Chengchang Tang Currently, the header length of all the layers are fixed, It would lead to a csum error when the header length changed. This patch fixes above problem by using the header length in mbuf instead of the fixed header length to perform the TX cksum offload. Fixes: bba636698316

[dpdk-dev] [PATCH 8/8] net/hns3: adjust some header files location

2020-11-02 Thread Lijun Ou
Some header files have included by others. Also, some header files have a header file self-contained error will trigger building warning. As a result, it is unnecessary and move it into the correct location. Beside, here also remove some unused lines. Signed-off-by: Lijun Ou --- drivers/net/hns

[dpdk-dev] [PATCH 4/8] net/hns3: add VXLAN-GPE packets TSO and checksum support

2020-11-02 Thread Lijun Ou
From: Chengchang Tang Kupeng920 support tso and checksum offload for VXLAN_GPE with the next protocol id 3(i.e., Ethernet). Kupeng930 support TSO and checksum offload for VXLAN_GPE with the next protocol id 1,2,3(i.e., IPv4, IPv6 and Ethernet). This patch add support for this tunnel type. Sign

[dpdk-dev] [PATCH 6/8] net/hns3: fix visit unsupported QL register error

2020-11-02 Thread Lijun Ou
From: Hongbo Zheng If hardware does not support QL(quantity limiter), the int_ql_max is 0, software should confirm ql_value is less than int_ql_max before write QL register. This patch add check of int_ql_max value from firmware and delete the unused variable coalesce_mode. Fixes: 27911a6e62e5 (

[dpdk-dev] [PATCH 5/8] net/hns3: fix configurations of port-level scheduling rate

2020-11-02 Thread Lijun Ou
From: Huisong Li Scheduling rate of port-level in hns3 PF driver configured to hardware is obtained from firmware, which determines the bandwidth capability of the port. The rate in firmware is generally configured with the maximum value for network engine supporting multiple rates, such as 10G a

[dpdk-dev] [PATCH 7/8] net/hns3: fix some static check errors by coverity

2020-11-02 Thread Lijun Ou
From: Hongbo Zheng This patch fixes some warnings. coverity:function format symbol does not match coverity:not_unsigned: Violation: Operand "hw->hw_tc_map & (1UL << i)", Right Expression: "1UL << i" is not an unsigned type Coverity issue: 91708127 Coverity issue: 89776953 Fixes: 62e3ccc2b94c (

Re: [dpdk-dev] [PATCH v6 08/11] build: optional NUMA and cpu counts detection

2020-11-02 Thread Bruce Richardson
On Mon, Nov 02, 2020 at 02:21:15PM +0100, Juraj Linkeš wrote: > Add an option to automatically discover the host's numa and cpu counts > and use those values for a non cross-build. > Give users the option to override the per-arch default values or values > from cross files by specifying them on the

  1   2   3   >