02/11/2020 10:38, Thomas Monjalon: > 01/11/2020 19:28, Jerin Jacob: > > On Sun, Nov 1, 2020 at 11:40 PM Thomas Monjalon <tho...@monjalon.net> wrote: > > > > > > The mbuf timestamp is moved to a dynamic field > > > in order to allow removal of the deprecated static field. > > > The related mbuf flag is also replaced. > > > > > > Signed-off-by: Thomas Monjalon <tho...@monjalon.net> > > > --- > [...] > > > +uint64_t rte_pmd_octeontx2_timestamp_rx_dynflag; > > > +int rte_pmd_octeontx2_timestamp_dynfield_offset = -1; > > > > Instead of the global variable, please move the offset to struct > > otx2_timesync_info(which is used in fastpath) and accessible in slow > > path. > > This structure is initialized in otx2_nix_dev_start(). > otx2_rx_timestamp_setup() is called earlier in otx2_nix_configure(). > One of the two has to change. Which one?
I see that the timestamp config can be changed in otx2_nix_dev_start() so it looks I have no other choice than moving timestamp setup at "start" stage anyway. Will be done in v3, that I will send later today.
