On Sun, Nov 1, 2020 at 10:26 PM McDaniel, Timothy <timothy.mcdan...@intel.com> wrote: > > + I did not look too much at the PCI code in this file, but I suspect > > we could factor some of it with librte_pci. > > > > Can we look at possibly doing that post rc2 merge?
Please try to look at dpdk existing API before adding code. Ok for a followup cleanup. > > > > > > - fix missing "~" in dlb documentation > > > - delay introduction of _delayed token pop functions to > > > token pop commit (fixes 8 or so unused function errors) > > > - all patches build incrementally (gcc), and checkpatches reports > > > success > > > > There is a valid warning on patch 6: > > http://mails.dpdk.org/archives/test-report/2020-November/164347.html > > > > WARNING:REPEATED_WORD: Possible repeated word: 'of' > > #1493: FILE: drivers/event/dlb/pf/base/dlb_osdep_bitmap.h:364: > > + * Returns the bitmap's longest contiguous range of of set bits upon > > success, > > > > I will address with the next patch-set. Odd that I did not see the > error/warning when I > ran devtools/checkpatches.sh You need a fairly recent checkpatch.pl. -- David Marchand
