Re: [dpdk-dev] [PATCH v2] net/ice: cleanup RSS/FDIR profile when device init

2019-10-18 Thread Ye Xiaolong
On 10/18, Ying Wang wrote: >When app restart, RSS/FDIR profile ID will increase which may >run out of all the profile resources. > >The patch cleanup RSS/FDIR profile resources when device init >to fix this issue. > >Fixes: d7d150b93070 ("net/ice: enable RSS when device init") >Cc: sta...@dpdk.org

Re: [dpdk-dev] [PATCH v2 2/3] config: add arm neoverse N1 SDP configuration

2019-10-18 Thread Jerin Jacob
On Fri, Oct 18, 2019 at 10:42 AM Honnappa Nagarahalli wrote: > > > > > > > On Thu, 2019-08-01 at 07:48 +0800, Gavin Hu wrote: > > > Arm N1 SDP is an infrastructure segment development platform based on > > > armv8.2-a Neoverse N1 CPU. For more information, refer to: > > > https://community.arm.co

Re: [dpdk-dev] [PATCH v12 0/7] ethdev: add new Rx offload flags

2019-10-18 Thread Andrew Rybchenko
Hi Ferruh, since I've reviewed I'll reply as I understand it. On 10/17/19 8:43 PM, Ferruh Yigit wrote: On 10/17/2019 1:02 PM, pbhagavat...@marvell.com wrote: From: Pavan Nikhilesh Add new Rx offload flags `DEV_RX_OFFLOAD_RSS_HASH` and `DEV_RX_OFFLOAD_FLOW_MARK`. These flags can be used t

Re: [dpdk-dev] [PATCH v5] ethdev: add HIGIG2 key field to flow API

2019-10-18 Thread Andrew Rybchenko
On 10/18/19 7:13 AM, kirankum...@marvell.com wrote: From: Kiran Kumar K Add new rte_flow_item_higig2_hdr in order to match higig2 header. It is a layer 2.5 protocol and used in Broadcom switches. Header format is based on the following document. http://read.pudn.com/downloads558/doc/comm/230146

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-18 Thread Olivier Matz
Hi Haiyue, On Fri, Oct 18, 2019 at 02:47:50AM +, Wang, Haiyue wrote: > Hi Olivier > > > -Original Message- > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > Sent: Thursday, October 17, 2019 22:42 > > To: dev@dpdk.org > > Cc: Andrew Rybchenko ; Richardson, Bruce > > ; Wang, >

[dpdk-dev] [PATCH] test/crypto: fix compilation issue without security

2019-10-18 Thread Hemant Agrawal
This patch fixes the compilation issue in test_cryptodev.c when RTE_LIBRTE_SECURITY is disabled. Fixes: d883e6e7131b ("test/crypto: add PDCP C-Plane encap cases") Signed-off-by: Hemant Agrawal --- app/test/test_cryptodev.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH] app/proc-info: fix compilation with no security

2019-10-18 Thread Hemant Agrawal
This patch fixes the compilation issues when RTE_LIBRTE_SECURITY is disabled. Fixes: 8a37f37fc243 ("app/procinfo: add --show-port") Cc: sta...@dpdk.org Cc: vipin.vargh...@intel.com Signed-off-by: Hemant Agrawal --- app/proc-info/main.c | 4 1 file changed, 4 insertions(+) diff --git a/app

[dpdk-dev] [PATCH] crypto/dpaa_sec: enable compilation without security

2019-10-18 Thread Hemant Agrawal
This patch enables the dpaaX_sec compilation when SECURITY is disabled. Signed-off-by: Hemant Agrawal --- drivers/crypto/Makefile | 4 ++-- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 26 +++-- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 11 +++-- dri

[dpdk-dev] [PATCH] tools: add EditorConfig file

2019-10-18 Thread Robin Jarry
EditorConfig is a file format and collection of text editor plugins for maintaining consistent coding styles between different editors and IDEs. Initialize the file following the coding rules in doc/guides/contributing/coding_style.rst, doc/guides/contributing/documentation.rst and doc/guides/cont

Re: [dpdk-dev] [PATCH v4 1/2] lib/ring: apis to support configurable element size

2019-10-18 Thread Jerin Jacob
On Fri, Oct 18, 2019 at 8:48 AM Honnappa Nagarahalli wrote: > > > > > Subject: Re: [PATCH v4 1/2] lib/ring: apis to support configurable element > > size > > > > >>> I tried this. On x86 (Xeon(R) Gold 6132 CPU @ 2.60GHz), the results > > >>> are as > > >> follows. The numbers in brackets are with

Re: [dpdk-dev] [PATCH] test/crypto: fix compilation issue without security

2019-10-18 Thread Thierry Herbelot
On 10/18/19 9:56 AM, Hemant Agrawal wrote: This patch fixes the compilation issue in test_cryptodev.c when RTE_LIBRTE_SECURITY is disabled. Fixes: d883e6e7131b ("test/crypto: add PDCP C-Plane encap cases") Signed-off-by: Hemant Agrawal --- app/test/test_cryptodev.c | 9 - 1 file chan

Re: [dpdk-dev] [PATCH] app/proc-info: fix compilation with no security

2019-10-18 Thread Thierry Herbelot
On 10/18/19 9:56 AM, Hemant Agrawal wrote: This patch fixes the compilation issues when RTE_LIBRTE_SECURITY is disabled. Fixes: 8a37f37fc243 ("app/procinfo: add --show-port") Cc: sta...@dpdk.org Cc: vipin.vargh...@intel.com Signed-off-by: Hemant Agrawal --- app/proc-info/main.c | 4 1

Re: [dpdk-dev] [PATCH] crypto/dpaa_sec: enable compilation without security

2019-10-18 Thread Thierry Herbelot
On 10/18/19 9:56 AM, Hemant Agrawal wrote: This patch enables the dpaaX_sec compilation when SECURITY is disabled. Signed-off-by: Hemant Agrawal --- drivers/crypto/Makefile | 4 ++-- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 26 +++-- drivers/crypto/

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: add flow match on GENEVE item

2019-10-18 Thread Slava Ovsiienko
> -Original Message- > From: Moti Haimovsky > Sent: Wednesday, October 16, 2019 11:36 > To: Slava Ovsiienko ; Raslan Darawsheh > > Cc: dev@dpdk.org > Subject: [PATCH 2/2] net/mlx5: add flow match on GENEVE item > > This commit adds support for matching flows on Geneve headers. > > Signe

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: query HCA for enabled FLEX parser protos

2019-10-18 Thread Slava Ovsiienko
> -Original Message- > From: Moti Haimovsky > Sent: Wednesday, October 16, 2019 11:36 > To: Slava Ovsiienko ; Raslan Darawsheh > > Cc: dev@dpdk.org > Subject: [PATCH 1/2] net/mlx5: query HCA for enabled FLEX parser protos > > This commit add querying the HCA which FLEX protocols are alre

Re: [dpdk-dev] [PATCH 2/2] net/virtio: do not require IO permissions

2019-10-18 Thread Tiwei Bie
On Thu, Oct 17, 2019 at 01:56:28PM +0200, David Marchand wrote: > On x86, iopl permissions are only needed when the virtio devices are > bound to a uio kernel module. > > When running a dpdk application as non root, the virtio driver was > refusing to register because of this check while it could

[dpdk-dev] [pull-request] next-eventdev 19.11 RC1 - Iteration 2

2019-10-18 Thread Jerin Jacob Kollanukkaran
The following changes since commit b36f587f010bba421a8fd0b4c383276ecb796ae3: rcu: fix spurious thread unregister (2019-10-18 06:13:36 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to 6e547f64f32ff2a3831d21931156c571e8d

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-18 Thread Ferruh Yigit
On 10/17/2019 4:33 PM, Ferruh Yigit wrote: > On 10/17/2019 2:43 PM, Bruce Richardson wrote: >> On Thu, Oct 17, 2019 at 12:05:56PM +0100, Ferruh Yigit wrote: >>> On 10/17/2019 11:51 AM, Andrew Rybchenko wrote: On 10/17/19 1:47 PM, Ferruh Yigit wrote: > On 10/17/2019 11:37 AM, Andrew Rybchen

Re: [dpdk-dev] [PATCH 1/4] net/hns3: modify the statistics for sending and receiving messages

2019-10-18 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2019/10/15 16:45, Ferruh Yigit wrote: > On 10/9/2019 3:16 PM, Wei Hu (Xavier) wrote: >> From: Hao Chen >> >> In receiving direction, for FCS error messages, drivers no longer >> record them in rte_eth_stats.ipackets statistics. > If this patch is fixing statistics better to c

Re: [dpdk-dev] [PATCH 0/4] updates for hns3 ethernet pmd driver

2019-10-18 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2019/10/15 16:46, Ferruh Yigit wrote: > On 10/9/2019 3:16 PM, Wei Hu (Xavier) wrote: >> This series adds some updates for hns3 ethernet pmd driver. >> >> The No.1 patch modifies the statistics information for sending >> and receiving packets. >> The No.2 patch changes the retu

[dpdk-dev] [RFC PATCH 0/1] vhost: Add dynamic log tracing

2019-10-18 Thread Adrian Moreno
Hi, Current logging in vhost library has two important limitations: - dapatath and control logs path use the same log level - both paths are compiled out by default This patch (targeting 20.2), changes the logging system in librte_vhost to overcome these limitations. Cc: maxime.coque...@redhat.c

[dpdk-dev] [RFC PATCH 1/1] vhost: Add dynamic logging system

2019-10-18 Thread Adrian Moreno
Currently there are a couple of limitations on the logging system: Most of the logs are compiled out and both datapath and controlpath logs share the same loglevel. This patch tries to help fix that situation by: - Splitting control plane and data plane logs - Making control plane logs dynamic whi

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-18 Thread Wang, Haiyue
Hi Olivier, > -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Friday, October 18, 2019 15:54 > To: Wang, Haiyue > Cc: dev@dpdk.org; Andrew Rybchenko ; Richardson, > Bruce > ; Jerin Jacob Kollanukkaran ; > Wiles, Keith > ; Ananyev, Konstantin ; > Morten B

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-18 Thread Andrew Rybchenko
On 10/18/19 11:18 AM, Ferruh Yigit wrote: On 10/17/2019 4:33 PM, Ferruh Yigit wrote: On 10/17/2019 2:43 PM, Bruce Richardson wrote: On Thu, Oct 17, 2019 at 12:05:56PM +0100, Ferruh Yigit wrote: On 10/17/2019 11:51 AM, Andrew Rybchenko wrote: On 10/17/19 1:47 PM, Ferruh Yigit wrote: On 10/17/

Re: [dpdk-dev] [PATCH 2/2] net/virtio: do not require IO permissions

2019-10-18 Thread David Marchand
On Fri, Oct 18, 2019 at 10:19 AM Tiwei Bie wrote: > > On Thu, Oct 17, 2019 at 01:56:28PM +0200, David Marchand wrote: > > On x86, iopl permissions are only needed when the virtio devices are > > bound to a uio kernel module. > > > > When running a dpdk application as non root, the virtio driver wa

Re: [dpdk-dev] [PATCH v1 1/2] lib/mbuf: add GTP tunnel type flag

2019-10-18 Thread Olivier Matz
Hi, On Fri, Sep 20, 2019 at 08:36:23AM +, Ting Xu wrote: > Add GTP tunnel type flag in mbuf for future use in GTP > checksum offload. > > Signed-off-by: Ting Xu > --- > lib/librte_mbuf/rte_mbuf.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/li

Re: [dpdk-dev] [PATCH] net: add missing endianness annotations

2019-10-18 Thread Olivier Matz
Hi David, 2lOn Fri, Sep 27, 2019 at 01:58:02PM +0200, David Marchand wrote: > OVS currently maintains a copy of those headers with the right endianness > annotations so that sparse checks can pass. > > We introduced rte_beXX_t for better readibility in v17.08. > Let's make use of them, OVS then o

Re: [dpdk-dev] [PATCH] net: add missing endianness annotations

2019-10-18 Thread David Marchand
On Fri, Oct 18, 2019 at 10:43 AM Olivier Matz wrote: > > Hi David, > > 2lOn Fri, Sep 27, 2019 at 01:58:02PM +0200, David Marchand wrote: > > OVS currently maintains a copy of those headers with the right endianness > > annotations so that sparse checks can pass. > > > > We introduced rte_beXX_t fo

Re: [dpdk-dev] [PATCH v1 1/5] lib/eal: implement the family of rte bitoperation APIs

2019-10-18 Thread Joyce Kong (Arm Technology China)
Hi Morten, > -Original Message- > From: Morten Brørup > Sent: Thursday, October 17, 2019 9:32 PM > To: Joyce Kong (Arm Technology China) ; > dev@dpdk.org > Cc: nd ; tho...@monjalon.net; jer...@marvell.com; > ravi1.ku...@amd.com; xuanziya...@huawei.com; > cloud.wangxiao...@huawei.com; zhou

Re: [dpdk-dev] [PATCH v1 0/5] implement common rte bit operation APIs in PMDs

2019-10-18 Thread Joyce Kong (Arm Technology China)
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, October 16, 2019 12:51 AM > To: Joyce Kong (Arm Technology China) > Cc: dev@dpdk.org; nd ; tho...@monjalon.net; > jer...@marvell.com; ravi1.ku...@amd.com; xuanziya...@huawei.com; > cloud.wangxiao...@huawei.com; zhouguoy...@

Re: [dpdk-dev] [PATCH v1 1/5] lib/eal: implement the family of rte bit operation APIs

2019-10-18 Thread Joyce Kong (Arm Technology China)
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, October 16, 2019 12:54 AM > To: Joyce Kong (Arm Technology China) > Cc: dev@dpdk.org; nd ; tho...@monjalon.net; > jer...@marvell.com; ravi1.ku...@amd.com; xuanziya...@huawei.com; > cloud.wangxiao...@huawei.com; zhouguoy...@

Re: [dpdk-dev] [PATCH v1 1/5] lib/eal: implement the family of rte bit operation APIs

2019-10-18 Thread Joyce Kong (Arm Technology China)
> -Original Message- > From: Jerin Jacob > Sent: Wednesday, October 16, 2019 3:54 PM > To: Joyce Kong (Arm Technology China) > Cc: dpdk-dev ; nd ; tho...@monjalon.net; > jer...@marvell.com; ravi1.ku...@amd.com; Ziyang Xuan > ; Xiaoyun Wang > ; Guoyang Zhou > ; Rasesh Mody ; > Shahed Shaik

Re: [dpdk-dev] [PATCH 8/9 v2] bus/dpaa: moving qbman global init to bus

2019-10-18 Thread Akhil Goyal
> > From: Hemant Agrawal > > DPAA SEC shall be able to work independent of DPAA ETH > driver. > This patch moves qbman init to bus, so that any driver > can use them even when no eth resources are present > or none of the eth devices are probed. > > Signed-off-by: Hemant Agrawal > --- Acked

[dpdk-dev] [PATCH v3] app/testpmd: enable GTP header parse and Tx checksum offload

2019-10-18 Thread Ting Xu
This patch enables testpmd to forward GTP packet in csum fwd mode. GTP header structure (without optional fields and extension header) and parser function are added. GTPU and GTPC packets are both supported, with respective UDP destination port and GTP message type. Signed-off-by: Ting Xu --- v3

Re: [dpdk-dev] [PATCH] tools: add EditorConfig file

2019-10-18 Thread Burakov, Anatoly
On 18-Oct-19 8:59 AM, Robin Jarry wrote: EditorConfig is a file format and collection of text editor plugins for maintaining consistent coding styles between different editors and IDEs. Initialize the file following the coding rules in doc/guides/contributing/coding_style.rst, doc/guides/contrib

Re: [dpdk-dev] [PATCH v2] ethdev: extend flow metadata

2019-10-18 Thread Olivier Matz
Hi Viacheslav, Few comments on the dynamic mbuf part below. On Thu, Oct 10, 2019 at 04:02:39PM +, Viacheslav Ovsiienko wrote: > Currently, metadata can be set on egress path via mbuf tx_metadata field > with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_META matches metadata. > > This patch ex

Re: [dpdk-dev] [PATCH] net: add missing endianness annotations

2019-10-18 Thread Olivier Matz
On Fri, Oct 18, 2019 at 10:47:37AM +0200, David Marchand wrote: > On Fri, Oct 18, 2019 at 10:43 AM Olivier Matz wrote: > > > > Hi David, > > > > 2lOn Fri, Sep 27, 2019 at 01:58:02PM +0200, David Marchand wrote: > > > OVS currently maintains a copy of those headers with the right endianness > > > a

Re: [dpdk-dev] [PATCH v12 0/7] ethdev: add new Rx offload flags

2019-10-18 Thread Ferruh Yigit
On 10/18/2019 8:32 AM, Andrew Rybchenko wrote: > Hi Ferruh, > > since I've reviewed I'll reply as I understand it. > > On 10/17/19 8:43 PM, Ferruh Yigit wrote: >> On 10/17/2019 1:02 PM, pbhagavat...@marvell.com wrote: >>> From: Pavan Nikhilesh >>> >>> Add new Rx offload flags `DEV_RX_OFFLOAD_R

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-18 Thread Olivier Matz
On Fri, Oct 18, 2019 at 08:28:02AM +, Wang, Haiyue wrote: > Hi Olivier, > > > -Original Message- > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > Sent: Friday, October 18, 2019 15:54 > > To: Wang, Haiyue > > Cc: dev@dpdk.org; Andrew Rybchenko ; Richardson, > > Bruce > > ; J

[dpdk-dev] [PATCH] rcu: fix reference to offline function

2019-10-18 Thread David Marchand
Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mechanism") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- I intend to add this patch to this series. Honnappa, can you review it please ? --- lib/librte_rcu/rte_rcu_qsbr.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-

Re: [dpdk-dev] [PATCH 2/2] net/virtio: do not require IO permissions

2019-10-18 Thread Tiwei Bie
On Fri, Oct 18, 2019 at 10:33:47AM +0200, David Marchand wrote: > On Fri, Oct 18, 2019 at 10:19 AM Tiwei Bie wrote: > > On Thu, Oct 17, 2019 at 01:56:28PM +0200, David Marchand wrote: > > > On x86, iopl permissions are only needed when the virtio devices are > > > bound to a uio kernel module. > >

Re: [dpdk-dev] [PATCH v3 1/9] config: change ABI versioning to global

2019-10-18 Thread Kevin Traynor
On 17/10/2019 15:09, Luca Boccassi wrote: > On Thu, 2019-10-17 at 09:44 +0100, Bruce Richardson wrote: >> On Wed, Oct 16, 2019 at 06:03:36PM +0100, Anatoly Burakov wrote: >>> From: Marcin Baran < >>> marcinx.ba...@intel.com >>> >>> As per new ABI policy, all of the libraries are now versioned

Re: [dpdk-dev] [PATCH v6 6/6] doc/ipsec: update ipsec programmer's guide

2019-10-18 Thread Ananyev, Konstantin
> > Add section about ipsec SAD > Update release notes > > Signed-off-by: Vladimir Medvedkin > --- Acked-by: Konstantin Ananyev > -- > 2.7.4

Re: [dpdk-dev] [RFC] mempool: introduce indexed memory pool

2019-10-18 Thread Xueming(Steven) Li
> -Original Message- > From: Jerin Jacob > Sent: Friday, October 18, 2019 12:41 AM > To: Xueming(Steven) Li > Cc: Olivier Matz ; Andrew Rybchenko > ; dpdk-dev ; Asaf Penso > ; Ori Kam ; Stephen > Hemminger > Subject: Re: [dpdk-dev] [RFC] mempool: introduce indexed memory pool > > On Thu

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-18 Thread Bruce Richardson
On Thu, Oct 17, 2019 at 04:33:59PM +0100, Ferruh Yigit wrote: > On 10/17/2019 2:43 PM, Bruce Richardson wrote: > > On Thu, Oct 17, 2019 at 12:05:56PM +0100, Ferruh Yigit wrote: > >> On 10/17/2019 11:51 AM, Andrew Rybchenko wrote: > >>> On 10/17/19 1:47 PM, Ferruh Yigit wrote: > On 10/17/2019 1

Re: [dpdk-dev] [PATCH v12 0/7] ethdev: add new Rx offload flags

2019-10-18 Thread Andrew Rybchenko
On 10/18/19 12:42 PM, Ferruh Yigit wrote: On 10/18/2019 8:32 AM, Andrew Rybchenko wrote: Hi Ferruh, since I've reviewed I'll reply as I understand it. On 10/17/19 8:43 PM, Ferruh Yigit wrote: On 10/17/2019 1:02 PM, pbhagavat...@marvell.com wrote: From: Pavan Nikhilesh Add new Rx offload

Re: [dpdk-dev] [PATCH] common/octeontx2: upgrade the mbox definition to version 2

2019-10-18 Thread Jerin Jacob
On Mon, Oct 14, 2019 at 3:12 PM Nithin Dabilpuram wrote: > > Sync mail box data structures to version 0x0002. > This patch checks for mismatch in mail box revision and > avoids initializing octeontx2 pci device if > there is a mismatch. > > Signed-off-by: Nithin Dabilpuram > --- > drivers/common

Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on VLAN header

2019-10-18 Thread Hideyuki Yamashita
Dear Slava and experts, Thanks for your answering me. Baased on your answer, I tested using testpmd. And about the outcome, I have several questions. [1.Test environment] OS:Ubuntu18.04 NIC1:MCX4121A-ACAT 25G NIC2:MCX516A-CCAT 100G Repo:dpdk-next-net I checked that the following is shown in git

Re: [dpdk-dev] [PATCH v3] doc: add graphic showing layout of mbuf struct

2019-10-18 Thread Jerin Jacob
On Thu, Oct 17, 2019 at 9:28 PM Olivier Matz wrote: > > Hi, > > On Tue, Aug 27, 2019 at 10:02:30AM +0100, A.McLoughlin wrote: > > This patch adds a graphical overview of the rte_mbuf struct, showing where > > each value is stored within the struct. > > > > Signed-off-by: A.McLoughlin > > --- > >

Re: [dpdk-dev] [PATCH v1 1/1] net/octeontx2: add multicast filter support

2019-10-18 Thread Jerin Jacob
On Tue, Oct 15, 2019 at 4:14 PM wrote: > > From: Vamsi Attunuru > > Patch adds mc filter support for otx2 eth devices. > > Signed-off-by: Vamsi Attunuru Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/master. Thanks > --- > doc/guides/nics/features/octeontx2.ini | 1 + > doc/guid

[dpdk-dev] [PATCH v11 3/3] eal/stack: enable lock-free stack for aarch64

2019-10-18 Thread Phil Yang
Enable both c11 atomic and non c11 atomic lock-free stack for aarch64. Introduced a new header to reduce the ifdef clutter across generic and c11 files. The rte_stack_lf_stubs.h contains stub implementations of __rte_stack_lf_count, __rte_stack_lf_push_elems and __rte_stack_lf_pop_elems. Suggeste

[dpdk-dev] [PATCH v11 1/3] eal/arm64: add 128-bit atomic compare exchange

2019-10-18 Thread Phil Yang
This patch adds the implementation of the 128-bit atomic compare exchange API on AArch64. Using 64-bit 'ldxp/stxp' instructions can perform this operation. Moreover, on the LSE atomic extension accelerated platforms, it implemented by 'casp' instructions for better performance. Since the '__ARM_FE

[dpdk-dev] [PATCH v11 2/3] test/atomic: add 128b compare and swap test

2019-10-18 Thread Phil Yang
Add 128b atomic compare and swap test for aarch64 and x86_64. Extend the test iteration from 10 thousand to 1 million times to test the stability of the atomic APIs. Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli Acked-by: Gage Eads Acked-by: Jerin Jacob Tested-by: Jerin Jacob ---

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-18 Thread Wang, Haiyue
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Friday, October 18, 2019 17:48 > To: Wang, Haiyue > Cc: dev@dpdk.org; Andrew Rybchenko ; Richardson, > Bruce > ; Jerin Jacob Kollanukkaran ; > Wiles, Keith > ; Ananyev, Konstantin ; > Morten Brørup > ; Ste

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-18 Thread Ferruh Yigit
On 10/18/2019 11:13 AM, Bruce Richardson wrote: > On Thu, Oct 17, 2019 at 04:33:59PM +0100, Ferruh Yigit wrote: >> On 10/17/2019 2:43 PM, Bruce Richardson wrote: >>> On Thu, Oct 17, 2019 at 12:05:56PM +0100, Ferruh Yigit wrote: On 10/17/2019 11:51 AM, Andrew Rybchenko wrote: > On 10/17/19

Re: [dpdk-dev] [PATCH v14 0/3] extend RSS offload types

2019-10-18 Thread Ferruh Yigit
On 10/15/2019 4:09 PM, Simei Su wrote: > [PATCH v14 1/3] ethdev: decouple flow types and RSS offload types. > [PATCH v14 2/3] ethdev: add several bits for extending rss offload types. > [PATCH v14 3/3] app/testpmd: add cmdline support for extending rss types. > > v14: > * Adjust the location of th

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-18 Thread Andrew Rybchenko
On 10/18/19 2:38 PM, Ferruh Yigit wrote: On 10/18/2019 11:13 AM, Bruce Richardson wrote: On Thu, Oct 17, 2019 at 04:33:59PM +0100, Ferruh Yigit wrote: On 10/17/2019 2:43 PM, Bruce Richardson wrote: On Thu, Oct 17, 2019 at 12:05:56PM +0100, Ferruh Yigit wrote: On 10/17/2019 11:51 AM, Andrew Ry

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-18 Thread Ferruh Yigit
On 10/18/2019 12:57 PM, Andrew Rybchenko wrote: > On 10/18/19 2:38 PM, Ferruh Yigit wrote: >> On 10/18/2019 11:13 AM, Bruce Richardson wrote: >>> On Thu, Oct 17, 2019 at 04:33:59PM +0100, Ferruh Yigit wrote: On 10/17/2019 2:43 PM, Bruce Richardson wrote: > On Thu, Oct 17, 2019 at 12:05:56P

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-18 Thread Bruce Richardson
On Fri, Oct 18, 2019 at 12:38:53PM +0100, Ferruh Yigit wrote: > On 10/18/2019 11:13 AM, Bruce Richardson wrote: > > On Thu, Oct 17, 2019 at 04:33:59PM +0100, Ferruh Yigit wrote: > >> On 10/17/2019 2:43 PM, Bruce Richardson wrote: > >>> On Thu, Oct 17, 2019 at 12:05:56PM +0100, Ferruh Yigit wrote: >

[dpdk-dev] [PATCH] test/crypto: add unit tests for AES-CTR + AES CMAC

2019-10-18 Thread Adam Dybkowski
This patch adds tests for AES-CTR + AES CMAC using mixed auth-cipher algorithm functions. Tests allow easy extending with new cases, check in-place and out-of-place operations and use linear and sgl buffers as input/output. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c

Re: [dpdk-dev] [PATCH 7/8] bpf/arm64: add atomic-exchange-and-add operation

2019-10-18 Thread David Marchand
On Tue, Sep 3, 2019 at 1:00 PM wrote: > > From: Jerin Jacob > > Implement XADD eBPF instruction using STADD arm64 instruction. > If the given platform does not have atomics support, > use LDXR and STXR pair for critical section instead of STADD. For the record, this patch had a missed dependency

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-18 Thread Akhil Goyal
Hi Konstantin, Added my comments inline with your draft. > > > Hi Akhil, > > > > BTW, to be honest, I don't consider current rte_cryptodev_sym_session > > > construct for multiple device_ids: > > > __extension__ struct { > > > void *data; > > > uint16_t refcnt; >

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-18 Thread Ferruh Yigit
On 10/18/2019 2:12 PM, Bruce Richardson wrote: > On Fri, Oct 18, 2019 at 12:38:53PM +0100, Ferruh Yigit wrote: >> On 10/18/2019 11:13 AM, Bruce Richardson wrote: >>> On Thu, Oct 17, 2019 at 04:33:59PM +0100, Ferruh Yigit wrote: On 10/17/2019 2:43 PM, Bruce Richardson wrote: > On Thu, Oct 1

Re: [dpdk-dev] [PATCH] rcu: fix reference to offline function

2019-10-18 Thread Honnappa Nagarahalli
> Subject: [PATCH] rcu: fix reference to offline function > > Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mechanism") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- > I intend to add this patch to this series. > Honnappa, can you review it please ? > > --- > lib

Re: [dpdk-dev] [PATCH v11 1/3] eal/arm64: add 128-bit atomic compare exchange

2019-10-18 Thread David Marchand
On Fri, Oct 18, 2019 at 1:22 PM Phil Yang wrote: > > This patch adds the implementation of the 128-bit atomic compare > exchange API on AArch64. Using 64-bit 'ldxp/stxp' instructions > can perform this operation. Moreover, on the LSE atomic extension > accelerated platforms, it implemented by 'cas

[dpdk-dev] [PATCH v4] net/af_packet: improve Tx statistics accuracy

2019-10-18 Thread Flavia Musatescu
When sendto call fails and ENOBUFS/EAGAIN error is being set some of the packets are actually successfully transmitted. There is no available count of those packets, so in order to make the statistics more accurate, all the previously enqueued packets will be considered successful, even though this

Re: [dpdk-dev] [PATCH v11 1/3] eal/arm64: add 128-bit atomic compare exchange

2019-10-18 Thread Jerin Jacob
On Fri, Oct 18, 2019 at 7:46 PM David Marchand wrote: > > On Fri, Oct 18, 2019 at 1:22 PM Phil Yang wrote: > > > > This patch adds the implementation of the 128-bit atomic compare > > exchange API on AArch64. Using 64-bit 'ldxp/stxp' instructions > > can perform this operation. Moreover, on the L

Re: [dpdk-dev] [PATCH v11 1/3] eal/arm64: add 128-bit atomic compare exchange

2019-10-18 Thread David Marchand
On Fri, Oct 18, 2019 at 4:25 PM Jerin Jacob wrote: > > On Fri, Oct 18, 2019 at 7:46 PM David Marchand > wrote: > > > > On Fri, Oct 18, 2019 at 1:22 PM Phil Yang wrote: > > > > > > This patch adds the implementation of the 128-bit atomic compare > > > exchange API on AArch64. Using 64-bit 'ldxp/s

Re: [dpdk-dev] [PATCH v11 1/3] eal/arm64: add 128-bit atomic compare exchange

2019-10-18 Thread Jerin Jacob
On Fri, Oct 18, 2019 at 8:04 PM David Marchand wrote: > > On Fri, Oct 18, 2019 at 4:25 PM Jerin Jacob wrote: > > > > On Fri, Oct 18, 2019 at 7:46 PM David Marchand > > wrote: > > > > > > On Fri, Oct 18, 2019 at 1:22 PM Phil Yang wrote: > > > > > > > > This patch adds the implementation of the 1

Re: [dpdk-dev] [PATCH] maintainers: add net-brcm sub-tree

2019-10-18 Thread Ferruh Yigit
On 10/17/2019 10:23 PM, Thomas Monjalon wrote: > 17/10/2019 19:39, Ajit Khaparde: >> On Tue, Oct 15, 2019 at 12:38 AM Ferruh Yigit >> wrote: >> >>> Adding vendor specific sub-tree for Broadcom drivers. >>> The next-net-brcm sub-tree will be sub-tree of the next-net. >>> >>> Signed-off-by: Ferruh Y

Re: [dpdk-dev] [PATCH] test/crypto: add unit tests for AES-CTR + AES CMAC

2019-10-18 Thread Kusztal, ArkadiuszX
Hi Adam, Can you add some information that it is digest encrypted case? This change also needs change in QAT capabilities (currently we support 12-16 bytes digest size), I will send it as a fix as 3gpp specifies MAC-I for CMAC as MSb32, same way as IPSec CMAC-96 (MSb96) which is already working

[dpdk-dev] [PATCH] doc/guides/nics: fix typos

2019-10-18 Thread Thierry Herbelot
'CRC striping' should be spelled 'CRC stripping'. Fixes: 3eee1f067e7c ('fm10k: add guide') Fixes: 7a4d9f6676d7 ('doc: add liquidio') Fixes: f820b5896631 ('doc: add octeontx ethdev driver documentation') Fixes: 920717e4d8ba ('net/octeontx2: add device start operation') Fixes: f994cecafdcf ('doc: ad

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/af_packet: improve Tx statistics accuracy

2019-10-18 Thread Ferruh Yigit
On 10/18/2019 3:24 PM, Flavia Musatescu wrote: > When sendto call fails and ENOBUFS/EAGAIN error is being set > some of the packets are actually successfully transmitted. > There is no available count of those packets, so in order to > make the statistics more accurate, all the previously enqueued

Re: [dpdk-dev] [PATCH] tools: add EditorConfig file

2019-10-18 Thread Stephen Hemminger
On Fri, 18 Oct 2019 09:59:54 +0200 Robin Jarry wrote: Looks good, you should add a reference to https://editorconfig.org so others understand this > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright 2019 6WIND S.A. > + > +root = true > + > +[*] > +end_of_line = lf > +insert_final_newline =

[dpdk-dev] [PATCH] app/testpmd: fix missing loop topology option

2019-10-18 Thread Ciara Power
The testpmd --help option did not show all possible choices for port topology previously. The loop topology option is now added. Fixes: 3e2006d6186c ("app/testpmd: add loopback topology") Cc: cchempara...@tilera.com Cc: sta...@dpdk.org Signed-off-by: Ciara Power --- app/test-pmd/parameters.c |

Re: [dpdk-dev] [PATCH] tools: add EditorConfig file

2019-10-18 Thread Stephen Hemminger
On Fri, 18 Oct 2019 09:59:54 +0200 Robin Jarry wrote: > diff --git a/.editorconfig b/.editorconfig > new file mode 100644 > index ..c5704d89b8c6 > --- /dev/null > +++ b/.editorconfig > @@ -0,0 +1,23 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright 2019 6WIND S.A. > + > +ro

Re: [dpdk-dev] [PATCH] tools: add EditorConfig file

2019-10-18 Thread Robin Jarry
2019-10-18, Stephen Hemminger: > In the example on web site, they use > [*.py] not [**.py] I've tested both forms, they work the same. I don't have a strong opinion on this, I can change to [*.py]. -- Robin

Re: [dpdk-dev] [PATCH] tools: add EditorConfig file

2019-10-18 Thread Robin Jarry
2019-10-18, Stephen Hemminger: > Why not add this (since git doesn't like trailing whitespace). > > trim_trailing_whitespace=true Because EditorConfig applies the setting to the whole file when saving. This has chances of trimming white space on lines that you did not modify. I figure this is not

Re: [dpdk-dev] [PATCH] tools: add EditorConfig file

2019-10-18 Thread Stephen Hemminger
On Fri, 18 Oct 2019 17:56:48 +0200 Robin Jarry wrote: > 2019-10-18, Stephen Hemminger: > > Why not add this (since git doesn't like trailing whitespace). > > > > trim_trailing_whitespace=true > > Because EditorConfig applies the setting to the whole file when saving. > This has chances of tri

Re: [dpdk-dev] [PATCH v4 1/2] lib/ring: apis to support configurable element size

2019-10-18 Thread Jerin Jacob
On Fri, Oct 18, 2019 at 1:34 PM Jerin Jacob wrote: > > On Fri, Oct 18, 2019 at 8:48 AM Honnappa Nagarahalli > wrote: > > > > > > > > > Subject: Re: [PATCH v4 1/2] lib/ring: apis to support configurable element > > > size > > > > > > >>> I tried this. On x86 (Xeon(R) Gold 6132 CPU @ 2.60GHz), the

Re: [dpdk-dev] [PATCH] eal: added new api to only enqueue a packet in tx buffer

2019-10-18 Thread Yigit, Ferruh
On 8/8/2019 1:28 PM, Nilanjan Sarkar wrote: > This api is similar like api `rte_eth_tx_buffer` except it > does not attempt to flush the buffer in case buffer is full. > The advantage is that, this api does not need port id and > queue id. In case port id and queue id are shared within threads > th

Re: [dpdk-dev] [PATCH] doc/guides/nics: fix typos

2019-10-18 Thread Ferruh Yigit
On 10/18/2019 4:06 PM, Thierry Herbelot wrote: > 'CRC striping' should be spelled 'CRC stripping'. > > Fixes: 3eee1f067e7c ('fm10k: add guide') > Fixes: 7a4d9f6676d7 ('doc: add liquidio') > Fixes: f820b5896631 ('doc: add octeontx ethdev driver documentation') > Fixes: 920717e4d8ba ('net/octeontx2:

Re: [dpdk-dev] [RFC] ethdev: add new fields for max LRO session size

2019-10-18 Thread Ferruh Yigit
On 10/2/2019 2:58 PM, Thomas Monjalon wrote: > 24/09/2019 14:03, Matan Azrad: >> From: Ferruh Yigit >>> On 9/15/2019 8:48 AM, Matan Azrad wrote: Hi Ferruh From: Ferruh Yigit > On 8/29/2019 8:47 AM, Matan Azrad wrote: >> It may be needed by the user to limit the LRO session p

Re: [dpdk-dev] [EXT] Re: [PATCH v10 0/5] kni: add IOVA=VA support

2019-10-18 Thread Vamsi Krishna Attunuru
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, October 16, 2019 9:52 PM > To: Vamsi Krishna Attunuru ; Yigit, Ferruh > > Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; > olivier.m...@6wind.com; anatoly.bura...@intel.com; > arybche...@solarflare.com; Kiran Kumar Kokki

Re: [dpdk-dev] [PATCH v4 1/2] lib/ring: apis to support configurable element size

2019-10-18 Thread Ananyev, Konstantin
Hi everyone, > > > >>> I tried this. On x86 (Xeon(R) Gold 6132 CPU @ 2.60GHz), the results > > > >>> are as > > > >> follows. The numbers in brackets are with the code on master. > > > >>> gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0 > > > >>> > > > >>> RTE>>ring_perf_elem_autotest > > > >>> ### Te

Re: [dpdk-dev] [PATCH] eal: add option --iso-cmem for external custom memory

2019-10-18 Thread Burakov, Anatoly
On 18-Oct-19 11:54 AM, Rajesh Ravi wrote: + Srinath Thanks Anatoly for reviewing this. Please find my reply inline  below: [Anatoly] First of all, what is "iso-cmem"? It doesn't seem to have any defined meaning nor any relation to any existing functionality, and it's not explained anywhere wh

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/axgbe: fix double unlock coverity issue

2019-10-18 Thread Ferruh Yigit
On 10/9/2019 9:41 AM, Ferruh Yigit wrote: > On 9/19/2019 12:01 PM, Pallantla Poornima wrote: >> One issue caught by Coverity 340835 >> *unlock: axgbe_phy_set_mode unlocks pdata->phy_mutex >> *double_unlock: axgbe_phy_sfp_detect unlocks pdata->phy_mutex >> while it is unlocked. >> >> In axgbe_phy_sf

Re: [dpdk-dev] [PATCH v2 2/3] vhost: call vDPA callback at the end of vring enable handler

2019-10-18 Thread Ferruh Yigit
On 9/23/2019 9:12 AM, Tiwei Bie wrote: > On Tue, Sep 17, 2019 at 05:09:47PM +0800, Andy Pei wrote: >> vDPA's set_vring_state callback would need to know the virtqueues' >> enable status to configure the hardware. >> >> Signed-off-by: Xiaolong Ye >> Signed-off-by: Andy Pei >> --- >> v2: >> add nr

Re: [dpdk-dev] [PATCH] build: print out dependency names for clarity

2019-10-18 Thread Burakov, Anatoly
On 19-Sep-19 4:07 PM, Bruce Richardson wrote: To help developers to get the correct dependency name e.g. when creating a new example that depends on a specific component, print out the dependency name for each lib/driver as it is processed. Signed-off-by: Bruce Richardson --- Very nice change

Re: [dpdk-dev] [PATCH] net: add missing endianness annotations

2019-10-18 Thread Ferruh Yigit
On 10/18/2019 10:23 AM, Olivier Matz wrote: > On Fri, Oct 18, 2019 at 10:47:37AM +0200, David Marchand wrote: >> On Fri, Oct 18, 2019 at 10:43 AM Olivier Matz wrote: >>> >>> Hi David, >>> >>> 2lOn Fri, Sep 27, 2019 at 01:58:02PM +0200, David Marchand wrote: OVS currently maintains a copy of t

Re: [dpdk-dev] [PATCH] net: add missing endianness annotations

2019-10-18 Thread Ferruh Yigit
On 10/18/2019 6:00 PM, Ferruh Yigit wrote: > On 10/18/2019 10:23 AM, Olivier Matz wrote: >> On Fri, Oct 18, 2019 at 10:47:37AM +0200, David Marchand wrote: >>> On Fri, Oct 18, 2019 at 10:43 AM Olivier Matz >>> wrote: Hi David, 2lOn Fri, Sep 27, 2019 at 01:58:02PM +0200, David

Re: [dpdk-dev] [EXT] Re: [PATCH v10 4/5] kni: add IOVA=VA support in KNI module

2019-10-18 Thread Vamsi Krishna Attunuru
> -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: Wednesday, October 16, 2019 9:44 PM > To: Vamsi Krishna Attunuru ; Stephen Hemminger > ; Yigit, Ferruh > > Cc: dev@dpdk.org; tho...@monjalon.net; Jerin Jacob Kollanukkaran > ; olivier.m...@6wind.com; > anatoly.bura...@in

Re: [dpdk-dev] [PATCH v4 1/2] lib/ring: apis to support configurable element size

2019-10-18 Thread David Christensen
Tried this on a Power9 platform (3.6GHz), with two numa nodes and 16 cores/node (SMT=4). Applied all 3 patches in v5, test results are as follows: RTE>>ring_perf_elem_autotest ### Testing single element and burst enq/deq ### SP/SC single enq/dequeue: 42 MP/MC single enq/dequeue: 59 SP/SC burs

Re: [dpdk-dev] [PATCH v5] ethdev: add HIGIG2 key field to flow API

2019-10-18 Thread Ferruh Yigit
On 10/18/2019 5:13 AM, kirankum...@marvell.com wrote: > From: Kiran Kumar K > > Add new rte_flow_item_higig2_hdr in order to match higig2 header. > It is a layer 2.5 protocol and used in Broadcom switches. > Header format is based on the following document. > http://read.pudn.com/downloads558/doc

Re: [dpdk-dev] [RFC] ethdev: add new fields for max LRO session size

2019-10-18 Thread Ananyev, Konstantin
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, October 18, 2019 5:36 PM > To: Thomas Monjalon ; Matan Azrad > Cc: dev@dpdk.org; Andrew Rybchenko ; Ananyev, > Konstantin ; Olivier Matz > > Subject: Re: [RFC] ethdev: add new fields for max LRO session size > > On 10/2/2019 2

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix missing loop topology option

2019-10-18 Thread Ferruh Yigit
On 10/18/2019 4:45 PM, Ciara Power wrote: > The testpmd --help option did not show all possible choices for port > topology previously. The loop topology option is now added. > > Fixes: 3e2006d6186c ("app/testpmd: add loopback topology") > Cc: cchempara...@tilera.com > Cc: sta...@dpdk.org > > Sig

[dpdk-dev] [PATCH v3] app/test: add tests for atomic exchanges

2019-10-18 Thread David Christensen
The test works by creating a token comprised of random data and a CRC8 value, using the rte_atomicXX_exchange to exchange the new token for a previously generated token, and then verifying that the exchanged data is intact (i.e. the CRC8 is still correct for the data). Signed-off-by: David Christe

Re: [dpdk-dev] [PATCH v3] app/testpmd: enable GTP header parse and Tx checksum offload

2019-10-18 Thread Ferruh Yigit
On 10/18/2019 5:08 PM, Ting Xu wrote: > This patch enables testpmd to forward GTP packet in csum fwd mode. > GTP header structure (without optional fields and extension header) > and parser function are added. GTPU and GTPC packets are both > supported, with respective UDP destination port and GTP

Re: [dpdk-dev] [PATCH v4 1/2] lib/ring: apis to support configurable element size

2019-10-18 Thread Honnappa Nagarahalli
> Subject: RE: [dpdk-dev] [PATCH v4 1/2] lib/ring: apis to support configurable > element size > > > Hi everyone, > > > > > > >>> I tried this. On x86 (Xeon(R) Gold 6132 CPU @ 2.60GHz), the > > > > >>> results are as > > > > >> follows. The numbers in brackets are with the code on master. > >

Re: [dpdk-dev] [PATCH v4 00/15] add hairpin feature

2019-10-18 Thread Ferruh Yigit
On 10/17/2019 4:32 PM, Ori Kam wrote: > s patch set implements the hairpin feature. > The hairpin feature was introduced in RFC[1] > > The hairpin feature (different name can be forward) acts as "bump on the > wire", > meaning that a packet that is received from the wire can be modified using > o

  1   2   >