On 10/18/2019 5:13 AM, kirankum...@marvell.com wrote: > From: Kiran Kumar K <kirankum...@marvell.com> > > Add new rte_flow_item_higig2_hdr in order to match higig2 header. > It is a layer 2.5 protocol and used in Broadcom switches. > Header format is based on the following document. > http://read.pudn.com/downloads558/doc/comm/2301468/HiGig_protocol.pdf
+1 to have protocol documentation, but what is 'pudn.com'? Is it kind of download site? Isn't there any official web site for the protocol? > > Signed-off-by: Kiran Kumar K <kirankum...@marvell.com> > --- > V5 changes: > * Changed broadcom to Broadcom > * Changed RTE_HIGIG2_H to RTE_HIGIG_H > * Fixed meson build > > V4 Changes: > * Removed packed attribute > > V3 Changes: > * Fixed Copyright header > * Fixed version info in the subject > > V2 Changes: > * Added support in testpmd to parse the higig2 item > * Moved the higig2 header to new file > * Added indentation in doc > > app/test-pmd/cmdline_flow.c | 33 +++++++ > doc/guides/prog_guide/rte_flow.rst | 8 ++ > lib/librte_ethdev/rte_flow.c | 1 + > lib/librte_ethdev/rte_flow.h | 7 ++ > lib/librte_net/Makefile | 2 +- > lib/librte_net/meson.build | 3 +- > lib/librte_net/rte_higig.h | 138 +++++++++++++++++++++++++++++ 'lib/librte_net/' maintainer is Olivier, so by default new file maintainer will be Olivier, it is good to get his ack to confirm this before merging patch. Also can you please update "doc/api/doxy-api-index.md" to add new 'rte_higig.h' file so that it can be part of our API documentation. btw, 'rte_gre.h' & 'rte_mpls.h' are seems missing in API documentation, another patch to add them would be nice if possible.
