Re: [dpdk-dev] [PATCH] ethdev: add HIGIG2 key field to flow API

2019-10-14 Thread Andrew Rybchenko
On 10/14/19 7:29 AM, kirankum...@marvell.com wrote: From: Kiran Kumar K Add new rte_flow_item_higig2_hdr in order to match higig2 header. It is a layer 2.5 protocol and used in broadcom switches. Header format is based on the following document. http://read.pudn.com/downloads558/doc/comm/230146

Re: [dpdk-dev] [PATCH 00/17] Series short description

2019-10-14 Thread Alfredo Cardigliano
Hi Stephen yes, we were thinking of doing a single post for just that reason, but Thomas recommended that we split it up. Thank you Alfredo > On 12 Oct 2019, at 17:28, Stephen Hemminger > wrote: > > On Sat, 12 Oct 2019 02:26:26 +0200 > Alfredo Cardigliano wrote: > >> The patch series provid

[dpdk-dev] [PATCH v9 00/18] add PCIe AER disable and IRQ support for ipn3ke

2019-10-14 Thread Andy Pei
This patch set adds PCIe AER disable and IRQ support for ipn3ke. Disable PCIe AER is very useful when FPGA reload. IRQ is used very widely in interrupt process. For ipn3ke is connect to CPU with PCIe switch, driver needs to scan all PCIe devices of ipn3ke, it also can get all i40e of card, so ipn3

[dpdk-dev] [PATCH v9 03/18] raw/ifpga/base: clear pending bit

2019-10-14 Thread Andy Pei
From: Tianfei zhang Every defined bit in FME_ERROR0 is RW1C. Other reserved bits are always 0 when readout and it will plan to be RW1C if needed in future. So it is safe just write the read back value to clear all the errors. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/ra

[dpdk-dev] [PATCH v9 01/18] net/i40e: i40e support ipn3ke FPGA port bonding

2019-10-14 Thread Andy Pei
In ipn3ke, each FPGA network side port bonding to an i40e pf, each i40e pf link status should get data from FPGA network, side port. This patch provide bonding relationship. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/net/i40e/base/i40e_type.h | 3 +++ drivers/net/i40e/

[dpdk-dev] [PATCH v9 05/18] raw/ifpga/base: add device tree support

2019-10-14 Thread Andy Pei
From: Tianfei zhang In PAC N3000 card, this is a BMC chip which using MAX10 FPGA to manage the board configuration, like sensors, flash controller, QSFP, powers. And this is a SPI bus connected between A10 FPGA and MAX10, we can access the MAX10 registers over this SPI bus. In BMC, there are abo

[dpdk-dev] [PATCH v9 06/18] raw/ifpga/base: align the send buffer for SPI

2019-10-14 Thread Andy Pei
From: Tianfei zhang The length of send buffer of SPI bus should be 4bytes align. Signed-off-by: Tianfei Zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/opae_spi_transaction.c | 40 --- 1 file changed, 36 insertions(+), 4 deletions(-) diff --git a/drivers/raw/

[dpdk-dev] [PATCH v9 04/18] raw/ifpga/base: add SEU error support

2019-10-14 Thread Andy Pei
From: Tianfei zhang This patch exposes SEU error information to application then application could compare this information (128bit) with its own SMH file to know if this SEU is a fatal error or not. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_defines

[dpdk-dev] [PATCH v9 02/18] raw/ifpga/base: add irq support

2019-10-14 Thread Andy Pei
From: Tianfei zhang Add irq support for ifpga FME global error, port error and uint unit. We implmented this feature by vfio interrupt mechanism. To build this feature, CONFIG_RTE_EAL_VFIO should be enabled. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- config/common_base

[dpdk-dev] [PATCH v9 08/18] raw/ifpga/base: introducing sensor APIs

2019-10-14 Thread Andy Pei
From: Tianfei zhang Introducing sensor APIs to PMD driver for PAC N3000 card. Those sensor APIs: 1. opae_mgr_for_each_sensor() 2. opae_mgr_get_sensor_by_name() 3. opae_mgr_get_sensor_by_id() 4. opae_mgr_get_sensor_value_by_name() 5. opae_mgr_get_sensor_value_by_id() 6. opae_mgr_get_sensor_value(

[dpdk-dev] [PATCH v9 11/18] raw/ifpga: add PCIe BDF devices tree scan

2019-10-14 Thread Andy Pei
From: Rosen Xu Add PCIe BDF devices tree scan for ipn3ke. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/raw/ifpga/ifpga_rawdev.c | 551 ++- drivers/raw/ifpga/ifpga_rawdev.h | 16 ++ 2 files changed, 562 insertions(+), 5 deletions(-) diff --g

[dpdk-dev] [PATCH v9 09/18] raw/ifpga/base: update SEU register definition

2019-10-14 Thread Andy Pei
From: Tianfei zhang Update the SEU registser definition. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_defines.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/raw/ifpga/base/ifpga_defines.h b/drivers/raw/ifpga/base/ifpg

[dpdk-dev] [PATCH v9 10/18] raw/ifpga: add SEU error handler

2019-10-14 Thread Andy Pei
From: Rosen Xu Add SEU interrupt support for FPGA. Signed-off-by: Tianfei zhang Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/raw/ifpga/ifpga_rawdev.c | 245 +++ 1 file changed, 245 insertions(+) diff --git a/drivers/raw/ifpga/ifpga_rawdev.c

[dpdk-dev] [PATCH v9 07/18] raw/ifpga/base: add sensor support

2019-10-14 Thread Andy Pei
From: Tianfei zhang The sensor devices are connected in MAX10 FPGA. we used the device tree to describe those sensor devices. Parse the device tree to get the sensor devices and add them into a list. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/opae_intel_ma

[dpdk-dev] [PATCH v9 12/18] net/ipn3ke: remove configuration for i40e port bonding

2019-10-14 Thread Andy Pei
From: Rosen Xu The ipn3ke board FPGA and i40e BDF scan has added in ifpga_rawdev, so it doesn't need to provide configuration for i40e port bonding. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/net/ipn3ke/Makefile | 2 + drivers/net/ipn3ke/ipn3ke_ethdev.c | 2

[dpdk-dev] [PATCH v9 13/18] raw/ifpga/base: add secure support

2019-10-14 Thread Andy Pei
From: Tianfei zhang Add secure max10 device support. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_defines.h| 2 + drivers/raw/ifpga/base/ifpga_fme.c| 26 -- drivers/raw/ifpga/base/opae_intel_max10.c | 136 +---

[dpdk-dev] [PATCH v9 17/18] raw/ifpga: add lightweight fpga image support

2019-10-14 Thread Andy Pei
if fpga image support lightweight feature, set afu uuid to all 0, ipn3ke representor will not be probed. Signed-off-by: Andy Pei --- drivers/raw/ifpga/ifpga_rawdev.c | 44 +--- 1 file changed, 32 insertions(+), 12 deletions(-) diff --git a/drivers/raw/ifpga/i

[dpdk-dev] [PATCH v9 16/18] raw/ifpga/base: add new API get board info

2019-10-14 Thread Andy Pei
From: Tianfei zhang Add new API to get the board info. opae_mgr_get_board_info() Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_api.c | 11 +++ drivers/raw/ifpga/base/ifpga_defines.h | 55 ++ drivers/raw/ifpga/base

[dpdk-dev] [PATCH v9 14/18] raw/ifpga/base: configure FEC mode

2019-10-14 Thread Andy Pei
From: Tianfei zhang We can change the PKVL FEC mode when the A10 NIOS FW initialization. The end-user can use this feature the change the FEC mode, the default mode is RS FEC mode. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_fme.c | 42 +++

[dpdk-dev] [PATCH v9 15/18] raw/ifpga/base: clean fme errors

2019-10-14 Thread Andy Pei
From: Tianfei zhang Clean fme errors register when some fme errors occurred. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_fme_error.c | 24 ++-- drivers/raw/ifpga/ifpga_rawdev.c | 22 ++ 2 files changed,

[dpdk-dev] [PATCH v9 18/18] raw/ifpga/base: add multiple cards support

2019-10-14 Thread Andy Pei
From: Tianfei zhang In PAC N3000 card, there is one MAX10 chip in each card, and all of the sensors are connected to MAX10 chip. To support multiple cards in one server, we introducing a sensor device list under intel_max10_device instead of a global list. On the other hand, we using separate int

Re: [dpdk-dev] [PATCH v4 1/2] virtio: one way barrier for packed vring desc avail flags

2019-10-14 Thread Maxime Coquelin
On 9/17/19 7:28 AM, Joyce Kong wrote: > In case VIRTIO_F_ORDER_PLATFORM(36) is not negotiated, then the frontend > and backend are assumed to be implemented in software, that is they can > run on identical CPUs in an SMP configuration. > Thus a weak form of memory barriers like rte_smp_r/wmb, ot

Re: [dpdk-dev] [PATCH v4 2/2] virtio: one way barrier for packed vring desc used flags

2019-10-14 Thread Maxime Coquelin
On 9/17/19 7:28 AM, Joyce Kong wrote: > In case VIRTIO_F_ORDER_PLATFORM(36) is not negotiated, then the frontend > and backend are assumed to be implemented in software, that is they can > run on identical CPUs in an SMP configuration. > Thus a weak form of memory barriers like rte_smp_r/wmb, ot

[dpdk-dev] net/i40e: fix vlan packets drop

2019-10-14 Thread Xiao Zhang
vlan packets with ip length bigger then 1496 will not be received by i40e due to wrong packets size checking. This patch fixes the issue by correcting the maximum frame size during checking. Fixes: 35b2d13fd6fd ("net: add rte prefix to ether defines") Cc: sta...@dpdk.org Signed-off-by: Xiao Zhang

Re: [dpdk-dev] [PATCH 00/17] Series short description

2019-10-14 Thread Andrew Rybchenko
On 10/14/19 10:16 AM, Alfredo Cardigliano wrote: Hi Stephen yes, we were thinking of doing a single post for just that reason, but Thomas recommended that we split it up. I agree with Thomas that it is better to split it up. What I don't understand from the list below is, for example, why RSS g

[dpdk-dev] [DPDK] broken compilation when RTE_LIBRTE_SECURITY is not enabled

2019-10-14 Thread Thierry Herbelot
Hello, When disabling RTE_LIBRTE_SECURITY, DPDK compilation fails with the following error messages: CC test_cryptodev.o /home/herbelot/work/dpdk/app/test/test_cryptodev.c:76:40: error: field ‘type’ has incomplete type enum rte_security_session_action_type type;

Re: [dpdk-dev] [PATCH v1] net/ice: avoid the parsed devargs value being overwritten

2019-10-14 Thread Ye Xiaolong
On 10/09, Haiyue Wang wrote: >If the default dev args 'proto_xtr' is not in the first position, it >will overwrite the parsed queue map value, so use an new variable to >save the default. > >And enhance the error message printing to show the right information. > >Signed-off-by: Haiyue Wang >--- >

[dpdk-dev] net/i40e: fix integer overflow

2019-10-14 Thread Xiao Zhang
When configuring i40e rx queue, the temporary variable to store max packet length is not big enough which leads to integer overflow issue. This patch is to fix the issue by changing the variable type from uint16_t to uint32_t. Fixes: c511a96a34d7 ("mbuf: add accessors for data room and private siz

[dpdk-dev] [PATCH] net/ice: invoke callback func when link status change

2019-10-14 Thread Leyi Rong
Call _rte_eth_dev_callback_process when link status change. Signed-off-by: Leyi Rong --- drivers/net/ice/ice_ethdev.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index dfccef65d..ddcb4848b 100644 --- a/drive

Re: [dpdk-dev] [PATCH v1] net/memif: optimized with one-way barrier

2019-10-14 Thread Ferruh Yigit
On 10/9/2019 12:17 PM, Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) wrote: > > > -Original Message- > From: dev On Behalf Of Phil Yang > Sent: Monday, August 26, 2019 7:00 PM > To: jgraj...@cisco.com; dev@dpdk.org > Cc: tho...@monjalon.net; jer...@mar

Re: [dpdk-dev] [PATCH] doc: replace license text with SPDX tag in ARK nic

2019-10-14 Thread Ferruh Yigit
On 10/11/2019 2:10 PM, Ed Czeck wrote: > Thanks.Do not hesitate to message me directly about needed ACKs. > > Acked-by: Ed Czeck Applied to dpdk-next-net/master, thanks. > > On Fri, Sep 27, 2019 at 5:06 AM Hemant Agrawal > wrote: > >> Cc: Ed Czeck >> Cc: John Miller >> >> Signed-off-by

Re: [dpdk-dev] [PATCH] doc: replace license text with SPDX tag for AVP nic

2019-10-14 Thread Ferruh Yigit
On 9/27/2019 12:00 PM, Legacy, Allain wrote: >> -Original Message- >> From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] >> Sent: Friday, September 27, 2019 5:05 AM >> To: dev@dpdk.org >> Cc: Legacy, Allain; Peters, Matt; Hemant Agrawal >> Subject: [PATCH] doc: replace license text with S

[dpdk-dev] [PATCH v4] build: add emag target

2019-10-14 Thread Gavin Hu
From: Jerry Hao OS Add the make and meson based build infrastructure for the eMAG platform from Ampere Computing corp., which is a 64-bit ARM processor with 32 Armv8 64-bit CPU cores. For more information, refer to: https://amperecomputing.com/product/ Signed-off-by: Jerry Hao OS Signed-off-by:

Re: [dpdk-dev] [PATCH v2 01/14] ethdev: add support for hairpin queue

2019-10-14 Thread Andrew Rybchenko
Hi Ori, see my answers below. On 10/11/19 12:07 AM, Ori Kam wrote: Hi Andrew, Thanks for your comments, PSB, Ori -Original Message- From: Andrew Rybchenko Sent: Tuesday, October 8, 2019 7:11 PM To: Ori Kam ; Thomas Monjalon ; Ferruh Yigit Cc: dev@dpdk.org; jingjing...@intel.com; s

Re: [dpdk-dev] [PATCH v2] net/dpaa2: set port in the mbuf

2019-10-14 Thread Ferruh Yigit
On 10/9/2019 12:13 PM, Nipun Gupta wrote: > This patch sets the port in mbuf for event scenarios as well > > Fixes: b677d4c6d281 ("net/dpaa2: add API for event Rx adapter") > Fixes: 2d3788631862 ("net/dpaa2: support atomic queues") > Fixes: 16c4a3c46ab7 ("bus/fslmc: add enqueue response read in qb

[dpdk-dev] [PATCH] common/octeontx2: upgrade the mbox definition to version 2

2019-10-14 Thread Nithin Dabilpuram
Sync mail box data structures to version 0x0002. This patch checks for mismatch in mail box revision and avoids initializing octeontx2 pci device if there is a mismatch. Signed-off-by: Nithin Dabilpuram --- drivers/common/octeontx2/otx2_mbox.c | 6 ++ drivers/common/octeontx2/otx2_mbox.h | 190

Re: [dpdk-dev] [PATCH v2 1/2] lib/distributor: fix deadlock issue for aarch64

2019-10-14 Thread Ruifeng Wang (Arm Technology China)
> -Original Message- > From: Honnappa Nagarahalli > Sent: Sunday, October 13, 2019 10:32 > To: Ruifeng Wang (Arm Technology China) ; > david.h...@intel.com > Cc: dev@dpdk.org; hka...@marvell.com; Gavin Hu (Arm Technology China) > ; nd ; Ruifeng Wang (Arm Technology > China) ; sta...@dpdk

[dpdk-dev] [PATCH] examples/vm_power: fix build

2019-10-14 Thread Ferruh Yigit
Fixes: 70febdcfd60f ("examples: check status of getting MAC address") Signed-off-by: Ferruh Yigit --- Cc: Igor Romanov Cc: Andrew Rybchenko --- examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/examples/vm_power

Re: [dpdk-dev] [PATCH] examples/vm_power: fix build

2019-10-14 Thread Andrew Rybchenko
On 10/14/19 1:03 PM, Ferruh Yigit wrote: Fixes: 70febdcfd60f ("examples: check status of getting MAC address") Signed-off-by: Ferruh Yigit Thanks Ferruh, it is consequences of vm_power_manager excluded from build because of missing libvirt dependency and our inattentiveness when checking buil

Re: [dpdk-dev] [PATCH] examples/vm_power: fix build

2019-10-14 Thread Ferruh Yigit
On 10/14/2019 11:10 AM, Andrew Rybchenko wrote: > On 10/14/19 1:03 PM, Ferruh Yigit wrote: >> Fixes: 70febdcfd60f ("examples: check status of getting MAC address") >> >> Signed-off-by: Ferruh Yigit > > Thanks Ferruh, it is consequences of vm_power_manager > excluded from build because of missing

Re: [dpdk-dev] [PATCH v2 01/14] ethdev: add support for hairpin queue

2019-10-14 Thread Ori Kam
Thanks for your comments, I will start working on V3 Ori > -Original Message- > From: Andrew Rybchenko > Sent: Monday, October 14, 2019 12:37 PM > To: Ori Kam ; Thomas Monjalon > ; Ferruh Yigit > Cc: dev@dpdk.org; jingjing...@intel.com; step...@networkplumber.org > Subject: Re: [PATCH

Re: [dpdk-dev] net/i40e: fix integer overflow

2019-10-14 Thread Kevin Traynor
On 14/10/2019 09:33, Xiao Zhang wrote: > When configuring i40e rx queue, the temporary variable to store max packet > length is not big enough which leads to integer overflow issue. This > patch is to fix the issue by changing the variable type from uint16_t > to uint32_t. > > Fixes: c511a96a34d7

Re: [dpdk-dev] [PATCH v2] app/testpmd: support QinQ offload in VLAN set command

2019-10-14 Thread Ferruh Yigit
On 10/11/2019 5:05 AM, viveksha...@marvell.com wrote: > From: Vivek Sharma > > Segregate QinQ from Extend Offload and support QinQ offload > in vlan set command. Merge all port wise rx vlan offloads in > command line help and documentation for a cleaner structure. > > Fix port info display to di

Re: [dpdk-dev] [PATCH v2] app/testpmd: introduce QinQ offload argument

2019-10-14 Thread Ferruh Yigit
On 10/11/2019 3:36 AM, viveksha...@marvell.com wrote: > From: Vivek Sharma > > Introduce boot time argument for configuring QinQ strip > offload. > > Signed-off-by: Vivek Sharma Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH] doc: add known issue for ice

2019-10-14 Thread Min JiaqiX
Add known issue for incorrect Rx statistics when packet is oversize. Signed-off-by: Min JiaqiX --- doc/guides/nics/ice.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index 03819d29f..3e9bc9d33 100644 --- a/doc/guides/nics/ice.rst

Re: [dpdk-dev] [PATCH] app/testpmd: introduce Rx offloads argument

2019-10-14 Thread Ferruh Yigit
On 10/10/2019 5:34 AM, viveksha...@marvell.com wrote: > From: Vivek Sharma > > Introduce boot time argument for configuring all rx offloads. > > Signed-off-by: Vivek Sharma Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH v4 01/17] sched: add pipe config params to subport struct

2019-10-14 Thread Jasvinder Singh
Add pipe configuration parameters to subport level structure to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/Makefile| 2 +-

[dpdk-dev] [PATCH v4 00/17] sched: subport level configuration of pipe nodes

2019-10-14 Thread Jasvinder Singh
This patchset refactors the dpdk qos sched library to allow subport level configuration flexibility of the pipe nodes. Currently, all parameters for the pipe nodes (subscribers) configuration are part of the port level structure which forces all groups of subscribers (pipes) in different subports

[dpdk-dev] [PATCH v4 06/17] sched: modify pkt enqueue for config flexibility

2019-10-14 Thread Jasvinder Singh
Modify scheduler packet enqueue operation of the scheduler to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 277 +

[dpdk-dev] [PATCH v4 04/17] sched: add pipe config to subport level

2019-10-14 Thread Jasvinder Singh
Add pipes configuration from the port level to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 388

[dpdk-dev] [PATCH v4 03/17] sched: remove pipe params config from port level

2019-10-14 Thread Jasvinder Singh
Remove pipes configuration from the port level to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 254 ++---

[dpdk-dev] [PATCH v4 07/17] sched: update memory compute to support flexiblity

2019-10-14 Thread Jasvinder Singh
Update memory footprint compute function for allowing subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 100 ++---

[dpdk-dev] [PATCH v4 02/17] sched: modify internal structs for config flexibility

2019-10-14 Thread Jasvinder Singh
Update internal structures related to port and subport to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 106 +

[dpdk-dev] [PATCH v4 05/17] sched: modify pipe functions for config flexibility

2019-10-14 Thread Jasvinder Singh
Modify pipe level functions to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 103 +

[dpdk-dev] [PATCH v4 08/17] sched: update grinder functions for config flexibility

2019-10-14 Thread Jasvinder Singh
Modify packet grinder functions of the schedule to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 223

[dpdk-dev] [PATCH v4 13/17] ip_pipeline: add subport config flexibility to TM

2019-10-14 Thread Jasvinder Singh
Modify ip pipeline traffic management function to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- examples/ip_pipeline/cli.c | 71 ++-

[dpdk-dev] [PATCH v4 09/17] sched: update pkt dequeue for flexible config

2019-10-14 Thread Jasvinder Singh
Modify scheduler packet dequeue operation to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 51 +++

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-14 Thread Ananyev, Konstantin
> Hi Akhil, > > Thanks for the review and comments! > Knowing you are extremely busy. Here is my point in brief: > I think placing the CPU synchronous crypto in the rte_security make sense, as > > 1. rte_security contains inline crypto and lookaside crypto action type > already, adding cpu_cry

[dpdk-dev] [PATCH v4 11/17] test/sched: modify tests for subport config flexibility

2019-10-14 Thread Jasvinder Singh
Modify tests function to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- app/test/test_sched.c | 35 ++- 1 file change

[dpdk-dev] [PATCH v4 10/17] sched: update queue stats read for config flexibility

2019-10-14 Thread Jasvinder Singh
Modify pipe queue stats read function to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 28 +++

[dpdk-dev] [PATCH v4 12/17] net/softnic: add subport config flexibility to TM

2019-10-14 Thread Jasvinder Singh
Modify softnic traffic management function to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- drivers/net/softnic/rte_eth_softnic_tm.c | 54 ++

[dpdk-dev] [PATCH v4 17/17] sched: modify internal structs and functions for 64 bit values

2019-10-14 Thread Jasvinder Singh
Modify internal structure and functions to support 64-bit values for rates and stats parameters. Release note is updated and deprecation notice is removed. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- doc/guides/rel_notes/deprecation.rst | 6 - doc/guides/rel_notes/re

[dpdk-dev] [PATCH v4 16/17] sched: add support for 64 bit values

2019-10-14 Thread Jasvinder Singh
To support high bandwidth NICs, all rates (port, subport level token bucket and traffic class rates, pipe level token bucket and traffic class rates) and stats counters defined in public data structures (rte_sched.h) are modified to support 64-bit values. Signed-off-by: Jasvinder Singh Signed-off

[dpdk-dev] [PATCH v4 15/17] sched: remove redundant code

2019-10-14 Thread Jasvinder Singh
Remove redundant data structure fields from port level data structures. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 42 +--- lib/librte_sched/rte_sched.h | 22 --- 2 files changed, 1 insertion(

[dpdk-dev] [PATCH v4 14/17] examples/qos_sched: add subport configuration flexibility

2019-10-14 Thread Jasvinder Singh
Modify qos sample app to allow different subports of the same port to have different configuration in terms of number of pipes, pipe queue sizes, etc. Signed-off-by: Jasvinder Singh Signed-off-by: Lukasz Krakowiak --- examples/qos_sched/app_thread.c | 20 ++- examples/qos_sched/cfg_file.c

Re: [dpdk-dev] [PATCH] vfio: free mp_reply msgs in failure cases

2019-10-14 Thread David Marchand
On Fri, Aug 16, 2019 at 9:19 PM Jim Harris wrote: > > The code checks both rte_mp_request_sync() return > code and that the number of messages in the reply > equals 1. If rte_mp_request_sync() succeeds but > there was more than one message, those messages > would get leaked. > > Found via code re

Re: [dpdk-dev] [PATCH v1] app/testpmd: fix CRC strip config error

2019-10-14 Thread Iremonger, Bernard
Hi Ting, > -Original Message- > From: Xu, Ting > Sent: Saturday, October 12, 2019 1:19 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > ; sta...@dpdk.org > Subject: [PATCH v1] app/testpmd: fix CRC strip config error > > This patch fixed the bug that an error

[dpdk-dev] [PATCH 3/8] examples/performance-thread: remove warning disabling

2019-10-14 Thread Bruce Richardson
The warnings about functions not returning values can be removed from the code by just adding an attribute to the function to specify it doesn't return. The GCC bug referenced in the makefile which prevents this from working has been fixed for >10 years according to bugzilla. Signed-off-by: Bruce

[dpdk-dev] [PATCH 2/8] examples/ethtool: allow building as part of meson build

2019-10-14 Thread Bruce Richardson
Since the code for the ethtool example was contained in subdirectories the compilation of this example is different from most of the other apps, and it had not been abled when the user requests a build with "-Dexamples=all". To simplify the build with meson, the separate ethtool library is not bui

[dpdk-dev] [PATCH 0/8] support all examples in a meson build

2019-10-14 Thread Bruce Richardson
When build with meson, some examples were skipped when "-Dexamples=all" parameter was passed. Ignoring examples slated for removal by other patches[1], this set adds support for building the rest of the examples. The only exception is "bpf" which is a set of code snippets rather than code to be nat

[dpdk-dev] [PATCH 1/8] examples/bpf: remove from list of examples to build

2019-10-14 Thread Bruce Richardson
The examples/bpf directory does not contain an example app, but rather example code for use with testpmd's BPF support. Therefore, we should not attempt to build it when the user requests "examples=all". This also synchronises the meson behaviour with make which similarly doesn't compile up the cod

[dpdk-dev] [PATCH 5/8] examples/performance-thread: add l3fwd-thread to meson

2019-10-14 Thread Bruce Richardson
Limited to x86_64 systems, as it fails to compile on any others and is disabled in the examples makefile for non-x86_64 systems. Signed-off-by: Bruce Richardson --- examples/meson.build | 3 ++- .../l3fwd-thread/meson.build | 22 +++ exa

[dpdk-dev] [PATCH 6/8] examples/performance-thread: add pthread shim to meson

2019-10-14 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- examples/meson.build | 1 + .../pthread_shim/meson.build | 23 +++ 2 files changed, 24 insertions(+) create mode 100644 examples/performance-thread/pthread_shim/meson.build diff --git a/examples/meson

[dpdk-dev] [PATCH 4/8] examples/performance-thread: rename directory to standard

2019-10-14 Thread Bruce Richardson
In other places in DPDK, e.g. EAL, the architecture-specific files for arm are just stored in a folder called "arm". Rename the "arm64" folder for performance thread example to align to this naming. Signed-off-by: Bruce Richardson --- examples/performance-thread/common/arch/{arm64 => arm}/ctx.c

[dpdk-dev] [PATCH 8/8] examples/server_node_efd: add server binary to meson build

2019-10-14 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- examples/meson.build| 1 + examples/server_node_efd/server/meson.build | 13 + 2 files changed, 14 insertions(+) create mode 100644 examples/server_node_efd/server/meson.build diff --git a/examples/meson.build b/examples/m

[dpdk-dev] [PATCH 7/8] examples/server_node_efd: add node binary to meson build

2019-10-14 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- examples/meson.build| 3 ++- examples/server_node_efd/{ => node}/meson.build | 9 ++--- 2 files changed, 8 insertions(+), 4 deletions(-) rename examples/server_node_efd/{ => node}/meson.build (60%) diff --git a/examples/meson.b

Re: [dpdk-dev] [PATCH v1] app/testpmd: fix CRC strip config error

2019-10-14 Thread Iremonger, Bernard
Hi Ting, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Iremonger, Bernard > Sent: Monday, October 14, 2019 12:26 PM > To: Xu, Ting ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] app/testpmd: fix CRC str

[dpdk-dev] [PATCH v4 0/5] rework for ice generic flow framework and switch filter

2019-10-14 Thread Ying Wang
patch 1/5 minor code clean patch 2/5 adds devargs to control pipeline mode patch 3/5 rework for ice generic flow framework patch 4/5 add rte_flow pattern list patch 5/5 rework switch filter on new framework Qiming Yang (1): net/ice: add devargs to control pipeline mode Ying Wang (3): net/ice:

[dpdk-dev] [PATCH v4 3/5] net/ice: rework for generic flow enabling

2019-10-14 Thread Ying Wang
The patch reworks the generic flow API (rte_flow) implementation. It introduces an abstract layer which provides a unified interface for low-level filter engine (switch, fdir, hash) to register supported patterns and actions and implement flow validate/create/destroy/flush/ query activities. The p

[dpdk-dev] [PATCH v4 1/5] net/ice: minor code clean

2019-10-14 Thread Ying Wang
The patch removes redundant code and cleans up some wrong indentations. Signed-off-by: Ying Wang Acked-by: Qi Zhang --- drivers/net/ice/ice_generic_flow.c | 39 +++--- 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/drivers/net/ice/ice_generic_flo

[dpdk-dev] [PATCH v4 5/5] net/ice: rework switch filter

2019-10-14 Thread Ying Wang
From: wei zhao The patch reworks packet process engine's binary classifier (switch) for the new framework. It also adds support for new packet type like PPPoE for switch filter. Signed-off-by: Wei Zhao Acked-by: Qi Zhang --- doc/guides/rel_notes/release_19_11.rst |1 + drivers/net/ice/ice

[dpdk-dev] [PATCH v4 2/5] net/ice: add devargs to control pipeline mode

2019-10-14 Thread Ying Wang
From: Qiming Yang Added a devarg to control the mode in generic flow API. We use none-pipeline mode by default. Signed-off-by: Qiming Yang Acked-by: Qi Zhang --- doc/guides/nics/ice.rst| 19 +++ doc/guides/rel_notes/release_19_11.rst | 2 ++ drivers/net/ice/ic

[dpdk-dev] [PATCH v4 4/5] net/ice: add pattern manifest

2019-10-14 Thread Ying Wang
The patch adds a manifest for all patterns which can be selected by low level filter engine to compose their supported list. Signed-off-by: Ying Wang Acked-by: Qi Zhang --- drivers/net/ice/ice_generic_flow.c | 1287 drivers/net/ice/ice_generic_flow.h | 201

Re: [dpdk-dev] [PATCH v2 0/4] get Rx/Tx packet burst mode information

2019-10-14 Thread Ferruh Yigit
On 9/26/2019 3:54 PM, Haiyue Wang wrote: > v1 -> v2: > 1). Change the return type of dev_ops callback from 'void' to > 'int'. > 2). Update the ice/i40 PMD patches with clear git commit log. > > RFCv3 -> v1: > https://patchwork.dpdk.org/patch/59103/ > https://patch

Re: [dpdk-dev] [dpdk-stable] [PATCH v1] app/testpmd: fix CRC strip config error

2019-10-14 Thread Ferruh Yigit
On 10/12/2019 1:18 PM, Ting Xu wrote: > This patch fixed the bug that an error appears when config rx_offload > crc_strip using command "port config all crc-strip on|off". The reason > is that this command was removed previously. However, the current command > does not enable "crc_strip" option pro

[dpdk-dev] [PATCH v12 0/3] extend RSS offload types

2019-10-14 Thread Simei Su
[PATCH v12 1/3] ethdev: decouple flow types and RSS offload types. [PATCH v12 2/3] ethdev: add several bits for extending rss offload types. [PATCH v12 3/3] app/testpmd: add cmdline support for extending rss types. v12: * Use a macro to replace a function. v11: * Update code logic in rte_eth_dev_

[dpdk-dev] [PATCH v12 1/3] ethdev: decouple flow types and RSS offload types

2019-10-14 Thread Simei Su
This patch decouples RTE_ETH_FLOW_* and ETH_RSS_*. The former defines flow types and the latter defines RSS offload types. Signed-off-by: Simei Su Reviewed-by: Qi Zhang Acked-by: Ori Kam Acked-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev.h | 51 ---

[dpdk-dev] [PATCH v12 3/3] app/testpmd: add RSS offload types extending support

2019-10-14 Thread Simei Su
This patch adds cmdline support for extended rss types configuration. Signed-off-by: Simei Su Reviewed-by: Qi Zhang --- app/test-pmd/cmdline.c | 14 -- app/test-pmd/config.c | 4 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test

[dpdk-dev] [PATCH v12 2/3] ethdev: extend RSS offload types

2019-10-14 Thread Simei Su
This patch reserves several bits as input set selection from the high end of the 64 bits. It is combined with exisiting ETH_RSS_* to represent RSS types. This patch also checks the simultaneous use of SRC_ONLY and DST_ONLY of the same level. Signed-off-by: Simei Su Reviewed-by: Qi Zhang Acked-by

Re: [dpdk-dev] [PATCH v3 1/2] compress/qat: overflow catch for stateless compression

2019-10-14 Thread Trahe, Fiona
> -Original Message- > From: Trybula, ArturX > Sent: Friday, October 11, 2019 6:46 PM > To: dev@dpdk.org; Trahe, Fiona ; shal...@marvell.com; > Dybkowski, AdamX > ; Trybula, ArturX ; > akhil.go...@nxp.com > Subject: [PATCH v3 1/2] compress/qat: overflow catch for stateless compression

Re: [dpdk-dev] [PATCH v3 2/2] test/compress: unit test for stateless overflow recovery

2019-10-14 Thread Trahe, Fiona
Hi Artur, > -Original Message- > From: Trybula, ArturX > Sent: Friday, October 11, 2019 6:46 PM > To: dev@dpdk.org; Trahe, Fiona ; shal...@marvell.com; > Dybkowski, AdamX > ; Trybula, ArturX ; > akhil.go...@nxp.com > Subject: [PATCH v3 2/2] test/compress: unit test for stateless overflow

[dpdk-dev] [PATCH v7 2/4] examples/ipsec-secgw: add fallback session feature

2019-10-14 Thread Marcin Smoczynski
Inline processing is limited to a specified subset of traffic. It is often unable to handle more complicated situations, such as fragmented traffic. When using inline processing such traffic is dropped. Introduce fallback session for inline crypto processing allowing handling packets that normally

[dpdk-dev] [PATCH v7 0/4] add fallback session

2019-10-14 Thread Marcin Smoczynski
Add fallback session feature allowing to process packets that inline processor is unable to handle (e.g. fragmented traffic). Processing takes place in a secondary session defined for SA in a configuration file. This feature is limited to ingress IPsec traffic only. IPsec anti-replay window and ES

[dpdk-dev] [PATCH v7 3/4] examples/ipsec-secgw: add frag TTL cmdline option

2019-10-14 Thread Marcin Smoczynski
Due to fragment loss on highly saturated links and long fragment lifetime, ipsec-secgw application quickly runs out of free reassembly buckets. As a result new fragments are being dropped. Introduce --frag-ttl option which allow user to lower default fragment lifitime which solves problem of satur

[dpdk-dev] [PATCH v7 1/4] examples/ipsec-secgw: sa structure cleanup

2019-10-14 Thread Marcin Smoczynski
Cleanup ipsec_sa structure by removing every field that is already in the rte_ipsec_session structure: * cryptodev/security session union * action type * offload flags * security context References to abovementioned fields are changed to direct references to matching fields of rte_ipsec_session

[dpdk-dev] [PATCH v7 4/4] examples/ipsec-secgw: add offload fallback tests

2019-10-14 Thread Marcin Smoczynski
Add tests for offload fallback feature; add inbound config modificator SGW_CFG_XPRM_IN (offload fallback setting can be set only for inbound SAs). Tests are using cryptodev for outbound SA. To test fragmentation with QAT set: MULTI_SEG_TEST="--reassemble=4096 --cryptodev_mask=0x" Acked-by: Ko

Re: [dpdk-dev] [PATCH] vfio: free mp_reply msgs in failure cases

2019-10-14 Thread Harris, James R
On 10/14/19, 4:18 AM, "David Marchand" wrote: On Fri, Aug 16, 2019 at 9:19 PM Jim Harris wrote: > > The code checks both rte_mp_request_sync() return > code and that the number of messages in the reply > equals 1. If rte_mp_request_sync() succeeds but > there was more

Re: [dpdk-dev] [PATCH v2 0/4] get Rx/Tx packet burst mode information

2019-10-14 Thread Wang, Haiyue
Hi, Ferruh > -Original Message- > From: Yigit, Ferruh > Sent: Monday, October 14, 2019 20:12 > To: Wang, Haiyue ; dev@dpdk.org; Ye, Xiaolong > > Cc: Kinsella, Ray ; Iremonger, Bernard > ; Sun, > Chenmin > Subject: Re: [PATCH v2 0/4] get Rx/Tx packet burst mode information > > On 9/26/

Re: [dpdk-dev] [PATCH v1] net/ice: avoid the parsed devargs value being overwritten

2019-10-14 Thread Wang, Haiyue
> -Original Message- > From: Ye, Xiaolong > Sent: Monday, October 14, 2019 16:25 > To: Wang, Haiyue > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] net/ice: avoid the parsed devargs value > being overwritten > > On 10/09, Haiyue Wang wrote: > >If the default dev args 'proto_xtr'

Re: [dpdk-dev] [PATCH v2 1/3] examples/ipsec-secgw: set default to IPsec library mode

2019-10-14 Thread Nicolau, Radu
On 10/1/2019 4:17 PM, Bernard Iremonger wrote: Set the default code path to librte_ipsec mode. Add parameter 0 | 1 to -l option and update error message. Check for conflicting options, -w -a -e and reassembly options are not supported in legacy mode. Show fragment table size. Update print_usage

  1   2   3   >