On 9/26/2019 3:54 PM, Haiyue Wang wrote:
> v1 -> v2:
>       1). Change the return type of dev_ops callback from 'void' to
>           'int'.
>       2). Update the ice/i40 PMD patches with clear git commit log.
> 
> RFCv3 -> v1:
>       https://patchwork.dpdk.org/patch/59103/
>       https://patchwork.dpdk.org/patch/59104/
>       https://patchwork.dpdk.org/patch/59105/
>       https://patchwork.dpdk.org/patch/59106/
>       1). Use the function 'rte_bsf64' to iterate the options for
>           getting the name.
> 
> Haiyue Wang (4):
>   ethdev: add the API for getting burst mode information
>   net/i40e: add Rx/Tx burst mode get callbacks
>   net/ice: add Rx/Tx burst mode get callbacks
>   app/testpmd: show the Rx/Tx burst mode description

Hi Haiyue,

Overall lgtm, but what do you think adding a new feature to default.ini for
this, something like 'Burst mode info"?

And i40e and ixgbe patches can add this feature to the PMD .ini files.

Also please remind 'doc/guides/nics/features.rst' also needs to be updated with
default.ini update.

Thanks,
ferruh

Reply via email to