On 10/14/19 10:16 AM, Alfredo Cardigliano wrote:
Hi Stephen
yes, we were thinking of doing a single post for just that reason,
but Thomas recommended that we split it up.
I agree with Thomas that it is better to split it up.
What I don't understand from the list below is, for example,
why RSS goes before Rx/Tx handling. Ideally, it should be
no dead code in patches, the driver should be buildable
from patch #1 and subsequent patches should add more
and more functionality which is testable. Of course, it is
not always doable, for example when a base driver should
be added first, but it does not look so in this case.
Thank you
Alfredo
On 12 Oct 2019, at 17:28, Stephen Hemminger <step...@networkplumber.org> wrote:
On Sat, 12 Oct 2019 02:26:26 +0200
Alfredo Cardigliano <cardigli...@ntop.org> wrote:
The patch series provides an initial version of a
poll mode driver for Pensando network adapters.
The driver name is ionic.
---
Alfredo Cardigliano (17):
net/ionic: add skeleton
net/ionic: add hardware structures definitions
net/ionic: add log
net/ionic: register and initialize the adapter
net/ionic: add port management commands
net/ionic: add basic lif support
net/ionic: add doorbells
net/ionic: add adminq support
net/ionic: add notifyq support
net/ionic: add basic port operations
net/ionic: add RX filters support
net/ionic: net-ionic-add-flow-control-support
net/ionic: add RSS support
net/ionic: add RX and TX handling
net/ionic: add stats
net/ionic: add TX checksum support
net/ionic: read fw version
When adding a new driver, could you send it as
one unit, yes it is a big bit of code to review but
drippling it out in pieces doesn't make review easier.
