> On May 1, 2019, at 6:44 PM, Yongseok Koh wrote:
>
> Set RTE_PCI_DRV_IOVA_AS_VA to driver's drv_flags as device's IOMMU takes
> virtual address.
>
> Cc: sta...@dpdk.org
> Cc: Davide Caratti
>
> Signed-off-by: Yongseok Koh
> ---
Self nack.
pci_one_device_has_iova_va() checks RTE_KDRV_VFIO
Mellanox mlx4/5 PMD doesn't need to be detached from kernel driver and
attached to VFIO/UIO. Control path still goes through the existing kernel
drivers, which is mlx4_core/mlx5_core.
Cc: sta...@dpdk.org
Signed-off-by: Yongseok Koh
---
v2:
* add RTE_KDRV_NIC_MLX
drivers/bus/pci/linux/pci.c
Set RTE_PCI_DRV_IOVA_AS_VA to driver's drv_flags as device's IOMMU takes
virtual address.
Cc: sta...@dpdk.org
Signed-off-by: Yongseok Koh
---
v2:
* add RTE_KDRV_NIC_MLX
drivers/net/mlx4/mlx4.c | 4 ++--
drivers/net/mlx5/mlx5.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff -
Hi Suanming,
snipped
>
> /* true if x is a power of 2 */
> #define POWEROF2(x) x)-1) & (x)) == 0) @@ -413,6 +416,18 @@ struct
Can we use ` RTE_IS_POWER_OF_2(n) ' instead of ` POWEROF2`?
> parse_val { }
>
> static void
> +monitor_primary(void *arg __rte_unused) {
> + if (quit_signal
02/05/2019 09:43, Yongseok Koh:
> Mellanox mlx4/5 PMD doesn't need to be detached from kernel driver and
> attached to VFIO/UIO. Control path still goes through the existing kernel
> drivers, which is mlx4_core/mlx5_core.
The real change here is to handle RTE_PCI_DRV_IOVA_AS_VA
with Mellanox kerne
On 2019/5/2 16:04, Varghese, Vipin wrote:
Hi Suanming,
snipped
/* true if x is a power of 2 */
#define POWEROF2(x) x)-1) & (x)) == 0) @@ -413,6 +416,18 @@ struct
Can we use ` RTE_IS_POWER_OF_2(n) ' instead of ` POWEROF2`?
I'm sorry, but that line is not add by this patch this time.
When checking RTE_PCI_DRV_IOVA_AS_VA flag to determine IOVA mode,
pci_one_device_has_iova_va() returns true only if kernel driver of the
device is vfio. However, Mellanox mlx4/5 PMD doesn't need to be detached
from kernel driver and attached to VFIO/UIO. Control path still goes
through the existing
Set RTE_PCI_DRV_IOVA_AS_VA to driver's drv_flags as device's IOMMU takes
virtual address.
Cc: sta...@dpdk.org
Signed-off-by: Yongseok Koh
---
v3:
* no change
v2:
* add RTE_KDRV_NIC_MLX
drivers/net/mlx4/mlx4.c | 4 ++--
drivers/net/mlx5/mlx5.c | 4 ++--
2 files changed, 4 insertions(+), 4 del
01/05/2019 17:53, Bruce Richardson:
> Some fixes for the dependency checking of the kasumi and zuc PMDs, and an
> addition of meson support for snow3g which seems to have been overlooked
> previously.
>
> [Apologies for the late submission, but hopefully these can make it into
> 19.05]
>
> Bruce
On 02-May-19 9:32 AM, Suanming.Mou wrote:
On 2019/5/2 16:04, Varghese, Vipin wrote:
Hi Suanming,
snipped
/* true if x is a power of 2 */
#define POWEROF2(x) x)-1) & (x)) == 0) @@ -413,6 +416,18 @@ struct
Can we use ` RTE_IS_POWER_OF_2(n) ' instead of ` POWEROF2`?
I'm sorry, but tha
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Thursday, May 2, 2019 2:41 AM
> To: Ido Goshen ; Lu, Wenzhuo
>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] net/ixgbe: 10GBASE-T SFP+ copper support
>
>
>
> > -Original Message-
> > From: Ido Goshen [mailto:i...@cgstowerne
On 01-May-19 8:00 PM, Erik Gabriel Carrillo wrote:
The finalize function should free the memzone created in the init
function, rather than freeing the allocation the memzone references,
otherwise a memzone descriptor can be leaked.
Fixes: c0749f7096c7 ("timer: allow management in shared memory")
HI Suanming,
snipped
> >> /* true if x is a power of 2 */
> >> #define POWEROF2(x) x)-1) & (x)) == 0) @@ -413,6 +416,18 @@
> >> struct
> > Can we use ` RTE_IS_POWER_OF_2(n) ' instead of ` POWEROF2`?
>
> I'm sorry, but that line is not add by this patch this time.
>
> Maybe another commit
gcc 9 on Fedora 30 gives an error
"taking address of packed member may result in an
unaligned pointer value" warnings.
For clang builds this warning is already disabled,
so disable "-Waddress-of-packed-member" for gcc builds
also.
Snippet of build error:
...lib/librte_eal/linux/eal/eal_memalloc.c
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Suanming.Mou
> static void
> +monitor_primary(void *arg __rte_unused) {
> + if (quit_signal)
> + return;
> +
> + if (rte_eal_primary_proc_alive(NULL))
> + rte_eal_alarm_set(MO
> -Original Message-
> From: dev On Behalf Of Yongseok Koh
> Sent: Thursday, May 2, 2019 11:17 AM
> To: Honnappa Nagarahalli
> Cc: Jerin Jacob Kollanukkaran ; Shahaf Shuler
> ; Thomas Monjalon ;
> dev@dpdk.org; bruce.richard...@intel.com; Pavan Nikhilesh Bhagavatula
> ; Gavin Hu (Arm Tech
On Thu, May 2, 2019 at 11:33 AM Reshma Pattan
wrote:
> gcc 9 on Fedora 30 gives an error
> "taking address of packed member may result in an
> unaligned pointer value" warnings.
>
> For clang builds this warning is already disabled,
> so disable "-Waddress-of-packed-member" for gcc builds
> also.
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Tuesday, April 30, 2019 9:04 AM
> To: ys...@mellanox.com
> Cc: Jerin Jacob Kollanukkaran ;
> bruce.richard...@intel.com; Pavan Nikhilesh Bhagavatula
> ; Shahaf Shuler ;
> dev@dpdk.org; tho...@monjalon.net; Gavin Hu (Arm Technology C
When primary app exits, the residual running pdump will stop the
primary app to restart. Add pdump exits with primary support.
Signed-off-by: Suanming.Mou
---
V7:
* omit `else` in monitor_primary.
* add eixting due to primary is not alive message.
* add pdump.rst update.
app/pdump/main.c
Hi,
Thanks for the advises from you all.
The latest v7 patch has sent out.
Br,
Mou
On 2019/5/2 17:54, Pattan, Reshma wrote:
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Suanming.Mou
static void
+monitor_primary(void *arg __rte_unused) {
+ if
Recent patch [1] added, at the end of mlx5_dev_configure(), a call to
mlx5_proc_priv_init(), initializing process_private data of eth_dev.
This call is not reached if PMD is started with zero Rx queues.
In this case mlx5_dev_configure() returns earlier due to the check:
if (rxqs_n == priv->
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Suanming.Mou
> Sent: Thursday, May 2, 2019 1:35 PM
> To: dev@dpdk.org
> Cc: Varghese, Vipin ; Burakov, Anatoly
>
> Subject: [dpdk-dev] [PATCH v7] app/pdump: add pudmp exits with primary
> support
>
> When prima
As part of the documentation update on the changes made to the power
library for 19.05, information on SST-BF was added. This patch updates
the comment to clarify that a priority core is an SST-BF high
frequency core.
Signed-off-by: David Hunt
---
lib/librte_power/rte_power.h | 2 +-
1 file chan
The distributor sample application has been enhanced to be aware of
Intel SST-BF high frequency cores. Docs also contain a link to
the Intel SST-BF application note.
Signed-off-by: David Hunt
---
doc/guides/sample_app_ug/dist_app.rst | 20 +++-
1 file changed, 19 insertions(+), 1
In the Power Library, a new bit has been added to the mask returned by
rte_power_get_capabilities which indicates whether the core is an
Intel SST-BF high frequency core.
The Distributor sample app has also been enhanced to make use of SST-BF
cores, and pin relevant workloads to the higher frequen
https://bugs.dpdk.org/show_bug.cgi?id=264
Bug ID: 264
Summary: ring_pmd fails to properly release used port on 17.11
branch
Product: DPDK
Version: 17.11
Hardware: All
OS: All
Status: CONFIRMED
On 02-May-19 1:35 PM, Suanming.Mou wrote:
When primary app exits, the residual running pdump will stop the
primary app to restart. Add pdump exits with primary support.
Signed-off-by: Suanming.Mou
---
<...>
+ if (rte_eal_primary_proc_alive(NULL)) {
+ rte_eal_alarm_set(MO
Some NICs allow to timestamp packets, but do not support the full
PTP synchronization process. Hence, the value set in the mbuf
timestamp field is only the raw value of an internal clock.
To make sense of this value, one at least needs to be able to query
the current hardware clock value. This pat
Add rte_eth_read_clock to read the raw clock of a device.
The main use is to get the device clock conversion co-efficients to be
able to translate the raw clock of the timestamp field of the pkt mbuf
to a local synced time value.
This function was missing to allow users to convert the Rx timestam
Use rxtx callback to demonstrate a way to use rte_eth_read_clock to
convert the hardware timestamps to an amount of cycles.
This allows to get the amount of time the packet spent since its entry
in the device. While the regular latency only shows the latency from
when it entered the software stack
Implements support for read_clock for the mlx5 driver. mlx5 supports
hardware timestamp offload, setting packets timestamp field to the
device clock. rte_eth_read_clock allows to read the device's current
clock value and therefore compare values on similar time base.
See rxtx_callbacks for an exam
01/05/2019 21:50, Bruce Richardson:
> This set of changes fixes warnings seen when compiling DPDK on Fedora 30.
> In most cases these warnings appear to be false positives, which means we
> have the option to just disable the warning. Because the changes required
> to the code to silence the warnin
> -Original Message-
> From: Burakov, Anatoly
> Sent: Thursday, May 2, 2019 4:18 AM
> To: Carrillo, Erik G ; rsanf...@akamai.com;
> tho...@monjalon.net
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] timer: fix resource leak in finalize
>
> On 01-May-19 8:00 PM, Erik Gabriel Carrill
On Wed, May 1, 2019 at 9:50 PM Bruce Richardson
wrote:
> Printing a null pointer with %s is flagged as a warning by GCC 9, and
> should not be done. Replace the %s with the word "null" itself.
>
> Fixes: 828d51d8fc3e ("bus/fslmc: refactor scan and probe functions")
> Cc: shreyansh.j...@nxp.com
>
On Wed, May 1, 2019 at 9:50 PM Bruce Richardson
wrote:
> Compiling on Fedora 30, we get the following warning, causing build failure
> when Werror flag is set:
>
> ../drivers/net/ixgbe/ixgbe_rxtx.c:2141:14: warning: ‘nmb’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> 214
On Wed, May 1, 2019 at 9:51 PM Bruce Richardson
wrote:
> GCC9 gives warnings if the parameter passed to printf for "%s" could be
> NULL, so we need to add checks in some cases to ensure that is not the
> case.
>
> Fixes: 61c592a8d035 ("raw/skeleton: introduce skeleton rawdev driver")
> Cc: shreya
On Wed, May 1, 2019 at 9:51 PM Bruce Richardson
wrote:
> GCC9 gives warnings if the parameter passed to printf for "%s" could be
> NULL, so we need to add checks in some cases to ensure that is not the
> case.
>
> Fixes: 3298fa4853b8 ("raw/dpaa2_cmdif: introduce DPAA2 command interface
> driver")
On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon wrote:
> 01/05/2019 21:50, Bruce Richardson:
> > This set of changes fixes warnings seen when compiling DPDK on Fedora 30.
> > In most cases these warnings appear to be false positives, which means we
> > have the option to just disable the warning.
Ah, yes!
I'm so sorry that I have left the company today. It's not able to update the
patch now.
I think it will be done tomorrow.
Thanks again for your suggestions enriched that simple patch.
(May the reply on mobile phone won't break any mail formats)
---
From: Ferruh Yigit
Sent: Monday, March 25, 2019 9:58 PM
To: Jakub Grajciar; dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC v5] /net: memory interface (memif)
On 3/22/2019 11:57 AM, Jakub Grajciar wrote:
> Memory interface (memif), provides high performance
> p
Hi,
I will probably have a ton of comments about adding a new compilation tests,
and I think it is a bit late for such an addition.
However, all the fixes should go in 19.05.
26/04/2019 18:50, Bruce Richardson:
> The pkg-config file generated as part of the build of DPDK should allow
> applicatio
On Thu, 2019-05-02 at 14:38 +0200, Thomas Monjalon wrote:
> > +$ninja_cmd -C $build_path install
> > +
> > +pc_file=$(find $DESTDIR -name libdpdk.pc)
> > +PKG_CONFIG_PATH=$(dirname $pc_file) ; export PKG_CONFIG_PATH
> > +
> > +# rather than hacking our environment, just edit the .pc file
> > prefix
On 02-May-19 1:19 PM, Carrillo, Erik G wrote:
-Original Message-
From: Burakov, Anatoly
Sent: Thursday, May 2, 2019 4:18 AM
To: Carrillo, Erik G ; rsanf...@akamai.com;
tho...@monjalon.net
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] timer: fix resource leak in finalize
On 01-May-1
Thursday, May 2, 2019 12:08 PM, Yongseok Koh:
> Subject: [dpdk-dev] [PATCH v3 2/2] net/mlx: support IOVA VA mode
>
> Set RTE_PCI_DRV_IOVA_AS_VA to driver's drv_flags as device's IOMMU
> takes virtual address.
>
> Cc: sta...@dpdk.org
>
> Signed-off-by: Yongseok Koh
Acked-by: Shahaf Shuler
> -
26/04/2019 16:56, Bruce Richardson:
> On Wed, Apr 24, 2019 at 02:37:58PM +0100, Luca Boccassi wrote:
> > On Wed, 2019-04-24 at 13:31 +0100, Bruce Richardson wrote:
> > > On Wed, Apr 24, 2019 at 12:02:24PM +0100, Luca Boccassi wrote:
> > > > On Wed, 2019-04-24 at 11:41 +0100, Bruce Richardson wrote:
On Thu, May 02, 2019 at 03:11:10PM +0200, Thomas Monjalon wrote:
> 26/04/2019 16:56, Bruce Richardson:
> > On Wed, Apr 24, 2019 at 02:37:58PM +0100, Luca Boccassi wrote:
> > > On Wed, 2019-04-24 at 13:31 +0100, Bruce Richardson wrote:
> > > > On Wed, Apr 24, 2019 at 12:02:24PM +0100, Luca Boccassi
On Thu, May 02, 2019 at 02:38:49PM +0200, Thomas Monjalon wrote:
> Hi,
>
> I will probably have a ton of comments about adding a new compilation tests,
> and I think it is a bit late for such an addition.
> However, all the fixes should go in 19.05.
>
> 26/04/2019 18:50, Bruce Richardson:
> > The
On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote:
>On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon <[1]tho...@monjalon.net>
>wrote:
>
> 01/05/2019 21:50, Bruce Richardson:
> > This set of changes fixes warnings seen when compiling DPDK on
> Fedora 30.
> > I
On Thu, May 02, 2019 at 12:07:17PM +0200, David Marchand wrote:
> On Thu, May 2, 2019 at 11:33 AM Reshma Pattan
> wrote:
>
> > gcc 9 on Fedora 30 gives an error
> > "taking address of packed member may result in an
> > unaligned pointer value" warnings.
> >
> > For clang builds this warning is al
On Thu, May 2, 2019 at 3:26 PM Bruce Richardson
wrote:
> On Thu, May 02, 2019 at 12:07:17PM +0200, David Marchand wrote:
> > On Thu, May 2, 2019 at 11:33 AM Reshma Pattan
> > wrote:
> >
> > > gcc 9 on Fedora 30 gives an error
> > > "taking address of packed member may result in an
> > > unaligne
Just syntax change to reduce indentation, no functional change.
Signed-off-by: Ferruh Yigit
Acked-by: Bruce Richardson
---
config/x86/meson.build | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/config/x86/meson.build b/config/x86/meson.build
index 0a7bed75e..bb23771b
On Skylake platform, with native build, KNI kernel module crashes
because of the corrupted values passed to kernel module.
The corruption occurs because the userspace kni library works
unexpectedly. Compiler [1] is using AVX512 instructions and generated
binary is wrong [2].
It turned around gcc
On Thu, May 2, 2019 at 3:24 PM Bruce Richardson
wrote:
> On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote:
> >On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon <[1]
> tho...@monjalon.net>
> >wrote:
> >
> > 01/05/2019 21:50, Bruce Richardson:
> > > This set of changes
From: David Marchand [mailto:david.march...@redhat.com]
Sent: Thursday, May 2, 2019 2:31 PM
To: Richardson, Bruce
Cc: Pattan, Reshma ; dev
Subject: Re: [dpdk-dev] [PATCH] mk: disable warning with gcc 9 on Fedora 30
On Thu, May 2, 2019 at 3:26 PM Bruce Richardson
mailto:bruce.richard...@inte
The '-mno-avx512f' compiler flag is not passed to the compiler,
detection of the binutils and setting flags works fine, but the flag
itself not used by compiler.
Removing the interim 'march_opt' variable and using directly
'machine_args' and setting '-mno-avx512f' to 'machine_args'
Fixes: 566b4d7
On 5/2/2019 2:35 PM, Ferruh Yigit wrote:
> The '-mno-avx512f' compiler flag is not passed to the compiler,
> detection of the binutils and setting flags works fine, but the flag
> itself not used by compiler.
>
> Removing the interim 'march_opt' variable and using directly
> 'machine_args' and set
On Thu, May 02, 2019 at 03:32:20PM +0200, David Marchand wrote:
>On Thu, May 2, 2019 at 3:24 PM Bruce Richardson
><[1]bruce.richard...@intel.com> wrote:
>
> On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote:
> >On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon
>
> -Original Message-
> From: Burakov, Anatoly
> Sent: Thursday, May 2, 2019 8:04 AM
> To: Carrillo, Erik G ; rsanf...@akamai.com;
> tho...@monjalon.net
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] timer: fix resource leak in finalize
>
> On 02-May-19 1:19 PM, Carrillo, Erik G wro
On Thu, May 2, 2019 at 3:46 PM Bruce Richardson
wrote:
> On Thu, May 02, 2019 at 03:32:20PM +0200, David Marchand wrote:
> >On Thu, May 2, 2019 at 3:24 PM Bruce Richardson
> ><[1]bruce.richard...@intel.com> wrote:
> >
> > On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote
02/05/2019 15:21, Bruce Richardson:
> On Thu, May 02, 2019 at 02:38:49PM +0200, Thomas Monjalon wrote:
> > Hi,
> >
> > I will probably have a ton of comments about adding a new compilation tests,
> > and I think it is a bit late for such an addition.
> > However, all the fixes should go in 19.05.
On Thu, May 02, 2019 at 03:53:36PM +0200, David Marchand wrote:
>On Thu, May 2, 2019 at 3:46 PM Bruce Richardson
><[1]bruce.richard...@intel.com> wrote:
>
> On Thu, May 02, 2019 at 03:32:20PM +0200, David Marchand wrote:
> >On Thu, May 2, 2019 at 3:24 PM Bruce Richardson
>
On Thu, 2019-05-02 at 14:17 +0100, Bruce Richardson wrote:
> On Thu, May 02, 2019 at 03:11:10PM +0200, Thomas Monjalon wrote:
> > 26/04/2019 16:56, Bruce Richardson:
> > > On Wed, Apr 24, 2019 at 02:37:58PM +0100, Luca Boccassi wrote:
> > > > On Wed, 2019-04-24 at 13:31 +0100, Bruce Richardson wrot
Hi Dekel,
Monday, April 29, 2019 2:01 PM, Dekel Peled:
> Subject: [dpdk-dev] [PATCH 0/4] net/mlx5: code cleanup in rx and tx files
>
> During work on Rx feature I did some cleanup actions.
> This series includes those changes divided by their type.
Good cleanup.
I am basically OK w/ the series,
gcc 9 on Fedora 30 gives an error
"taking address of packed member may result in an
unaligned pointer value" for -Waddress-of-packed-member.
Report it as warning instead of error to fix the build.
Snippet of build before fix
...lib/librte_eal/linux/eal/eal_memalloc.c: In function ‘alloc_seg_walk’
On Thu, May 2, 2019 at 4:13 PM Reshma Pattan
wrote:
> gcc 9 on Fedora 30 gives an error
> "taking address of packed member may result in an
> unaligned pointer value" for -Waddress-of-packed-member.
>
> Report it as warning instead of error to fix the build.
>
> Snippet of build before fix
> ...l
On Thu, May 02, 2019 at 04:24:37PM +0200, David Marchand wrote:
>On Thu, May 2, 2019 at 4:13 PM Reshma Pattan
><[1]reshma.pat...@intel.com> wrote:
>
> gcc 9 on Fedora 30 gives an error
> "taking address of packed member may result in an
> unaligned pointer value" for -Waddre
On Thu, May 2, 2019 at 4:42 PM Bruce Richardson
wrote:
> On Thu, May 02, 2019 at 04:24:37PM +0200, David Marchand wrote:
> >On Thu, May 2, 2019 at 4:13 PM Reshma Pattan
> ><[1]reshma.pat...@intel.com> wrote:
> >
> > gcc 9 on Fedora 30 gives an error
> > "taking address of packed
On Thu, May 2, 2019 at 11:33 AM Reshma Pattan
wrote:
> gcc 9 on Fedora 30 gives an error
> "taking address of packed member may result in an
> unaligned pointer value" warnings.
>
> For clang builds this warning is already disabled,
> so disable "-Waddress-of-packed-member" for gcc builds
> also.
Reference to test/Makefile was forgotten when removing this file.
Reference to app/test/test_rcu* was forgotten when adding the files.
Fixes: a9de470cc7c0 ("test: move to app directory")
Fixes: b87089b0bb19 ("test/rcu: add API and functional tests")
Signed-off-by: Thomas Monjalon
---
MAINTAINER
During work on Rx feature I did some cleanup actions.
This series includes those changes divided by their type.
---
v2: change 2nd patch type to "fix"
---
Dekel Peled (4):
net/mlx5: remove unused functions
net/mlx5: fix missing validation of null pointer
net/mlx5: fix description of functio
Function mlx5_rxq_ibv_release() is called in several places.
Before each call except one, the input parameter is validated to make
sure it is not null.
This patch adds the missing validation where it is missing.
Fixes: af4f09f28294 ("net/mlx5: prefix all functions with mlx5")
Cc: sta...@dpdk.org
Functions implemented but never called:
mlx5_rxq_ibv_releasable()
mlx5_rxq_cleanup()
mlx5_txq_ibv_releasable()
Function declared but not implemented:
rxq_alloc_mprq_buf()
This patch removes these functions from code and header file.
Signed-off-by: Dekel Peled
---
drivers/net/mlx5/mlx5_rxq.c |
Multiple functions were declared in header file mlx5_rxtx.h,
inplemented in mlx5_rxq.c, and called only in mlx5_rxq.c.
This patch moves all these functions declarations into mlx5_rxq.c,
as static functions.
Some functions implementation was copied higher in the file to
precede the functions calls.
Return value of function mlx5_rxq_releasable() was not described
correctly in function description.
This patch updates the description to correctly describe the optional
return values.
Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values")
cc: sta...@dpdk.org
Signed-off-by: Dekel
02/05/2019 16:08, Luca Boccassi:
> On Thu, 2019-05-02 at 14:17 +0100, Bruce Richardson wrote:
> > On Thu, May 02, 2019 at 03:11:10PM +0200, Thomas Monjalon wrote:
> > > 26/04/2019 16:56, Bruce Richardson:
> > > > On Wed, Apr 24, 2019 at 02:37:58PM +0100, Luca Boccassi wrote:
> > > > > On Wed, 2019-
On Thu, May 02, 2019 at 05:11:30PM +0200, Thomas Monjalon wrote:
> 02/05/2019 16:08, Luca Boccassi:
> > On Thu, 2019-05-02 at 14:17 +0100, Bruce Richardson wrote:
> > > On Thu, May 02, 2019 at 03:11:10PM +0200, Thomas Monjalon wrote:
> > > > 26/04/2019 16:56, Bruce Richardson:
> > > > > On Wed, Apr
02/05/2019 17:30, Bruce Richardson:
> On Thu, May 02, 2019 at 05:11:30PM +0200, Thomas Monjalon wrote:
> > 02/05/2019 16:08, Luca Boccassi:
> > > On Thu, 2019-05-02 at 14:17 +0100, Bruce Richardson wrote:
> > > > On Thu, May 02, 2019 at 03:11:10PM +0200, Thomas Monjalon wrote:
> > > > > 26/04/2019
On Thu, May 02, 2019 at 05:38:17PM +0200, Thomas Monjalon wrote:
> 02/05/2019 17:30, Bruce Richardson:
> > On Thu, May 02, 2019 at 05:11:30PM +0200, Thomas Monjalon wrote:
> > > 02/05/2019 16:08, Luca Boccassi:
> > > > On Thu, 2019-05-02 at 14:17 +0100, Bruce Richardson wrote:
> > > > > On Thu, May
add a warning message when user sets port config all rxq value larger
than txq in interactive mode.
Signed-off-by: Herakliusz Lipiec
---
app/test-pmd/cmdline.c | 8
1 file changed, 8 insertions(+)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 5a10c5f38..94be3c6f8 1
02/05/2019 15:44, Ferruh Yigit:
> On 5/2/2019 2:35 PM, Ferruh Yigit wrote:
> > The '-mno-avx512f' compiler flag is not passed to the compiler,
> > detection of the binutils and setting flags works fine, but the flag
> > itself not used by compiler.
> >
> > Removing the interim 'march_opt' variable
02/05/2019 17:01, Thomas Monjalon:
> Reference to test/Makefile was forgotten when removing this file.
> Reference to app/test/test_rcu* was forgotten when adding the files.
>
> Fixes: a9de470cc7c0 ("test: move to app directory")
> Fixes: b87089b0bb19 ("test/rcu: add API and functional tests")
>
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt
> Sent: Thursday, May 2, 2019 12:18 PM
> To: dev@dpdk.org
> Cc: Hunt, David
> Subject: [dpdk-dev] [PATCH v1 1/3] doc/distributor: add SST-BF enhancement
> info
>
> The distributor sample application h
On 02-May-19 3:13 PM, Reshma Pattan wrote:
gcc 9 on Fedora 30 gives an error
"taking address of packed member may result in an
unaligned pointer value" for -Waddress-of-packed-member.
Report it as warning instead of error to fix the build.
Snippet of build before fix
...lib/librte_eal/linux/eal
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt
> Sent: Thursday, May 2, 2019 12:18 PM
> To: dev@dpdk.org
> Cc: Hunt, David
> Subject: [dpdk-dev] [PATCH v1 2/3] doc: add release note for power changes
>
> In the Power Library, a new bit has been a
02/05/2019 17:00, David Marchand:
> On Thu, May 2, 2019 at 11:33 AM Reshma Pattan
> wrote:
>
> > gcc 9 on Fedora 30 gives an error
> > "taking address of packed member may result in an
> > unaligned pointer value" warnings.
> >
> > For clang builds this warning is already disabled,
> > so disable
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hemant Agrawal
> Sent: Wednesday, April 24, 2019 12:45 PM
> To: dev@dpdk.org
> Cc: shreyansh.j...@nxp.com
> Subject: [dpdk-dev] [PATCH 4/5] doc: update the dpaaX platform guides
>
> Update the dpaa platform guid
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pallavi Kadam
> Sent: Tuesday, April 23, 2019 7:13 PM
> To: dev@dpdk.org
> Cc: Menon, Ranjit ; Kadam, Pallavi
>
> Subject: [dpdk-dev] [PATCH v2] doc: update release notes for windows
> support
>
Acked-by: Joh
> -Original Message-
> From: Rami Rosen [mailto:ramir...@gmail.com]
> Sent: Friday, April 12, 2019 11:27 AM
> To: dev@dpdk.org
> Cc: Trahe, Fiona ; akhil.go...@nxp.com; Mcnamara,
> John ; Kovacevic, Marko
> ; sta...@dpdk.org; Rami Rosen
>
> Subject: [PATCH V3] doc: add guideines for ini
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt
> Sent: Thursday, May 2, 2019 12:18 PM
> To: dev@dpdk.org
> Cc: Hunt, David
> Subject: [dpdk-dev] [PATCH v1 3/3] lib/power: clarify comment on priority
> core
>
> As part of the documentation update
Minutes 2 May 2019
--
Agenda:
* Release Dates
* RC2 status
* Subtrees
* OvS
* Conferences
* Opens
Participants:
* Debian
* Intel
* Mellanox
* RedHat
Release Dates
-
* v19.05 dates, RC3 date pushed to Friday, 3 May:
* RC3: *Friday, 3 May*
* RC4: Wednesday, 8 May
On 4/29/2019 6:31 PM, Herakliusz Lipiec wrote:
> When secondary to primary process synchronization occours
> there is no check for number of fds which could cause buffer overrun.
>
> Bugzilla ID: 252
> Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary")
> Cc: rasl...@mell
On 5/1/2019 7:02 PM, Yong Wang wrote:
> -Original Message-
> From: Mark Gillott
> Date: Wednesday, May 1, 2019 at 8:30 AM
> To: Yong Wang
> Cc: "dev@dpdk.org" , Mark Gillott
> Subject: [PATCH] net/vmxnet3: add VLAN filter capability
>
> The driver supports VLAN filtering, but the op
Split off from the previous set to test the pkg-config file, this set
includes only the fixes encountered during that work.
V4: Removed the changes to the test script and to hard-code the list of
example apps, so that only the more important patches are included.
V3: Minor style changes to pat
When we install dpdk onto a system, we want to put the examples into
the /usr/share/dpdk (or /usr/local/share) directory for reference.
Signed-off-by: Bruce Richardson
Acked-by: Luca Boccassi
---
examples/meson.build | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff
On freebsd we need to include sys/socket.h to get the definition of
AF_INET in order to compile.
Fixes: d5ceea4ab160 ("examples/l3fwd: format IP addresses for printing")
Signed-off-by: Bruce Richardson
Acked-by: Luca Boccassi
---
examples/l3fwd/l3fwd_lpm.c | 1 +
1 file changed, 1 insertion(+)
The post-install script to symlink the PMDs from their own PMD directory to
the regular lib directory (so they would be found by ld at runtime) was
using the "-r" flag to ln to create relative symlinks. This flag is
unsupported by ln on FreeBSD causing the ninja install step to fail.
Reworking the
If libbsd is enabled in DPDK, the strlcpy and strlcat functions in
rte_string_fns.h redirect to the varients in libbsd, only using the
fallbacks if it is not enabled. Therefore, if libbsd is enabled, it needs
to be called out as a DPDK dependency in the pkgconfig file.
To ensure that we don't have
> On May 2, 2019, at 8:01 AM, Dekel Peled wrote:
>
> Function mlx5_rxq_ibv_release() is called in several places.
> Before each call except one, the input parameter is validated to make
> sure it is not null.
>
> This patch adds the missing validation where it is missing.
>
> Fixes: af4f09f28
> On May 2, 2019, at 8:01 AM, Dekel Peled wrote:
>
> Functions implemented but never called:
> mlx5_rxq_ibv_releasable()
> mlx5_rxq_cleanup()
> mlx5_txq_ibv_releasable()
>
> Function declared but not implemented:
> rxq_alloc_mprq_buf()
>
> This patch removes these functions from code and head
> On May 2, 2019, at 8:01 AM, Dekel Peled wrote:
>
> Return value of function mlx5_rxq_releasable() was not described
> correctly in function description.
>
> This patch updates the description to correctly describe the optional
> return values.
>
> Fixes: a6d83b6a9209 ("net/mlx5: standardize
1 - 100 of 126 matches
Mail list logo
