Re: [dpdk-dev] [PATCH v6] app/pdump: add pudmp exits with primary support

[Suanming . Mou]

Hi,

Thanks for the advises from you all.

The latest v7 patch has sent out.

Br,

Mou

On 2019/5/2 17:54, Pattan, Reshma wrote:

-----Original Message-----
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Suanming.Mou

<snip>

  static void
+monitor_primary(void *arg __rte_unused) {
+       if (quit_signal)
+               return;
+
+       if (rte_eal_primary_proc_alive(NULL))
+               rte_eal_alarm_set(MONITOR_INTERVAL, monitor_primary,
NULL);
+       else
+               quit_signal = 1;
+}
+

Adding the log message saying primary existing so, secondary.. would be helpful 
here.
I am ok to have it as default behaviour.
As Vipin mentioned, can you also update the document doc/guides/tools/pdump.rst

Thanks,
Reshma