On Wed, May 1, 2019 at 9:51 PM Bruce Richardson <bruce.richard...@intel.com>
wrote:
> GCC9 gives warnings if the parameter passed to printf for "%s" could be
> NULL, so we need to add checks in some cases to ensure that is not the
> case.
>
> Fixes: 61c592a8d035 ("raw/skeleton: introduce skeleton rawdev driver")
> Cc: shreyansh.j...@nxp.com
>
> Signed-off-by: Bruce Richardson <bruce.richard...@intel.com>
> ---
> drivers/raw/skeleton_rawdev/skeleton_rawdev.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c
> b/drivers/raw/skeleton_rawdev/skeleton_rawdev.c
> index d7630fc69..63f2b9a09 100644
> --- a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c
> +++ b/drivers/raw/skeleton_rawdev/skeleton_rawdev.c
> @@ -705,6 +705,9 @@ skeleton_rawdev_probe(struct rte_vdev_device *vdev)
>
>
> name = rte_vdev_device_name(vdev);
> + if (name == NULL)
> + return -EINVAL;
> +
> /* More than one instance is not supported */
> if (skeldev_init_once) {
> SKELETON_PMD_ERR("Multiple instance not supported for %s",
> @@ -740,6 +743,8 @@ skeleton_rawdev_remove(struct rte_vdev_device *vdev)
> int ret;
>
> name = rte_vdev_device_name(vdev);
> + if (name == NULL)
> + return -1;
>
> SKELETON_PMD_INFO("Closing %s on NUMA node %d", name,
> rte_socket_id());
>
> --
> 2.21.0
>
Tested-by: David Marchand <david.march...@redhat.com>
--
David Marchand
