if reset but not reinit adminq, some operations in i40evf_dev_close()
like i40evf_dev_promiscuous_disable() and
i40evf_dev_allmulticast_disable() will result in failures.
Fixes: cae18d2b0fb4 ("net/i40e: add workaround promiscuous disable")
Signed-off-by: Zhirun Yan
Signed-off-by: Haiyue Wang
--
Negative test case for passing invalid count size to
rte_metrics_update_values() will pass if count value
is any value greater than 1 because set size wrt to
key id 1 is 1 and passing 0 as no of values to be
updated will not hit the ERANGE check.
Signed-off-by: Harman Kalra
---
Fixed the patch cr
Negative test case for passing invalid count size to
rte_metrics_update_values() will pass if count value
is any value greater than 1 because set size wrt to
key id 1 is 1 and passing 0 as no of values to be
updated will not hit the ERANGE check.
Signed-off-by: Harman Kalra
---
Fixed the patch cr
use case: if callback is used to receive message form socket,
and the message received is disconnect/error, this callback needs
to be unregistered, but cannot because it is still active.
With this patch it is possible to mark the callback to be
unregistered once the interrupt process is done with
Signed-off-by: Jakub Grajciar
---
config/common_base |5 +
config/common_linuxapp |1 +
drivers/net/Makefile|1 +
drivers/net/memif/Makefile | 29 +
drivers/net/memif/memif.h |
Hi,
we are interested to run DPDK 18.11 on POWER8 based server. I've read
the recent release notes update regarding P8 support. At the same time
after some playing I was able to run l2fwd with huge pages normally by
hacking following commits:
https://github.com/DPDK/dpdk/commit/284ae3e9ff9a
Signed-off-by: Jakub Grajciar
---
config/common_base |5 +
config/common_linuxapp |1 +
drivers/net/Makefile|1 +
drivers/net/memif/Makefile | 29 +
drivers/net/memif/memif.h |
On 09-Dec-18 8:14 AM, Asaf Sinai wrote:
Hi all,
Thanks for the detailed explanations!
So, what we understood from that, is the following (please correct, if it is
wrong):
Before 18.05 version:
- Dividing huge pages between NUMAs was based, by default, on Linux good will.
- Enforcing Linux to d
On Fri, Dec 07, 2018 at 05:24:20PM -0500, David Harton wrote:
> The zalloc and calloc functions do not actually zero the memory.
> Added memset to rte_zmalloc_socket() so allocated memory is cleared.
>
> Signed-off-by: David Harton
> ---
> lib/librte_eal/common/rte_malloc.c | 4 +++-
> 1 file ch
On Fri, Dec 07, 2018 at 04:01:26PM -0800, Jeff Shaw wrote:
> The __rte_hash_lookup_bulk() function returns void, and therefore
> should not return with an expression. This commit fixes the following
> compiler warning when attempting to compile with "-pedantic -std=c11".
>
> warning: ISO C forbi
On 10-Dec-18 10:06 AM, Jakub Grajciar wrote:
Signed-off-by: Jakub Grajciar
---
As a general comment, some description/cover letter would have been nice.
+
+ memif_msg_disconnect_t *d = &e->msg.disconnect;
+
+ e->msg.type = MEMIF_MSG_TYPE_DISCONNECT;
+ d->code = err_code;
+
On 10-Dec-18 10:26 AM, Bruce Richardson wrote:
On Fri, Dec 07, 2018 at 05:24:20PM -0500, David Harton wrote:
The zalloc and calloc functions do not actually zero the memory.
Added memset to rte_zmalloc_socket() so allocated memory is cleared.
Signed-off-by: David Harton
---
lib/librte_eal/co
On 07-Dec-18 8:10 PM, Seth Howell wrote:
When secondary process hotplugs memory, it sends a request
to primary, which then performs the real mmap() and sends
sync requests to all secondary processes. Upon receiving
such sync request, each secondary process will notify the
upper layers of hotplugg
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Burakov, Anatoly
> Sent: Monday, December 10, 2018 10:43 AM
> To: Jakub Grajciar ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [RFC v2] /net: memory interface (memif)
>
> On 10-Dec-18 10:06 AM, Jakub Grajciar wrote:
>
On 03-Dec-18 7:25 AM, Tone Zhang (Arm Technology China) wrote:
Hi all,
Could anyone please have a review and re-test the change?
Thanks a lot!
Br,
Tone
Tested with latest 18.11, all seems to work fine.
Tested-by: Anatoly Burakov
--
Thanks,
Anatoly
On 19-Nov-18 2:37 AM, tone.zhang wrote:
With a larger PAGE_SIZE it is possible for the MSI table to very
close to the end of the BAR s.t. when we align the start and end
of the MSI table to the PAGE_SIZE, the end offset of the MSI
table is out of the PCI BAR boundary.
This patch addresses the is
On 22-Nov-18 5:02 PM, David Hunt wrote:
vm_power_manager currently makes use of uint64_t masks to keep track of
cores in use, limiting use of the app to only being able to manage the
first 64 cores in a multi-core system. Many modern systems have core
counts greater than 64, so this limitation ne
> -Original Message-
> From: Yan, Zhirun
> Sent: Monday, December 10, 2018 10:09 PM
> To: dev@dpdk.org; Wang, Haiyue ; Zhang, Qi Z
>
> Cc: Yan, Zhirun
> Subject: [PATCH v4] net/i40e: fix VF/PF port close
>
> Port reset will call i40evf_uninit_vf() to release resource. It wants to call
On 22-Nov-18 5:02 PM, David Hunt wrote:
Increase the number of addressable cores from 64 to 256. Also remove the
warning that incresing this number beyond 64 will cause problems (because
of the previous use of uint64_t masks). Now this number can be increased
significantly without causing problem
On 22-Nov-18 5:02 PM, David Hunt wrote:
since we're moving to allowing greater than 64 cores, the mask functions
that use uint64_t to perform functions on a masked set of cores are no
longer feasable, so removing them.
Perhaps "needed" is a better word, rather than "feasible" :)
Please correct
> -Original Message-
> From: Yan, Zhirun
> Sent: Monday, December 10, 2018 9:32 PM
> To: dev@dpdk.org; Zhang, Qi Z ; Wang, Haiyue
>
> Cc: Yan, Zhirun
> Subject: [PATCH v1] net/i40e: remove redundant code in free queues.
>
> Before this patch, there are two functions that will clear RX
> -Original Message-
> From: Zhang, Qi Z
> Sent: Monday, December 10, 2018 20:36
> To: Yan, Zhirun ; dev@dpdk.org; Wang, Haiyue
>
> Subject: RE: [PATCH v1] net/i40e: remove redundant code in free queues.
>
>
>
> > -Original Message-
> > From: Yan, Zhirun
> > Sent: Monday, Decemb
On 22-Nov-18 5:02 PM, David Hunt wrote:
Extending the functionality to allow vms to power manage cores beyond 63.
Signed-off-by: David Hunt
---
examples/vm_power_manager/channel_manager.c | 59 -
examples/vm_power_manager/channel_manager.h | 30 ++-
examples/vm_p
> -Original Message-
> From: Yan, Zhirun
> Sent: Tuesday, December 11, 2018 12:05 AM
> To: dev@dpdk.org; Wang, Haiyue ; Zhang, Qi Z
>
> Cc: Yan, Zhirun
> Subject: [PATCH v1] net/i40e: avoid invalid operations after reset
>
> if reset but not reinit adminq, some operations in i40evf_de
> -Original Message-
> From: Wang, Haiyue
> Sent: Monday, December 10, 2018 8:47 PM
> To: Zhang, Qi Z ; Yan, Zhirun ;
> dev@dpdk.org
> Subject: RE: [PATCH v1] net/i40e: remove redundant code in free queues.
>
> > -Original Message-
> > From: Zhang, Qi Z
> > Sent: Monday, Decembe
> On Dec 10, 2018, at 4:06 AM, Jakub Grajciar wrote:
I do not like being the coding style police, but that is most of the comments
here and I will try to test this one later this week. Plus I am sure I missed
some style problems, if you have not read the coding style for DPDK please have
a
> On Dec 10, 2018, at 8:48 AM, Wiles, Keith wrote:
>
>
>
>> On Dec 10, 2018, at 4:06 AM, Jakub Grajciar wrote:
>
> I do not like being the coding style police, but that is most of the comments
> here and I will try to test this one later this week. Plus I am sure I missed
> some style pr
On Mon, 10 Dec 2018 11:45:37 +
"Burakov, Anatoly" wrote:
> > /* Skip this BAR */
> > + RTE_LOG(INFO, EAL, "Skipping BAR%d\n", bar_index);
> > return 0;
>
> I would perhaps make it a DEBUG rather than INFO.
And drop the comment...
On Thu, 29 Nov 2018 11:24:42 +0530
Nikhil Rao wrote:
>
> + /** Double precision RED queue weight support. When non-zero, this
> + * this parameter indicates that RED queue weight in double precision
> + * format is supported.
> + * @see struct rte_tm_red_params::wq_is_log2
>
On Mon, 10 Dec 2018 05:43:37 +
"Rao, Nikhil" wrote:
> > -Original Message-
> > From: Stephen Hemminger [mailto:step...@networkplumber.org]
> > Sent: Thursday, November 29, 2018 11:43 AM
> > To: Rao, Nikhil
> > Cc: Dumitrescu, Cristian ; Singh, Jasvinder
> > ; dev@dpdk.org
> > Subject
On 23-Nov-18 11:33 AM, Liang Ma wrote:
Previously, in order to use the power library, it was necessary
for the user to disable the intel_pstate driver by adding
“intel_pstate=disable” to the kernel command line for the system,
which causes the acpi_cpufreq driver to be loaded in its place.
This
Things I saw so far, probably not everything
> +
> +_Static_assert(sizeof(memif_msg_t) == 128, "Size of memif_msg_t must be
> 128");
> +
DPDK uses RTE_BUILD_BUG_ON for checks like this.
> diff --git a/drivers/net/memif/Makefile b/drivers/net/memif/Makefile
> new file mode 100644
> index 000
On 09-Dec-18 8:11 PM, David Harton wrote:
The zalloc and calloc functions do not actually zero the memory.
Added memset to rte_zmalloc_socket() so allocated memory is cleared.
Signed-off-by: David Harton
---
v2 Indented if clause
lib/librte_eal/common/rte_malloc.c | 5 -
1 file changed
On 05-Dec-18 2:50 AM, gfree.w...@vip.163.com wrote:
From: Gao Feng
When rte_eal_alarm_set failed, need to free the bundle mem in the
error handler of handle_primary_request and handle_secondary_request.
Signed-off-by: Gao Feng
---
Acked-by: Anatoly Burakov
--
Thanks,
Anatoly
On 05-Dec-18 6:19 AM, gfree.w...@vip.163.com wrote:
From: Gao Feng
Add the check for null peer pointer like the bundle pointer in the mp request
handler. They should follow same style. And add some logs for nomem cases.
Signed-off-by: Gao Feng
---
lib/librte_eal/common/hotplug_mp.c | 15 +++
> -Original Message-
> From: Zhang, Qi Z
> Sent: Monday, December 10, 2018 22:08
> To: Wang, Haiyue ; Yan, Zhirun
> ; dev@dpdk.org
> Subject: RE: [PATCH v1] net/i40e: remove redundant code in free queues.
>
>
>
> > -Original Message-
> > From: Wang, Haiyue
> > Sent: Monday, Decem
Hi Mattias,
Thanks for the review. Responses in-line:
> -Original Message-
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com]
> Sent: Sunday, December 9, 2018 1:17 PM
> To: Carrillo, Erik G ;
> jerin.ja...@caviumnetworks.com
> Cc: pbhagavat...@caviumnetworks.com; rsanf...@ak
On 11/22/2018 5:38 PM, Qi Zhang wrote:
> Move macswap workload to dedicate function, so we can further enable
> platform specific optimized version.
>
> Signed-off-by: Qi Zhang
<...>
> @@ -0,0 +1,40 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2018 Intel Corporation
> + */
On 11/22/2018 5:38 PM, Qi Zhang wrote:
> The patch optimizes the mac swap operation by taking advantage
> of SSE instructions, it only impacts x86 platform.
>
> Signed-off-by: Qi Zhang
<...>
> +
> +#include "macswap_common.h"
And empty line after include can be good.
> -Original Message-
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Saturday, December 1, 2018 2:23 PM
> To: Singh, Jasvinder
> Cc: dev@dpdk.org; Dumitrescu, Cristian ;
> Pattan, Reshma ; Rao, Nikhil
>
> Subject: Re: [dpdk-dev] [PATCH] mbuf: implement generic forma
Hi Reshma,
> -Original Message-
> From: Pattan, Reshma
> Sent: Friday, December 7, 2018 2:32 PM
> To: dev@dpdk.org; Dumitrescu, Cristian ;
> jerin.ja...@caviumnetworks.com; Singh, Jasvinder
>
> Cc: Pattan, Reshma
> Subject: [PATCH v2 2/3] eal: add new rte color definition
>
> Added new
These are patches for 19.02.
Hyong Youb Kim (4):
net/enic: release port upon close
net/enic: add handler to return firmware version string
net/enic: support multicast filtering
doc: update release notes for enic
doc/guides/nics/features/enic.ini | 3 +-
doc/guides/rel_notes/releas
Cisco VIC adapters run firmware. Add the fw_version_get handler to
help diagnostics.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
doc/guides/nics/features/enic.ini | 1 +
drivers/net/enic/base/vnic_dev.c | 26 ++
drivers/net/enic/enic_ethdev.c| 21
Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so rte_eth_dev_close() can
later free port resources including mac_addrs.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_ethdev.c | 2 ++
drivers/net/enic/enic_main.c | 4 +---
2 files changed, 3 insertions(+), 3 deletio
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
doc/guides/rel_notes/release_19_02.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/doc/guides/rel_notes/release_19_02.rst
b/doc/guides/rel_notes/release_19_02.rst
index a94fa86a7..4c789d2a9 100644
--- a/doc/guides/rel_notes/
The VIC hardware has 64 MAC filters per vNIC, which can be either
unicast or multicast. Use one half for unicast and the other half for
multicast, as the VIC kernel drivers for Linux and Windows do.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
doc/guides/nics/features/enic.ini | 2
On Thu, 2018-11-29 at 16:23 +, Luca Boccassi wrote:
> Hi all,
>
> Here is a list of patches targeted for LTS release 16.11.9. Please
> help review and test. The planned date for the final release is
> December the 10th.
> Before that, please shout if anyone has objections with these
> patches
Adding my colleague Yasufumi and Hiroyuki as CC.
We are waiting valuable advice from you.
Thanks in advance,
Hideyuki Yamashita
NTT TechnoCross
>
> Dear Thomas and all,
>
> I hope you all get safely back home after DPDK summit.
> (When I get back Japan, it is chilling. (start of winter))
>
>
> -Original Message-
> From: Wang, Haiyue
> Sent: Tuesday, December 11, 2018 1:00 AM
> To: Zhang, Qi Z ; Yan, Zhirun ;
> dev@dpdk.org
> Subject: RE: [PATCH v1] net/i40e: remove redundant code in free queues.
>
> > -Original Message-
> > From: Zhang, Qi Z
> > Sent: Monday, Decemb
> -Original Message-
> From: Zhang, Qi Z
> Sent: Tuesday, December 11, 2018 09:22
> To: Wang, Haiyue ; Yan, Zhirun
> ; dev@dpdk.org
> Subject: RE: [PATCH v1] net/i40e: remove redundant code in free queues.
>
>
>
> > -Original Message-
> > From: Wang, Haiyue
> > Sent: Tuesday, Dec
Hi Hyong,
Thanks for sharing the information a query 'is ENIC Poll Mode Driver is been
updated too?'(Section 16 under Network Interface Controller).
a. If yes is it ok to link the patchwork in comment section?
b. If no, will you be updating the documentation?
Thanks
Vipin Varghese
> -Orig
ping
On Wed, Nov 28, 2018 at 9:56 PM Tonghao Zhang wrote:
>
> In some case, we may create sched port dynamically,
> if err when creating so memory will leak.
>
> Signed-off-by: Tonghao Zhang
> ---
> lib/librte_sched/rte_sched.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_
This patch makes the configuration based on makefile and the
configuration based on meson to be the same.
Fixes: c6e536e38437 ("build: add more implementers IDs and PNs for ARM")
Cc: sta...@dpdk.org
Signed-off-by: Gavin Hu
Reviewed-by: Ruifeng Wang
Reviewed-by: Honnappa Nagarahalli
---
config
> -Original Message-
> From: Yigit, Ferruh
> Sent: Tuesday, December 11, 2018 1:44 AM
> To: Zhang, Qi Z ; Richardson, Bruce
> ; Wiles, Keith ; Ananyev,
> Konstantin
> Cc: dev@dpdk.org; Lu, Wenzhuo ; Iremonger, Bernard
> ; Yongseok Koh
> Subject: Re: [dpdk-dev] [PATCH v2 1/3] app/testpmd
> -Original Message-
> From: Zhang, Qi Z
> Sent: Monday, December 10, 2018 9:13 PM
> To: Yan, Zhirun ; dev@dpdk.org; Wang, Haiyue
>
> Subject: RE: [PATCH v1] net/i40e: avoid invalid operations after reset
>
>
>
> > -Original Message-
> > From: Yan, Zhirun
> > Sent: Tuesday, D
Move macswap workload to dedicate function, so we can further enable
platform specific optimized version.
Signed-off-by: Qi Zhang
---
app/test-pmd/macswap.c| 32 ++---
app/test-pmd/macswap.h| 40
app/test-pmd/macswap_co
Improved testpmd macswap performance for x86 by take advantage of SSE
instructions.
On a broadwell 1.6GHz sever with a i40e 25G NIC.
We abserve 17.7% performance improvement for testpmd's macswap test.
v2:
- replace PKT_TX_VLAN_PKT/PKT_TX_QINQ_PKT with PKT_TX_VLAN/PKT_TX_QINQ
- only set vlan / ou
The patch optimizes the mac swap operation by taking advantage
of SSE instructions, it only impacts x86 platform.
Signed-off-by: Qi Zhang
---
app/test-pmd/macswap.c| 4
app/test-pmd/macswap_common.h | 1 -
app/test-pmd/macswap_sse.h| 45
Do four packets macswap in same loop iterate to squeeze more
CPU cycles.
Signed-off-by: Qi Zhang
---
app/test-pmd/macswap_sse.h | 62 +-
1 file changed, 50 insertions(+), 12 deletions(-)
diff --git a/app/test-pmd/macswap_sse.h b/app/test-pmd/macswap_s
+ Bruce
> -Original Message-
> From: Gavin Hu
> Sent: Monday, December 10, 2018 9:56 PM
> To: dev@dpdk.org
> Cc: tho...@monjalon.net; jerin.ja...@caviumnetworks.com;
> hemant.agra...@nxp.com; Honnappa Nagarahalli
> ; Gavin Hu (Arm Technology China)
> ; sta...@dpdk.org
> Subject: [PATCH v1
>
> > > >
> > > > > > +
> > > > > > +/* Add a reader thread, running on an lcore, to the list of
> > > > > > +threads
> > > > > > + * reporting their quiescent state on a TQS variable.
> > > > > > + */
> > > > > > +int __rte_experimental
> > > > > > +rte_tqs_register_lcore(struct rte_tqs *v, unsig
> -Original Message-
> From: Yan, Zhirun
> Sent: Tuesday, December 11, 2018 1:32 PM
> To: Zhang, Qi Z ; dev@dpdk.org; Wang, Haiyue
>
> Subject: RE: [PATCH v1] net/i40e: avoid invalid operations after reset
>
>
>
> > -Original Message-
> > From: Zhang, Qi Z
> > Sent: Monday, D
Regards,
Asaf Penso
> -Original Message-
> From: Stephen Hemminger
> Sent: Thursday, December 6, 2018 11:44 PM
> To: Asaf Penso
> Cc: Adrien Mazarguil ; dev@dpdk.org;
> Shahaf Shuler ; Ori Kam ;
> Thomas Monjalon
> Subject: Re: [dpdk-dev] [PATCH] ethdev: add function to print a flow
General comment for the discussion.
I think it is important that all fields of all actions and items will be
printed.
This means that any modification to the rte_flow should also reflect
in this function.
Best,
Ori
> -Original Message-
> From: Asaf Penso
> Sent: Tuesday, December 11,
Hi,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jakub Grajciar
> Sent: Monday, December 10, 2018 10:07 AM
> To: dev@dpdk.org
> Cc: Jakub Grajciar
> Subject: [dpdk-dev] [RFC v2] /net: memory interface (memif)
Could you please add some explanation -
what for
65 matches
Mail list logo
