On Thu, 29 Nov 2018 11:24:42 +0530 Nikhil Rao <nikhil....@intel.com> wrote:
> > + /** Double precision RED queue weight support. When non-zero, this > + * this parameter indicates that RED queue weight in double precision > + * format is supported. > + * @see struct rte_tm_red_params::wq_is_log2 > + * @see struct rte_tm_red_params::wq_dp > + */ > + int cman_wred_wq_dp_supported; > + > + /** Negated log2 RED queue weight support. When non-zero, this > + * parameter indicates that RED queue weight in negated log2 format > + * is supported. > + * @see struct rte_tm_red_params::wq_is_log2 > + * @see struct rte_tm_red_params::wq_log2 > + */ > + int cman_wred_wq_log2_supported; > + One suggestion: Since these are flag values use u8. Takes less space. And maybe use pahole utility to find existing hole to put them in.
