> On Dec 10, 2018, at 8:48 AM, Wiles, Keith <keith.wi...@intel.com> wrote:
>
>
>
>> On Dec 10, 2018, at 4:06 AM, Jakub Grajciar <jgraj...@cisco.com> wrote:
>
> I do not like being the coding style police, but that is most of the comments
> here and I will try to test this one later this week. Plus I am sure I missed
> some style problems, if you have not read the coding style for DPDK please
> have a read.
>
> http://doc.dpdk.org/guides/contributing/coding_style.html
>
> One comment, why did you include all of the code to handle memif instead of
> including the libmemif.a from VPP. I worry if libmemif is changed then we
> have a breakage. I do not mind the PMD being standalone and I do like not
> having the dependence.
>
> As I did not dive into the code much it does look reasonable and I hope to
> give it a try later this week.
>>
A couple more items, do you plan on writing the documentation for the PMD and
provide an example program?
Regards,
Keith
