> -----Original Message-----
> From: Yan, Zhirun
> Sent: Monday, December 10, 2018 9:32 PM
> To: dev@dpdk.org; Zhang, Qi Z <qi.z.zh...@intel.com>; Wang, Haiyue
> <haiyue.w...@intel.com>
> Cc: Yan, Zhirun <zhirun....@intel.com>
> Subject: [PATCH v1] net/i40e: remove redundant code in free queues.
>
> Before this patch, there are two functions that will clear RX/TX queues
> number: rte_eth_dev_close() and i40e_dev_free_queues().
I agree with what the patch changed, but the commit log is not comprehensive.
I40e_dev_free_queues is not only in the path of rte_eth_dev_close but also
rte_eth_dev_reset.
So
For rte_eth_dev_close, its redundant because of duplication.
For rte_eth_dev_reset its redundant because of not necessary, since following
dev_configure is required after dev_reset and it will be updated correctly.
>
> This patch remove redundant code in i40e_dev_free_queues().
>
> Signed-off-by: Zhirun Yan <zhirun....@intel.com>
> Signed-off-by: Haiyue Wang <haiyue.w...@intel.com>
> ---
> drivers/net/i40e/i40e_rxtx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index
> e1152ff0e..cc953ad58 100644
> --- a/drivers/net/i40e/i40e_rxtx.c
> +++ b/drivers/net/i40e/i40e_rxtx.c
> @@ -2753,7 +2753,6 @@ i40e_dev_free_queues(struct rte_eth_dev *dev)
> i40e_dev_rx_queue_release(dev->data->rx_queues[i]);
> dev->data->rx_queues[i] = NULL;
> }
> - dev->data->nb_rx_queues = 0;
>
> for (i = 0; i < dev->data->nb_tx_queues; i++) {
> if (!dev->data->tx_queues[i])
> @@ -2761,7 +2760,6 @@ i40e_dev_free_queues(struct rte_eth_dev *dev)
> i40e_dev_tx_queue_release(dev->data->tx_queues[i]);
> dev->data->tx_queues[i] = NULL;
> }
> - dev->data->nb_tx_queues = 0;
> }
>
> #define I40E_FDIR_NUM_TX_DESC I40E_MIN_RING_DESC
> --
> 2.17.1
