Re: [dpdk-dev] [PATCH v2] net/i40e: remove keeping CRC configuration for VF

2018-09-27 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Thursday, September 27, 2018 10:13 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: [PATCH v2] net/i40e: remove keeping CRC configuration for VF > > Remove keeping CRC configuration since it's not supported by i40e VF. > > Signed-off

[dpdk-dev] [PATCH] app/proc-info:fix port mask parse bug

2018-09-27 Thread Li Han
parse_portmask return type is int,but global variable "enabled_port_mask" type is uint32_t.so in proc_info_parse_args function,when parse_portmask return -1,"enabled_port_mask" will get a huge value and "if (enabled_port_mask == 0)" will never happen. Signed-off-by: Li Han --- app/proc-info/main

Re: [dpdk-dev] [PATCH 00/20] base code update

2018-09-27 Thread Xing, Beilei
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qi Zhang > Sent: Tuesday, September 25, 2018 10:34 AM > To: Xing, Beilei > Cc: dev@dpdk.org; Yigit, Ferruh ; Zhang, Helin > ; Zhang, Qi Z > Subject: [dpdk-dev] [PATCH 00/20] base code update > > Update base co

[dpdk-dev] [PATCH] drivers/net/i40e/:remove i40e_nvmupd_command redundant code in function i40e_nvmupd_validate_command, when "cmd->data_size < 1" it'll return I40E_NVMUPD_INVALID, and in function "i4

2018-09-27 Thread Li Han
Signed-off-by: Li Han --- drivers/net/i40e/base/i40e_nvm.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c index c77dac0..5de22e4 100644 --- a/drivers/net/i40e/base/i40e_nvm.c +++ b/drivers/net/i40e/base/i40e_nvm.c @@ -86

[dpdk-dev] [PATCH] drivers/net/i40e/:remove i40e_nvmupd_command redundant code

2018-09-27 Thread Li Han
in function i40e_nvmupd_validate_command, when "cmd->data_size < 1" it'll return I40E_NVMUPD_INVALID,and in function "i40e_nvmupd_command" when "upd_cmd == I40E_NVMUPD_STATUS",it check "!cmd->data_size" again, but it's no need. Signed-off-by: Li Han --- drivers/net/i40e/base/i40e_nvm.c | 5 -

Re: [dpdk-dev] [PATCH v2 2/4] devargs: simplify parameters of removal function

2018-09-27 Thread Ophir Munk
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, September 27, 2018 12:48 AM > To: dev@dpdk.org > Cc: gaetan.ri...@6wind.com; Ophir Munk ; > qi.z.zh...@intel.com; ferruh.yi...@intel.com; ktray...@redhat.com > Subject: [PATCH v2 2/4] devargs: sim

Re: [dpdk-dev] [04/12] vhost: introduce postcopy's advise message

2018-09-27 Thread Ilya Maximets
On 26.09.2018 10:26, Maxime Coquelin wrote: > This patch opens a userfaultfd and sends it back to Qemu's > VHOST_USER_POSTCOPY_ADVISE request. > > Signed-off-by: Dr. David Alan Gilbert > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/vhost.h | 2 ++ > lib/librte_vhost/vhost_user.

Re: [dpdk-dev] [PATCH v2 2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug

2018-09-27 Thread Luca Boccassi
On Wed, 2018-09-19 at 13:57 +0100, Luca Boccassi wrote: > The vmxnet3 driver can't call back into dev_close(), and possibly > dev_stop(), in dev_uninit().  When dev_uninit() is called, anything > that those routines would want to clean up has already been released. > Further, for complete cleanup,

Re: [dpdk-dev] [PATCH v2 1/3] net/virtio: register/unregister intr handler on start/stop

2018-09-27 Thread Luca Boccassi
On Wed, 2018-09-19 at 13:57 +0100, Luca Boccassi wrote: > Register and unregister the virtio interrupt handler when the device > is > started and stopped. This allows a virtio device to be hotplugged or > unplugged. > > Fixes: c1f86306a026 ("virtio: add new driver") > Cc: sta...@dpdk.org > > Sign

[dpdk-dev] [PATCH v2] devtools: move forbidden tokens awk script to a separate file

2018-09-27 Thread Arnon Warshavsky
The awk code previously read inline in checkpatches.pl was using -d which is a bash option, while bash is not the default shell in all distributions. Now moved to be read from a separate file. Signed-off-by: Arnon Warshavsky --- v2 - place original comment in the awk file devtools/check-forbid

Re: [dpdk-dev] How to replace rte_eth_dev_attach with rte_eal_hotplug_add

2018-09-27 Thread Thomas Monjalon
27/09/2018 03:38, Hideyuki Yamashita: > Dear Thomas, > > Thanks for your answer. > It took me a little time to digest answer. > Please see inline. > > > > 21/09/2018 09:19, Hideyuki Yamashita: > > > Dear Gaetan and Thomas, > > > > > > Thanks for your answer. > > > Please see inline. > > > > >

[dpdk-dev] [PATCH v3] devtools: move forbidden tokens awk script to a separate file

2018-09-27 Thread Arnon Warshavsky
The awk code previously read inline in checkpatches.pl was using -d which is a bash option, while bash is not the default shell in all distributions. Now moved to be read from a separate file. Signed-off-by: Arnon Warshavsky Acked-by: Andrzej Ostruszka --- v2 - place original comment in the awk

Re: [dpdk-dev] [PATCH v2 2/3] kni: fix kni fifo synchronization

2018-09-27 Thread Phil Yang (Arm Technology China)
Thanks for your comments. I'll update it in the next version. > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, September 26, 2018 7:43 PM > To: Honnappa Nagarahalli ; Jerin Jacob > > Cc: Phil Yang (Arm Technology China) ; dev@dpdk.org; nd > ; kkokkilaga...@caviumnetworks.com

[dpdk-dev] [PATCH] doc: add known issue about legacy intr mode for ixgbe

2018-09-27 Thread Xiaoyun Li
When using uio_pci_generic module or using legacy interrupt mode of igb_uio or vfio, X550 cannot get interrupts. Because the Interrupt Status bit is not implemented, then the irq cannot be handled correctly and cannot report the event fd to DPDK apps. Add this hw limitation and details into ixgbe

Re: [dpdk-dev] [PATCH 04/12] vhost: introduce postcopy's advise message

2018-09-27 Thread Maxime Coquelin
On 09/26/2018 05:22 PM, Alejandro Lucero wrote: On Wed, Sep 26, 2018 at 8:27 AM Maxime Coquelin mailto:maxime.coque...@redhat.com>> wrote: This patch opens a userfaultfd and sends it back to Qemu's VHOST_USER_POSTCOPY_ADVISE request. Signed-off-by: Dr. David Alan Gilbert mail

Re: [dpdk-dev] [PATCH 06/12] vhost: register new regions with userfaultfd

2018-09-27 Thread Maxime Coquelin
On 09/26/2018 05:31 PM, Alejandro Lucero wrote: On Wed, Sep 26, 2018 at 8:28 AM Maxime Coquelin mailto:maxime.coque...@redhat.com>> wrote: Signed-off-by: Dr. David Alan Gilbert mailto:dgilb...@redhat.com>> Signed-off-by: Maxime Coquelin mailto:maxime.coque...@redhat.com>> ---

[dpdk-dev] [PATCH 0/2] remove unnecessary call of rte intr enable

2018-09-27 Thread Xiaoyun Li
Since rte_intr_enable is called at init and start time. Remove it in interrupt_action function to avoid too many system calls. Xiaoyun Li (2): net/ixgbe: remove unnecessary call of rte intr enable net/i40e: remove unnecessary call of rte intr enable drivers/net/i40e/i40e_ethdev.c | 1 - dr

[dpdk-dev] [PATCH 2/2] net/i40e: remove unnecessary call of rte intr enable

2018-09-27 Thread Xiaoyun Li
Since rte_intr_enable is called at init and start time. Remove it in interrupt_action function to avoid too many system calls. Signed-off-by: Xiaoyun Li --- drivers/net/i40e/i40e_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_et

[dpdk-dev] [PATCH 1/2] net/ixgbe: remove unnecessary call of rte intr enable

2018-09-27 Thread Xiaoyun Li
Since rte_intr_enable is called at init and start time. Remove it in interrupt_action function to avoid too many system calls. Signed-off-by: Xiaoyun Li --- drivers/net/ixgbe/ixgbe_ethdev.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethde

Re: [dpdk-dev] How to replace rte_eth_dev_attach with rte_eal_hotplug_add

2018-09-27 Thread Hideyuki Yamashita
Dear Thomas, Thansk for your answer. Please see inline. > 27/09/2018 03:38, Hideyuki Yamashita: > > Dear Thomas, > > > > Thanks for your answer. > > It took me a little time to digest answer. > > Please see inline. > > > > > > > 21/09/2018 09:19, Hideyuki Yamashita: > > > > Dear Gaetan and Tho

[dpdk-dev] [PATCH v6 00/21] Support externally allocated memory in DPDK

2018-09-27 Thread Anatoly Burakov
This is a proposal to enable using externally allocated memory in DPDK. In a nutshell, here is what is being done here: - Index internal malloc heaps by NUMA node index, rather than NUMA node itself (external heaps will have ID's in order of creation) - Add identifier string to malloc heap, to

[dpdk-dev] [PATCH v6 09/21] malloc: add function to query socket ID of named heap

2018-09-27 Thread Anatoly Burakov
When we will be creating external heaps, they will have their own "fake" socket ID, so add a function that will map the heap name to its socket ID. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 14 lib/librte_eal/common/rte_malloc.c | 37 +++

[dpdk-dev] [PATCH v6 04/21] mem: do not check for invalid socket ID

2018-09-27 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. This changes the semantics of what we understand by "socket ID", so document the change in the release

[dpdk-dev] [PATCH v6 07/21] sched: do not check for invalid socket ID

2018-09-27 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. Signed-off-by: Anatoly Burakov --- lib/librte_sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(

[dpdk-dev] [PATCH v6 13/21] malloc: allow adding memory to named heaps

2018-09-27 Thread Anatoly Burakov
Add an API to add externally allocated memory to malloc heap. The memory will be stored in memseg lists like regular DPDK memory. Multiple segments are allowed within a heap. If IOVA table is not provided, IOVA addresses are filled in with RTE_BAD_IOVA. Signed-off-by: Anatoly Burakov --- lib/lib

[dpdk-dev] [PATCH v6 10/21] malloc: add function to check if socket is external

2018-09-27 Thread Anatoly Burakov
An API is needed to check whether a particular socket ID belongs to an internal or external heap. Prime user of this would be mempool allocator, because normal assumptions of IOVA contiguousness in IOVA as VA mode do not hold in case of externally allocated memory. Signed-off-by: Anatoly Burakov

[dpdk-dev] [PATCH v6 08/21] malloc: add name to malloc heaps

2018-09-27 Thread Anatoly Burakov
We will need to refer to external heaps in some way. While we use heap ID's internally, for external API use it has to be something more user-friendly. So, we will be using a string to uniquely identify a heap. Signed-off-by: Anatoly Burakov --- doc/guides/rel_notes/release_18_11.rst |

[dpdk-dev] [PATCH v6 14/21] malloc: allow removing memory from named heaps

2018-09-27 Thread Anatoly Burakov
Add an API to remove memory from specified heaps. This will first check if all elements within the region are free, and that the region is the original region that was added to the heap (by comparing its length to length of memory addressed by the underlying memseg list). Signed-off-by: Anatoly Bu

[dpdk-dev] [PATCH v6 12/21] malloc: allow destroying heaps

2018-09-27 Thread Anatoly Burakov
Add an API to destroy specified heap. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 23 + lib/librte_eal/common/malloc_heap.c| 22 lib/librte_eal/common/malloc_heap.h| 3 ++ lib/librte_eal/common/rte_malloc.c | 58 ++

[dpdk-dev] [PATCH v6 01/21] mem: add length to memseg list

2018-09-27 Thread Anatoly Burakov
Previously, to calculate length of memory area covered by a memseg list, we would've needed to multiply page size by length of fbarray backing that memseg list. This is not obvious and unnecessarily low level, so store length in the memseg list itself. Signed-off-by: Anatoly Burakov --- drivers/

[dpdk-dev] [PATCH v6 18/21] test: add unit tests for external memory support

2018-09-27 Thread Anatoly Burakov
Add simple unit tests to test external memory support. The tests are pretty basic and mostly consist of checking if invalid API calls are handled correctly, plus a simple allocation/deallocation test for malloc and memzone. Signed-off-by: Anatoly Burakov --- test/test/Makefile| 1 +

[dpdk-dev] [PATCH v6 11/21] malloc: allow creating malloc heaps

2018-09-27 Thread Anatoly Burakov
Add API to allow creating new malloc heaps. They will be created with socket ID's going above RTE_MAX_NUMA_NODES, to avoid clashing with internal heaps. Signed-off-by: Anatoly Burakov --- doc/guides/rel_notes/release_18_11.rst| 2 + .../common/include/rte_eal_memconfig.h| 3 ++

[dpdk-dev] [PATCH v6 15/21] malloc: allow attaching to external memory chunks

2018-09-27 Thread Anatoly Burakov
In order to use external memory in multiple processes, we need to attach to primary process's memseg lists, so add a new API to do that. It is the responsibility of the user to ensure that memory is accessible and that it has been previously added to the malloc heap by another process. Signed-off-

[dpdk-dev] [PATCH v6 16/21] malloc: allow detaching from external memory

2018-09-27 Thread Anatoly Burakov
Add API to detach from existing chunk of external memory in a process. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 27 +++ lib/librte_eal/common/rte_malloc.c | 31 +- lib/librte_eal/rte_eal_version.map | 1 +

[dpdk-dev] [PATCH v6 05/21] flow_classify: do not check for invalid socket ID

2018-09-27 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. Signed-off-by: Anatoly Burakov --- lib/librte_flow_classify/rte_flow_classify.c | 3 +-- 1 file chan

[dpdk-dev] [PATCH v6 19/21] app/testpmd: add support for external memory

2018-09-27 Thread Anatoly Burakov
Currently, mempools can only be allocated either using native DPDK memory, or anonymous memory. This patch will add two new methods to allocate mempool using external memory (regular or hugepage memory), and add documentation about it to testpmd user guide. It adds a new flag "--mp-alloc", with fo

[dpdk-dev] [PATCH v6 21/21] doc: add external memory feature to programmer's guide

2018-09-27 Thread Anatoly Burakov
Add a short chapter on usage of external memory in DPDK to the Programmer's Guide. Signed-off-by: Anatoly Burakov --- .../prog_guide/env_abstraction_layer.rst | 37 +++ 1 file changed, 37 insertions(+) diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst b/doc/guid

[dpdk-dev] [PATCH v6 17/21] malloc: enable event callbacks for external memory

2018-09-27 Thread Anatoly Burakov
When adding or removing external memory from the memory map, there may be actions that need to be taken on account of this memory (e.g. DMA mapping). Add support for triggering callbacks when adding, removing, attaching or detaching external memory. Some memory event callback handlers will need ad

[dpdk-dev] [PATCH v6 20/21] doc: add external memory feature to the release notes

2018-09-27 Thread Anatoly Burakov
Document the addition of external memory support to DPDK. Signed-off-by: Anatoly Burakov --- doc/guides/rel_notes/release_18_11.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst index 5065ec1af..4248ff4f9

[dpdk-dev] [PATCH v6 06/21] pipeline: do not check for invalid socket ID

2018-09-27 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. Signed-off-by: Anatoly Burakov --- lib/librte_pipeline/rte_pipeline.c | 3 +-- 1 file changed, 1 ins

[dpdk-dev] [PATCH v6 03/21] malloc: index heaps using heap ID rather than NUMA node

2018-09-27 Thread Anatoly Burakov
Switch over all parts of EAL to use heap ID instead of NUMA node ID to identify heaps. Heap ID for DPDK-internal heaps is NUMA node's index within the detected NUMA node list. Heap ID for external heaps will be order of their creation. Signed-off-by: Anatoly Burakov --- config/common_base

[dpdk-dev] [PATCH] kni: add IOVA va support for kni

2018-09-27 Thread Kiran Kumar
With current KNI implementation kernel module will work only in IOVA=PA mode. This patch will add support for kernel module to work with IOVA=VA mode. The idea is to maintain a mapping in KNI module between user pages and kernel pages and in fast path perform a lookup in this table and get the ker

[dpdk-dev] [PATCH v6 02/21] mem: allow memseg lists to be marked as external

2018-09-27 Thread Anatoly Burakov
When we allocate and use DPDK memory, we need to be able to differentiate between DPDK hugepage segments and segments that were made part of DPDK but are externally allocated. Add such a property to memseg lists. This breaks the ABI, so bump the EAL library ABI version and document the change in r

Re: [dpdk-dev] [PATCH v2 1/3] net/virtio: register/unregister intr handler on start/stop

2018-09-27 Thread Maxime Coquelin
On 09/27/2018 10:40 AM, Luca Boccassi wrote: On Wed, 2018-09-19 at 13:57 +0100, Luca Boccassi wrote: Register and unregister the virtio interrupt handler when the device is started and stopped. This allows a virtio device to be hotplugged or unplugged. Fixes: c1f86306a026 ("virtio: add new d

Re: [dpdk-dev] [PATCH] kni: add IOVA va support for kni

2018-09-27 Thread Burakov, Anatoly
On 27-Sep-18 11:49 AM, Kiran Kumar wrote: With current KNI implementation kernel module will work only in IOVA=PA mode. This patch will add support for kernel module to work with IOVA=VA mode. The idea is to maintain a mapping in KNI module between user pages and kernel pages and in fast path pe

Re: [dpdk-dev] [PATCH v6 02/21] mem: allow memseg lists to be marked as external

2018-09-27 Thread Shreyansh Jain
On Thursday 27 September 2018 04:10 PM, Anatoly Burakov wrote: When we allocate and use DPDK memory, we need to be able to differentiate between DPDK hugepage segments and segments that were made part of DPDK but are externally allocated. Add such a property to memseg lists. This breaks the ABI,

Re: [dpdk-dev] [PATCH v6 01/21] mem: add length to memseg list

2018-09-27 Thread Shreyansh Jain
On Thursday 27 September 2018 04:10 PM, Anatoly Burakov wrote: Previously, to calculate length of memory area covered by a memseg list, we would've needed to multiply page size by length of fbarray backing that memseg list. This is not obvious and unnecessarily low level, so store length in the m

Re: [dpdk-dev] [PATCH v6 02/21] mem: allow memseg lists to be marked as external

2018-09-27 Thread Burakov, Anatoly
On 27-Sep-18 12:03 PM, Shreyansh Jain wrote: On Thursday 27 September 2018 04:10 PM, Anatoly Burakov wrote: When we allocate and use DPDK memory, we need to be able to differentiate between DPDK hugepage segments and segments that were made part of DPDK but are externally allocated. Add such a p

Re: [dpdk-dev] [PATCH v6 02/21] mem: allow memseg lists to be marked as external

2018-09-27 Thread Shreyansh Jain
On Thursday 27 September 2018 04:38 PM, Burakov, Anatoly wrote: On 27-Sep-18 12:03 PM, Shreyansh Jain wrote: On Thursday 27 September 2018 04:10 PM, Anatoly Burakov wrote: When we allocate and use DPDK memory, we need to be able to differentiate between DPDK hugepage segments and segments that

Re: [dpdk-dev] [PATCH v2 1/3] net/virtio: register/unregister intr handler on start/stop

2018-09-27 Thread Maxime Coquelin
On 09/19/2018 02:57 PM, Luca Boccassi wrote: Register and unregister the virtio interrupt handler when the device is started and stopped. This allows a virtio device to be hotplugged or unplugged. Fixes: c1f86306a026 ("virtio: add new driver") Cc: sta...@dpdk.org Signed-off-by: Brian Russell

Re: [dpdk-dev] [PATCH v2 2/2] test/event: add adapter tests to meson build

2018-09-27 Thread Bruce Richardson
On Thu, Sep 27, 2018 at 11:16:15AM +0530, Nikhil Rao wrote: > Add tests for event eth Rx, crypto and timer adapters to > meson build > > Cc: Abhinandan Gujjar > Cc: Erik G. Carrillo > > Signed-off-by: Nikhil Rao > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v2 1/2] test: fix event timer compiler warning

2018-09-27 Thread Bruce Richardson
On Thu, Sep 27, 2018 at 11:16:14AM +0530, Nikhil Rao wrote: > Limit the number of objects passed to rte_mempool_put_bulk() > to the size of the object table. This fix eliminates a compiler > warning (array-bounds) triggered when the march command line > parameter to gcc is set to nehalem. > > Fixe

Re: [dpdk-dev] [PATCH v2 5/7] hash: add extendable bucket feature

2018-09-27 Thread Bruce Richardson
On Thu, Sep 27, 2018 at 04:23:48AM +, Honnappa Nagarahalli wrote: > > > > -Original Message- > > From: Yipeng Wang > > Sent: Friday, September 21, 2018 12:18 PM > > To: bruce.richard...@intel.com > > Cc: dev@dpdk.org; yipeng1.w...@intel.com; mic...@digirati.com.br; > > Honnappa Nagar

Re: [dpdk-dev] [PATCH v3 1/5] test/hash: fix bucket size in hash perf test

2018-09-27 Thread Bruce Richardson
On Wed, Sep 26, 2018 at 05:54:21AM -0700, Yipeng Wang wrote: > The bucket size was changed from 4 to 8 but the corresponding > perf test was not changed accordingly. > > In the test, the bucket size and number of buckets are used > to map to the underneath rte_hash structure. They are used > to te

[dpdk-dev] [PATCH v3 2/2] net/tap: add queues when attaching from secondary process

2018-09-27 Thread Raslan Darawsheh
In the case the device is created by the primary process, the secondary must request some file descriptors to attach the queues. The file descriptors are shared via IPC Unix socket. Thanks to the IPC synchronization, the secondary process is now able to do Rx/Tx on a TAP created by the primary pro

Re: [dpdk-dev] [PATCH v3 3/5] test/hash: fix rw test with non-consecutive cores

2018-09-27 Thread Bruce Richardson
On Wed, Sep 26, 2018 at 05:54:23AM -0700, Yipeng Wang wrote: > the multi-reader and multi-writer rte_hash unit test does not > work correctly with non-consicutive core ids. This commit ^^ typo, forgot to mention on previous review > fixes the issue. > > Fixes: 0eb37

[dpdk-dev] [PATCH v3 1/2] net/tap: change queue fd to be pointers to process private

2018-09-27 Thread Raslan Darawsheh
change the fds for the queues to be pointers and add new process private structure and make the queue fds point to it. Signed-off-by: Raslan Darawsheh --- drivers/net/tap/rte_eth_tap.c | 63 --- drivers/net/tap/rte_eth_tap.h | 9 +-- drivers/net/tap/t

[dpdk-dev] [PATCH] examples/client_server_mp: add sigint handler to server

2018-09-27 Thread Raslan Darawsheh
add sigint handler in the server application to stop and close ports Signed-off-by: Raslan Darawsheh --- .../multi_process/client_server_mp/mp_server/main.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/examples/multi_process/client_server_mp/mp_serve

Re: [dpdk-dev] [PATCH v3 4/5] test/hash: fix missing file in meson build file

2018-09-27 Thread Bruce Richardson
On Wed, Sep 26, 2018 at 05:54:24AM -0700, Yipeng Wang wrote: > The test_hash_readwrite.c was not in the meson.build file. This > commit adds the missing test into the file. > > Fixes: 0eb3726ebcf1 ("test/hash: add test for read/write concurrency") > Cc: sta...@dpdk.org > > Signed-off-by: Yipeng W

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-09-27 Thread Justin He
> -Original Message- > From: Gavin Hu (Arm Technology China) > Sent: 2018年9月26日 17:29 > To: Gavin Hu (Arm Technology China) ; dev@dpdk.org > Cc: Honnappa Nagarahalli ; Steve Capper > ; Ola Liljedahl ; > jerin.ja...@caviumnetworks.com; nd ; sta...@dpdk.org; Justin > He > Subject: RE: [PA

Re: [dpdk-dev] [PATCH v3 3/3] ring: move the atomic load of head above the loop

2018-09-27 Thread Justin He
> -Original Message- > From: Gavin Hu (Arm Technology China) > Sent: 2018年9月26日 17:30 > To: Gavin Hu (Arm Technology China) ; dev@dpdk.org > Cc: Honnappa Nagarahalli ; Steve Capper > ; Ola Liljedahl ; > jerin.ja...@caviumnetworks.com; nd ; sta...@dpdk.org; Justin > He > Subject: RE: [PA

Re: [dpdk-dev] [PATCH 1/2] compress/qat: fix for zero checksum on decompression

2018-09-27 Thread Jozwiak, TomaszX
> -Original Message- > From: Fiona Trahe > Date: Sat, 22 Sep 2018 14:25:37 +0100 > Subject: [dpdk-dev] [PATCH 1/2] compress/qat: fix for zero checksum on > decompression > To: dev@dpdk.org > CC: akhil.go...@nxp.com, sta...@dpdk.org, Fiona Trahe > > > Checksum was always 0 on QAT decompr

Re: [dpdk-dev] [PATCH v3 2/3] ring: synchronize the load and store of the tail

2018-09-27 Thread Justin He
Hi Gavin > -Original Message- > From: Gavin Hu (Arm Technology China) > Sent: 2018年9月26日 17:30 > To: Gavin Hu (Arm Technology China) ; dev@dpdk.org > Cc: Honnappa Nagarahalli ; Steve Capper > ; Ola Liljedahl ; > jerin.ja...@caviumnetworks.com; nd ; sta...@dpdk.org; Justin > He > Subject:

Re: [dpdk-dev] [PATCH] examples/client_server_mp: add sigint handler to server

2018-09-27 Thread Bruce Richardson
On Thu, Sep 27, 2018 at 02:21:52PM +0300, Raslan Darawsheh wrote: > add sigint handler in the server application to stop and close ports > > Signed-off-by: Raslan Darawsheh > --- > .../multi_process/client_server_mp/mp_server/main.c | 17 > +++-- > 1 file changed, 15 insertions(

[dpdk-dev] [PATCH] ethdev: add field for device data per process

2018-09-27 Thread Alejandro Lucero
Primary and secondary processes share a per-device private data. With current design it is not possible to have data per-device per-process. This is required for handling properly the CPP interface inside the NFP PMD with multiprocess support. There is also at least another PMD driver, tap, with s

[dpdk-dev] [PATCH v2] examples/client_server_mp: add sigint handler to server

2018-09-27 Thread Raslan Darawsheh
add sigint handler in the server application to stop and close ports Signed-off-by: Raslan Darawsheh --- v2: - fix includes order --- --- examples/multi_process/client_server_mp/mp_server/main.c | 13 + 1 file changed, 13 insertions(+) diff --git a/examples/multi_process/cl

Re: [dpdk-dev] [PATCH v2 5/7] hash: add extendable bucket feature

2018-09-27 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Thursday, September 27, 2018 12:15 PM > To: Honnappa Nagarahalli > Cc: Wang, Yipeng1 ; dev@dpdk.org; > mic...@digirati.com.br > Subject: Re: [dpdk-dev] [PATCH v2 5/7] hash: add extendab

Re: [dpdk-dev] [PATCH 2/2] compress/qat: remove unnecessary assignment

2018-09-27 Thread Jozwiak, TomaszX
> -Original Message- > From: Fiona Trahe > Date: Sat, 22 Sep 2018 14:25:38 +0100 > Subject: [dpdk-dev] [PATCH 2/2] compress/qat: remove unnecessary > assignment > To: dev@dpdk.org > CC: akhil.go...@nxp.com, sta...@dpdk.org, Fiona Trahe > > > Same variable was assigned twice, remove one.

Re: [dpdk-dev] [PATCH v6 02/21] mem: allow memseg lists to be marked as external

2018-09-27 Thread Burakov, Anatoly
On 27-Sep-18 12:12 PM, Shreyansh Jain wrote: On Thursday 27 September 2018 04:38 PM, Burakov, Anatoly wrote: On 27-Sep-18 12:03 PM, Shreyansh Jain wrote: On Thursday 27 September 2018 04:10 PM, Anatoly Burakov wrote: When we allocate and use DPDK memory, we need to be able to differentiate bet

Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-09-27 Thread Ferruh Yigit
On 9/26/2018 7:56 PM, Dan Gora wrote: > On Wed, Sep 26, 2018 at 1:42 PM, Ferruh Yigit wrote: >>> There is nothing to "reflect" to the kernel interface, nor to apply to >>> the kernel interface. This is exactly how every other kernel driver >>> works on link status changes. There is no "netif_set

Re: [dpdk-dev] [PATCH v2] examples/client_server_mp: add sigint handler to server

2018-09-27 Thread Thomas Monjalon
27/09/2018 13:26, Raslan Darawsheh: > v2: > - fix includes order I'm afraid you will need a v3 to fix spacing :) > --- a/examples/multi_process/client_server_mp/mp_server/main.c > +++ b/examples/multi_process/client_server_mp/mp_server/main.c > @@ -37,6 +37,7 @@ > #include "common.h" > #i

Re: [dpdk-dev] How to replace rte_eth_dev_attach with rte_eal_hotplug_add

2018-09-27 Thread Thomas Monjalon
27/09/2018 12:40, Hideyuki Yamashita: > Dear Thomas, > > Thansk for your answer. > Please see inline. > > > 27/09/2018 03:38, Hideyuki Yamashita: > > > Dear Thomas, > > > > > > Thanks for your answer. > > > It took me a little time to digest answer. > > > Please see inline. > > > > > > > > > >

Re: [dpdk-dev] [PATCH v2 5/5] examples/kni: improve zeroing statistics

2018-09-27 Thread Ferruh Yigit
On 9/26/2018 3:48 PM, Dan Gora wrote: > On Wed, Sep 26, 2018 at 11:01 AM, Ferruh Yigit wrote: >> On 9/19/2018 8:55 PM, Dan Gora wrote: >>> The worker threads incrementing the rx/tx_packets race with the signal >>> handler from the main thread zeroing the entire statistics structure. >>> This can c

Re: [dpdk-dev] [PATCH] test/crypto: fix number of queue pairs

2018-09-27 Thread Akhil Goyal
On 9/22/2018 7:03 PM, Fiona Trahe wrote: Some of the tests use a QAT-specific value (2) for maximum nr of queue pairs to create valid/invalid test cases. This has accidentally worked ok as default max_qps for all PMDs is larger. It is incorrect however and would fail if a device had a max lowe

Re: [dpdk-dev] [PATCH 1/3] net/virtio-user: fix multiple queue for vhost-kernel

2018-09-27 Thread Maxime Coquelin
On 09/21/2018 02:52 PM, Tiwei Bie wrote: The multiple queue support in vhost-kernel is broken because the dev->vhostfd is only available for vhost-user. We should always try to enable queue pairs when it's not in server mode. Fixes: 201a41651715 ("net/virtio-user: fix multiple queues fail in

Re: [dpdk-dev] [PATCH 1/2] compress/qat: fix for zero checksum on decompression

2018-09-27 Thread Akhil Goyal
On 9/22/2018 6:55 PM, Fiona Trahe wrote: Checksum was always 0 on QAT decompression due to incorrect use of union variable. Fixes: 6a7ea14819e9 ("compress/qat: add xform processing") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- Applied to dpdk-next-crypto Thanks

Re: [dpdk-dev] [PATCH 2/2] compress/qat: remove unnecessary assignment

2018-09-27 Thread Akhil Goyal
On 9/22/2018 6:55 PM, Fiona Trahe wrote: Same variable was assigned twice, remove one. Fixes: 6a7ea14819e9 ("compress/qat: add xform processing") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- Applied to dpdk-next-crypto Thanks

Re: [dpdk-dev] [PATCH 2/3] net/virtio: add the missing supported features

2018-09-27 Thread Maxime Coquelin
On 09/21/2018 02:52 PM, Tiwei Bie wrote: The virtio features VIRTIO_NET_F_CSUM, VIRTIO_NET_F_HOST_TSO4 and VIRTIO_NET_F_HOST_TSO6 are supported by the virtio PMD. But they are missing in the supported feature set. And since below commit: commit 4174a7b59d05 ("net/virtio: improve Tx offload fe

[dpdk-dev] [PATCH v3] examples/client_server_mp: add sigint handler to server

2018-09-27 Thread Raslan Darawsheh
add sigint handler in the server application to stop and close ports Signed-off-by: Raslan Darawsheh --- v2: - fix includes order v3: - fix spacing --- --- examples/multi_process/client_server_mp/mp_server/main.c | 15 +++ 1 file changed, 15 insertions(+) diff --gi

Re: [dpdk-dev] [PATCH 3/3] doc: update the doc for virtio-user

2018-09-27 Thread Maxime Coquelin
On 09/21/2018 02:52 PM, Tiwei Bie wrote: Update the doc for virtio-user to use the latest testpmd parameters and commands. Signed-off-by: Tiwei Bie --- doc/guides/contributing/documentation.rst | 4 ++-- .../howto/virtio_user_as_exceptional_path.rst | 23 +++ .../vir

Re: [dpdk-dev] [PATCH v2 3/5] examples/kni: monitor and update link status continually

2018-09-27 Thread Ferruh Yigit
On 9/26/2018 8:16 PM, Dan Gora wrote: > On Wed, Sep 26, 2018 at 11:00 AM, Ferruh Yigit wrote: >> On 9/19/2018 8:55 PM, Dan Gora wrote: >>> Update KNI example to continuously monitor the Ethernet link status of >>> the physical link and update the carrier status of the corresponding >>> interfaces

Re: [dpdk-dev] [PATCH 0/3] Some fixes and doc updates for virtio-user

2018-09-27 Thread Maxime Coquelin
On 09/21/2018 02:52 PM, Tiwei Bie wrote: This series consists of some fixes and doc updates for virtio-user. Tiwei Bie (3): net/virtio-user: fix multiple queue for vhost-kernel net/virtio: add the missing supported features doc: update the doc for virtio-user doc/guides/contribut

Re: [dpdk-dev] [PATCH v2] vhost: fix corner case for enqueue operation

2018-09-27 Thread Maxime Coquelin
On 09/17/2018 05:54 AM, Jiayu Hu wrote: When perform enqueue operations on the split and packed ring, s/perform/performing/ s/ring/rings/ if the reserved buffer length from the descriptor table execeeds 65535, the returned length by fill_vec_buf_split/_packed() is overflowed. This patch is t

Re: [dpdk-dev] [PATCH v2 5/7] hash: add extendable bucket feature

2018-09-27 Thread Bruce Richardson
On Thu, Sep 27, 2018 at 12:27:21PM +0100, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Thursday, September 27, 2018 12:15 PM > > To: Honnappa Nagarahalli > > Cc: Wang, Yipeng1 ; dev@dpdk.org; >

Re: [dpdk-dev] [PATCH v2] examples/client_server_mp: add sigint handler to server

2018-09-27 Thread Bruce Richardson
On Thu, Sep 27, 2018 at 01:36:06PM +0200, Thomas Monjalon wrote: > 27/09/2018 13:26, Raslan Darawsheh: > > v2: > > - fix includes order > > I'm afraid you will need a v3 to fix spacing :) > > > --- a/examples/multi_process/client_server_mp/mp_server/main.c > > +++ b/examples/multi_process/cli

[dpdk-dev] [PATCH] bus/pci: set intr_handle type for secondary processes

2018-09-27 Thread Alejandro Lucero
Invoking rte_pci_read/write_config functions requires device with a intr_handle type for using VFIO or UIO driver related functions. Secondary processes rely on primary processes for device initialization so they do not usually require using these functions. However, some PMDs, like NFP PMD, requi

Re: [dpdk-dev] [PATCH v2 5/7] hash: add extendable bucket feature

2018-09-27 Thread Ananyev, Konstantin
> -Original Message- > From: Richardson, Bruce > Sent: Thursday, September 27, 2018 1:28 PM > To: Ananyev, Konstantin > Cc: Honnappa Nagarahalli ; Wang, Yipeng1 > ; dev@dpdk.org; > mic...@digirati.com.br > Subject: Re: [dpdk-dev] [PATCH v2 5/7] hash: add extendable bucket feature > >

Re: [dpdk-dev] [PATCH v2] vhost: fix corner case for enqueue operation

2018-09-27 Thread Maxime Coquelin
On 09/27/2018 02:24 PM, Maxime Coquelin wrote: On 09/17/2018 05:54 AM, Jiayu Hu wrote: When perform enqueue operations on the split and packed ring, s/perform/performing/ s/ring/rings/ if the reserved buffer length from the descriptor table execeeds 65535, the returned length by fill_vec_

Re: [dpdk-dev] [PATCH] drivers/bus: fill driver reference after NXP probing

2018-09-27 Thread Thomas Monjalon
26/09/2018 10:12, Shreyansh Jain: > On Wednesday 26 September 2018 12:52 AM, Thomas Monjalon wrote: > > The probing functions of NXP buses were missing to set > > the driver used for successfully probing a device. > > > > The NXP driver and the generic rte_driver are now set > > in the device stru

Re: [dpdk-dev] [PATCH] bus/ifpga: remove useless driver cast

2018-09-27 Thread Thomas Monjalon
> > The rte_afu_driver is assigned to rte_afu_device.driver during probing. > > There is no need of accessing the rte_afu_driver via rte_device.driver and > > type casting to its container. > > > > Signed-off-by: Thomas Monjalon > > Acked-by: Rosen Xu Applied

Re: [dpdk-dev] [PATCH v2] examples/client_server_mp: add sigint handler to server

2018-09-27 Thread Thomas Monjalon
27/09/2018 14:30, Bruce Richardson: > On Thu, Sep 27, 2018 at 01:36:06PM +0200, Thomas Monjalon wrote: > > 27/09/2018 13:26, Raslan Darawsheh: > > > v2: > > > - fix includes order > > > > I'm afraid you will need a v3 to fix spacing :) > > > > > --- a/examples/multi_process/client_server_mp/mp_

Re: [dpdk-dev] [PATCH v6 03/21] malloc: index heaps using heap ID rather than NUMA node

2018-09-27 Thread Alejandro Lucero
On Thu, Sep 27, 2018 at 11:47 AM Anatoly Burakov wrote: > Switch over all parts of EAL to use heap ID instead of NUMA node > ID to identify heaps. Heap ID for DPDK-internal heaps is NUMA > node's index within the detected NUMA node list. Heap ID for > external heaps will be order of their creatio

Re: [dpdk-dev] [PATCH v3 2/2] net/tap: add queues when attaching from secondary process

2018-09-27 Thread Wiles, Keith
> On Sep 27, 2018, at 6:19 AM, Raslan Darawsheh wrote: > > In the case the device is created by the primary process, > the secondary must request some file descriptors to attach the queues. > The file descriptors are shared via IPC Unix socket. > > Thanks to the IPC synchronization, the secon

Re: [dpdk-dev] [PATCH v6 04/21] mem: do not check for invalid socket ID

2018-09-27 Thread Alejandro Lucero
On Thu, Sep 27, 2018 at 11:41 AM Anatoly Burakov wrote: > We will be assigning "invalid" socket ID's to external heap, and > malloc will now be able to verify if a supplied socket ID is in > fact a valid one, rendering parameter checks for sockets > obsolete. > > This changes the semantics of wha

Re: [dpdk-dev] [PATCH v3 1/2] net/tap: change queue fd to be pointers to process private

2018-09-27 Thread Wiles, Keith
> On Sep 27, 2018, at 6:19 AM, Raslan Darawsheh wrote: > > change the fds for the queues to be pointers and add new process private > structure and make the queue fds point to it. > > Signed-off-by: Raslan Darawsheh > --- > drivers/net/tap/rte_eth_tap.c | 63 -

Re: [dpdk-dev] [PATCH v6 03/21] malloc: index heaps using heap ID rather than NUMA node

2018-09-27 Thread Burakov, Anatoly
On 27-Sep-18 2:01 PM, Alejandro Lucero wrote: On Thu, Sep 27, 2018 at 11:47 AM Anatoly Burakov wrote: Switch over all parts of EAL to use heap ID instead of NUMA node ID to identify heaps. Heap ID for DPDK-internal heaps is NUMA node's index within the detected NUMA node list. Heap ID for exte

[dpdk-dev] [PATCH 4/6] net/softnic: disable softnic build in FREEBSD

2018-09-27 Thread Agalya Babu RadhaKrishnan
Disabled softnic build in FreeBSD because it is not supported Added changes to enable softnic build if it is Linux OS and disable in FreeBSD. Fixes: 6e8a721044 ("vfio: export functions even when disabled") Signed-off-by: Agalya Babu RadhaKrishnan --- drivers/net/softnic/meson.build | 3 +++ 1 f

[dpdk-dev] [PATCH 6/6] net/vdev_netvsc: disable vdev netvsc build in FREEBSD

2018-09-27 Thread Agalya Babu RadhaKrishnan
Disabled vdev_netvsc build in FreeBSD because it is not supported Added changes to enable vdev_netvsc build if it is Linux OS and disable in FreeBSD. Fixes: 6e8a721044 ("vfio: export functions even when disabled") Signed-off-by: Agalya Babu RadhaKrishnan --- drivers/net/vdev_netvsc/meson.build

[dpdk-dev] [PATCH 2/6] net/nfp: disable nfp build in FREEBSD

2018-09-27 Thread Agalya Babu RadhaKrishnan
Disabled nfp build in FreeBSD because it is not supported Added changes to enable NFP build if it is Linux OS and disable in FreeBSD. Fixes: 6e8a721044 ("vfio: export functions even when disabled") Signed-off-by: Agalya Babu RadhaKrishnan --- drivers/net/nfp/meson.build | 3 +++ 1 file changed,

[dpdk-dev] [PATCH 3/6] net/avp: disable avp build in FREEBSD

2018-09-27 Thread Agalya Babu RadhaKrishnan
Disabled avp build in FreeBSD because it is not supported. Added changes to enable avp build if it is Linux OS and disable in FreeBSD. Fixes: 6e8a721044 ("vfio: export functions even when disabled") Signed-off-by: Agalya Babu RadhaKrishnan --- drivers/net/avp/meson.build | 3 +++ 1 file changed

  1   2   >