27/09/2018 14:30, Bruce Richardson: > On Thu, Sep 27, 2018 at 01:36:06PM +0200, Thomas Monjalon wrote: > > 27/09/2018 13:26, Raslan Darawsheh: > > > v2: > > > - fix includes order > > > > I'm afraid you will need a v3 to fix spacing :) > > > > > --- a/examples/multi_process/client_server_mp/mp_server/main.c > > > +++ b/examples/multi_process/client_server_mp/mp_server/main.c > > > @@ -37,6 +37,7 @@ > > > #include "common.h" > > > #include "args.h" > > > #include "init.h" > > > +#include<signal.h> > > > > A space is missing here. > > > > Also, the norm in DPDK is to list all standard headers first, then the DPDK > headers and finally the local headers. "signal.h" therefore should be > further up in the file, with the first group.
I think he did that already in v3 :)
