> -----Original Message-----
> From: Gavin Hu (Arm Technology China)
> Sent: 2018年9月26日 17:29
> To: Gavin Hu (Arm Technology China) <[email protected]>; [email protected]
> Cc: Honnappa Nagarahalli <[email protected]>; Steve Capper
> <[email protected]>; Ola Liljedahl <[email protected]>;
> [email protected]; nd <[email protected]>; [email protected]; Justin
> He <[email protected]>
> Subject: RE: [PATCH v3 1/3] ring: read tail using atomic load
>
> +Justin He
>
> > -----Original Message-----
> > From: Gavin Hu <[email protected]>
> > Sent: Monday, September 17, 2018 4:17 PM
> > To: [email protected]
> > Cc: Gavin Hu (Arm Technology China) <[email protected]>; Honnappa
> > Nagarahalli <[email protected]>; Steve Capper
> > <[email protected]>; Ola Liljedahl <[email protected]>;
> > [email protected]; nd <[email protected]>; [email protected]
> > Subject: [PATCH v3 1/3] ring: read tail using atomic load
> >
> > In update_tail, read ht->tail using __atomic_load.Although the
> > compiler currently seems to be doing the right thing even without
> > _atomic_load, we don't want to give the compiler freedom to optimise
> > what should be an atomic load, it should not be arbitarily moved around.
> >
> > Fixes: 39368ebfc6 ("ring: introduce C11 memory model barrier option")
> > Cc: [email protected]
> >
> > Signed-off-by: Gavin Hu <[email protected]>
> > Reviewed-by: Honnappa Nagarahalli <[email protected]>
> > Reviewed-by: Steve Capper <[email protected]>
> > Reviewed-by: Ola Liljedahl <[email protected]>
> > ---
> > lib/librte_ring/rte_ring_c11_mem.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_ring/rte_ring_c11_mem.h
> > b/lib/librte_ring/rte_ring_c11_mem.h
> > index 94df3c4..234fea0 100644
> > --- a/lib/librte_ring/rte_ring_c11_mem.h
> > +++ b/lib/librte_ring/rte_ring_c11_mem.h
> > @@ -21,7 +21,8 @@ update_tail(struct rte_ring_headtail *ht, uint32_t
> > old_val, uint32_t new_val,
> > * we need to wait for them to complete
> > */
> > if (!single)
> > -while (unlikely(ht->tail != old_val))
> > +while (unlikely(old_val != __atomic_load_n(&ht->tail,
> > +__ATOMIC_RELAXED)))
I still wonder why an atomic load is needed here?
Cheers,
Justin (Jia He)
> > rte_pause();
> >
> > __atomic_store_n(&ht->tail, new_val, __ATOMIC_RELEASE);
> > --
> > 2.7.4
IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended recipient,
please notify the sender immediately and do not disclose the contents to any
other person, use it for any purpose, or store or copy the information in any
medium. Thank you.
