in function i40e_nvmupd_validate_command, when "cmd->data_size < 1" it'll return I40E_NVMUPD_INVALID,and in function "i40e_nvmupd_command" when "upd_cmd == I40E_NVMUPD_STATUS",it check "!cmd->data_size" again, but it's no need.
Signed-off-by: Li Han <han....@zte.com.cn> --- drivers/net/i40e/base/i40e_nvm.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c index c77dac0..5de22e4 100644 --- a/drivers/net/i40e/base/i40e_nvm.c +++ b/drivers/net/i40e/base/i40e_nvm.c @@ -869,11 +869,6 @@ enum i40e_status_code i40e_nvmupd_command(struct i40e_hw *hw, * going into the state machine */ if (upd_cmd == I40E_NVMUPD_STATUS) { - if (!cmd->data_size) { - *perrno = -EFAULT; - return I40E_ERR_BUF_TOO_SHORT; - } - bytes[0] = hw->nvmupd_state; if (cmd->data_size >= 4) { -- 1.8.3.1