Re: [dpdk-dev] [PATCH] build: enable Arm NEON flags when __aarch64__ is defined

> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, August 22, 2018 11:01 PM > To: bruce.richard...@intel.com > Cc: dev@dpdk.org; Gavin Hu ; rasl...@mellanox.com; > therb...@redhat.com; Honnappa Nagarahalli > > Subject: [PATCH] build: enable Arm NEON flags when __aarch

Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type

On 08/27/2018 03:38 PM, Jerin Jacob wrote: Add support for IGMP packet type. Signed-off-by: Jerin Jacob Acked-by: Andrew Rybchenko

[dpdk-dev] [PATCH 0/4] net/failsafe: support deferred queue start

Ian Dolzhansky (4): app/testpmd: add queue deferred start switch net/failsafe: add checks for deferred queue setup net/failsafe: add Rx queue start and stop functions net/failsafe: add Tx queue start and stop functions app/test-pmd/cmdline.c | 91 ++ doc/guide

[dpdk-dev] [PATCH 1/4] app/testpmd: add queue deferred start switch

From: Ian Dolzhansky Signed-off-by: Ian Dolzhansky Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c | 91 ++ doc/guides/rel_notes/release_18_11.rst | 6 ++ 2 files changed, 97 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/c

[dpdk-dev] [PATCH 2/4] net/failsafe: add checks for deferred queue setup

From: Ian Dolzhansky Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") Cc: sta...@dpdk.org Signed-off-by: Ian Dolzhansky Signed-off-by: Andrew Rybchenko --- drivers/net/failsafe/failsafe_ops.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/failsafe/failsafe_

[dpdk-dev] [PATCH 4/4] net/failsafe: add Tx queue start and stop functions

From: Ian Dolzhansky Support Tx queue deferred start. Signed-off-by: Ian Dolzhansky Signed-off-by: Andrew Rybchenko --- doc/guides/nics/features/failsafe.ini | 2 +- doc/guides/rel_notes/release_18_11.rst | 4 +- drivers/net/failsafe/failsafe_ether.c | 44 +++ drivers/net/fail

[dpdk-dev] [PATCH 3/4] net/failsafe: add Rx queue start and stop functions

From: Ian Dolzhansky Support Rx queue deferred start. Signed-off-by: Ian Dolzhansky Signed-off-by: Andrew Rybchenko --- doc/guides/nics/features/failsafe.ini | 1 + doc/guides/rel_notes/release_18_11.rst | 7 ++ drivers/net/failsafe/failsafe_ether.c | 44 drivers/net/failsafe

Re: [dpdk-dev] [PATCH] build: enable Arm NEON flags when __aarch64__ is defined

-Original Message- > Date: Wed, 22 Aug 2018 10:01:07 -0500 > From: Honnappa Nagarahalli > To: bruce.richard...@intel.com > CC: dev@dpdk.org, gavin...@arm.com, rasl...@mellanox.com, > therb...@redhat.com, honnappa.nagaraha...@arm.com > Subject: [dpdk-dev] [PATCH] build: enable Arm NEON fla

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

Is the rte_kni kernel/user binary interface subject to backwards compatibility requirements? Or can we change it for a new DPDK release? -- Ola From: "Kokkilagadda, Kiran" Date: Wednesday, 29 August 2018 at 07:50 To: Honnappa Nagarahalli , Gavin Hu , Ferruh Yigit , "Jacob, Jerin" Cc: "dev@dp

[dpdk-dev] [PATCH 1/2] net/sfc: support runtime Rx queue setup

From: Igor Romanov Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- doc/guides/nics/features/sfc_efx.ini | 1 + drivers/net/sfc/sfc_ethdev.c | 6 ++ drivers/net/sfc/sfc_rx.c | 6 -- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/doc/g

[dpdk-dev] [PATCH 2/2] net/sfc: support runtime Tx queue setup

From: Igor Romanov Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- doc/guides/nics/features/sfc_efx.ini | 1 + drivers/net/sfc/sfc_ethdev.c | 7 ++- drivers/net/sfc/sfc_tx.c | 8 +--- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/do

[dpdk-dev] [PATCH] net/failsafe: limit device capabilities to really supported

From: Igor Romanov Failsafe driver does not support any device capabilities yet. Make fs_dev_infos_get() consider default ones to limit advertised device capabilities to really supported instead of unconditional inheritance from sub-devices. Fixes: cac923cfea47 ("ethdev: support runtime queue se

[dpdk-dev] [PATCH] net/bonding: use evenly distributed default RSS RETA

From: Igor Romanov Default Redirection Table that is set in bonding driver is distributed evenly over all Rx queues only within every RETA group (the first RETA entries in every group are always start with zero). But in the most drivers, default RETA is distributed over all Rx queues without sequ

[dpdk-dev] [PATCH] net/bonding: don't ignore RSS key on device configuration

From: Igor Romanov Bonding driver ignores the value of RSS key (that is set in the port RSS configuration) in bond_ethdev_configure(). So the only way to set non-default RSS key is by using rss_hash_update(). This is not an expected behaviour. Make the bond_ethdev_configure() set default RSS key

Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure

On Tue, Aug 28, 2018 at 04:54:33PM +, Van Haaren, Harry wrote: > Hi Gaetan, > > > -Original Message- > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > Sent: Tuesday, August 28, 2018 12:47 PM > > To: Power, Ciara > > Cc: Van Haaren, Harry ; Archbold, Brian > > ; Kenny, Emma ;

Re: [dpdk-dev] 18.08 build error on ppc64el - bool as vector type

On Tue, Aug 28, 2018 at 5:02 PM Adrien Mazarguil wrote: > On Tue, Aug 28, 2018 at 02:38:35PM +0200, Christian Ehrhardt wrote: > > On Tue, Aug 28, 2018 at 1:44 PM Adrien Mazarguil < > adrien.mazarg...@6wind.com> > > wrote: > > > > > On Tue, Aug 28, 2018 at 01:30:12PM +0200, Christian Ehrhardt wrot

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

-Original Message- > Date: Wed, 29 Aug 2018 07:34:34 + > From: Ola Liljedahl > To: "Kokkilagadda, Kiran" , Honnappa > Nagarahalli , Gavin Hu , > Ferruh Yigit , "Jacob, Jerin" > > CC: "dev@dpdk.org" , nd , Steve Capper > > Subject: Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo p

Re: [dpdk-dev] [RFC] ethdev: add action to swap source and destination MAC to flow API

On Tuesday, August 08/28/18, 2018 at 16:27:43 +0530, Andrew Rybchenko wrote: >On 08/27/2018 03:54 PM, Rahul Lakkireddy wrote: > > From: Shagun Agrawal [1] > > This action is useful for offloading loopback mode, where the hardware > will swap source and destination MAC address before loopin

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

There was a mention of rte_ring which is a different data structure. But perhaps I misunderstood why this was mentioned and the idea was only to use the C11 memory model as is also used in rte_ring nowadays. But why would we have different code for x86 and for other architectures (ARM, Power)?

Re: [dpdk-dev] [PATCH] checkpatches: don't assume bash syntax

Hi Stephen, On 13/8/2018 4:47 PM, Stephen Hemminger wrote: The read -d option is a bash extension and not avaiable in other shells. On Debian, /bin/sh is dash and checktpatches would fail with: ./devtools/checkpatches.sh: 52: read: Illegal option -d Fix by using awk -e and adding necessary dou

[dpdk-dev] [RFC v2] ethdev: add action to swap source and destination MAC to flow API

From: Shagun Agrawal This action is useful for offloading loopback mode, where the hardware will swap source and destination MAC addresses in the outermost Ethernet header before looping back the packet. This action can be used in conjunction with other rewrite actions to achieve MAC layer transp

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

-Original Message- > Date: Wed, 29 Aug 2018 08:47:56 + > From: Ola Liljedahl > To: Jerin Jacob > CC: "Kokkilagadda, Kiran" , Honnappa > Nagarahalli , Gavin Hu , > Ferruh Yigit , "Jacob, Jerin" > , "dev@dpdk.org" , nd > , Steve Capper > Subject: Re: [dpdk-dev] [PATCH v2] kni: fix

Re: [dpdk-dev] [PATCH 02/10] qat: update code to use __rte_weak macro

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Keith Wiles > Sent: Friday, August 3, 2018 4:06 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 02/10] qat: update code to use __rte_weak > macro > > Signed-off-by: Keith Wiles Acked-by: tomaszx.jozw...@inte

Re: [dpdk-dev] [PATCH v2] net/mlx: add meson build support

Hi Bruce, Thanks for your comments I have address almost all of them in the v3 by doing what you suggest, I still have some comments, please see below, On Tue, Aug 28, 2018 at 04:45:00PM +0100, Bruce Richardson wrote: > Thanks for this, comments inline below. > > /Bruce > > On Mon, Aug 27, 2018

Re: [dpdk-dev] [PATCH 0/4] net/failsafe: support deferred queue start

Hello Ian, Andrew, Clean patchset. Only nitpick would be on eth_dev_ops ordering, but this is secondary. For the series: Acked-by: Gaetan Rivet On Wed, Aug 29, 2018 at 08:16:02AM +0100, Andrew Rybchenko wrote: > Ian Dolzhansky (4): > app/testpmd: add queue deferred start switch > net/failsa

[dpdk-dev] [PATCH v2] app/testpmd: add new command for show port info

existing testpmd command "show port info" is too verbose. Added a new summary command to print brief information on ports. console output: testpmd> show port summary all Number of available ports: 2 Port MAC Address Name Driver Status Link 011:2

Re: [dpdk-dev] [PATCH] kni: dynamically allocate memory for each KNI

Hello Ferruh, Thanks for the review, comments inline. On Mon, Aug 27, 2018 at 8:06 PM, Ferruh Yigit wrote: > On 8/2/2018 3:25 PM, Igor Ryzhov wrote: > > Long time ago preallocation of memory for KNI was introduced in commit > > 0c6bc8e. It was done because of lack of ability to free previously

Re: [dpdk-dev] 16.11.8 (LTS) patches review and test

On Mon, 2018-08-27 at 17:17 +0100, Luca Boccassi wrote: > On Thu, 2018-08-23 at 09:55 +0100, Luca Boccassi wrote: > > On Mon, 2018-08-13 at 19:21 +0100, luca.bocca...@gmail.com wrote: > > > Hi all, > > > > > > Here is a list of patches targeted for LTS release 16.11.8. > > > Please > > > help revi

Re: [dpdk-dev] [PATCH v2] net/mlx: add meson build support

On Tue, 2018-08-28 at 16:45 +0100, Bruce Richardson wrote: > Thanks for this, comments inline below. > > /Bruce > > On Mon, Aug 27, 2018 at 02:42:25PM +0200, Nelio Laranjeiro wrote: > > Mellanox drivers remains un-compiled by default due to third party > > libraries dependencies.  They can be ena

Re: [dpdk-dev] [PATCH v2] net/mlx: add meson build support

On Wed, Aug 29, 2018 at 11:34:10AM +0200, Nélio Laranjeiro wrote: > Hi Bruce, > > Thanks for your comments I have address almost all of them in the v3 by > doing what you suggest, I still have some comments, please see below, > Thanks. > On Tue, Aug 28, 2018 at 04:45:00PM +0100, Bruce Richardso

Re: [dpdk-dev] [PATCH v2 01/10] kni: remove unused variables from struct kni_dev

On 6/29/2018 2:54 AM, Dan Gora wrote: > Remove the unused fields 'status' and 'synchro' from the struct > kni_dev. > > Signed-off-by: Dan Gora Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH v3] app/testpmd: add new command for show port info

existing testpmd command "show port info" is too verbose. Added a new summary command to print brief information on ports. console output: testpmd> show port summary all Number of available ports: 2 Port MAC Address Name Driver Status Link 011:2

[dpdk-dev] [PATCH 02/13] net/dpaa: fix jumbo buffer config

Avoid return after the jumbo buffer config in dev config API Fixes: 9658ac3a4ef6 ("net/dpaa: set the correct frame size in device MTU") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --g

[dpdk-dev] [PATCH 03/13] net/dpaa: implement scatter offload support

Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 62 +++--- drivers/net/dpaa/dpaa_ethdev.h | 3 +- drivers/net/dpaa/dpaa_rxtx.c | 8 +++--- drivers/net/dpaa/dpaa_rxtx.h | 2 -- 4 files changed, 64 insertions(+), 11 deletions(-) diff --

[dpdk-dev] [PATCH 00/13] driver/net: NXP DPAA driver enhancements

Hemant Agrawal (9): net/dpaa: configure frame queue on MAC ID basis net/dpaa: fix jumbo buffer config net/dpaa: implement scatter offload support net/dpaa: minor debug log enhancements bus/dpaa: add interrupt based portal fd support net/dpaa: separate Rx function for LS1046 net/dpaa

[dpdk-dev] [PATCH 01/13] net/dpaa: configure frame queue on MAC ID basis

Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 25 ++--- drivers/net/dpaa/dpaa_ethdev.h | 2 +- 2 files changed, 15 insertions(+), 12 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index 7a950ac..009ef84 100644 -

[dpdk-dev] [PATCH 05/13] net/dpaa: minor debug log enhancements

Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index 4e5cc0f..df72510 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/d

[dpdk-dev] [PATCH 04/13] net/dpaa: set correct speed based on MAC type

From: Sachin Saxena Fixes: 799db4568c76 ("net/dpaa: support device info and speed capability") Cc: shreyansh.j...@nxp.com Cc: sta...@dpdk.org Signed-off-by: Sachin Saxena --- drivers/net/dpaa/dpaa_ethdev.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/

[dpdk-dev] [PATCH 07/13] bus/dpaa: avoid tag Set for eqcr in Tx path

From: Nipun Gupta Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/base/qbman/qman.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman/qman.c index 8730550..71da275 100644 --- a/drivers/bus/dpaa/base/qbman/qman.c +++ b/drive

[dpdk-dev] [PATCH 06/13] bus/dpaa: add interrupt based portal fd support

Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/bman_driver.c | 17 ++ drivers/bus/dpaa/base/qbman/qman.c| 52 +++ drivers/bus/dpaa/base/qbman/qman_driver.c | 7 - drivers/bus/dpaa/include/fsl_qman.h | 20 drivers/b

[dpdk-dev] [PATCH 09/13] net/dpaa: rearranging of atomic queue support code

From: Sunil Kumar Kori Signed-off-by: Sunil Kumar Kori --- drivers/net/dpaa/dpaa_rxtx.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c index 3a3a048..6698c97 100644 --- a/drivers/net/dpa

[dpdk-dev] [PATCH 08/13] bus/dpaa: avoid using be conversions for contextb

From: Nipun Gupta Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/base/qbman/qman.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman/qman.c index 71da275..dc64d08 100644 --- a/drivers/bus/dpaa/

[dpdk-dev] [PATCH 10/13] net/dpaa: separate Rx function for LS1046

This is to avoid the checks in datapath Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 9 +-- drivers/net/dpaa/dpaa_rxtx.c | 60 +- drivers/net/dpaa/dpaa_rxtx.h | 3 +++ 3 files changed, 58 insertions(+), 14 deletions(-) diff

[dpdk-dev] [PATCH 11/13] net/dpaa: tune prefetch in Rx path

Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_rxtx.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c index 2c57741..c4471c2 100644 --- a/drivers/net/dpaa/dpaa_rxtx.c +++ b/drivers/net/dpaa/dpaa_rxtx.c

[dpdk-dev] [PATCH 12/13] bus/dpaa: add check for re-definition in compat

Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/include/compat.h | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/bus/dpaa/include/compat.h b/drivers/bus/dpaa/include/compat.h index 92241d2..4122657 100644 --- a/drivers/bus/dpaa/include/compat.

[dpdk-dev] [PATCH 13/13] mempool/dpaa: change the debug log level to DP

Signed-off-by: Hemant Agrawal --- drivers/mempool/dpaa/dpaa_mempool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mempool/dpaa/dpaa_mempool.c b/drivers/mempool/dpaa/dpaa_mempool.c index 10c536b..1c12122 100644 --- a/drivers/mempool/dpaa/dpaa_mempool.c +++ b/driver

Re: [dpdk-dev] 16.11.8 (LTS) patches review and test

Hi Luca, On Wed, 2018-08-29 at 10:55 +0100, Luca Boccassi wrote: > On Mon, 2018-08-27 at 17:17 +0100, Luca Boccassi wrote: > > On Thu, 2018-08-23 at 09:55 +0100, Luca Boccassi wrote: > > > On Mon, 2018-08-13 at 19:21 +0100, luca.bocca...@gmail.com wrote: > > > > Hi all, > > > > > > > > Here is a

Re: [dpdk-dev] [PATCH v2 02/10] kni: separate releasing netdev from freeing KNI interface

On 6/29/2018 2:55 AM, Dan Gora wrote: > Currently the rte_kni kernel driver suffers from a problem where > when the interface is released, it generates a callback to the DPDK > application to change the interface state to Down. However, after the > DPDK application handles the callback and generat

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

On 6/29/2018 2:55 AM, Dan Gora wrote: > Add a new API function to KNI, rte_kni_update_link() to allow DPDK > applications to update the link state for the KNI network interfaces > in the linux kernel. > > Note that the default carrier state is set to off when the interface > is opened. Why set ca

[dpdk-dev] [PATCH 1/7] linuxapp: build with _GNU_SOURCE defined by default

We use _GNU_SOURCE all over the place, but often times we miss defining it, resulting in broken builds on musl. Rather than fixing every library's and driver's and application's makefile, fix it by simply defining _GNU_SOURCE by default for all Linuxapp builds. Signed-off-by: Anatoly Burakov ---

[dpdk-dev] [PATCH 3/7] fbarray: improve musl compatibility

When built against musl, fcntl.h doesn't silently get included. Fix by including it explicitly. Bugzilla ID: 34 Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_fbarray.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/eal_common_fbarray.c b/lib/lib

[dpdk-dev] [PATCH 5/7] mem: improve musl compatibility

When built against musl, fcntl.h doesn't silently get included. Fix by including it explicitly. Bugzilla ID: 31 Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_memory.c | 1 + lib/librte_eal/linuxapp/eal/eal_memory.c | 1 + 2 files changed, 2 insertions(+) diff --git a/lib

[dpdk-dev] [PATCH 0/7] Improve core EAL musl compatibility

This patchset fixes numerous issues with musl compatibility in the core EAL libraries. It does not fix anything beyond core EAL (so, PCI driver is still broken, so are a few other drivers), but it's a good start. Tested on container with Alpine Linux. Alpine dependencies: build-base bsd-compat-he

[dpdk-dev] [PATCH 6/7] string_fns: improve musl compatibility

Musl wraps various string functions such as strlcpy in order to harden them. However, the fortify wrappers are included without including the actual string functions being wrapped, which throws missing definition compile errors. Fix by including string.h in string functions header. Signed-off-by:

[dpdk-dev] [PATCH 2/7] pci/vfio: improve musl compatibility

Musl already has PAGE_SIZE defined, and our define clashed with it. Rename our define to SYS_PAGE_SIZE. Bugzilla ID: 36 Signed-off-by: Anatoly Burakov --- drivers/bus/pci/linux/pci_vfio.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/bus/pci/linux/pci_vfio.

[dpdk-dev] [PATCH 4/7] eal/hugepage_info: improve musl compatibility

When built against musl, fcntl.h doesn't silently get included. Fix by including it explicitly. Bugzilla ID: 33 Signed-off-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c

[dpdk-dev] [PATCH 7/7] eal: improve musl compatibility

Musl complains about pthread id being of wrong size. Fix it by casting to 64-bit and printing 64-bit hex unconditionally. Signed-off-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal.c| 5 +++-- lib/librte_eal/linuxapp/eal/eal_thread.c | 5 +++-- 2 files changed, 6 insertions(+), 4

Re: [dpdk-dev] [PATCH v2] net/mlx: add meson build support

On Wed, Aug 29, 2018 at 11:00:54AM +0100, Luca Boccassi wrote: > On Tue, 2018-08-28 at 16:45 +0100, Bruce Richardson wrote: > > Thanks for this, comments inline below. > > > > /Bruce > > > > On Mon, Aug 27, 2018 at 02:42:25PM +0200, Nelio Laranjeiro wrote: > > > Mellanox drivers remains un-compil

Re: [dpdk-dev] [RFC v2] ethdev: support metadata as flow rule criteria

Hi Dekel, Could you please show with an example i.e how the corresponding 'flow create' cmd will look like in testpmd? Also I'm guessing you would need to change the cmdline_parser logic in testpmd application as well to recognize this new rte_flow_item? Thanks Som On Wed, Aug 29, 2018 at

[dpdk-dev] [PATCH] mem: fix undefined behavior in NUMA code

When NUMA-aware hugepages config option is set, we rely on libnuma to tell the kernel to allocate hugepages on a specific NUMA node. However, we allocate node mask before we check if NUMA is available in the first place, which, according to the manpage [1], causes undefined behaviour. Fix by only

Re: [dpdk-dev] [PATCH v2] net/mlx: add meson build support

On Wed, 2018-08-29 at 13:59 +0200, Nélio Laranjeiro wrote: > On Wed, Aug 29, 2018 at 11:00:54AM +0100, Luca Boccassi wrote: > > On Tue, 2018-08-28 at 16:45 +0100, Bruce Richardson wrote: > > > Thanks for this, comments inline below. > > > > > > /Bruce > > > > > > On Mon, Aug 27, 2018 at 02:42:25P

Re: [dpdk-dev] [PATCH 2/7] pci/vfio: improve musl compatibility

On Wed, Aug 29, 2018 at 12:56:16PM +0100, Anatoly Burakov wrote: > Musl already has PAGE_SIZE defined, and our define clashed with it. > Rename our define to SYS_PAGE_SIZE. > > Bugzilla ID: 36 > > Signed-off-by: Anatoly Burakov > --- Would it not be easier to just do? #ifndef PAGE_SIZE #define

Re: [dpdk-dev] [PATCH 7/7] eal: improve musl compatibility

On Wed, Aug 29, 2018 at 12:56:21PM +0100, Anatoly Burakov wrote: > Musl complains about pthread id being of wrong size. Fix it by > casting to 64-bit and printing 64-bit hex unconditionally. > > Signed-off-by: Anatoly Burakov > --- Given that on linux pthread_t is a pointer type, will this not gi

Re: [dpdk-dev] [PATCH 7/7] eal: improve musl compatibility

On Wed, Aug 29, 2018 at 01:39:26PM +0100, Bruce Richardson wrote: > On Wed, Aug 29, 2018 at 12:56:21PM +0100, Anatoly Burakov wrote: > > Musl complains about pthread id being of wrong size. Fix it by > > casting to 64-bit and printing 64-bit hex unconditionally. > > > > Signed-off-by: Anatoly Bura

Re: [dpdk-dev] [PATCH v2] net/mlx: add meson build support

On Wed, Aug 29, 2018 at 11:01:15AM +0100, Bruce Richardson wrote: > On Wed, Aug 29, 2018 at 11:34:10AM +0200, Nélio Laranjeiro wrote: > > Hi Bruce, > > > > Thanks for your comments I have address almost all of them in the v3 by > > doing what you suggest, I still have some comments, please see bel

Re: [dpdk-dev] [PATCH] mem: fix undefined behavior in NUMA code

Hi. Thanks for the fix. Comments inline. Best regards, Ilya Maximets. On 29.08.2018 15:21, Anatoly Burakov wrote: > When NUMA-aware hugepages config option is set, we rely on > libnuma to tell the kernel to allocate hugepages on a specific > NUMA node. However, we allocate node mask before we che

Re: [dpdk-dev] 18.08 build error on ppc64el - bool as vector type

On Wed, Aug 29, 2018 at 10:27:03AM +0200, Christian Ehrhardt wrote: > On Tue, Aug 28, 2018 at 5:02 PM Adrien Mazarguil > wrote: > > > On Tue, Aug 28, 2018 at 02:38:35PM +0200, Christian Ehrhardt wrote: > > > --- a/lib/librte_eal/common/include/arch/ppc_64/rte_memcpy.h > > > +++ b/lib/librte_eal/

Re: [dpdk-dev] 16.11.8 (LTS) patches review and test

Hi Luca & all, I confirm tests carried out via test_pmd and Ovs-DPDK do not show any regression for us. Cheers, Marco On Wed, 2018-08-29 at 10:55 +0100, Luca Boccassi wrote: > On Mon, 2018-08-27 at 17:17 +0100, Luca Boccassi wrote: > > On Thu, 2018-08-23 at 09:55 +0100, Luca Boccassi wrote: > >

Re: [dpdk-dev] [dpdk-stable] 16.11.8 (LTS) patches review and test

Great, thank you very much. I'll push the release later tonight. On Wed, 2018-08-29 at 15:28 +0200, Marco Varlese wrote: > Hi Luca & all, > > I confirm tests carried out via test_pmd and Ovs-DPDK do not show any > regression > for us. > > > Cheers, > Marco > > On Wed, 2018-08-29 at 10:55 +010

[dpdk-dev] [PATCH v3] net/mlx: add meson build support

Compile Mellanox drivers when their external dependencies are met. A glue version of the driver can still be requested by using the -Denable_driver_mlx_glue=true To avoid modifying the whole sources and keep the compatibility with current build systems (e.g. make), the mlx{4,5}_autoconf.h is stil

Re: [dpdk-dev] [PATCH] vhost: fix crash if set vring num handling failed

Any thoughts on this? Best regards, Ilya Maximets. On 17.08.2018 14:33, Ilya Maximets wrote: > Allocation failures of shadow used ring and batched copy array > are not recoverable and leads to the segmentation faults like > this on the receiving/transmission path: > > Program received signal S

Re: [dpdk-dev] [PATCH 7/7] eal: improve musl compatibility

On 29-Aug-18 1:39 PM, Bruce Richardson wrote: On Wed, Aug 29, 2018 at 12:56:21PM +0100, Anatoly Burakov wrote: Musl complains about pthread id being of wrong size. Fix it by casting to 64-bit and printing 64-bit hex unconditionally. Signed-off-by: Anatoly Burakov --- Given that on linux pthre

Re: [dpdk-dev] [PATCH 2/7] pci/vfio: improve musl compatibility

On 29-Aug-18 1:35 PM, Bruce Richardson wrote: On Wed, Aug 29, 2018 at 12:56:16PM +0100, Anatoly Burakov wrote: Musl already has PAGE_SIZE defined, and our define clashed with it. Rename our define to SYS_PAGE_SIZE. Bugzilla ID: 36 Signed-off-by: Anatoly Burakov --- Would it not be easier to

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/bonding: per-slave intermediate rx ring

On Tue, Aug 28, 2018 at 5:51 AM Matan Azrad wrote: > > > From: Chas Williams > >On Mon, Aug 27, 2018 at 11:30 AM Matan Azrad > wrote: > > >>>Because rings are generally quite efficient. > >> > >>But you are using a ring in addition to regular array management, it > mu

Re: [dpdk-dev] 18.08 build error on ppc64el - bool as vector type

On Wed, Aug 29, 2018 at 3:16 PM Adrien Mazarguil wrote: > On Wed, Aug 29, 2018 at 10:27:03AM +0200, Christian Ehrhardt wrote: > > On Tue, Aug 28, 2018 at 5:02 PM Adrien Mazarguil < > adrien.mazarg...@6wind.com> > > wrote: > > > > > On Tue, Aug 28, 2018 at 02:38:35PM +0200, Christian Ehrhardt wrot

Re: [dpdk-dev] [PATCH v5] app/testpmd: add forwarding mode to simulate a noisy neighbour

On 08/10/2018 03:49 PM, Jens Freimann wrote: > This adds a new forwarding mode to testpmd to simulate > more realistic behavior of a guest machine engaged in receiving > and sending packets performing Virtual Network Function (VNF). > Hi Jens, comments below, thanks, Kevin. > The goal is to ena

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/bonding: per-slave intermediate rx ring

From: Chas Williams >On Tue, Aug 28, 2018 at 5:51 AM Matan Azrad wrote: > > >From: Chas Williams >>On Mon, Aug 27, 2018 at 11:30 AM Matan Azrad >> wrote: > Because rings are generally quite efficient. >>> >>>But you are using a ri

Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type

On Mon, 27 Aug 2018 18:08:35 +0530 Jerin Jacob wrote: > Add support for IGMP packet type. > > Signed-off-by: Jerin Jacob Could you add logic to recoginize IGMP to the software packet type identification rte_net_get_ptype used by drivers that don't have hardware support. Also shouldn't this b

Re: [dpdk-dev] [PATCH v3] app/testpmd: add new command for show port info

On Wed, 29 Aug 2018 11:47:29 +0100 Emma Finn wrote: > existing testpmd command "show port info" is too verbose. > Added a new summary command to print brief information on ports. > > console output: > testpmd> show port summary all > Number of available ports: 2 > Port MAC Ad

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

On Thu, 28 Jun 2018 18:55:08 -0700 Dan Gora wrote: > Add a new API function to KNI, rte_kni_update_link() to allow DPDK > applications to update the link state for the KNI network interfaces > in the linux kernel. > > Note that the default carrier state is set to off when the interface > is open

[dpdk-dev] [PATCH v3] net/virtio-user: check negotiated features before set

This patch checks negotiated features to see if necessary to offload before set the tap device offload capabilities. It also checks if kernel support the TUNSETOFFLOAD operation. Signed-off-by: eric zhang --- v3: * make other offloading features depend on CSUM * check IFF_VNET_HDR support when h

[dpdk-dev] [PATCH] eal: force IOVA mode to physical

This patch adds a configuration option to force the IOVA mode to physical address (PA). There exists virtual devices that are not directly attached to the PCI bus, and therefore the auto detection of the IOVA mode based on probing the PCI bus and IOMMU configuration may not report the required addr

Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type

-Original Message- > Date: Wed, 29 Aug 2018 08:31:10 -0700 > From: Stephen Hemminger > To: Jerin Jacob > Cc: dev@dpdk.org, olivier.m...@6wind.com > Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type > > External Email > > On Mon, 27 Aug 2018 18:08:35 +0530 > Jerin Jacob wrote:

[dpdk-dev] [PATCH] test-meson-builds: add 32-bit compilation test

Add in a cross-file to enable 32-bit compile tests as part of the test-meson-builds script. Signed-off-by: Bruce Richardson --- NOTE: For ease of use, it's recommended that meson 0.47 be used for this testing. With earlier versions, it may be necessary to ensure that the same development packages

[dpdk-dev] [PATCH] build: add configuration summary at end of config

After running meson to configure a DPDK build, it can be useful to know what was automatically enabled or disabled. Therefore, print out by way of summary a categorised list of libraries and drivers to be built. Signed-off-by: Bruce Richardson --- drivers/meson.build | 5 + lib/meson.build

Re: [dpdk-dev] [PATCH v3] app/testpmd: add new command for show port info

On 8/29/2018 11:47 AM, Emma Finn wrote: > existing testpmd command "show port info" is too verbose. > Added a new summary command to print brief information on ports. > > console output: > testpmd> show port summary all > Number of available ports: 2 > Port MAC Address Name

Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type

On Wed, 29 Aug 2018 21:29:05 +0530 Jerin Jacob wrote: > -Original Message- > > Date: Wed, 29 Aug 2018 08:31:10 -0700 > > From: Stephen Hemminger > > To: Jerin Jacob > > Cc: dev@dpdk.org, olivier.m...@6wind.com > > Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type > > > > Exte

Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type

On Wed, 29 Aug 2018 21:29:05 +0530 Jerin Jacob wrote: > -Original Message- > > Date: Wed, 29 Aug 2018 08:31:10 -0700 > > From: Stephen Hemminger > > To: Jerin Jacob > > Cc: dev@dpdk.org, olivier.m...@6wind.com > > Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type > > > > Exte

Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type

-Original Message- > Date: Wed, 29 Aug 2018 09:34:36 -0700 > From: Stephen Hemminger > To: Jerin Jacob > Cc: dev@dpdk.org, olivier.m...@6wind.com > Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type > > External Email > > On Wed, 29 Aug 2018 21:29:05 +0530 > Jerin Jacob wrote:

Re: [dpdk-dev] [PATCH 7/7] eal: improve musl compatibility

On Wed, 29 Aug 2018 12:56:21 +0100 Anatoly Burakov wrote: > Musl complains about pthread id being of wrong size. Fix it by > casting to 64-bit and printing 64-bit hex unconditionally. > > Signed-off-by: Anatoly Burakov What is pthread_t on musl? On Linux it is unsigned long.

Re: [dpdk-dev] [PATCH 7/7] eal: improve musl compatibility

On Wed, 29 Aug 2018 15:09:47 +0100 "Burakov, Anatoly" wrote: > On 29-Aug-18 1:39 PM, Bruce Richardson wrote: > > On Wed, Aug 29, 2018 at 12:56:21PM +0100, Anatoly Burakov wrote: > >> Musl complains about pthread id being of wrong size. Fix it by > >> casting to 64-bit and printing 64-bit hex un

Re: [dpdk-dev] IXGBE throughput loss with 4+ cores

On 08/29/2018 01:39 AM, Wiles, Keith wrote: On Aug 28, 2018, at 2:16 PM, Saber Rezvani wrote: On 08/28/2018 11:39 PM, Wiles, Keith wrote: Which version of Pktgen? I just pushed a patch in 3.5.3 to fix a performance problem. I use Pktgen verion 3.0.0, indeed it is O.k as far as I hav

[dpdk-dev] [dpdk-announce] DPDK 16.11.8 (LTS) released

Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-16.11.8.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=16.11 Luca Boccassi --- MAINTAINERS| 10 +- app/test-pmd/testpmd.c

Re: [dpdk-dev] IXGBE throughput loss with 4+ cores

> On Aug 29, 2018, at 12:19 PM, Saber Rezvani wrote: > > > > On 08/29/2018 01:39 AM, Wiles, Keith wrote: >> >>> On Aug 28, 2018, at 2:16 PM, Saber Rezvani wrote: >>> >>> >>> >>> On 08/28/2018 11:39 PM, Wiles, Keith wrote: Which version of Pktgen? I just pushed a patch in 3.5.3 to fi

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

On Wed, Aug 29, 2018 at 12:54 PM, Stephen Hemminger wrote: > On Thu, 28 Jun 2018 18:55:08 -0700 > Dan Gora wrote: > >> Add a new API function to KNI, rte_kni_update_link() to allow DPDK >> applications to update the link state for the KNI network interfaces >> in the linux kernel. >> >> Note that

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

On Wed, Aug 29, 2018 at 8:48 AM, Ferruh Yigit wrote: > On 6/29/2018 2:55 AM, Dan Gora wrote: >> Add a new API function to KNI, rte_kni_update_link() to allow DPDK >> applications to update the link state for the KNI network interfaces >> in the linux kernel. >> >> Note that the default carrier sta

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

On Wed, 29 Aug 2018 18:02:06 -0300 Dan Gora wrote: > On Wed, Aug 29, 2018 at 12:54 PM, Stephen Hemminger > wrote: > > On Thu, 28 Jun 2018 18:55:08 -0700 > > Dan Gora wrote: > > > >> Add a new API function to KNI, rte_kni_update_link() to allow DPDK > >> applications to update the link state f

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

On Wed, 29 Aug 2018 18:10:35 -0300 Dan Gora wrote: > On Wed, Aug 29, 2018 at 8:48 AM, Ferruh Yigit wrote: > > On 6/29/2018 2:55 AM, Dan Gora wrote: > >> Add a new API function to KNI, rte_kni_update_link() to allow DPDK > >> applications to update the link state for the KNI network interfaces

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

On Wed, Aug 29, 2018 at 7:00 PM, Stephen Hemminger wrote: >> >> Add a new API function to KNI, rte_kni_update_link() to allow DPDK >> >> applications to update the link state for the KNI network interfaces >> >> in the linux kernel. >> >> >> >> Note that the default carrier state is set to off whe

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

On Wed, Aug 29, 2018 at 7:12 PM, Dan Gora wrote: > On Wed, Aug 29, 2018 at 7:00 PM, Stephen Hemminger > wrote: >>> >> Add a new API function to KNI, rte_kni_update_link() to allow DPDK >>> >> applications to update the link state for the KNI network interfaces >>> >> in the linux kernel. >>> >> >

  1   2   >