Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: convert to new Rx offloads API

2018-03-30 Thread Zhang, Qi Z
Hi Yanglong > > if (frame_size > ETHER_MAX_LEN) > - dev_data->dev_conf.rxmode.jumbo_frame = 1; > + dev_data->dev_conf.rxmode.offloads |= > + DEV_RX_OFFLOAD_JUMBO_FRAME; > else > - dev_data->dev_conf.rxmode.jumbo_frame = 0; > +

Re: [dpdk-dev] [PATCH 4/4] eal: set affinity for control threads

2018-03-30 Thread Olivier Matz
On Thu, Mar 29, 2018 at 09:04:52AM +0100, Burakov, Anatoly wrote: > On 27-Feb-18 2:46 PM, Olivier Matz wrote: > > The management threads must not bother the dataplane or service cores. > > Set the affinity of these threads accordingly. > > > > Signed-off-by: Olivier Matz > > --- > > <...> > > >

Re: [dpdk-dev] [PATCH v3] net/vhost: fix segfault when creating vdev dynamically

2018-03-30 Thread Yang, Zhiyong
Hi Maxime, Junjie, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Junjie Chen > Sent: Friday, March 30, 2018 2:59 PM > To: Tan, Jianfeng ; maxime.coque...@redhat.com; > mtetsu...@gmail.com > Cc: dev@dpdk.org; Chen, Junjie J ; > c...@dpdk.org > Subject: [dpdk-de

Re: [dpdk-dev] [PATCH v3] net/vhost: fix segfault when creating vdev dynamically

2018-03-30 Thread Maxime Coquelin
Hi Junjie, On 03/30/2018 08:58 AM, Junjie Chen wrote: When creating vdev dynamically, vhost pmd driver starts directly without checking TX/RX queues are ready or not, and thus causes segmentation fault when vhost library accesses queues. This patch adds a flag to check whether queues are setup o

Re: [dpdk-dev] [PATCH v3] net/vhost: fix segfault when creating vdev dynamically

2018-03-30 Thread Maxime Coquelin
On 03/30/2018 09:32 AM, Yang, Zhiyong wrote: Hi Maxime, Junjie, -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Junjie Chen Sent: Friday, March 30, 2018 2:59 PM To: Tan, Jianfeng ; maxime.coque...@redhat.com; mtetsu...@gmail.com Cc: dev@dpdk.org; Chen, Junjie J

Re: [dpdk-dev] [PATCH v3 2/7] crpyto/virtio: add crypto related session structure

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhoujian (jay) [mailto:jianjay.z...@huawei.com] > Sent: Friday, March 30, 2018 3:44 AM > To: De Lara Guarch, Pablo ; > dev@dpdk.org > Cc: Zhang, Roy Fan ; tho...@monjalon.net; > Gonglei (Arei) ; Zeng, Xin > ; Huangweidong (C) ; > wangxin (U) ; longpeng > > Su

Re: [dpdk-dev] [PATCH v3 3/7] cryptodev/virtio: core code of crypto devices

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhoujian (jay) [mailto:jianjay.z...@huawei.com] > Sent: Friday, March 30, 2018 4:03 AM > To: De Lara Guarch, Pablo ; > dev@dpdk.org > Cc: Zhang, Roy Fan ; tho...@monjalon.net; > Gonglei (Arei) ; Zeng, Xin > ; Huangweidong (C) ; > wangxin (U) ; longpeng > > Su

Re: [dpdk-dev] [PATCH v3 4/4] net/vhost: add NULL pointer checking

2018-03-30 Thread Yang, Zhiyong
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yang, Zhiyong > Sent: Friday, March 30, 2018 10:01 AM > To: Maxime Coquelin ; dev@dpdk.org > Cc: Tan, Jianfeng ; Wang, Zhihong > ; tho...@monjalon.net; Wang, Dong1 > ; Bie, Tiwei > Subject: Re: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH] vhost: avoid concurrency when logging dirty pages

2018-03-30 Thread Maxime Coquelin
On 03/21/2018 04:44 PM, Maxime Coquelin wrote: This patch aims at fixing a migration performance regression faced since atomic operation is used to log pages as dirty when doing live migration. Instead of setting a single bit by doing an atomic read-modify-write operation to log a page as dirt

Re: [dpdk-dev] [PATCH v3] net/vhost: fix segfault when creating vdev dynamically

2018-03-30 Thread Maxime Coquelin
On 03/30/2018 08:58 AM, Junjie Chen wrote: When creating vdev dynamically, vhost pmd driver starts directly without checking TX/RX queues are ready or not, and thus causes segmentation fault when vhost library accesses queues. This patch adds a flag to check whether queues are setup or not, and

Re: [dpdk-dev] [PATCH 2/2] vhost: add pipe event for optimizing negotiating

2018-03-30 Thread Maxime Coquelin
Hi Xiangxia, On 03/29/2018 01:24 PM, Tonghao Zhang wrote: On Thu, Mar 29, 2018 at 3:32 PM, Tan, Jianfeng wrote: Hi Xiangxia, -Original Message- From: xiangxia.m@gmail.com [mailto:xiangxia.m@gmail.com] Sent: Wednesday, March 28, 2018 1:49 PM To: Tan, Jianfeng Cc: dev@dpdk.org;

Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: convert to new Rx offloads API

2018-03-30 Thread Wu, Yanglong
Hi, -Original Message- From: Zhang, Qi Z Sent: Friday, March 30, 2018 3:25 PM To: Wu, Yanglong ; dev@dpdk.org Cc: Dai, Wei ; Xing, Beilei Subject: RE: [PATCH v3 1/2] net/i40e: convert to new Rx offloads API Hi Yanglong > > if (frame_size > ETHER_MAX_LEN) > - dev_data

Re: [dpdk-dev] [PATCH v2 1/2] vhost: make sure vhost fdset-thread created successfully

2018-03-30 Thread Maxime Coquelin
On 03/23/2018 03:18 AM, xiangxia.m@gmail.com wrote: From: Tonghao Zhang When first call the 'rte_vhost_driver_start', the fdset_event_dispatch thread should be created successfully. Because the vhost uses it to poll socket events for vhost server or clients. Without it, for example, vhost

Re: [dpdk-dev] [PATCH v2 2/2] vhost: add fdset-event thread name

2018-03-30 Thread Maxime Coquelin
On 03/23/2018 03:18 AM, xiangxia.m@gmail.com wrote: From: Tonghao Zhang This patch adds the name for vhost fdset thread. It can help us to know whether the thread is running. Signed-off-by: Tonghao Zhang Reviewed-by: Jianfeng Tan --- lib/librte_vhost/socket.c | 9 + 1 file c

Re: [dpdk-dev] [PATCH 2/2] vhost: add pipe event for optimizing negotiating

2018-03-30 Thread Tonghao Zhang
On Fri, Mar 30, 2018 at 3:57 PM, Maxime Coquelin wrote: > Hi Xiangxia, > > > On 03/29/2018 01:24 PM, Tonghao Zhang wrote: >> >> On Thu, Mar 29, 2018 at 3:32 PM, Tan, Jianfeng >> wrote: >>> >>> Hi Xiangxia, >>> -Original Message- From: xiangxia.m@gmail.com [mailto:xiangxia.m.

Re: [dpdk-dev] [PATCH 2/2] vhost: add pipe event for optimizing negotiating

2018-03-30 Thread Maxime Coquelin
On 03/30/2018 10:07 AM, Tonghao Zhang wrote: On Fri, Mar 30, 2018 at 3:57 PM, Maxime Coquelin wrote: Hi Xiangxia, On 03/29/2018 01:24 PM, Tonghao Zhang wrote: On Thu, Mar 29, 2018 at 3:32 PM, Tan, Jianfeng wrote: Hi Xiangxia, -Original Message- From: xiangxia.m@gmail.com

Re: [dpdk-dev] [PATCH 1/2] vhost: move stdbool header file to vhost.h

2018-03-30 Thread Maxime Coquelin
On 03/28/2018 07:49 AM, xiangxia.m@gmail.com wrote: From: Tonghao Zhang The vhost.h file uses bool type, but not include stdbool header file. If other c files include vhost.h directly, there will be a compile error. This patch will be used in the next patch. Signed-off-by: Tonghao Zhang

Re: [dpdk-dev] [PATCH 0/2] add pipe event for optimizing negotiating

2018-03-30 Thread Maxime Coquelin
On 03/28/2018 07:49 AM, xiangxia.m@gmail.com wrote: From: Tonghao Zhang These patches depend on previous patches. 1. http://dpdk.org/dev/patchwork/patch/36440/ 2. http://dpdk.org/dev/patchwork/patch/36441/ Tonghao Zhang (2): vhost: move stdbool header file to vhost.h vhost: add pip

Re: [dpdk-dev] [PATCH v2] vhost: avoid populate guest memory

2018-03-30 Thread Maxime Coquelin
On 03/28/2018 08:56 AM, Jianfeng Tan wrote: It's not necessary to populate guest memory from vhost side unless zerocopy is enabled or users want better performance. Update the doc for guest memory requirement clarification. Cc: maxime.coque...@redhat.com Signed-off-by: Jianfeng Tan --- do

[dpdk-dev] [PATCH v4 0/2] convert to new Rx/Tx offloads API

2018-03-30 Thread Yanglong Wu
This patch support new offloads API in i40e PF and VF. Yanglong Wu (2): net/i40e: convert to new Rx offloads API net/i40e: convert to new Tx offloads API drivers/net/i40e/i40e_ethdev.c| 28 +-- drivers/net/i40e/i40e_ethdev_vf.c | 22 +-- drivers/net/i40e/i40e_

[dpdk-dev] [PATCH v4 2/2] net/i40e: convert to new Tx offloads API

2018-03-30 Thread Yanglong Wu
Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new Tx offloads API. Signed-off-by: Yanglong Wu --- v2: Adding offload requests checking and reworking patch according to review comments --- v3: fix error --- v4: fix

[dpdk-dev] [PATCH v4 1/2] net/i40e: convert to new Rx offloads API

2018-03-30 Thread Yanglong Wu
Ethdev Rx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Rx queue offloads API") This commit support the new Rx offloads API. Signed-off-by: Yanglong Wu --- v2: Adding offload requests checking and reworking patch according to review comments --- v3: fix error --- v4: fix

[dpdk-dev] [PATCH] net/virtio-user: fix port_id type

2018-03-30 Thread zhiyong . yang
virtio-user port_id range should be increased from 8 bits to 16 bits. Fixes: f8244c6399d9 ("ethdev: increase port id range") Signed-off-by: Zhiyong Yang --- drivers/net/virtio/virtio_user/virtio_user_dev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio/vir

Re: [dpdk-dev] [PATCH] mk: fix kernel modules build dependency

2018-03-30 Thread Thomas Monjalon
29/03/2018 20:43, Ferruh Yigit: > On 3/29/2018 7:21 PM, Ferruh Yigit wrote: > > On 3/29/2018 6:01 PM, Thomas Monjalon wrote: > >> 29/03/2018 18:50, Ferruh Yigit: > >>> On 3/29/2018 5:43 PM, Thomas Monjalon wrote: > 29/03/2018 18:38, Ferruh Yigit: > > On 3/29/2018 5:32 PM, Thomas Monjalon w

Re: [dpdk-dev] [PATCH v2] vhost: avoid populate guest memory

2018-03-30 Thread Maxime Coquelin
On 03/30/2018 10:21 AM, Maxime Coquelin wrote: On 03/28/2018 08:56 AM, Jianfeng Tan wrote: It's not necessary to populate guest memory from vhost side unless zerocopy is enabled or users want better performance. Update the doc for guest memory requirement clarification. Cc: maxime.coque...

Re: [dpdk-dev] [PATCH] net/virtio-user: fix port_id type

2018-03-30 Thread Maxime Coquelin
On 03/30/2018 10:31 AM, zhiyong.y...@intel.com wrote: virtio-user port_id range should be increased from 8 bits to 16 bits. Fixes: f8244c6399d9 ("ethdev: increase port id range") Next time, please add cc: sta...@dpdk.org as it targets v17.11 LTS. Signed-off-by: Zhiyong Yang Reviewed-by:

Re: [dpdk-dev] [PATCH] net/virtio-user: fix port_id type

2018-03-30 Thread Yang, Zhiyong
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Friday, March 30, 2018 4:37 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: Bie, Tiwei ; sta...@dpdk.org > Subject: Re: [PATCH] net/virtio-user: fix port_id type > > > > On 03/30/2018 10:31 AM, zhiyong

Re: [dpdk-dev] [PATCH v6 1/2] app/testpmd: add commands to test new Rx offload API

2018-03-30 Thread Wu, Jingjing
> -Original Message- > From: Dai, Wei > Sent: Thursday, March 22, 2018 1:00 AM > To: Lu, Wenzhuo ; Wu, Jingjing > Cc: dev@dpdk.org; Dai, Wei > Subject: [PATCH v6 1/2] app/testpmd: add commands to test new Rx offload API > > Add following testpmd run-time commands to support test of > n

Re: [dpdk-dev] [PATCH v3 0/5] vhost: support selective datapath

2018-03-30 Thread Wang, Zhihong
Pawel, > > 3. To make vhost aware of its own type, an engine id (eid) and a device > > id (did) are added into the vhost data structure to identify the actual > > device. APIs are introduced to let app configure them. When the default > > software datapath is used, eid and did are set

[dpdk-dev] [PATCH v2 24/41] vfio: allow to map other memory regions

2018-03-30 Thread Gowrishankar
From: Gowrishankar Muthukrishnan Below patch adds powerpc arch specific changes. Signed-off-by: Gowrishankar Muthukrishnan --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 63 +- 1 file changed, 47 insertions(+), 16 deletions(-) diff --git a/lib/librte_eal/linuxapp

Re: [dpdk-dev] [PATCH v4 1/2] eventdev: add device stop flush callback

2018-03-30 Thread Liang, Ma
On 29 Mar 04:02, Van Haaren, Harry wrote: > (+Liang Ma for OPDL maintainer) > > Ping to maintainers, is the below suggestion acceptable for your PMDs? > > Summary of suggestion: > - After event_dev_stop() dequeue() is no longer allowed on any thread > - All events in the system (queues, ports, in

[dpdk-dev] [PATCH v4 1/5] vhost: export vhost feature definitions

2018-03-30 Thread Zhihong Wang
This patch exports vhost-user protocol features to support device driver development. Signed-off-by: Zhihong Wang --- Changes in v3: 1. Keep macro names the same as in the spec. lib/librte_vhost/rte_vhost.h | 30 ++ lib/librte_vhost/vhost.h | 2 -- lib/librt

[dpdk-dev] [PATCH v4 2/5] vhost: support selective datapath

2018-03-30 Thread Zhihong Wang
This patch set introduces support for selective datapath in DPDK vhost-user lib. vDPA stands for vhost Data Path Acceleration. The idea is to support virtio ring compatible devices to serve virtio driver directly to enable datapath acceleration. A set of device ops is defined for device specific o

[dpdk-dev] [PATCH v4 0/5] vhost: support selective datapath

2018-03-30 Thread Zhihong Wang
This patch set introduces support for selective datapath in DPDK vhost-user lib. vDPA stands for vhost Data Path Acceleration. The idea is to support virtio ring compatible devices to serve virtio driver directly to enable datapath acceleration. Design details A vDPA device is a virtio ring

[dpdk-dev] [PATCH v4 5/5] vhost: add apis for live migration

2018-03-30 Thread Zhihong Wang
This patch adds APIs to enable live migration for non-builtin data paths. At src side, last_avail/used_idx from the device need to be set into the virtio_net structure, and the log_base and log_size from the virtio_net structure need to be set into the device. At dst side, last_avail/used_idx nee

[dpdk-dev] [PATCH v4 3/5] vhost: add apis for datapath configuration

2018-03-30 Thread Zhihong Wang
This patch adds APIs for datapath configuration. The did of the vhost-user socket can be set to identify the backend device, in this case each vhost-user socket can have only 1 connection. The did is set to -1 by default when the software datapath is used. Signed-off-by: Zhihong Wang --- Changes

[dpdk-dev] [PATCH v4 4/5] vhost: adapt vhost lib for selective datapath

2018-03-30 Thread Zhihong Wang
This patch adapts vhost lib for selective datapath by calling device ops at the corresponding stage. Signed-off-by: Zhihong Wang --- Changes in v4: 1. Remove the "engine" concept in the lib. --- Changes in v2: 1. Ensure negotiated capabilities are supported in vhost-user lib. 2. Configure

Re: [dpdk-dev] [PATCH] mk: fix kernel modules build dependency

2018-03-30 Thread Ferruh Yigit
On 3/30/2018 9:32 AM, Thomas Monjalon wrote: > 29/03/2018 20:43, Ferruh Yigit: >> On 3/29/2018 7:21 PM, Ferruh Yigit wrote: >>> On 3/29/2018 6:01 PM, Thomas Monjalon wrote: 29/03/2018 18:50, Ferruh Yigit: > On 3/29/2018 5:43 PM, Thomas Monjalon wrote: >> 29/03/2018 18:38, Ferruh Yigit:

Re: [dpdk-dev] [PATCH v3] ethdev: replace bus specific struct with generic dev

2018-03-30 Thread Ferruh Yigit
On 3/30/2018 7:44 AM, David Marchand wrote: > Hello Ferruh, > > On Thu, Mar 29, 2018 at 7:52 PM, Ferruh Yigit wrote: >> Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it >> although it is common for all ethdev in all buses. >> >> Replacing pci specific struct with generic d

Re: [dpdk-dev] [PATCH 0/3] net/sfc: support Medford2 family adapters

2018-03-30 Thread Ferruh Yigit
On 3/21/2018 1:51 PM, Andrew Rybchenko wrote: > dpdk-web patch will follow. Thanks. > Andrew Rybchenko (3): > net/sfc: support link speeds up to 100G > net/sfc: support runtime VI window size > net/sfc: support Medford2 family adapters Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v4 0/2] convert to new Rx/Tx offloads API

2018-03-30 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Yanglong > Sent: Friday, March 30, 2018 4:22 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Dai, Wei ; Xing, > Beilei ; Wu, Yanglong > Subject: [PATCH v4 0/2] convert to new Rx/Tx offloads API > > This patch support new offloads API in i40e PF and VF. > > Ya

Re: [dpdk-dev] [PATCH v2 0/4] ethdev: add per-PMD tuning of RxTx parmeters

2018-03-30 Thread Ferruh Yigit
On 3/27/2018 7:43 PM, Ferruh Yigit wrote: > On 3/21/2018 2:27 PM, Remy Horton wrote: >> The optimal values of several transmission & reception related parameters, >> such as burst sizes, descriptor ring sizes, and number of queues, varies >> between different network interface devices. This patchse

Re: [dpdk-dev] [PATCH v3] igb_uio: bind error if pcie bridge

2018-03-30 Thread Ferruh Yigit
On 3/29/2018 5:37 PM, Ajit Khaparde wrote: > From: Darren Edamura > > Probe function should exit immediately if pcie bridge detected > > Signed-off-by: Darren Edamura > Signed-off-by: Rahul Gupta > Signed-off-by: Scott Branden > Signed-off-by: Ajit Khaparde Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH 1/4] introduce Broadcom Stingray

2018-03-30 Thread Ferruh Yigit
On 3/21/2018 6:06 PM, Ajit Khaparde wrote: > From: Scott Branden > > Add Broadcom Stingray machine support based on armv8. > > For product brief see: > https://www.broadcom.com/products/ethernet-connectivity/controllers/bcm58800 > > Signed-off-by: Scott Branden > Signed-off-by: Ajit Khaparde

Re: [dpdk-dev] [PATCH 3/4] mk: allow kernel artifacts to be located in output directory

2018-03-30 Thread Ferruh Yigit
On 3/21/2018 6:06 PM, Ajit Khaparde wrote: > From: Scott Branden > > Allow kernel artifacts to be located in output directory specific > by RTE_KERNELDIR_OUT. How to use this variable, I tried following but kernel modules are still in same place: - make RTE_KERNELDIR_OUT=/tmp/kmod O=ferruh DE

Re: [dpdk-dev] [PATCH 2/4] net/bnxt: add support for Stingray PF devices ids

2018-03-30 Thread Ferruh Yigit
On 3/21/2018 6:06 PM, Ajit Khaparde wrote: > From: Scott Branden > > Add support for Stingray PF devices ids: > BCM58802 = 0xd802 > BCM58804 = 0xd804 > BCM58808 = 0x16f0 > > Signed-off-by: Scott Branden > Signed-off-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_ethdev.c | 6 ++ Can you

Re: [dpdk-dev] [PATCH v2] net/bnxt: convert to SPDX license tag

2018-03-30 Thread Ferruh Yigit
On 3/29/2018 5:40 PM, Ajit Khaparde wrote: > From: Scott Branden > > Update the license header on bnxt files to be the standard > BSD-3-Clause license used for the rest of DPDK, > bring the files in compliance with the DPDK licensing policy. > > Signed-off-by: Scott Branden > Signed-off-by: Aji

Re: [dpdk-dev] [PATCH 1/4] net/nfp: add NFP CPP support

2018-03-30 Thread Ferruh Yigit
On 3/23/2018 5:35 PM, Alejandro Lucero wrote: > CPP refers to the internal NFP Command Push Pull bus. This patch allows > to create CPP commands from user space allowing to access any single > part of the chip. > > This CPP interface is the base for having other functionalities like > mutexes when

Re: [dpdk-dev] [PATCH 3/4] doc: update NFP guide

2018-03-30 Thread Ferruh Yigit
On 3/23/2018 5:35 PM, Alejandro Lucero wrote: > New CPP interface changes the way firmware upload is managed by > the PMD. It also supports different firmware file names for > having specific firmware aplications per card. > > Signed-off-by: Alejandro Lucero This conflicts with another nfp doc p

Re: [dpdk-dev] [PATCH v2] net/mrvl: rename PMD driver as mvpp2

2018-03-30 Thread Ferruh Yigit
On 3/27/2018 8:20 PM, Ferruh Yigit wrote: > On 3/26/2018 3:38 PM, Tomasz Duszynski wrote: >> From: Natalie Samsonov >> >> The name "mrvl" for Marvell PMD driver for PPv2 Marvell PPv2 >> (Packet Processor v2) 1/10 Gbps adapter is too generic and causes >> problem for adding new PMD drivers for othe

Re: [dpdk-dev] [PATCH v2] net/bnxt: switch to the new offload API

2018-03-30 Thread Ferruh Yigit
On 3/26/2018 11:47 PM, Ajit Khaparde wrote: > Update bnxt PMD to new ethdev offloads API. > > Signed-off-by: Ajit Khaparde > --- > v1->v2: return an error if requested offload flags do not > match supported offload capabilities. <...> > + > + dev_info->rx_queue_offload_capa = BNXT_DEV_RX_OF

Re: [dpdk-dev] [PATCH 1/5] net/qede: convert to new Rx/Tx offloads API

2018-03-30 Thread Ferruh Yigit
On 3/28/2018 1:15 AM, Rasesh Mody wrote: > From: Harish Patil > > Ethdev RX/TX offloads API has changed since: > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") > commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") > > This patch makes use of new offload flags as sugg

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-03-30 Thread Ferruh Yigit
On 3/28/2018 1:07 PM, Matan Azrad wrote: > Hi Ferruh > >> From: Ferruh Yigit, Wednesday, March 28, 2018 1:38 AM >> On 3/5/2018 3:12 PM, Matan Azrad wrote: >>> Hi Ferruh >>> >>> From: Ferruh Yigit, Sent: Monday, March 5, 2018 5:07 PM On 3/5/2018 2:52 PM, Matan Azrad wrote: > HI > >

Re: [dpdk-dev] [PATCH v2] maintainers: call out subtree committers

2018-03-30 Thread Ferruh Yigit
On 3/28/2018 8:30 PM, Pablo de Lara wrote: > The MAINTAINERS file contains information of the maintainers > of the different components on DPDK. > However, it does not give any information on who maintains the > different subtrees which accept new commits for these components. > > This commit adds

Re: [dpdk-dev] [PATCH] ethdev: fix port accessing after release

2018-03-30 Thread Ferruh Yigit
On 3/28/2018 1:25 PM, Thomas Monjalon wrote: > 28/03/2018 14:10, Matan Azrad: >> rte_eth_dev_pci_release() function wrongly releases an ethdev port and >> then releases internal fields of this port. >> This behavior is problematic, because after the release, the port may >> be reallocated again by

Re: [dpdk-dev] [PATCH] mk: fix kernel modules build dependency

2018-03-30 Thread Thomas Monjalon
30/03/2018 12:15, Ferruh Yigit: > On 3/30/2018 9:32 AM, Thomas Monjalon wrote: > > 29/03/2018 20:43, Ferruh Yigit: > >> On 3/29/2018 7:21 PM, Ferruh Yigit wrote: > >>> On 3/29/2018 6:01 PM, Thomas Monjalon wrote: > 29/03/2018 18:50, Ferruh Yigit: > > On 3/29/2018 5:43 PM, Thomas Monjalon w

[dpdk-dev] [pull-request] next-net 18.05 PRE-RC1

2018-03-30 Thread Ferruh Yigit
The following changes since commit 984af543c254be1fc3f0ae46f381d75dcd0af361: mk: fix kernel modules build dependency (2018-03-30 13:01:17 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-net for you to fetch changes up to 8dd1be166be212db7f0cc0d4e3f680772c3

Re: [dpdk-dev] [PATCH v4 00/49] ip_pipeline: refactoring

2018-03-30 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Thursday, March 29, 2018 7:31 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH v4 00/49] ip_pipeline: refactoring > > Refactored the IP pipeline application. As result, the code base > size (lines of code) reduces b

[dpdk-dev] [pull-request] next-pipeline 18.05 PRE-RC1

2018-03-30 Thread Cristian Dumitrescu
The following changes since commit 20526313ba41174d3e7831ee800f6e938a1d5b85: usertools: support AVP device (2018-03-28 00:49:53 +0200) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-pipeline for you to fetch changes up to 36220e6943edf997941f3375e5a5b4a222e45445

[dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Andrew Rybchenko
Hi all, Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: lib/librte_vhost/fd_man.c:284:2: error: ignoring return value of ‘read’, declared with attribute warn_unused_result [-Werror=unused-result] read(readfd, charbuf, siz

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Maxime Coquelin
Hi Andrew, On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: Hi all, Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: lib/librte_vhost/fd_man.c:284:2: error: ignoring return value of ‘read’, declared with attribute warn_unus

[dpdk-dev] Survey for final decision about per-port offload API

2018-03-30 Thread Thomas Monjalon
There are some discussions about a specific part of the offload API: "To enable per-port offload, the offload should be set on both device configuration and queue setup." It means the application must repeat the port offload flags in rte_eth_conf.[rt]xmode.offloads and rte_eth_[rt]

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Ferruh Yigit
On 3/30/2018 2:27 PM, Maxime Coquelin wrote: > Hi Andrew, > > On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: >> Hi all, >> >> Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: >> >> lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: >> lib/librte_vhost/fd_man.c:284:2: error: ig

[dpdk-dev] [PATCH 2/2] ip_pipeline: add ecmp route example

2018-03-30 Thread Jasvinder Singh
From: Cristian Dumitrescu Add example to build pipeline to demonstrate equal-cost multi-path routing example. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline_new/examples/route_ecmp.cli | 57 1 file changed, 57 insertions(+)

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Tonghao Zhang
On Fri, Mar 30, 2018 at 10:13 PM, Ferruh Yigit wrote: > On 3/30/2018 2:27 PM, Maxime Coquelin wrote: >> Hi Andrew, >> >> On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: >>> Hi all, >>> >>> Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: >>> >>> lib/librte_vhost/fd_man.c: In function ‘fd

[dpdk-dev] [PATCH 1/2] ip_pipleine: fix load balance table action

2018-03-30 Thread Jasvinder Singh
Fix bug in load balance action for pipeline table. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/action.c | 42 ++ examples/ip_pipeline/cli.c| 9 - 2 files changed, 46 insertions(+), 5 deletions(-)

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Maxime Coquelin
On 03/30/2018 04:16 PM, Tonghao Zhang wrote: On Fri, Mar 30, 2018 at 10:13 PM, Ferruh Yigit wrote: On 3/30/2018 2:27 PM, Maxime Coquelin wrote: Hi Andrew, On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: Hi all, Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: lib/librte_vhost/f

[dpdk-dev] Cross-compile bug: buildtools/check-experimental-syms.sh

2018-03-30 Thread Raphael Cohn
Hi, I'm getting back into using DPDK after a break of about a year, and have tried to compile it again to run on Linux with the musl libc; I'm cross-compiling using a Mac and and a suitable cross toolchain (that works find for lots of other libraries; eg libverbs, rdma-core, etc). One of the firs

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Timothy Redaelli
On Fri, 30 Mar 2018 15:27:55 +0200 Maxime Coquelin wrote: > Hi Andrew, > > On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: > > Hi all, > > > > Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: > > > > lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: > > lib/librte_vhost/fd

[dpdk-dev] [PATCH v2 1/2] ip_pipleine: fix load balance table action

2018-03-30 Thread Jasvinder Singh
Fix bug in load balance action for pipeline table. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- examples/ip_pipeline/action.c | 42 ++ examples/ip_pipeline/cli.c| 9 - 2 files changed, 46 insertions(+), 5 deletions(-)

[dpdk-dev] [PATCH v2 2/2] ip_pipeline: add ecmp route example

2018-03-30 Thread Jasvinder Singh
Add example to build pipeline to demonstrate equal-cost multi-path routing example. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- v2: - fix checkpatch warnings on file permission. examples/ip_pipeline/examples/route_ecmp.cli | 57 1 file cha

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Tonghao Zhang
I rebuild it on ubuntu 17.10 and cash it. I use the 'RTE_SET_USED' to fix it. diff --git a/lib/librte_vhost/fd_man.c b/lib/librte_vhost/fd_man.c index 771675718..f11803191 100644 --- a/lib/librte_vhost/fd_man.c +++ b/lib/librte_vhost/fd_man.c @@ -279,7 +279,8 @@ fdset_pipe_read_cb(int readfd, voi

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Maxime Coquelin
On 03/30/2018 04:28 PM, Timothy Redaelli wrote: On Fri, 30 Mar 2018 15:27:55 +0200 Maxime Coquelin wrote: Hi Andrew, On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: Hi all, Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Maxime Coquelin
Thanks Xiangxia, I can post it, do you agree if I add below comments? On 03/30/2018 04:47 PM, Tonghao Zhang wrote: I rebuild it on ubuntu 17.10 and cash it. I use the 'RTE_SET_USED' to fix it. diff --git a/lib/librte_vhost/fd_man.c b/lib/librte_vhost/fd_man.c index 771675718..f11803191 100644

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-03-30 Thread Tonghao Zhang
On Fri, Mar 30, 2018 at 10:59 PM, Maxime Coquelin wrote: > Thanks Xiangxia, > > I can post it, do you agree if I add below comments? yes, thanks. > On 03/30/2018 04:47 PM, Tonghao Zhang wrote: >> >> I rebuild it on ubuntu 17.10 and cash it. I use the 'RTE_SET_USED' to fix >> it. >> >> >> diff --g

Re: [dpdk-dev] Survey for final decision about per-port offload API

2018-03-30 Thread Andrew Rybchenko
On 03/30/2018 04:47 PM, Thomas Monjalon wrote: There are some discussions about a specific part of the offload API: "To enable per-port offload, the offload should be set on both device configuration and queue setup." It means the application must repeat the port offload flags in

Re: [dpdk-dev] [PATCH v1 1/2] crypto/aesni_mb: support IPsec MUlti-buffer lib v0.49

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: Kovacevic, Marko > Sent: Tuesday, March 27, 2018 1:14 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Kovacevic, > Marko > Subject: [PATCH v1 1/2] crypto/aesni_mb: support IPsec MUlti-buffer lib > v0.49 > > From: Marko Kovacevic > > Signed-off-by: Mark

Re: [dpdk-dev] [PATCH v1 2/2] crypto/aesni_gcm: support IPsec Multi-buffer lib v0.49

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: Kovacevic, Marko > Sent: Tuesday, March 27, 2018 1:15 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Kovacevic, Marko > > Subject: [PATCH v1 2/2] crypto/aesni_gcm: support IPsec Multi-buffer lib v0.49 > > Signed-off-by: Marko Kovacevic Acked-by: Pablo

[dpdk-dev] [PATCH] vhost: fix build issue caused by unchecked returned values

2018-03-30 Thread Maxime Coquelin
This patch fixes below build issue seen with some compilers or build options: lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: lib/librte_vhost/fd_man.c:284:2: error: ignoring return value of ‘read’, declared with attribute warn_unused_result [-Werror=unused-result] read(readfd, cha

[dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with generic dev

2018-03-30 Thread Ferruh Yigit
Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it although it is common for all ethdev in all buses. Replacing pci specific struct with generic device struct and updating places that are using pci device in a way to get this information from generic device. Signed-off-by: F

Re: [dpdk-dev] [PATCH v4 0/2] convert to new Rx/Tx offloads API

2018-03-30 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Friday, March 30, 2018 6:33 PM > To: Wu, Yanglong; dev@dpdk.org > Cc: Dai, Wei; Xing, Beilei > Subject: Re: [dpdk-dev] [PATCH v4 0/2] convert to new Rx/Tx offloads API > > > > > -Origina

Re: [dpdk-dev] [PATCH] vhost: fix build issue caused by unchecked returned values

2018-03-30 Thread Andrew Rybchenko
On 03/30/2018 06:16 PM, Maxime Coquelin wrote: This patch fixes below build issue seen with some compilers or build options: lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: lib/librte_vhost/fd_man.c:284:2: error: ignoring return value of ‘read’, declared with attribute warn_unused_

Re: [dpdk-dev] [PATCH] vhost: fix build issue caused by unchecked returned values

2018-03-30 Thread Ferruh Yigit
On 3/30/2018 4:18 PM, Andrew Rybchenko wrote: > On 03/30/2018 06:16 PM, Maxime Coquelin wrote: >> This patch fixes below build issue seen with some compilers >> or build options: >> >> lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: >> lib/librte_vhost/fd_man.c:284:2: error: ignoring r

Re: [dpdk-dev] [PATCH v4 09/20] eal/dev: implement device iteration initialization

2018-03-30 Thread Wiles, Keith
> On Mar 29, 2018, at 4:23 PM, Gaetan Rivet wrote: > > Parse a device description. > Split this description in their relevant part for each layers. > No dynamic allocation is performed. > > Signed-off-by: Gaetan Rivet > --- > lib/Makefile| 1 + > lib/librte_eal/bs

Re: [dpdk-dev] [PATCH] vhost: fix build issue caused by unchecked returned values

2018-03-30 Thread Maxime Coquelin
On 03/30/2018 05:21 PM, Ferruh Yigit wrote: On 3/30/2018 4:18 PM, Andrew Rybchenko wrote: On 03/30/2018 06:16 PM, Maxime Coquelin wrote: This patch fixes below build issue seen with some compilers or build options: lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: lib/librte_vhost

Re: [dpdk-dev] [PATCH v1] crypto/aesni_mb: support AES CMAC

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: Kovacevic, Marko > Sent: Tuesday, March 27, 2018 1:16 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Jain, Deepak K > ; Kovacevic, Marko > Subject: [PATCH v1] crypto/aesni_mb: support AES CMAC > > From: Marko Kovacevic > > Signed-off-by: Marko Kovacev

Re: [dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with generic dev

2018-03-30 Thread David Marchand
On Fri, Mar 30, 2018 at 5:17 PM, Ferruh Yigit wrote: > Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it > although it is common for all ethdev in all buses. > > Replacing pci specific struct with generic device struct and updating > places that are using pci device in a way

Re: [dpdk-dev] [PATCH] vhost: fix build issue caused by unchecked returned values

2018-03-30 Thread Ferruh Yigit
On 3/30/2018 4:16 PM, Maxime Coquelin wrote: > This patch fixes below build issue seen with some compilers > or build options: > > lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: > lib/librte_vhost/fd_man.c:284:2: error: ignoring return value of ‘read’, > declared with attribute warn

Re: [dpdk-dev] [PATCH v2 1/2] ip_pipleine: fix load balance table action

2018-03-30 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Friday, March 30, 2018 3:31 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH v2 1/2] ip_pipleine: fix load balance table action > > Fix bug in load balance action for pipeline table. > > Signed-off-by: Cristian Dum

Re: [dpdk-dev] [PATCH v2 2/2] ip_pipeline: add ecmp route example

2018-03-30 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Friday, March 30, 2018 3:31 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH v2 2/2] ip_pipeline: add ecmp route example > > Add example to build pipeline to demonstrate equal-cost multi-path > routing example. > >

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-30 Thread Thomas Monjalon
I know that this patch is already applied, but I have some comments below. Please try to address them. 21/03/2018 15:27, Remy Horton: > + /* If number of queues specified by application for both Rx and Tx is > + * zero, use driver preferred values. This cannot be done individually > +

Re: [dpdk-dev] [PATCH v1 1/2] crypto/aesni_mb: support IPsec MUlti-buffer lib v0.49

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Friday, March 30, 2018 4:16 PM > To: Kovacevic, Marko ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 1/2] crypto/aesni_mb: support IPsec MUlti- > buffer lib v0.49 > > > > > ---

Re: [dpdk-dev] [PATCH v1 2/2] crypto/aesni_gcm: support IPsec Multi-buffer lib v0.49

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Friday, March 30, 2018 4:16 PM > To: Kovacevic, Marko ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 2/2] crypto/aesni_gcm: support IPsec Multi- > buffer lib v0.49 > > > > > --

Re: [dpdk-dev] [PATCH v1] crypto/aesni_mb: support AES CMAC

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Friday, March 30, 2018 4:29 PM > To: Kovacevic, Marko ; dev@dpdk.org > Cc: Jain, Deepak K > Subject: Re: [dpdk-dev] [PATCH v1] crypto/aesni_mb: support AES CMAC > > > > > -Ori

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: remove redundant string compare

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Radu Nicolau > Sent: Thursday, March 29, 2018 11:06 AM > To: Anoob Joseph ; Akhil Goyal > > Cc: Doherty, Declan ; Jerin Jacob > ; Narayana Prasad > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-

Re: [dpdk-dev] Survey for final decision about per-port offload API

2018-03-30 Thread Thomas Monjalon
30/03/2018 17:13, Andrew Rybchenko: > On 03/30/2018 04:47 PM, Thomas Monjalon wrote: > > There is the same kind of confusion in the offload capabilities: > > rte_eth_dev_info.[rt]x_offload_capa > > rte_eth_dev_info.[rt]x_queue_offload_capa > > The queue capabilities must be a subset of port

Re: [dpdk-dev] [PATCH v8 7/9] test: add event timer adapter auto-test

2018-03-30 Thread Bhagavatula, Pavan
Hi Erik, Few comments below, On Thu, Mar 29, 2018 at 04:27:30PM -0500, Erik Gabriel Carrillo wrote: > Signed-off-by: Erik Gabriel Carrillo > --- > test/test/Makefile |1 + > test/test/test_event_timer_adapter.c | 1837 > ++ > 2 files change

Re: [dpdk-dev] [PATCH v4 09/20] eal/dev: implement device iteration initialization

2018-03-30 Thread Gaëtan Rivet
Hello Keith, On Fri, Mar 30, 2018 at 03:22:59PM +, Wiles, Keith wrote: > > > > On Mar 29, 2018, at 4:23 PM, Gaetan Rivet wrote: > > > > Parse a device description. > > Split this description in their relevant part for each layers. > > No dynamic allocation is performed. > > > > Signed-off

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-30 Thread Thomas Monjalon
30/03/2018 17:40, Thomas Monjalon: > I know that this patch is already applied, > but I have some comments below. > Please try to address them. > > 21/03/2018 15:27, Remy Horton: > > + /* If number of queues specified by application for both Rx and Tx is > > +* zero, use driver preferred val

Re: [dpdk-dev] [PATCH 2/7] app/crypto-perf: fix excess crypto device error

2018-03-30 Thread De Lara Guarch, Pablo
> -Original Message- > From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] > Sent: Tuesday, March 27, 2018 1:01 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > akhil.go...@nxp.com > Subject: [PATCH 2/7] app/crypto-perf: fix excess crypto device error > > If number of available dev

  1   2   >