Hi Junjie, On 03/30/2018 08:58 AM, Junjie Chen wrote:
When creating vdev dynamically, vhost pmd driver starts directly without checking TX/RX queues are ready or not, and thus causes segmentation fault when vhost library accesses queues. This patch adds a flag to check whether queues are setup or not, and adds queues setup into dev_start function to allow user to start them after setting up.Fixes: aed0b12930b3 ("net/vhost: fix socket file deleted on stop") Signed-off-by: Chen, Junjie <junjie.j.c...@intel.com> --- Changes in v3: - Update commit log, refine duplicated code Changes in v2: - Check queues status in new_device, create queue in dev_start if not setup yet drivers/net/vhost/rte_eth_vhost.c | 69 ++++++++++++++++++++++++++------------- 1 file changed, 46 insertions(+), 23 deletions(-)
Nice patch! Thanks for having handled the changes that quickly. Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com> Maxime
