> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Radu Nicolau > Sent: Thursday, March 29, 2018 11:06 AM > To: Anoob Joseph <anoob.jos...@caviumnetworks.com>; Akhil Goyal > <akhil.go...@nxp.com> > Cc: Doherty, Declan <declan.dohe...@intel.com>; Jerin Jacob > <jerin.ja...@caviumnetworks.com>; Narayana Prasad > <narayanaprasad.athr...@caviumnetworks.com>; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: remove redundant > string compare > > > On 3/28/2018 3:28 PM, Anoob Joseph wrote: > > Hi Akhil, Radu, > > > > Did you get time to review the patch? > > > > Thanks, > > Anoob > > > > On 23/03/18 11:20, Anoob Joseph wrote: > >> Removing redundant strncmp in parsing long arguments. The getopt > >> library provides means to identify long options using the "val" field > >> of structure option. The existing code gets 0 as "val" for all long > >> arguments and then uses strncmp to figure out which long option was > >> being referred to. Fixing this. > >> > >> In addition, the macros and enums used for long arguments have been > >> renamed and repositioned adhering to the general convention followed > >> in various other apps, like l3fwd. > >> > >> Signed-off-by: Anoob Joseph <anoob.jos...@caviumnetworks.com> > >> --- > Acked-by: Radu Nicolau <radu.nico...@intel.com> > <mailto:radu.nico...@intel.com>
Applied to dpdk-next-crypto. Thanks, Pablo
