Hi, -----Original Message----- From: Zhang, Qi Z Sent: Friday, March 30, 2018 3:25 PM To: Wu, Yanglong <yanglong...@intel.com>; dev@dpdk.org Cc: Dai, Wei <wei....@intel.com>; Xing, Beilei <beilei.x...@intel.com> Subject: RE: [PATCH v3 1/2] net/i40e: convert to new Rx offloads API
Hi Yanglong > > if (frame_size > ETHER_MAX_LEN) > - dev_data->dev_conf.rxmode.jumbo_frame = 1; > + dev_data->dev_conf.rxmode.offloads |= > + DEV_RX_OFFLOAD_JUMBO_FRAME; > else > - dev_data->dev_conf.rxmode.jumbo_frame = 0; > + dev_data->dev_conf.rxmode.jumbo_frame &= > + ~DEV_RX_OFFLOAD_JUMBO_FRAME; Typo here, should be dev_conf.rxmode.offloads &= thx I will fix it! > > dev_data->dev_conf.rxmode.max_rx_pkt_len = frame_size; > > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > b/drivers/net/i40e/i40e_ethdev_vf.c > index c4dae4262..cb338def9 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > > if (frame_size > ETHER_MAX_LEN) > - dev_data->dev_conf.rxmode.jumbo_frame = 1; > + dev_data->dev_conf.rxmode.offloads |= > + DEV_RX_OFFLOAD_JUMBO_FRAME; > else > - dev_data->dev_conf.rxmode.jumbo_frame = 0; > - > + dev_data->dev_conf.rxmode.jumbo_frame &= > + ~DEV_RX_OFFLOAD_JUMBO_FRAME; Same as above Regards Qi