On 3/26/2018 11:47 PM, Ajit Khaparde wrote:
> Update bnxt PMD to new ethdev offloads API.
> 
> Signed-off-by: Ajit Khaparde <ajit.khapa...@broadcom.com>
> ---
> v1->v2: return an error if requested offload flags do not
> match supported offload capabilities.

<...>

> +
> +     dev_info->rx_queue_offload_capa = BNXT_DEV_RX_OFFLOAD_SUPPORT;

Hi Ajit,

Is bnxt supports queue level offloads? If not PMD should return 0 as
rx_queue_offload_capa and tx_queue_offload_capa.

<...>

>               .rx_free_thresh = 32,
> -             .rx_drop_en = 0,
> +             /* If no descriptors available, pkts are dropped by default */
> +             .rx_drop_en = 1,

This is not related to the offload API but changing default config, does it make
sense a separate patch for this?

Reply via email to