On Wed, Jan 17, 2018 at 11:15:53AM +, Anatoly Burakov wrote:
> Get rid of global static ring variable and don't reuse rings
> between test runs.
>
> Fixes: 4e32101f9b01 ("ring: support freeing")
> Cc: pablo.de.lara.gua...@intel.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Anatoly Burakov
Ac
On Thu, Jan 18, 2018 at 05:13:08PM +0100, Olivier Matz wrote:
> On Thu, Jan 18, 2018 at 05:04:27PM +0100, Nélio Laranjeiro wrote:
> > On Thu, Jan 18, 2018 at 02:00:42PM +0100, Olivier Matz wrote:
> > > On error, mlx5_dev_start() does not return a negative value
> > > as it is supposed to do. The co
On Wed, Jan 17, 2018 at 11:15:54AM +, Anatoly Burakov wrote:
> Fixes: ac3fb3019c52 ("app: rework ring tests")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Anatoly Burakov
Acked-by: Olivier Matz
On Thu, Jan 18, 2018 at 11:52:55PM -0800, Yongseok Koh wrote:
> This patch reverts:
> commit 3a6f2eb8c5c5 ("net/mlx5: fix Memory Region registration")
>
> Although granularity of chunks in a mempool is a cacheline, addresses are
> extended to align to page boundary for performance reason in
A typo in makefile that makes the RX/TX vector code
not to be compiled.
Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx")
Signed-off-by: Wenzhuo Lu
---
drivers/net/avf/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/avf/Makefile b/drivers/net/avf/Makefile
On Fri, Jan 19, 2018 at 09:35:01AM +0100, Nélio Laranjeiro wrote:
> On Thu, Jan 18, 2018 at 05:13:08PM +0100, Olivier Matz wrote:
> > On Thu, Jan 18, 2018 at 05:04:27PM +0100, Nélio Laranjeiro wrote:
> > > On Thu, Jan 18, 2018 at 02:00:42PM +0100, Olivier Matz wrote:
> > > > On error, mlx5_dev_star
> -Original Message-
> From: Nicolau, Radu
> Sent: Thursday, January 18, 2018 3:42 PM
> To: dev@dpdk.org
> Cc: Ananyev, Konstantin ; Yigit, Ferruh
> ; De Lara Guarch, Pablo
> ; Doherty, Declan
> ; akhil.go...@nxp.com; Nicolau, Radu
>
> Subject: [PATCH v3 1/3] security: add get session si
On Thu, Jan 18, 2018 at 04:29:59AM +, Xueming(Steven) Li wrote:
>
>
> > -Original Message-
> > From: Olivier Matz [mailto:olivier.m...@6wind.com]
> > Sent: Tuesday, January 16, 2018 8:46 PM
> > To: Xueming(Steven) Li
> > Cc: Adrien Mazarguil ; dev@dpdk.org
> > Subject: Re: [PATCH v2]
It is unnecessary to cast from void * to struct rte_mbuf *,
the change can make code more simple.
Signed-off-by: Zhiyong Yang
---
lib/librte_mbuf/rte_mbuf.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index a594e4
19/01/2018 04:15, Zhao1, Wei:
> Hi, Thomas
> Thank you! After discussion with Beilei, I have commit a new patch v4.
> https://dpdk.org/dev/patchwork/patch/33956/
> Beilei also commit another new patch, we are waiting for review by Mcnamara,
> John.
> Do you think this is ok?
Yes it is fine
19/01/2018 10:13, Thomas Monjalon:
> 19/01/2018 04:15, Zhao1, Wei:
> > Hi, Thomas
> > Thank you! After discussion with Beilei, I have commit a new patch v4.
> > https://dpdk.org/dev/patchwork/patch/33956/
> > Beilei also commit another new patch, we are waiting for review by
> > Mcnamara, Jo
On Fri, Jan 19, 2018 at 12:43:09AM +0100, Thomas Monjalon wrote:
> 11/12/2017 16:31, Bruce Richardson:
> > On Mon, Nov 06, 2017 at 10:05:43AM -0800, Elza Mathew wrote:
> > > Compile-time function selection can potentially lead to
> > > lower performance on generic builds done by distros.
> > > Repl
From: Ivan Malov
Fixes: bb0c613f1eed ("net/sfc: convert to the new Tx offload API")
Signed-off-by: Ivan Malov
Signed-off-by: Andrew Rybchenko
---
Feel free to squash the fix into fixes changeset.
doc/guides/nics/features/sfc_efx.ini | 1 +
1 file changed, 1 insertion(+)
diff --git a/doc/gui
On Fri, Jan 19, 2018 at 07:14:17AM +, Matan Azrad wrote:
>
> Hi Neil
> From: Neil Horman, Friday, January 19, 2018 3:41 AM
> > On Thu, Jan 18, 2018 at 08:21:34PM +, Matan Azrad wrote:
> > > Hi Neil.
> > >
> > > From: Neil Horman, Thursday, January 18, 2018 8:42 PM
>
>
> > > 1. What exact
This patch adds support for registering and waiting for Rx
interrupts in failsafe PMD,
The patch should be applied on top of the following series of
patches by Matan Azrad:
[PATCH v6 0/6] Fail-safe\ethdev: fix removal handling lack
[PATCH v6 0/8] Introduce virtual driver for Hyper-V/Azure plat
This patch adds support for registering and waiting for Rx
interrupts in failsafe PMD. This allows applications to wait
for Rx events from the PMD using the DPDK rte_epoll subsystem.
The failsafe PMD presents to the application a facade of a single
device to be handled by the application while inte
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Nélio Laranjeiro
> Sent: Tuesday, January 16, 2018 3:52 PM
> To: Olivier Matz
> Cc: dev@dpdk.org; bor...@mellanox.com
> Subject: Re: [dpdk-dev] [PATCH 1/2] net: fix ESP header byte ordering
> definition
>
> On T
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Nelio Laranjeiro
> Sent: Thursday, January 11, 2018 9:16 AM
> To: dev@dpdk.org; Olivier Matz
> Cc: bor...@mellanox.com
> Subject: [dpdk-dev] [PATCH 1/2] net: fix ESP header byte ordering definition
>
> ESP heade
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Nelio Laranjeiro
> Sent: Thursday, January 11, 2018 9:16 AM
> To: dev@dpdk.org; Olivier Matz
> Cc: akhil.go...@nxp.com
> Subject: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix SPI byte order in
> flow item
>
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch,
> Pablo
> Sent: Friday, January 19, 2018 9:34 AM
> To: Nelio Laranjeiro ; dev@dpdk.org; Olivier
> Matz
> Cc: bor...@mellanox.com
> Subject: Re: [dpdk-dev] [PATCH 1/2] net: fix ESP header byte orde
Hi Zhiyong,
3 comments about patch formatting:
1/ the title must follow the convention seen in the git history.
If you use git log --oneline lib/librte_mbuf
you will see that it must start with "mbuf:"
2/ The * character does not play well when patch saved in a file,
and it is useless: "void poi
This commit enhances the default Rx offload capabilities of the
failsafe device to initially support all possible capabilities.
This is done in order to support a wider range of Rx offloads
provided by different slave devices.
Fixes: 2199a208232e ("net/failsafe: use new Rx offloads API")
Cc: sta..
Thank you, Thomas, I will do that according to your comments.
Thanks
Zhiyong
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Friday, January 19, 2018 5:38 PM
> To: Yang, Zhiyong
> Cc: dev@dpdk.org; Yigit, Ferruh ;
> olivier.m...@6wind.com
> Subject: Re
On Thu, Jan 18, 2018 at 06:56:27PM +0530, Hemant Agrawal wrote:
> Add new API to set the user defined mbuf mempool ops name
> i.e. set the provided ops name to `internal_config.mbuf_pool_ops_name`.
>
> Signed-off-by: Pavan Nikhilesh
> Signed-off-by: Hemant Agrawal
> ---
> lib/librte_eal/bsdapp/
On Thu, Jan 18, 2018 at 06:56:26PM +0530, Hemant Agrawal wrote:
> This patch prefix the mbuf pool ops name with "user" to indicate
> that it is user defined.
>
> This patch also change the logic to maintain the value of
> user defined and compile time i.e. RTE_MBUF_DEFAULT_MEMPOOL_OPS.
>
> The pk
On Thu, Jan 18, 2018 at 06:56:28PM +0530, Hemant Agrawal wrote:
> This patch add support for various mempool ops config helper APIs.
>
> 1.User defined mempool ops
> 2.Platform detected HW mempool ops (active).
> 3.Best selection of mempool ops by looking into user defined,
> platform registered
On Thu, Jan 18, 2018 at 06:56:30PM +0530, Hemant Agrawal wrote:
> From: Pavan Nikhilesh
>
> Set the mempool preferred by the ethernet devices as default mbuf
> mempool before creating the pktpool.
>
> Signed-off-by: Pavan Nikhilesh
> ---
> app/test-pmd/testpmd.c | 3 +++
> 1 file changed, 3 in
Drop this one since the patch doesn't follow the convention. I will resend
another new one.
Thanks
Zhiyong
> -Original Message-
> From: Yang, Zhiyong
> Sent: Friday, January 19, 2018 5:13 PM
> To: dev@dpdk.org
> Cc: tho...@monjalon.net; Yigit, Ferruh ; Yang,
> Zhiyong
> Subject: [PATC
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Friday, January 19, 2018 6:38 AM
> To: dev@dpdk.org
> Cc: Richardson, Bruce ; Van Haaren, Harry
> ; Jerin Jacob ;
> sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] event/sw: fix debug logging config option
>
> align the config optio
In failsafe device start can be called for ports/devices that
had been plugged out.
This patch fixes mlx4 port start failure when called by the failsafe
PMD for removed devices.
Fixes: a6e8b01c3c26 ("net/mlx4: compact interrupt functions")
Signed-off-by: Moti Haimovsky
---
drivers/net/mlx4/mlx4
In failsafe device start can be called for ports/devices that
had been plugged out.
This patch fixes mlx4 port start failure when called by the failsafe
PMD for removed devices.
Fixes: a6e8b01c3c26 ("net/mlx4: compact interrupt functions")
Cc: sta...@dpdk.org
Signed-off-by: Moti Haimovsky
---
V2
It is unnecessary to cast from void * to struct rte_mbuf *,
the change can make code clearer.
Signed-off-by: Zhiyong Yang
---
lib/librte_mbuf/rte_mbuf.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index a594e4772.
Hi Moti,
On Fri, Jan 19, 2018 at 11:42:48AM +0200, Moti Haimovsky wrote:
> This commit enhances the default Rx offload capabilities of the
> failsafe device to initially support all possible capabilities.
> This is done in order to support a wider range of Rx offloads
> provided by different slave
> -Original Message-
> From: Tomasz Duszynski [mailto:t...@semihalf.com]
> Sent: Thursday, December 14, 2017 9:28 AM
> To: De Lara Guarch, Pablo
> Cc: Doherty, Declan ;
> jerin.ja...@caviumnetworks.com; j...@semihalf.com; t...@semihalf.com;
> d...@marvell.com; nsams...@marvell.com; jianb
Hi Bruce
From: Bruce Richardson, Friday, January 19, 2018 11:30 AM
> On Fri, Jan 19, 2018 at 07:14:17AM +, Matan Azrad wrote:
> >
> > Hi Neil
> > From: Neil Horman, Friday, January 19, 2018 3:41 AM
> > > On Thu, Jan 18, 2018 at 08:21:34PM +, Matan Azrad wrote:
> > > > Hi Neil.
> > > >
> > >
> -Original Message-
> From: Yongseok Koh [mailto:ys...@mellanox.com]
> Sent: Friday, January 19, 2018 7:10 AM
> To: Ananyev, Konstantin
> Cc: Lu, Wenzhuo ; Wu, Jingjing ;
> dev@dpdk.org; Jerin Jacob
>
> Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: make txonly mode generate
> multi
Added missing doxygen for rte_eth_dev_get_sec_ctx
and moved the declaration to the proper place.
Signed-off-by: Radu Nicolau
---
lib/librte_ether/rte_ethdev.h | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/r
Signed-off-by: Alok Makhariya
Signed-off-by: Akhil Goyal
---
doc/guides/cryptodevs/features/default.ini | 1 +
doc/guides/cryptodevs/features/dpaa2_sec.ini | 1 +
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 588 +--
test/test/test_cryptodev.c |
Hi Shally,
> -Original Message-
> From: Verma, Shally [mailto:shally.ve...@cavium.com]
> Sent: Thursday, January 18, 2018 12:54 PM
> To: Trahe, Fiona ; dev@dpdk.org
> Cc: Challa, Mahipal ; Athreya, Narayana Prasad
> ; De Lara Guarch, Pablo
> ;
> Gupta, Ashish ; Sahu, Sunila
> ; Jain, Dee
Hi Olivier,
On 1/19/2018 3:31 PM, Olivier Matz wrote:
On Thu, Jan 18, 2018 at 06:56:27PM +0530, Hemant Agrawal wrote:
Add new API to set the user defined mbuf mempool ops name
i.e. set the provided ops name to `internal_config.mbuf_pool_ops_name`.
Signed-off-by: Pavan Nikhilesh
Signed-off-by:
Hi Matan,
> -Original Message-
> From: Matan Azrad [mailto:ma...@mellanox.com]
> Sent: Thursday, January 18, 2018 4:35 PM
> To: Thomas Monjalon ; Gaetan Rivet
> ; Wu, Jingjing
> Cc: dev@dpdk.org; Neil Horman ; Richardson, Bruce
> ; Ananyev, Konstantin
>
> Subject: [PATCH v3 7/7] app/te
> -Original Message-
> From: Matan Azrad [mailto:ma...@mellanox.com]
> Sent: Thursday, January 18, 2018 4:35 PM
> To: Thomas Monjalon ; Gaetan Rivet
> ; Wu, Jingjing
> Cc: dev@dpdk.org; Neil Horman ; Richardson, Bruce
> ; Ananyev, Konstantin
> ; sta...@dpdk.org
> Subject: [PATCH v3 1/7
> -Original Message-
> From: Matan Azrad [mailto:ma...@mellanox.com]
> Sent: Thursday, January 18, 2018 4:35 PM
> To: Thomas Monjalon ; Gaetan Rivet
> ; Wu, Jingjing
> Cc: dev@dpdk.org; Neil Horman ; Richardson, Bruce
> ; Ananyev, Konstantin
> ; sta...@dpdk.org
> Subject: [PATCH v3 2/7
> -Original Message-
> From: Matan Azrad [mailto:ma...@mellanox.com]
> Sent: Thursday, January 18, 2018 4:35 PM
> To: Thomas Monjalon ; Gaetan Rivet
> ; Wu, Jingjing
> Cc: dev@dpdk.org; Neil Horman ; Richardson, Bruce
> ; Ananyev, Konstantin
>
> Subject: [PATCH v3 3/7] ethdev: add por
Hi Olivier,
On 1/19/2018 3:31 PM, Olivier Matz wrote:
On Thu, Jan 18, 2018 at 06:56:28PM +0530, Hemant Agrawal wrote:
This patch add support for various mempool ops config helper APIs.
1.User defined mempool ops
2.Platform detected HW mempool ops (active).
3.Best selection of mempool ops by lo
On Fri, Jan 19, 2018 at 06:01:55PM +0530, Hemant Agrawal wrote:
> Hi Olivier,
>
> On 1/19/2018 3:31 PM, Olivier Matz wrote:
> > On Thu, Jan 18, 2018 at 06:56:27PM +0530, Hemant Agrawal wrote:
> > > Add new API to set the user defined mbuf mempool ops name
> > > i.e. set the provided ops name to `i
> -Original Message-
> From: Matan Azrad [mailto:ma...@mellanox.com]
> Sent: Thursday, January 18, 2018 4:35 PM
> To: Thomas Monjalon ; Gaetan Rivet
> ; Wu, Jingjing
> Cc: dev@dpdk.org; Neil Horman ; Richardson, Bruce
> ; Ananyev, Konstantin
>
> Subject: [PATCH v3 4/7] ethdev: synchro
Hi Konstantin
From: Ananyev, Konstantin, Friday, January 19, 2018 2:38 PM
> To: Matan Azrad ; Thomas Monjalon
> ; Gaetan Rivet ; Wu,
> Jingjing
> Cc: dev@dpdk.org; Neil Horman ; Richardson,
> Bruce
> Subject: RE: [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership
>
> Hi Matan,
>
> >
On Fri, Jan 19, 2018 at 09:30:17AM +, Bruce Richardson wrote:
> On Fri, Jan 19, 2018 at 07:14:17AM +, Matan Azrad wrote:
> >
> > Hi Neil
> > From: Neil Horman, Friday, January 19, 2018 3:41 AM
> > > On Thu, Jan 18, 2018 at 08:21:34PM +, Matan Azrad wrote:
> > > > Hi Neil.
> > > >
> > >
Added support for detecting march and mcpu by reading midr_el1 register.
The implementer, primary part number values read can be used to figure
out the underlying arm cpu.
Signed-off-by: Pavan Nikhilesh
---
app/test-pmd/meson.build| 2 +-
config/arm/armv8_machine.py | 18
config/
From: Bruce Richardson
Add files to enable compiling for ARM cross builds.
This can be tested by doing a cross-compile for armv8-a type using
the linaro gcc toolchain.
meson arm-build --cross-file aarch64_cross.txt
ninja -C arm-build
where aarch64_cross.txt contained the followi
> -Original Message-
> From: Matan Azrad [mailto:ma...@mellanox.com]
> Sent: Friday, January 19, 2018 12:52 PM
> To: Ananyev, Konstantin ; Thomas Monjalon
> ; Gaetan Rivet
> ; Wu, Jingjing
> Cc: dev@dpdk.org; Neil Horman ; Richardson, Bruce
>
> Subject: RE: [PATCH v3 7/7] app/testpmd:
Hi Hemant,
On Fri, Jan 19, 2018 at 06:11:47PM +0530, Hemant Agrawal wrote:
> Hi Olivier,
>
> On 1/19/2018 3:31 PM, Olivier Matz wrote:
> > On Thu, Jan 18, 2018 at 06:56:28PM +0530, Hemant Agrawal wrote:
> > > This patch add support for various mempool ops config helper APIs.
> > >
> > > 1.User d
Add octeontx hardware mempool driver to meson build.
Signed-off-by: Pavan Nikhilesh
---
v3 Changes:
- added flag to disable array prefetch optimization in thunder-nicvf
v2:
- remove unneeded include variable.
- include SPDX license tags
drivers/mempool/meson.build | 2 +-
driver
Add Cavium octeontx and thunder nicvf to meson build infrastructure.
Signed-off-by: Pavan Nikhilesh
---
drivers/net/meson.build | 3 ++-
drivers/net/octeontx/base/meson.build | 21 +
drivers/net/octeontx/meson.build
Add Cavium octeontx to meson build and change order of drivers built
from event->mempool->net to mempool->net->event to resolve dependency.
Signed-off-by: Pavan Nikhilesh
---
drivers/event/meson.build | 2 +-
drivers/event/octeontx/meson.build
Signed-off-by: Pavan Nikhilesh
---
app/meson.build | 1 +
app/test-eventdev/meson.build | 28
2 files changed, 29 insertions(+)
create mode 100644 app/test-eventdev/meson.build
diff --git a/app/meson.build b/app/meson.build
index c5b785928..0088de464
Add various vendor specific cross build targets.
This can be verified by using linaro toolchain and running
meson build --cross-file config/arm/arch64_armv8__cross
In future more cross build targets can be added.
Signed-off-by: Pavan Nikhilesh
---
config/arm/arch64_armv8_generic_cross
Reviewed-by: Akhil Goyal
Signed-off-by: Alok Makhariya
Signed-off-by: Akhil Goyal
---
doc/guides/cryptodevs/features/dpaa_sec.ini | 1 +
drivers/crypto/dpaa_sec/dpaa_sec.c | 501 +--
test/test/test_cryptodev.c | 10 +
test/test/test_cryptodev_aes_test_vectors.h |
The word size of port_id is now 16 bits, but there were parsing directives
that assumed it was still of type UINT8, resulting in incorrect commandline
parse results.
Fixes: f14a210a65fe ("app: fix port id type")
Signed-off-by: Remy Horton
---
app/test-pmd/cmdline.c | 2 +-
1 file changed, 1 ins
On Fri, Jan 19, 2018 at 09:43:14AM +0100, Olivier Matz wrote:
> On Fri, Jan 19, 2018 at 09:35:01AM +0100, Nélio Laranjeiro wrote:
> > On Thu, Jan 18, 2018 at 05:13:08PM +0100, Olivier Matz wrote:
> > > On Thu, Jan 18, 2018 at 05:04:27PM +0100, Nélio Laranjeiro wrote:
> > > > On Thu, Jan 18, 2018 at
On Fri, Jan 19, 2018 at 10:44:32AM +, Matan Azrad wrote:
> Hi Bruce
> From: Bruce Richardson, Friday, January 19, 2018 11:30 AM
> > On Fri, Jan 19, 2018 at 07:14:17AM +, Matan Azrad wrote:
> > >
> > > Hi Neil
> > > From: Neil Horman, Friday, January 19, 2018 3:41 AM
> > > > On Thu, Jan 18,
Hi Konstantin
From: Ananyev, Konstantin, Friday, January 19, 2018 3:09 PM
> > -Original Message-
> > From: Matan Azrad [mailto:ma...@mellanox.com]
> > Sent: Friday, January 19, 2018 12:52 PM
> > To: Ananyev, Konstantin ; Thomas
> > Monjalon ; Gaetan Rivet
> ;
> > Wu, Jingjing
> > Cc: dev@
On Thu, Jan 18, 2018 at 02:00:42PM +0100, Olivier Matz wrote:
> On error, mlx5_dev_start() does not return a negative value
> as it is supposed to do. The consequence is that the application
> (ex: testpmd) does not notice that the port is not started
> and begins the rxtx on an uninitialized port,
On 01/19/2018 08:02 PM, Zhihong Wang wrote:
The VIRTIO_F_ANY_LAYOUT feature indicates the device accepts arbitrary
descriptor layouts. The vhost-user lib already supports it, but the
feature declaration is missing. This patch fixes the mismatch.
Signed-off-by: Zhihong Wang
---
lib/librte_vh
On Fri, Jan 19, 2018 at 02:30:45PM +0100, Olivier Matz wrote:
> On Fri, Jan 19, 2018 at 09:43:14AM +0100, Olivier Matz wrote:
> > On Fri, Jan 19, 2018 at 09:35:01AM +0100, Nélio Laranjeiro wrote:
> > > On Thu, Jan 18, 2018 at 05:13:08PM +0100, Olivier Matz wrote:
> > > > On Thu, Jan 18, 2018 at 05:
This patch series implements the virtio-vhost-user device, which tunnels
vhost-user protocol messages over virtio. This lets guests act as vhost device
backends for other guests.
The virtio-vhost-user device is the result of discussion about Wei Wang and
Zhiyong Yang's vhost-pci device. This pat
File descriptor passing is specific to the AF_UNIX vhost-user protocol
transport. In order to add support for additional transports it is
necessary to extract transport-specific code from the main vhost-user
code.
This patch introduces struct vhost_transport_ops and associates each
device with a
The socket.c file serves two purposes:
1. librte_vhost public API entry points, e.g. rte_vhost_driver_register().
2. AF_UNIX socket management.
Move AF_UNIX socket code into trans_af_unix.c so that socket.c only
handles the librte_vhost public API entry points. This will make it
possible to suppo
vhost-user transports have per-socket state (like file descriptors).
Make it possible for transports to keep state beyond what is included in
struct vhost_user_socket.
This patch makes it possible to move AF_UNIX-specific fields from struct
vhost_user_socket into trans_af_unix.c in later patches.
Introduce a vhost_transport_ops->socket_start() interface so the
transport can begin establishing vhost-user connections. This is part
of the AF_UNIX transport refactoring and removes AF_UNIX code from
vhost.h and socket.c.
Signed-off-by: Stefan Hajnoczi
---
lib/librte_vhost/vhost.h | 1
The socket file descriptor and AF_UNIX sockaddr are specific to the
AF_UNIX transport, so move them into trans_af_unix.c.
In order to do this we need to begin defining the vhost_transport_ops
interface that will allow librte_vhost to support multiple transports.
This patch adds socket_init() and s
The socket reconnection code is highly specific to AF_UNIX, so move the
remaining pieces of it into trans_af_unix.c.
Signed-off-by: Stefan Hajnoczi
---
lib/librte_vhost/vhost.h | 10 +++---
lib/librte_vhost/socket.c| 4
lib/librte_vhost/trans_af_unix.c | 9 +++--
3
The AF_UNIX transport can accept multiple client connections on a server
socket. Each connection instantiates a separate vhost-user device,
which is stored as a vhost_user_connection. This behavior is specific
to AF_UNIX and other transports may not support N connections per
socket endpoint.
Mov
The fdset is used by the AF_UNIX transport code but other transports may
not need it. Move it to trans_af_unix.c and then make struct vhost_user
private again since nothing outside socket.c needs it.
Signed-off-by: Stefan Hajnoczi
---
lib/librte_vhost/vhost.h | 15 ---
lib/l
This patch propagates struct vhost_user_socket's vhost_transport_ops
into the newly created vhost device.
This patch completes the initial refactoring of socket.c, with the
AF_UNIX-specific code now in trans_af_unix.c and the librte_vhost API
entrypoints in socket.c.
Now it is time to turn toward
The slave request file descriptor is specific to the AF_UNIX transport.
Move the field out of struct virtio_net and into the trans_af_unix.c
private struct vhost_user_connection struct.
This change will allow future transports to implement the slave request
fd without relying on socket I/O.
Signe
The core vhost-user protocol code should not do socket I/O because the
details are transport-specific. Move code to send and receive
vhost-user messages into trans_af_unix.c.
Signed-off-by: Stefan Hajnoczi
---
lib/librte_vhost/vhost.h | 26
lib/librte_vhost/vhost_user.h
There is a 1:1 relationship between struct virtio_net and struct
vhost_user_connection. They share the same lifetime. struct virtio_net
is the per-device state that is part of the vhost.h API. struct
vhost_user_connection is the AF_UNIX-specific per-device state and is
private to trans_af_unix.c
How mem table regions are mapped is transport-specific, so move the mmap
code into trans_af_unix.c. The new .map_mem_table()/.unmap_mem_table()
interfaces allow transports to perform the mapping and unmapping.
Drop the "mmap align:" debug output because the alignment is no longer
available from v
PCI drivers depend on the rte_bus_pci.h header file which is only
available when drivers/ is built. Code in lib/ cannot depend on code in
drivers/ because lib/ is built first during make install.
This patch moves librte_vhost into drivers/ so that later patches can
add a virtio-vhost-pci driver t
The virtio-vhost-user transport will involve a virtio pci device driver.
There is currently no librte_virtio API that we can reusable.
This commit is a hack that duplicates the virtio pci code from
drivers/net/. A better solution would be to extract the code cleanly
from drivers/net/ and share it
Currently the only way of determining a struct vhost_virtqueue's index
is to search struct virtio_net->virtqueue[] for its address. Stash the
index in struct vhost_virtqueue so we won't have to search the array.
This new field will be used by virtio-vhost-user.
Signed-off-by: Stefan Hajnoczi
--
Extend the API to support the virtio-vhost-user transport
as an alternative to the AF_UNIX transport. The caller provides a PCI
DomBDF address:
rte_vhost_driver_register(":00:04.0",
RTE_VHOST_USER_VIRTIO_TRANSPORT);
Signed-off-by: Stefan Hajnoczi
---
drivers/
This patch adds a new transport to librte_vhost for the
virtio-vhost-user device. This device replaces the AF_UNIX socket used
by traditional vhost-user with a virtio device that tunnels vhost-user
protocol messages. This allows a guest to act as a vhost device backend
for other guests.
The inte
The new virtio-transport=0|1 argument enables virtio-vhost-user support:
testpmd ... --pci-whitelist :00:04.0 \
--vdev vhost,iface=:00:04.0,virtio-transport=1
Signed-off-by: Stefan Hajnoczi
---
drivers/net/vhost/rte_eth_vhost.c | 13 +
1 file changed, 13 inse
The default filename built into examples/vhost_scsi may not be
convenient. Allow the user to specify the full UNIX domain socket path
on the command-line.
Signed-off-by: Stefan Hajnoczi
---
examples/vhost_scsi/vhost_scsi.c | 93
1 file changed, 75 insert
The new --virtio-vhost-user-pci command-line argument uses
virtio-vhost-user instead of the default AF_UNIX transport.
Signed-off-by: Stefan Hajnoczi
---
examples/vhost_scsi/vhost_scsi.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/examples/vhost_scsi/vhost
The virtio-vhost-user PCI adapter is not detected in any existing group
of devices supported by dpdk-devbind.py. Add a new "Others" group for
miscellaneous devices like this one.
Signed-off-by: Stefan Hajnoczi
---
usertools/dpdk-devbind.py | 8
1 file changed, 8 insertions(+)
diff --g
The EVENT_IDX code in DPDK is broken. It's missing the
signalled_used_valid flag that handles the corner cases (startup and
wrapping). Disable it for now.
Signed-off-by: Stefan Hajnoczi
---
examples/vhost_scsi/vhost_scsi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/examples/vhost_scsi/
The virtio-net mq vring deletion code should be in virtio_net.c, not in
the generic vhost_user.c code where it breaks non-virtio-net devices.
Signed-off-by: Stefan Hajnoczi
---
drivers/librte_vhost/vhost_user.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/librte_vhost/vhost_user
On Wed, Jan 17, 2018 at 03:49:25PM +0200, Victor Kaplansky wrote:
> When performing live migration or memory hot-plugging,
> the changes to the device and vrings made by message handler
> done independently from vring usage by PMD threads.
>
> This causes for example segfaults during live-migratio
From: Bruce Richardson
Add files to enable compiling for ARM cross builds.
This can be tested by doing a cross-compile for armv8-a type using
the linaro gcc toolchain.
meson arm-build --cross-file aarch64_cross.txt
ninja -C arm-build
where aarch64_cross.txt contained the followi
Added support for detecting march and mcpu by reading midr_el1 register.
The implementer, primary part number values read can be used to figure
out the underlying arm cpu.
Signed-off-by: Pavan Nikhilesh
---
app/test-pmd/meson.build| 2 +-
config/arm/armv8_machine.py | 18 +++
config
On Fri, Jan 19, 2018 at 07:14:17AM +, Matan Azrad wrote:
>
> Hi Neil
> From: Neil Horman, Friday, January 19, 2018 3:41 AM
> > On Thu, Jan 18, 2018 at 08:21:34PM +, Matan Azrad wrote:
> > > Hi Neil.
> > >
> > > From: Neil Horman, Thursday, January 18, 2018 8:42 PM
>
>
> > > 1. What exact
Hi Neil
From: Neil Horman, Friday, January 19, 2018 3:30 PM
> On Fri, Jan 19, 2018 at 10:44:32AM +, Matan Azrad wrote:
> > Hi Bruce
> > From: Bruce Richardson, Friday, January 19, 2018 11:30 AM
> > > On Fri, Jan 19, 2018 at 07:14:17AM +, Matan Azrad wrote:
> > > >
> > > > Hi Neil
> > > > Fr
On Thu, Jan 18, 2018 at 02:52:20PM +, Matan Azrad wrote:
> Hi Neil
>
> From: Neil Horman, Thursday, January 18, 2018 3:21 PM
> > On Wed, Jan 17, 2018 at 05:58:07PM +, Matan Azrad wrote:
> > >
> > > Hi Neil
> > >
> > > From: Neil Horman, Wednesday, January 17, 2018 4:00 PM
> > > > On Wed,
19/01/2018 14:57, Neil Horman:
> > > I specifically pointed that out above. There is no reason an owernship
> > > record
> > > couldn't be added to the rte_eth_dev structure.
> >
> > Sorry, don't understand why.
> >
> Because, thats the resource your trying to protect, and the object you want to
Hi Moti,
This patch is pretty big. It would have helped review to have it divided
in smaller patches.
Overall, I wholly support adding Rx interrupt support, and I think it is
interesting to have done it using rte_service.
I am entirely unfamiliar with rte_service however, so I will take your
wor
1 - 100 of 206 matches
Mail list logo
