On Thu, Jan 18, 2018 at 06:56:27PM +0530, Hemant Agrawal wrote:
> Add new API to set the user defined mbuf mempool ops name
> i.e. set the provided ops name to `internal_config.mbuf_pool_ops_name`.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavat...@caviumnetworks.com>
> Signed-off-by: Hemant Agrawal <hemant.agra...@nxp.com>
> ---
> lib/librte_eal/bsdapp/eal/eal.c | 6 ++++++
> lib/librte_eal/common/include/rte_eal.h | 9 +++++++++
> lib/librte_eal/linuxapp/eal/eal.c | 6 ++++++
> lib/librte_eal/rte_eal_version.map | 1 +
> 4 files changed, 22 insertions(+)
>
> diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
> index c602d02..64f010a 100644
> --- a/lib/librte_eal/bsdapp/eal/eal.c
> +++ b/lib/librte_eal/bsdapp/eal/eal.c
> @@ -117,6 +117,12 @@ rte_eal_mbuf_default_mempool_ops(void)
> return internal_config.user_mbuf_pool_ops_name;
> }
>
> +void
> +rte_eal_set_mbuf_user_mempool_ops(const char *ops_name)
> +{
> + internal_config.user_mbuf_pool_ops_name = ops_name;
> +}
> +
I think we should only have the "set" API in mbuf lib.
What do you think about what I suggested in
http://dpdk.org/ml/archives/dev/2018-January/087419.html ?
"""
The proper way is maybe to keep the parsing in eal, and at librte_mbuf
initialization, query the eal library to get the user pool if any.
After that, all will be managed inside librte_mbuf. So the eal lib will
only do the argument parsing.
"""
In that case, this patch could be dropped. Please refer to my comment
in patch 3 to see what other modifications would be needed.
